fixed_phy: pass 'irq' to fixed_phy_add()
Subsystems (3)
PATCH 1/1 fixed_phy: pass 'irq' to fixed_phy_add()
I've noticed that fixed_phy_register() ignores its 'irq' parameter instead of passing it to fixed_phy_add(). Luckily, fixed_phy_register() seems to always be called with PHY_POLL for 'irq'... :-)
---
The patch is against DaveM's 'net.git' repo.
drivers/net/phy/fixed_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/phy/fixed_phy.c +1 -1
@@ -325,7 +325,7 @@ struct phy_device *fixed_phy_register(un phy_addr = phy_fixed_addr++;spin_unlock (&phy_fixed_addr_lock); - ret =fixed_phy_add (PHY_POLL , phy_addr, status, link_gpio); + ret =fixed_phy_add (irq, phy_addr, status, link_gpio);if (ret <0 )return ERR_PTR (ret);
Quoted 3 lines · Sergei Shtylyov
I've noticed that
fixed_phy_register()ignores its 'irq' parameter instead of passing it tofixed_phy_add(). Luckily,fixed_phy_register()seems to always be called withPHY_POLLfor 'irq'... :-)
So not critical for -stable, good!
Quoted 3 lines
Fixes a75951217472 ("net: phy: extend fixed driver with fixed_phy_register()")Signed-off-by Sergei Shtylyov <[email protected]>
Signature · 1 line
Florian
From: Sergei Shtylyov <[email protected]>
Date: Thu, 03 Sep 2015 23:22:16 +0300
Quoted 6 lines
I've noticed that
fixed_phy_register()ignores its 'irq' parameter instead of passing it tofixed_phy_add(). Luckily,fixed_phy_register()seems to always be called withPHY_POLLfor 'irq'... :-)Fixes a75951217472 ("net: phy: extend fixed driver with fixed_phy_register()")Signed-off-by Sergei Shtylyov <[email protected]>
Applied, thanks.