Skip to contentSkip to conversation

vhost: vsock: select CONFIG_VHOST

PATCH In review Arnd Bergmann 3 participants 4 messages Dec 8, 2015

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vhost: vsock: select CONFIG_VHOST

When building the new vsock code without vhost, we get a build error:

drivers/built-in.o: In function `vhost_vsock_flush':
:(.text+0x24d29c): undefined reference to `vhost_poll_flush'

This adds an explicit 'select' like we have for the other vhost drivers.

---
 drivers/vhost/Kconfig.vsock | 2 ++
 1 file changed, 2 insertions(+)

The patch causing the problem is currently in net-next, so the fix should be applied on top of that.

drivers/vhost/Kconfig.vsock +2 -0
index 3491865d3eb9..bfb9edc4b5d6 100644
@@ -2,6 +2,8 @@ config VHOST_VSOCK
 	tristate "vhost virtio-vsock driver"
 	depends on VSOCKETS && EVENTFD
 	select VIRTIO_VSOCKETS_COMMON
+	select VHOST
+	select VHOST_RING
 	default n
 	---help---
 	Say M here to enable the vhost-vsock for virtio-vsock guests
Signature · 1 line
2.1.0.rc2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Arnd Bergmann

When building the new vsock code without vhost, we get a build error:

drivers/built-in.o: In function `vhost_vsock_flush':
:(.text+0x24d29c): undefined reference to `vhost_poll_flush'

This adds an explicit 'select' like we have for the other vhost drivers.

This will need to be done eventually, so

but I really think the right thing for now is to revert current vsock code, or disable building it unconditionally. Stefan, could you please send a patch like this?

Quoted 23 lines
---
 drivers/vhost/Kconfig.vsock | 2 ++
 1 file changed, 2 insertions(+)

The patch causing the problem is currently in net-next, so the fix should be applied on top of that.

drivers/vhost/Kconfig.vsock +2 -0
index 3491865d3eb9..bfb9edc4b5d6 100644
@@ -2,6 +2,8 @@ config VHOST_VSOCK
 	tristate "vhost virtio-vsock driver"
 	depends on VSOCKETS && EVENTFD
 	select VIRTIO_VSOCKETS_COMMON
+	select VHOST
+	select VHOST_RING
 	default n
 	---help---
 	Say M here to enable the vhost-vsock for virtio-vsock guests
Signature · 1 line
2.1.0.rc2
maintainer
#2 lore raw

From: "Michael S. Tsirkin" <[email protected]>
Date: Tue, 8 Dec 2015 18:09:44 +0200

Quoted 11 lines · Arnd Bergmann
Quoted 9 lines

When building the new vsock code without vhost, we get a build error:

drivers/built-in.o: In function `vhost_vsock_flush':
:(.text+0x24d29c): undefined reference to `vhost_poll_flush'

This adds an explicit 'select' like we have for the other vhost drivers.

Quoted 7 lines

This will need to be done eventually, so

but I really think the right thing for now is to revert current vsock code, or disable building it unconditionally. Stefan, could you please send a patch like this?

I'm waiting for the full single revert patch and will apply it as soon as I receive it.

maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Arnd Bergmann
Quoted 9 lines · Arnd Bergmann

When building the new vsock code without vhost, we get a build error:

drivers/built-in.o: In function `vhost_vsock_flush':
:(.text+0x24d29c): undefined reference to `vhost_poll_flush'

This adds an explicit 'select' like we have for the other vhost drivers.

This will need to be done eventually, so

but I really think the right thing for now is to revert current vsock code, or disable building it unconditionally. Stefan, could you please send a patch like this?

Quoted 23 lines
---
 drivers/vhost/Kconfig.vsock | 2 ++
 1 file changed, 2 insertions(+)

The patch causing the problem is currently in net-next, so the fix should be applied on top of that.

drivers/vhost/Kconfig.vsock +2 -0
index 3491865d3eb9..bfb9edc4b5d6 100644
@@ -2,6 +2,8 @@ config VHOST_VSOCK
 	tristate "vhost virtio-vsock driver"
 	depends on VSOCKETS && EVENTFD
 	select VIRTIO_VSOCKETS_COMMON
+	select VHOST
+	select VHOST_RING
 	default n
 	---help---
 	Say M here to enable the vhost-vsock for virtio-vsock guests
Signature · 1 line
2.1.0.rc2