Fix serial console for PREEMPT_RT
Subsystems (2)
cover Fix serial console for PREEMPT_RT
While dealing with a bug that breaks the serial console from qemu (8250) after printing a lot of data, I found some issues on this driver on RT as well as spurious IRQ behaviors that don't seem to be adeqate for RT.
Comments:
Patch #1:
I found out this driver get an IRQ request for every tx byte, but the handler is able to deal with sending multiple bytes per "thread wake up".
Since the irqs_unhandled keep growing, and theads_handled don't change as often, after some intense load (tx ~300kBytes) the serial will disable the IRQ line for this driver, which ultimately breaks the console.
My fist solution kept track of how many requests given handler dealt with, which got added to theads_handled. On note_interrupt I got the diff from theads_handled_last and subtracted that diff from irqs_unhandled.
This solution required a change in the irqreturn_t typedef and a bunch of helpers and defines, as well as adapting the 8250 driver.
At the end seemed like a overcomplicated solution for the issue, but it can be an alternative if the current solution is considered imprecise.
Mu cyrrent solution on patch #1 is much simpler, just keeping the IRQ enabled as long as the irq_thread deal with any IRQ request before irqs_unhandled hitting the limit value.
Patch #2:
In RT, the 8250 driver has an issue if it's interrupted while holding the port->lock. If the interruption needs to printk() anything, it will try to get the port->lock, which is busy, so spin_lock() will try to reschedule the interruption, which is in atomic context, and will trigger a bug.
This bug reproduces quite often, like in 50% of tests I did.
The only thing I could think of for fixing this is using in_atomic() when PREEMPT_RT=y, so it makes use of the same mechanism as for oops_in_progress to avoid getting the lock if it's busy. It's working just fine.
Yeah, I got the warning in checkpath:
"ERROR: do not use in_atomic in drivers"
So I need some feedback on what to do to avoid this bug, if not by using in_atomic() at this driver.
Since this one is linked to the console, any printk will try to get this drivers port->lock, and so it's kind of hard to avoid this accesses.
I though on doing an interface for spin_lock_only_if_can_sleep() but it seemed overkill.
Please provide comments / feedback.
Thanks!
Leo
Leonardo Bras (2):
irq/spurious: Reset irqs_unhandled if an irq_thread handles one IRQ
request
serial/8250: Avoid getting lock in RT atomic context
drivers/tty/serial/8250/8250_port.c | 2 +- kernel/irq/spurious.c | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-)
base-commit: 052d534373b7ed33712a63d5e17b2b6cdbce84fd
Signature · 1 line
2.43.0
RFC PATCH 1/2 irq/spurious: Reset irqs_unhandled if an irq_thread handles one IRQ request
When the IRQs are threaded, the part of the handler that runs in interruption context can be pretty fast, as per design, while letting the slow part to run into the thread handler.
In some cases, given IRQs can be triggered too fast, making it impossible for the irq_thread to be able to keep up handling every request.
If two requests happen before any irq_thread handler is able to finish, no increment to threads_handled happen, causing threads_handled and threads_handled_last to be equal, which will ends up
causing irqs_unhandled to be incremented in note_interrupt().
Once irqs_unhandled gets to ~100k, the IRQ line gets disabled, disrupting the device work.
As of today, the only way to reset irqs_unhandled before disabling the IRQ line is to stay 100ms without having any increment to irqs_unhandled, which can be pretty hard to happen if the IRQ is very busy.
On top of that, some irq_thread handlers can handle requests in batches, effectively incrementing threads_handled only once despite dealing with a lot of requests, which make the irqs_unhandled to reach 100k pretty fast if the IRQ is getting a lot of requests.
This IRQ line disable bug can be easily reproduced with a serial8250 console on a PREEMPT_RT kernel: it only takes the user to print a lot of text to the console (or to ttyS0): around 300k chars should be enough.
To fix this bug, reset irqs_unhandled whenever irq_thread handles at least one IRQ request.
This fix makes possible to avoid disabling IRQs which irq_thread handlers can take long (while on heavy usage of the IRQ line), without losing the ability of disabling IRQs that actually get unhandled for too long.
--- kernel/irq/spurious.c | 8 ++++++++ 1 file changed, 8 insertions(+)
kernel/irq/spurious.c +8 -0
@@ -339,6 +339,14 @@ void note_interrupt(struct irq_desc *desc, irqreturn_t action_ret) handled |=SPURIOUS_DEFERRED ;if (handled != desc->threads_handled_last) { action_ret =IRQ_HANDLED ; + +/* +* If the thread handlers handle +* one IRQ reset the unhandled +* IRQ counter. +*/ + desc->irqs_unhandled =0 ; +/* * Note: We keep the SPURIOUS_DEFERRED * bit set. We are handling the
Signature · 1 line
2.43.0
Re: [RESEND RFC PATCH v1 1/2] irq/spurious: Reset irqs_unhandled if an irq_thread handles one IRQ request
Quoted 4 lines · Leonardo Bras
This IRQ line disable bug can be easily reproduced with a serial8250 console on a
PREEMPT_RTkernel: it only takes the user to print a lot of text to the console (or to ttyS0): around 300k chars should be enough.
That has nothing to do with RT, it's a problem of force threaded interrupts in combination with an edge type interrupt line and a hardware which keeps firing interrupts forever.
Quoted 2 lines
To fix this bug, reset
irqs_unhandledwheneverirq_threadhandles at least one IRQ request.
This papers over the symptom and makes runaway detection way weaker for all interrupts or breaks it completely.
The problem with edge type interrupts is that we cannot mask them like we do with level type interrupts in the hard interrupt handler and unmask them once the threaded handler finishes.
So yes, we need special rules here when:
1) The interrupt handler is force threaded
2) The interrupt line is edge type
3) The accumulated unhandled interrupts are within a sane margin
Thanks,
tglx
Re: [RESEND RFC PATCH v1 1/2] irq/spurious: Reset irqs_unhandled if an irq_thread handles one IRQ request
Quoted 9 lines · Thomas Gleixner
Quoted 4 lines · Leonardo Bras
This IRQ line disable bug can be easily reproduced with a serial8250 console on a
PREEMPT_RTkernel: it only takes the user to print a lot of text to the console (or to ttyS0): around 300k chars should be enough.That has nothing to do with RT, it's a problem of force threaded interrupts in combination with an edge type interrupt line and a hardware which keeps firing interrupts forever.
Hello Thomas, thanks for your feedback!
I agreed it has nothing to do with RT.
I just mentioned PREEMPT_RT as my test case scenario, since it enables force-threaded IRQs.
Quoted 6 lines
Quoted 3 lines
To fix this bug, reset
irqs_unhandledwheneverirq_threadhandles at least one IRQ request.This papers over the symptom and makes runaway detection way weaker for all interrupts or breaks it completely.
This change is supposed to only touch threaded interruptions, since it will reach the included line only if (action_ret == IRQ_WAKE_THREAD) and if desc->threads_handled changes since the last IRQ request.
This incrementing also happens only on irq_forced_thread_fn() and irq_thread_fn(), which are called only from irq_thread_fn().
But I get the overall worry about having this making runaway detection way weaker for all threaded interrupts.
I have previously worked on a solution that can be more precise and be an opt-in for drivers instead of a general solution:
It required a change in IRQ interface that let the handlers inform how many IRQs were actually handled (batching). This number would then be added to desc->threads_handle (in irq_*thread_fn(), just changing the atomic_inc() to atomic_add()), and then subtracted from irqs_unhandled at note_interrupt().
In the serial8250 case, the driver would be changed to use that interface, since it's already able to process multiple IRQs, and the bug just vanishes.
This also solved the serial driver issue, but required a deeper change in the code, which caused me to consider a simpler solution first.
This solution sure does give better runnaway detection. Do you think it would be better that the one I sent in this patch?
Quoted 9 lines
The problem with edge type interrupts is that we cannot mask them like we do with level type interrupts in the hard interrupt handler and unmask them once the threaded handler finishes.
So yes, we need special rules here when:
1) The interrupt handler is force threaded
Quoted 8 lines
2) The interrupt line is edge type
3) The accumulated unhandled interrupts are within a sane margin
Thanks,
tglx
Completelly agree, that's why I am suggesting dealing with threaded interruptions in a different way: reseting the unhandled count when it handles a request.
I am not sure how force threaded and just threaded are different in this scenario. Could you help me understand?
Thanks!
Leo
Re: [RESEND RFC PATCH v1 1/2] irq/spurious: Reset irqs_unhandled if an irq_thread handles one IRQ request
Quoted 47 lines · Leonardo Bras
Quoted 9 lines · Thomas Gleixner
Quoted 4 lines · Leonardo Bras
This IRQ line disable bug can be easily reproduced with a serial8250 console on a
PREEMPT_RTkernel: it only takes the user to print a lot of text to the console (or to ttyS0): around 300k chars should be enough.That has nothing to do with RT, it's a problem of force threaded interrupts in combination with an edge type interrupt line and a hardware which keeps firing interrupts forever.
Hello Thomas, thanks for your feedback!
I agreed it has nothing to do with RT.
I just mentionedPREEMPT_RTas my test case scenario, since it enables force-threaded IRQs.Quoted 6 lines
Quoted 3 lines
To fix this bug, reset
irqs_unhandledwheneverirq_threadhandles at least one IRQ request.This papers over the symptom and makes runaway detection way weaker for all interrupts or breaks it completely.
This change is supposed to only touch threaded interruptions, since it will reach the included line only if (
action_ret==IRQ_WAKE_THREAD) and ifdesc->threads_handledchanges since the last IRQ request.This incrementing also happens only on
irq_forced_thread_fn()andirq_thread_fn(), which are called only fromirq_thread_fn().But I get the overall worry about having this making runaway detection way weaker for all threaded interrupts.
I have previously worked on a solution that can be more precise and be an opt-in for drivers instead of a general solution:
It required a change in IRQ interface that let the handlers inform how many IRQs were actually handled (batching). This number would then be added to
desc->threads_handle(in irq_*thread_fn(), just changing theatomic_inc()toatomic_add()), and then subtracted fromirqs_unhandledatnote_interrupt().In the serial8250 case, the driver would be changed to use that interface, since it's already able to process multiple IRQs, and the bug just vanishes.
Quoted 5 lines
This also solved the serial driver issue, but required a deeper change in the code, which caused me to consider a simpler solution first.
This solution sure does give better runnaway detection. Do you think it would be better that the one I sent in this patch?
For reference, this is the alternative:
https://gitlab.com/LeoBras/linux/-/commits/serial8250
Please let me know it you think this one is better.
Thanks!
Leo
Quoted 28 lines
Quoted 10 lines
The problem with edge type interrupts is that we cannot mask them like we do with level type interrupts in the hard interrupt handler and unmask them once the threaded handler finishes.
So yes, we need special rules here when:
1) The interrupt handler is force threaded
Quoted 8 lines
2) The interrupt line is edge type
3) The accumulated unhandled interrupts are within a sane margin
Thanks,
tglx
Completelly agree, that's why I am suggesting dealing with threaded interruptions in a different way: reseting the unhandled count when it handles a request.
I am not sure how force threaded and just threaded are different in this scenario. Could you help me understand?
Thanks!
Leo
RFC PATCH 2/2 serial/8250: Avoid getting lock in RT atomic context
In reply to Leonardo BrasWith PREEMPT_RT enabled, a spin_lock_irqsave() becomes a possibly sleeping spin_lock(), without preempt_disable() or irq_disable().
This allows a task T1 to get preempted or interrupted while holding the port->lock. If the preempting task T2 need the lock, spin_lock() code will schedule T1 back until it finishes using the lock, and then go back to T2.
There is an issue if a T1 holding port->lock is interrupted by an IRQ, and this IRQ handler needs to get port->lock for writting (printk):spin_lock() code will try to reschedule the interrupt handler, which is in atomic context, causing a BUG() for trying to reschedule/sleep in atomic context.
So for the case (PREEMPT_RT && in_atomic()) try to get the lock, and if it fails proceed anyway, just like it's done in oops_in_progress case.
--- drivers/tty/serial/8250/8250_port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/8250/8250_port.c +1 -1
@@ -3397,7 +3397,7 @@ void serial8250_console_write(struct uart_8250_port *up, const char *s,touch_nmi_watchdog (); -if (oops_in_progress) + if (oops_in_progress || (IS_ENABLED(CONFIG_PREEMPT_RT) && in_atomic()) locked =uart_port_trylock_irqsave (port, &flags);else uart_port_lock_irqsave (port, &flags);
Signature · 1 line
2.43.0
Re: [RESEND RFC PATCH v1 2/2] serial/8250: Avoid getting lock in RT atomic context
Quoted 8 lines · Leonardo Bras
With
PREEMPT_RTenabled, aspin_lock_irqsave()becomes a possibly sleepingspin_lock(), withoutpreempt_disable()orirq_disable().This allows a task T1 to get preempted or interrupted while holding the
port->lock. If the preempting task T2 need the lock,spin_lock()code will schedule T1 back until it finishes using the lock, and then go back to T2.
Quoted 5 lines
There is an issue if a T1 holding
port->lockis interrupted by an IRQ, and this IRQ handler needs to getport->lockfor writting (printk):spin_lock()code will try to reschedule the interrupt handler, which is in atomic context, causing aBUG()for trying to reschedule/sleep in atomic context.
I thought that the printk side was supposed to be become aware when it's not safe to write to serial side so the printing can be deferred... Has that plan changed?
Signature · 1 line
i.
Quoted 22 lines
So for the case (
PREEMPT_RT&&in_atomic()) try to get the lock, and if it fails proceed anyway, just like it's done inoops_in_progresscase.Signed-off-by Leonardo Bras <[email protected]>--- drivers/tty/serial/8250/8250_port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/tty/serial/8250/8250_port.c +1
-1@@ -3397,7 +3397,7 @@ void serial8250_console_write(struct uart_8250_port *up, const char *s,touch_nmi_watchdog (); -if (oops_in_progress) + if (oops_in_progress || (IS_ENABLED(CONFIG_PREEMPT_RT) && in_atomic()) locked =uart_port_trylock_irqsave (port, &flags);else uart_port_lock_irqsave (port, &flags);
Re: [RESEND RFC PATCH v1 2/2] serial/8250: Avoid getting lock in RT atomic context
Quoted 10 lines · Ilpo Järvinen
Quoted 8 lines · Leonardo Bras
With
PREEMPT_RTenabled, aspin_lock_irqsave()becomes a possibly sleepingspin_lock(), withoutpreempt_disable()orirq_disable().This allows a task T1 to get preempted or interrupted while holding the
port->lock. If the preempting task T2 need the lock,spin_lock()code will schedule T1 back until it finishes using the lock, and then go back to T2.
Quoted 5 lines
Quoted 5 lines
There is an issue if a T1 holding
port->lockis interrupted by an IRQ, and this IRQ handler needs to getport->lockfor writting (printk):spin_lock()code will try to reschedule the interrupt handler, which is in atomic context, causing aBUG()for trying to reschedule/sleep in atomic context.
Hello Ilpo, thanks for replying!
Quoted 7 lines
I thought that the printk side was supposed to be become aware when it's not safe to write to serial side so the printing can be deferred... Has that plan changed?
Signature · 1 line
i.
I was not aware of this plan.
Well, at least in an PREEMPT_RT=y kernel I have found this same bug reproducing several times, and through the debugging that I went through I saw no mechanism for preventing it.
This is one example of the bug:
While writing to serial with serial8250_tx_chars in a irq_thread handler there is an interruption, and __report_bad_irq() tries to printk stuff to the console, and when printk goes down to serial8250_console_write() and tried to get the port->lock, which causes the "BUG: scheduling while atomic":
[ 42.485878] irq 4: nobody cared (try booting with the "irqpoll" option) [ 42.485886] BUG: scheduling while atomic: irq/4-ttyS0/751/0x00010002 [ 42.485890] Modules linked in: [ 42.485892] Preemption disabled at: [ 42.485893] [<ffffffff8118ac80>] irq_enter_rcu+0x10/0x80 [ 42.485919] CPU: 0 PID: 751 Comm: irq/4-ttyS0 Not tainted 6.7.0-rc6+ #6 [ 42.485927] Hardware name: Red Hat KVM/RHEL, BIOS 1.16.3-1.el9 04/01/2014 [ 42.485929] Call Trace: [ 42.485940] <IRQ> [ 42.485944] dump_stack_lvl+0x33/0x50 [ 42.485976] __schedule_bug+0x89/0xa0 [ 42.485991] schedule_debug.constprop.0+0xd1/0x120 [ 42.485996] __schedule+0x50/0x690 [ 42.486026] schedule_rtlock+0x1e/0x40 [ 42.486029] rtlock_slowlock_locked+0xe7/0x2b0 [ 42.486047] rt_spin_lock+0x41/0x60 [ 42.486051] serial8250_console_write+0x1be/0x460 [ 42.486094] console_flush_all+0x18d/0x3c0 [ 42.486111] console_unlock+0x6c/0xd0 [ 42.486117] vprintk_emit+0x1d6/0x290 [ 42.486122] _printk+0x58/0x80 [ 42.486139] __report_bad_irq+0x26/0xc0 [ 42.486147] note_interrupt+0x2a1/0x2f0 [ 42.486155] handle_irq_event+0x84/0x90 [ 42.486161] handle_edge_irq+0x9f/0x260 [ 42.486168] __common_interrupt+0x68/0x100 [ 42.486178] common_interrupt+0x9f/0xc0 [ 42.486184] </IRQ>
Thanks!
Leo
Quoted 24 lines
Quoted 23 lines
So for the case (
PREEMPT_RT&&in_atomic()) try to get the lock, and if it fails proceed anyway, just like it's done inoops_in_progresscase.Signed-off-by Leonardo Bras <[email protected]>--- drivers/tty/serial/8250/8250_port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/tty/serial/8250/8250_port.c +1
-1@@ -3397,7 +3397,7 @@ void serial8250_console_write(struct uart_8250_port *up, const char *s,touch_nmi_watchdog (); -if (oops_in_progress) + if (oops_in_progress || (IS_ENABLED(CONFIG_PREEMPT_RT) && in_atomic()) locked =uart_port_trylock_irqsave (port, &flags);else uart_port_lock_irqsave (port, &flags);
Re: [RESEND RFC PATCH v1 2/2] serial/8250: Avoid getting lock in RT atomic context
Quoted 11 lines · Leonardo Bras
Well, at least in an PREEMPT_RT=y kernel I have found this same bug reproducing several times, and through the debugging that I went through I saw no mechanism for preventing it.
This is one example of the bug:
While writing to serial withserial8250_tx_charsin airq_threadhandler there is an interruption, and__report_bad_irq()tries to printk stuff to the console, and when printk goes down toserial8250_console_write()and tried to get theport->lock, which causes the "BUG: scheduling while atomic":
Quoted 6 lines
[ 42.485878] irq 4: nobody cared (try booting with the "irqpoll" option) [ 42.485886] BUG: scheduling while atomic: irq/4-ttyS0/751/0x00010002 [ 42.485890] Modules linked in: [ 42.485892] Preemption disabled at: [ 42.485893] [<ffffffff8118ac80>] irq_enter_rcu+0x10/0x80 [ 42.485919] CPU: 0 PID: 751 Comm: irq/4-ttyS0 Not tainted 6.7.0-rc6+ #6
This is 6.7.0-rc6+. How are you setting PREEMPT_RT?
Quoted 11 lines
[ 42.485927] Hardware name: Red Hat KVM/RHEL, BIOS 1.16.3-1.el9 04/01/2014 [ 42.485929] Call Trace: [ 42.485940] <IRQ> [ 42.485944] dump_stack_lvl+0x33/0x50 [ 42.485976] __schedule_bug+0x89/0xa0 [ 42.485991] schedule_debug.constprop.0+0xd1/0x120 [ 42.485996] __schedule+0x50/0x690 [ 42.486026] schedule_rtlock+0x1e/0x40 [ 42.486029] rtlock_slowlock_locked+0xe7/0x2b0 [ 42.486047] rt_spin_lock+0x41/0x60 [ 42.486051] serial8250_console_write+0x1be/0x460
On PREEMPT_RT-patched kernel, serial8250_console_write() is not compiled. So obviously you are not running a PREEMPT_RT-patched kernel.
Quoted 2 lines
[ 42.486094] console_flush_all+0x18d/0x3c0 [ 42.486111] console_unlock+0x6c/0xd0
Flushing on console_unlock() is the legacy method.
I assume you are using a mainline kernel with forced threading of irqs. Mainline has many known problems with console printing, including calling printk when the port->lock is held.
This has been discussed before [0].
Quoted 9 lines
[ 42.486117] vprintk_emit+0x1d6/0x290 [ 42.486122] _printk+0x58/0x80 [ 42.486139] __report_bad_irq+0x26/0xc0 [ 42.486147] note_interrupt+0x2a1/0x2f0 [ 42.486155] handle_irq_event+0x84/0x90 [ 42.486161] handle_edge_irq+0x9f/0x260 [ 42.486168] __common_interrupt+0x68/0x100 [ 42.486178] common_interrupt+0x9f/0xc0 [ 42.486184] </IRQ>
If you want to fix any threaded irq problems relating to printk and console drivers, please use the latest PREEMPT_RT patch series with CONFIG_PREEMPT_RT enabled. This is the current work that is being reviewed on LKML for mainline inclusion. Thanks!
John Ogness
Re: [RESEND RFC PATCH v1 2/2] serial/8250: Avoid getting lock in RT atomic context
Quoted 12 lines · John Ogness
Quoted 11 lines · Leonardo Bras
Well, at least in an PREEMPT_RT=y kernel I have found this same bug reproducing several times, and through the debugging that I went through I saw no mechanism for preventing it.
This is one example of the bug:
While writing to serial withserial8250_tx_charsin airq_threadhandler there is an interruption, and__report_bad_irq()tries to printk stuff to the console, and when printk goes down toserial8250_console_write()and tried to get theport->lock, which causes the "BUG: scheduling while atomic":
Quoted 8 lines
Quoted 6 lines
[ 42.485878] irq 4: nobody cared (try booting with the "irqpoll" option) [ 42.485886] BUG: scheduling while atomic: irq/4-ttyS0/751/0x00010002 [ 42.485890] Modules linked in: [ 42.485892] Preemption disabled at: [ 42.485893] [<ffffffff8118ac80>] irq_enter_rcu+0x10/0x80 [ 42.485919] CPU: 0 PID: 751 Comm: irq/4-ttyS0 Not tainted 6.7.0-rc6+ #6This is 6.7.0-rc6+. How are you setting
PREEMPT_RT?
By setting ARCH_SUPPORTS_RT=y
Quoted 13 lines
Quoted 12 lines
[ 42.485927] Hardware name: Red Hat KVM/RHEL, BIOS 1.16.3-1.el9 04/01/2014 [ 42.485929] Call Trace: [ 42.485940] <IRQ> [ 42.485944] dump_stack_lvl+0x33/0x50 [ 42.485976] __schedule_bug+0x89/0xa0 [ 42.485991] schedule_debug.constprop.0+0xd1/0x120 [ 42.485996] __schedule+0x50/0x690 [ 42.486026] schedule_rtlock+0x1e/0x40 [ 42.486029] rtlock_slowlock_locked+0xe7/0x2b0 [ 42.486047] rt_spin_lock+0x41/0x60 [ 42.486051] serial8250_console_write+0x1be/0x460
Quoted 2 lines
On PREEMPT_RT-patched kernel,
serial8250_console_write()is not compiled. So obviously you are not running a PREEMPT_RT-patched kernel.
Yes, as mentioned to Thomas before, I am on Vanilla torvalds/linux. I was not aware of any extra patches for PREEMPT_RT, could you please point the repo, or the patchset for that PREEMPT_RT-patched version?
Quoted 5 lines
Quoted 3 lines
[ 42.486094] console_flush_all+0x18d/0x3c0 [ 42.486111] console_unlock+0x6c/0xd0Flushing on
console_unlock()is the legacy method.
Great! so this part is solved :)
Quoted 4 lines
I assume you are using a mainline kernel with forced threading of irqs. Mainline has many known problems with console printing, including calling printk when the
port->lockis held.
I am using mainline (torvalds/linux) kernel, forcing ARCH_SUPPORTS_RT:
arch/Kconfig +1 -1
@@ -1195,7 +1195,7 @@ config ARCH_NO_PREEMPT bool config ARCH_SUPPORTS_RT - bool + def_bool y
Since I was not aware of a PREEMPT_RT-patched tree, I did this so I could compile a PREEMPT_RT kernel.
Quoted 13 lines
This has been discussed before [0].
Quoted 9 lines
[ 42.486117] vprintk_emit+0x1d6/0x290 [ 42.486122] _printk+0x58/0x80 [ 42.486139] __report_bad_irq+0x26/0xc0 [ 42.486147] note_interrupt+0x2a1/0x2f0 [ 42.486155] handle_irq_event+0x84/0x90 [ 42.486161] handle_edge_irq+0x9f/0x260 [ 42.486168] __common_interrupt+0x68/0x100 [ 42.486178] common_interrupt+0x9f/0xc0 [ 42.486184] </IRQ>
Quoted 5 lines
If you want to fix any threaded irq problems relating to printk and console drivers, please use the latest
PREEMPT_RTpatch series withCONFIG_PREEMPT_RTenabled. This is the current work that is being reviewed on LKML for mainline inclusion. Thanks!
Sure, please let me know of where can I find the latest PREEMPT_RT patch series so I can re-test my bug. By what you comment, it's higly probable that patch 2/2 will not be necessary.
On the other hand, unless some extra work was done in preventing the scenario in patch 1/2, I think that can still be discussed.
Quoted 4 lines
John Ogness
Thanks!
Leo
Re: [RESEND RFC PATCH v1 2/2] serial/8250: Avoid getting lock in RT atomic context
Quoted 3 lines · Leonardo Bras
Sure, please let me know of where can I find the latest
PREEMPT_RTpatch series so I can re-test my bug. By what you comment, it's higly probable that patch 2/2 will not be necessary.
Some links for you:
The Real-Time Wiki at the Linux Foundation:
https://wiki.linuxfoundation.org/realtime/
The latest development RT patch series for 6.7:
https://cdn.kernel.org/pub/linux/kernel/projects/rt/6.7/patches-6.7-rt6.tar.xz
RT git (branch linux-6.7.y-rt-rebase is probably what you want):
https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git
Quoted 2 lines
On the other hand, unless some extra work was done in preventing the scenario in patch 1/2, I think that can still be discussed.
I agree. Thanks for looking into this.
John
Re: [RESEND RFC PATCH v1 2/2] serial/8250: Avoid getting lock in RT atomic context
Quoted 13 lines · John Ogness
Quoted 3 lines · Leonardo Bras
Sure, please let me know of where can I find the latest
PREEMPT_RTpatch series so I can re-test my bug. By what you comment, it's higly probable that patch 2/2 will not be necessary.Some links for you:
The Real-Time Wiki at the Linux Foundation:
Quoted 9 lines
The latest development RT patch series for 6.7:
https://cdn.kernel.org/pub/linux/kernel/projects/rt/6.7/patches-6.7-rt6.tar.xz
RT git (branch linux-6.7.y-rt-rebase is probably what you want):
https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git
Hello John, thank you for sharing the links!
Quoted 8 lines
Quoted 3 lines
On the other hand, unless some extra work was done in preventing the scenario in patch 1/2, I think that can still be discussed.
I agree. Thanks for looking into this.
John
Thank you!
Leo
Jiri Slaby
maintainerRe: [RESEND RFC PATCH v1 2/2] serial/8250: Avoid getting lock in RT atomic context
In reply to Leonardo BrasQuoted 13 lines · Leonardo Bras
I am using mainline (torvalds/linux) kernel, forcing
ARCH_SUPPORTS_RT:arch/Kconfig +1
-1@@ -1195,7 +1195,7 @@ config ARCH_NO_PREEMPT bool config ARCH_SUPPORTS_RT - bool + def_bool y
Quoted 2 lines
Since I was not aware of a PREEMPT_RT-patched tree, I did this so I could compile a
PREEMPT_RTkernel.
Huh, when exactly did you intend to mention this?
Signature · 2 lines
js suse labs
Re: [RESEND RFC PATCH v1 2/2] serial/8250: Avoid getting lock in RT atomic context
Quoted 13 lines · Jiri Slaby
Quoted 12 lines · Leonardo Bras
I am using mainline (torvalds/linux) kernel, forcing
ARCH_SUPPORTS_RT:arch/Kconfig +1
-1@@ -1195,7 +1195,7 @@ config ARCH_NO_PREEMPT bool config ARCH_SUPPORTS_RT - bool + def_bool y
Quoted 4 lines
Quoted 2 lines
Since I was not aware of a PREEMPT_RT-patched tree, I did this so I could compile a
PREEMPT_RTkernel.Huh, when exactly did you intend to mention this?
Since I was not aware of an PREEMPT_RT-patched tree, I thought that this was the vanilla way to get a PREEMPT_RT kernel running.
TBH I did not even though that there were an external repo for PREEMPT_RT. I mean, I knew about non-mainline patches in the past, but I thought everything got already merged upstream, and any other patches would be WIP.
I understand this was a mistake on my part, and I feel sorry if this brought any pain to reviewers. For the future, I will be basing my RT work in this RT-devel tree shared by John.
Thanks!
Leo
Quoted 5 lines
Signature · 3 lines
-- js suse labs
Re: [RESEND RFC PATCH v1 2/2] serial/8250: Avoid getting lock in RT atomic context
In reply to Leonardo BrasQuoted 8 lines · Leonardo Bras
With
PREEMPT_RTenabled, aspin_lock_irqsave()becomes a possibly sleepingspin_lock(), withoutpreempt_disable()orirq_disable().This allows a task T1 to get preempted or interrupted while holding the
port->lock. If the preempting task T2 need the lock,spin_lock()code will schedule T1 back until it finishes using the lock, and then go back to T2.
Quoted 8 lines
There is an issue if a T1 holding
port->lockis interrupted by an IRQ, and this IRQ handler needs to getport->lockfor writting (printk):spin_lock()code will try to reschedule the interrupt handler, which is in atomic context, causing aBUG()for trying to reschedule/sleep in atomic context.So for the case (
PREEMPT_RT&&in_atomic()) try to get the lock, and if it fails proceed anyway, just like it's done inoops_in_progresscase.
That's just blantantly wrong. The locks are really only to be ignored for the oops case, but not for regular printk.
I assume that this is not against the latest RT kernel as that should not have that problem at all.
Thanks,
tglx
Re: [RESEND RFC PATCH v1 2/2] serial/8250: Avoid getting lock in RT atomic context
Quoted 15 lines · Thomas Gleixner
Quoted 14 lines · Leonardo Bras
With
PREEMPT_RTenabled, aspin_lock_irqsave()becomes a possibly sleepingspin_lock(), withoutpreempt_disable()orirq_disable().This allows a task T1 to get preempted or interrupted while holding the
port->lock. If the preempting task T2 need the lock,spin_lock()code will schedule T1 back until it finishes using the lock, and then go back to T2.There is an issue if a T1 holding
port->lockis interrupted by an IRQ, and this IRQ handler needs to getport->lockfor writting (printk):spin_lock()code will try to reschedule the interrupt handler, which is in atomic context, causing aBUG()for trying to reschedule/sleep in atomic context.
Quoted 5 lines
Quoted 2 lines
So for the case (
PREEMPT_RT&&in_atomic()) try to get the lock, and if it fails proceed anyway, just like it's done inoops_in_progresscase.That's just blantantly wrong. The locks are really only to be ignored for the oops case, but not for regular printk.
I agree, but the alternative was to have a BUG() due to scheduling in atomic context. This would only ignore the lock if it was already taken anyway.
That being said, I agree it is not the best solution for the issue, and just sent this in the RFC in order to get feedback on what could be done.
Quoted 3 lines
I assume that this is not against the latest RT kernel as that should not have that problem at all.
I am based on torvalds/linux at master branch, so maybe I am missing some RT-specific patches. Which tree do you recommend me testing?
Quoted 5 lines
Thanks,
tglx
Thank you!
Leo
kernel test robot
build botRe: [RESEND RFC PATCH v1 2/2] serial/8250: Avoid getting lock in RT atomic context
In reply to Leonardo Braskernel test robot noticed the following build errors:
Hi Leonardo,
[This is a private test report for your RFC patch.] kernel test robot noticed the following build errors:
[auto build test ERROR on 052d534373b7ed33712a63d5e17b2b6cdbce84fd]
url: https://github.com/intel-lab-lkp/linux/commits/Leonardo-Bras/irq-spurious-Reset-irqs_unhandled-if-an-irq_thread-handles-one-IRQ-request/20240116-153933 base: 052d534373b7ed33712a63d5e17b2b6cdbce84fd patch link: https://lore.kernel.org/r/20240116073701.2356171-3-leobras%40redhat.com patch subject: [RESEND RFC PATCH v1 2/2] serial/8250: Avoid getting lock in RT atomic context config: i386-buildonly-randconfig-001-20240119 (https://download.01.org/0day-ci/archive/20240119/[email protected]/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240119/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All error/warnings (new ones prefixed by >>):
drivers/tty/serial/8250/8250_port.c: In function 'serial8250_console_write':
>> drivers/tty/serial/8250/8250_port.c:3401:3: error: expected ')' before 'locked'
locked = uart_port_trylock_irqsave(port, &flags);
^~~~~~
>> drivers/tty/serial/8250/8250_port.c:3474:1: error: expected expression before '}' token
}
^
>> drivers/tty/serial/8250/8250_port.c:3396:6: warning: unused variable 'locked' [-Wunused-variable]
int locked = 1;
^~~~~~
>> drivers/tty/serial/8250/8250_port.c:3395:20: warning: unused variable 'use_fifo' [-Wunused-variable]
unsigned int ier, use_fifo;
^~~~~~~~
>> drivers/tty/serial/8250/8250_port.c:3395:15: warning: unused variable 'ier' [-Wunused-variable]
unsigned int ier, use_fifo;
^~~
>> drivers/tty/serial/8250/8250_port.c:3394:16: warning: unused variable 'flags' [-Wunused-variable]
unsigned long flags;
^~~~~
>> drivers/tty/serial/8250/8250_port.c:3393:20: warning: unused variable 'port' [-Wunused-variable]
struct uart_port *port = &up->port;
^~~~
>> drivers/tty/serial/8250/8250_port.c:3392:26: warning: unused variable 'em485' [-Wunused-variable]
struct uart_8250_em485 *em485 = up->em485;
^~~~~
At top level:
>> drivers/tty/serial/8250/8250_port.c:3357:13: warning: 'serial8250_console_fifo_write' defined but not used [-Wunused-function]
static void serial8250_console_fifo_write(struct uart_8250_port *up,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/tty/serial/8250/8250_port.c:3328:13: warning: 'serial8250_console_restore' defined but not used [-Wunused-function]
static void serial8250_console_restore(struct uart_8250_port *up)
^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/tty/serial/8250/8250_port.c:3317:13: warning: 'serial8250_console_putchar' defined but not used [-Wunused-function] static void serial8250_console_putchar(struct uart_port *port, unsigned char ch)
^~~~~~~~~~~~~~~~~~~~~~~~~~
vim +3401 drivers/tty/serial/8250/8250_port.c
b6830f6df8914f Peter Hurley 2015-06-27 3316
3f8bab174cb26a Jiri Slaby 2022-03-03 @3317 static void serial8250_console_putchar(struct uart_port *port, unsigned char ch)
b6830f6df8914f Peter Hurley 2015-06-27 3318 {
b6830f6df8914f Peter Hurley 2015-06-27 3319 struct uart_8250_port *up = up_to_u8250p(port);
b6830f6df8914f Peter Hurley 2015-06-27 3320
b6830f6df8914f Peter Hurley 2015-06-27 3321 wait_for_xmitr(up, UART_LSR_THRE);
b6830f6df8914f Peter Hurley 2015-06-27 3322 serial_port_out(port, UART_TX, ch);
b6830f6df8914f Peter Hurley 2015-06-27 3323 }
b6830f6df8914f Peter Hurley 2015-06-27 3324
10791233e98fbd Peter Hurley 2015-09-25 3325 /*
10791233e98fbd Peter Hurley 2015-09-25 3326 * Restore serial console when h/w power-off detected
10791233e98fbd Peter Hurley 2015-09-25 3327 */
10791233e98fbd Peter Hurley 2015-09-25 @3328 static void serial8250_console_restore(struct uart_8250_port *up)
10791233e98fbd Peter Hurley 2015-09-25 3329 {
10791233e98fbd Peter Hurley 2015-09-25 3330 struct uart_port *port = &up->port;
10791233e98fbd Peter Hurley 2015-09-25 3331 struct ktermios termios;
10791233e98fbd Peter Hurley 2015-09-25 3332 unsigned int baud, quot, frac = 0;
10791233e98fbd Peter Hurley 2015-09-25 3333
10791233e98fbd Peter Hurley 2015-09-25 3334 termios.c_cflag = port->cons->cflag;
379a33786d489a Pali Rohár 2022-09-24 3335 termios.c_ispeed = port->cons->ispeed;
379a33786d489a Pali Rohár 2022-09-24 3336 termios.c_ospeed = port->cons->ospeed;
379a33786d489a Pali Rohár 2022-09-24 3337 if (port->state->port.tty && termios.c_cflag == 0) {
10791233e98fbd Peter Hurley 2015-09-25 3338 termios.c_cflag = port->state->port.tty->termios.c_cflag;
379a33786d489a Pali Rohár 2022-09-24 3339 termios.c_ispeed = port->state->port.tty->termios.c_ispeed;
379a33786d489a Pali Rohár 2022-09-24 3340 termios.c_ospeed = port->state->port.tty->termios.c_ospeed;
379a33786d489a Pali Rohár 2022-09-24 3341 }
10791233e98fbd Peter Hurley 2015-09-25 3342
10791233e98fbd Peter Hurley 2015-09-25 3343 baud = serial8250_get_baud_rate(port, &termios, NULL);
6101be86cb1c46 Jisheng Zhang 2018-07-04 3344 quot = serial8250_get_divisor(port, baud, &frac);
10791233e98fbd Peter Hurley 2015-09-25 3345
10791233e98fbd Peter Hurley 2015-09-25 3346 serial8250_set_divisor(port, baud, quot, frac);
10791233e98fbd Peter Hurley 2015-09-25 3347 serial_port_out(port, UART_LCR, up->lcr);
6e6eebdf5e2455 Maciej W. Rozycki 2022-04-18 3348 serial8250_out_MCR(up, up->mcr | UART_MCR_DTR | UART_MCR_RTS);
10791233e98fbd Peter Hurley 2015-09-25 3349 }
10791233e98fbd Peter Hurley 2015-09-25 3350
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3351 /*
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3352 * Print a string to the serial port using the device FIFO
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3353 *
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3354 * It sends fifosize bytes and then waits for the fifo
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3355 * to get empty.
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3356 */
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 @3357 static void serial8250_console_fifo_write(struct uart_8250_port *up,
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3358 const char *s, unsigned int count)
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3359 {
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3360 int i;
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3361 const char *end = s + count;
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3362 unsigned int fifosize = up->tx_loadsz;
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3363 bool cr_sent = false;
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3364
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3365 while (s != end) {
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3366 wait_for_lsr(up, UART_LSR_THRE);
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3367
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3368 for (i = 0; i < fifosize && s != end; ++i) {
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3369 if (*s == '\n' && !cr_sent) {
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3370 serial_out(up, UART_TX, '\r');
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3371 cr_sent = true;
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3372 } else {
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3373 serial_out(up, UART_TX, *s++);
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3374 cr_sent = false;
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3375 }
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3376 }
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3377 }
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3378 }
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3379
b6830f6df8914f Peter Hurley 2015-06-27 3380 /*
b6830f6df8914f Peter Hurley 2015-06-27 3381 * Print a string to the serial port trying not to disturb
b6830f6df8914f Peter Hurley 2015-06-27 3382 * any possible real use of the port...
b6830f6df8914f Peter Hurley 2015-06-27 3383 *
b6830f6df8914f Peter Hurley 2015-06-27 3384 * The console_lock must be held when we get here.
bedb404e91bb29 Andy Shevchenko 2020-02-17 3385 *
bedb404e91bb29 Andy Shevchenko 2020-02-17 3386 * Doing runtime PM is really a bad idea for the kernel console.
bedb404e91bb29 Andy Shevchenko 2020-02-17 3387 * Thus, we assume the function is called when device is powered up.
b6830f6df8914f Peter Hurley 2015-06-27 3388 */
b6830f6df8914f Peter Hurley 2015-06-27 3389 void serial8250_console_write(struct uart_8250_port *up, const char *s,
b6830f6df8914f Peter Hurley 2015-06-27 3390 unsigned int count)
b6830f6df8914f Peter Hurley 2015-06-27 3391 {
7f9803072ff636 Lukas Wunner 2020-02-28 @3392 struct uart_8250_em485 *em485 = up->em485;
b6830f6df8914f Peter Hurley 2015-06-27 @3393 struct uart_port *port = &up->port;
b6830f6df8914f Peter Hurley 2015-06-27 @3394 unsigned long flags;
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 @3395 unsigned int ier, use_fifo;
b6830f6df8914f Peter Hurley 2015-06-27 @3396 int locked = 1;
b6830f6df8914f Peter Hurley 2015-06-27 3397
b6830f6df8914f Peter Hurley 2015-06-27 3398 touch_nmi_watchdog();
b6830f6df8914f Peter Hurley 2015-06-27 3399
5194c99b116191 Leonardo Bras 2024-01-16 3400 if (oops_in_progress || (IS_ENABLED(CONFIG_PREEMPT_RT) && in_atomic())
e8f87d3c335702 Thomas Gleixner 2023-09-14 @3401 locked = uart_port_trylock_irqsave(port, &flags);
b6830f6df8914f Peter Hurley 2015-06-27 3402 else
e8f87d3c335702 Thomas Gleixner 2023-09-14 3403 uart_port_lock_irqsave(port, &flags);
b6830f6df8914f Peter Hurley 2015-06-27 3404
b6830f6df8914f Peter Hurley 2015-06-27 3405 /*
b6830f6df8914f Peter Hurley 2015-06-27 3406 * First save the IER then disable the interrupts
b6830f6df8914f Peter Hurley 2015-06-27 3407 */
b6830f6df8914f Peter Hurley 2015-06-27 3408 ier = serial_port_in(port, UART_IER);
a3911f6ea5542d Ilpo Järvinen 2022-08-16 3409 serial8250_clear_IER(up);
b6830f6df8914f Peter Hurley 2015-06-27 3410
b6830f6df8914f Peter Hurley 2015-06-27 3411 /* check scratch reg to see if port powered off during system sleep */
b6830f6df8914f Peter Hurley 2015-06-27 3412 if (up->canary && (up->canary != serial_port_in(port, UART_SCR))) {
10791233e98fbd Peter Hurley 2015-09-25 3413 serial8250_console_restore(up);
b6830f6df8914f Peter Hurley 2015-06-27 3414 up->canary = 0;
b6830f6df8914f Peter Hurley 2015-06-27 3415 }
b6830f6df8914f Peter Hurley 2015-06-27 3416
7f9803072ff636 Lukas Wunner 2020-02-28 3417 if (em485) {
7f9803072ff636 Lukas Wunner 2020-02-28 3418 if (em485->tx_stopped)
7f9803072ff636 Lukas Wunner 2020-02-28 3419 up->rs485_start_tx(up);
7f9803072ff636 Lukas Wunner 2020-02-28 3420 mdelay(port->rs485.delay_rts_before_send);
7f9803072ff636 Lukas Wunner 2020-02-28 3421 }
7f9803072ff636 Lukas Wunner 2020-02-28 3422
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3423 use_fifo = (up->capabilities & UART_CAP_FIFO) &&
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3424 /*
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3425 * BCM283x requires to check the fifo
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3426 * after each byte.
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3427 */
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3428 !(up->capabilities & UART_CAP_MINI) &&
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3429 /*
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3430 * tx_loadsz contains the transmit fifo size
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3431 */
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3432 up->tx_loadsz > 1 &&
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3433 (up->fcr & UART_FCR_ENABLE_FIFO) &&
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3434 port->state &&
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3435 test_bit(TTY_PORT_INITIALIZED, &port->state->port.iflags) &&
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3436 /*
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3437 * After we put a data in the fifo, the controller will send
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3438 * it regardless of the CTS state. Therefore, only use fifo
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3439 * if we don't use control flow.
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3440 */
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3441 !(up->port.flags & UPF_CONS_FLOW);
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3442
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3443 if (likely(use_fifo))
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3444 serial8250_console_fifo_write(up, s, count);
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3445 else
b6830f6df8914f Peter Hurley 2015-06-27 3446 uart_console_write(port, s, count, serial8250_console_putchar);
b6830f6df8914f Peter Hurley 2015-06-27 3447
b6830f6df8914f Peter Hurley 2015-06-27 3448 /*
b6830f6df8914f Peter Hurley 2015-06-27 3449 * Finally, wait for transmitter to become empty
b6830f6df8914f Peter Hurley 2015-06-27 3450 * and restore the IER
b6830f6df8914f Peter Hurley 2015-06-27 3451 */
34619de1b8cb52 Ilpo Järvinen 2022-06-24 3452 wait_for_xmitr(up, UART_LSR_BOTH_EMPTY);
b6830f6df8914f Peter Hurley 2015-06-27 3453
7f9803072ff636 Lukas Wunner 2020-02-28 3454 if (em485) {
4e36f94e996ebe Lukas Wunner 2020-03-27 3455 mdelay(port->rs485.delay_rts_after_send);
7f9803072ff636 Lukas Wunner 2020-02-28 3456 if (em485->tx_stopped)
7f9803072ff636 Lukas Wunner 2020-02-28 3457 up->rs485_stop_tx(up);
7f9803072ff636 Lukas Wunner 2020-02-28 3458 }
7f9803072ff636 Lukas Wunner 2020-02-28 3459
8d5b305484e8a3 Lukas Wunner 2020-03-27 3460 serial_port_out(port, UART_IER, ier);
8d5b305484e8a3 Lukas Wunner 2020-03-27 3461
b6830f6df8914f Peter Hurley 2015-06-27 3462 /*
b6830f6df8914f Peter Hurley 2015-06-27 3463 * The receive handling will happen properly because the
b6830f6df8914f Peter Hurley 2015-06-27 3464 * receive ready bit will still be set; it is not cleared
b6830f6df8914f Peter Hurley 2015-06-27 3465 * on read. However, modem control will not, we must
b6830f6df8914f Peter Hurley 2015-06-27 3466 * call it if we have saved something in the saved flags
b6830f6df8914f Peter Hurley 2015-06-27 3467 * while processing with interrupts off.
b6830f6df8914f Peter Hurley 2015-06-27 3468 */
b6830f6df8914f Peter Hurley 2015-06-27 3469 if (up->msr_saved_flags)
b6830f6df8914f Peter Hurley 2015-06-27 3470 serial8250_modem_status(up);
b6830f6df8914f Peter Hurley 2015-06-27 3471
b6830f6df8914f Peter Hurley 2015-06-27 3472 if (locked)
e8f87d3c335702 Thomas Gleixner 2023-09-14 3473 uart_port_unlock_irqrestore(port, flags);
b6830f6df8914f Peter Hurley 2015-06-27 @3474 }
b6830f6df8914f Peter Hurley 2015-06-27 3475 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
kernel test robot
build botRe: [RESEND RFC PATCH v1 2/2] serial/8250: Avoid getting lock in RT atomic context
In reply to Leonardo Braskernel test robot noticed the following build errors:
Hi Leonardo,
[This is a private test report for your RFC patch.] kernel test robot noticed the following build errors:
[auto build test ERROR on 052d534373b7ed33712a63d5e17b2b6cdbce84fd]
url: https://github.com/intel-lab-lkp/linux/commits/Leonardo-Bras/irq-spurious-Reset-irqs_unhandled-if-an-irq_thread-handles-one-IRQ-request/20240116-153933 base: 052d534373b7ed33712a63d5e17b2b6cdbce84fd patch link: https://lore.kernel.org/r/20240116073701.2356171-3-leobras%40redhat.com patch subject: [RESEND RFC PATCH v1 2/2] serial/8250: Avoid getting lock in RT atomic context config: i386-randconfig-011-20240119 (https://download.01.org/0day-ci/archive/20240119/[email protected]/config) compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240119/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> drivers/tty/serial/8250/8250_port.c:3401:3: error: expected ')'
3401 | locked = uart_port_trylock_irqsave(port, &flags);
| ^
drivers/tty/serial/8250/8250_port.c:3400:5: note: to match this '('
3400 | if (oops_in_progress || (IS_ENABLED(CONFIG_PREEMPT_RT) && in_atomic())
| ^1 error generated.
vim +3401 drivers/tty/serial/8250/8250_port.c
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3379
b6830f6df8914f Peter Hurley 2015-06-27 3380 /*
b6830f6df8914f Peter Hurley 2015-06-27 3381 * Print a string to the serial port trying not to disturb
b6830f6df8914f Peter Hurley 2015-06-27 3382 * any possible real use of the port...
b6830f6df8914f Peter Hurley 2015-06-27 3383 *
b6830f6df8914f Peter Hurley 2015-06-27 3384 * The console_lock must be held when we get here.
bedb404e91bb29 Andy Shevchenko 2020-02-17 3385 *
bedb404e91bb29 Andy Shevchenko 2020-02-17 3386 * Doing runtime PM is really a bad idea for the kernel console.
bedb404e91bb29 Andy Shevchenko 2020-02-17 3387 * Thus, we assume the function is called when device is powered up.
b6830f6df8914f Peter Hurley 2015-06-27 3388 */
b6830f6df8914f Peter Hurley 2015-06-27 3389 void serial8250_console_write(struct uart_8250_port *up, const char *s,
b6830f6df8914f Peter Hurley 2015-06-27 3390 unsigned int count)
b6830f6df8914f Peter Hurley 2015-06-27 3391 {
7f9803072ff636 Lukas Wunner 2020-02-28 3392 struct uart_8250_em485 *em485 = up->em485;
b6830f6df8914f Peter Hurley 2015-06-27 3393 struct uart_port *port = &up->port;
b6830f6df8914f Peter Hurley 2015-06-27 3394 unsigned long flags;
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3395 unsigned int ier, use_fifo;
b6830f6df8914f Peter Hurley 2015-06-27 3396 int locked = 1;
b6830f6df8914f Peter Hurley 2015-06-27 3397
b6830f6df8914f Peter Hurley 2015-06-27 3398 touch_nmi_watchdog();
b6830f6df8914f Peter Hurley 2015-06-27 3399
5194c99b116191 Leonardo Bras 2024-01-16 3400 if (oops_in_progress || (IS_ENABLED(CONFIG_PREEMPT_RT) && in_atomic())
e8f87d3c335702 Thomas Gleixner 2023-09-14 @3401 locked = uart_port_trylock_irqsave(port, &flags);
b6830f6df8914f Peter Hurley 2015-06-27 3402 else
e8f87d3c335702 Thomas Gleixner 2023-09-14 3403 uart_port_lock_irqsave(port, &flags);
b6830f6df8914f Peter Hurley 2015-06-27 3404
b6830f6df8914f Peter Hurley 2015-06-27 3405 /*
b6830f6df8914f Peter Hurley 2015-06-27 3406 * First save the IER then disable the interrupts
b6830f6df8914f Peter Hurley 2015-06-27 3407 */
b6830f6df8914f Peter Hurley 2015-06-27 3408 ier = serial_port_in(port, UART_IER);
a3911f6ea5542d Ilpo Järvinen 2022-08-16 3409 serial8250_clear_IER(up);
b6830f6df8914f Peter Hurley 2015-06-27 3410
b6830f6df8914f Peter Hurley 2015-06-27 3411 /* check scratch reg to see if port powered off during system sleep */
b6830f6df8914f Peter Hurley 2015-06-27 3412 if (up->canary && (up->canary != serial_port_in(port, UART_SCR))) {
10791233e98fbd Peter Hurley 2015-09-25 3413 serial8250_console_restore(up);
b6830f6df8914f Peter Hurley 2015-06-27 3414 up->canary = 0;
b6830f6df8914f Peter Hurley 2015-06-27 3415 }
b6830f6df8914f Peter Hurley 2015-06-27 3416
7f9803072ff636 Lukas Wunner 2020-02-28 3417 if (em485) {
7f9803072ff636 Lukas Wunner 2020-02-28 3418 if (em485->tx_stopped)
7f9803072ff636 Lukas Wunner 2020-02-28 3419 up->rs485_start_tx(up);
7f9803072ff636 Lukas Wunner 2020-02-28 3420 mdelay(port->rs485.delay_rts_before_send);
7f9803072ff636 Lukas Wunner 2020-02-28 3421 }
7f9803072ff636 Lukas Wunner 2020-02-28 3422
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3423 use_fifo = (up->capabilities & UART_CAP_FIFO) &&
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3424 /*
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3425 * BCM283x requires to check the fifo
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3426 * after each byte.
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3427 */
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3428 !(up->capabilities & UART_CAP_MINI) &&
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3429 /*
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3430 * tx_loadsz contains the transmit fifo size
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3431 */
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3432 up->tx_loadsz > 1 &&
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3433 (up->fcr & UART_FCR_ENABLE_FIFO) &&
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3434 port->state &&
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3435 test_bit(TTY_PORT_INITIALIZED, &port->state->port.iflags) &&
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3436 /*
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3437 * After we put a data in the fifo, the controller will send
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3438 * it regardless of the CTS state. Therefore, only use fifo
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3439 * if we don't use control flow.
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3440 */
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3441 !(up->port.flags & UPF_CONS_FLOW);
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3442
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3443 if (likely(use_fifo))
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3444 serial8250_console_fifo_write(up, s, count);
8f3631f0f6eb42 Wander Lairson Costa 2022-04-11 3445 else
b6830f6df8914f Peter Hurley 2015-06-27 3446 uart_console_write(port, s, count, serial8250_console_putchar);
b6830f6df8914f Peter Hurley 2015-06-27 3447
b6830f6df8914f Peter Hurley 2015-06-27 3448 /*
b6830f6df8914f Peter Hurley 2015-06-27 3449 * Finally, wait for transmitter to become empty
b6830f6df8914f Peter Hurley 2015-06-27 3450 * and restore the IER
b6830f6df8914f Peter Hurley 2015-06-27 3451 */
34619de1b8cb52 Ilpo Järvinen 2022-06-24 3452 wait_for_xmitr(up, UART_LSR_BOTH_EMPTY);
b6830f6df8914f Peter Hurley 2015-06-27 3453
7f9803072ff636 Lukas Wunner 2020-02-28 3454 if (em485) {
4e36f94e996ebe Lukas Wunner 2020-03-27 3455 mdelay(port->rs485.delay_rts_after_send);
7f9803072ff636 Lukas Wunner 2020-02-28 3456 if (em485->tx_stopped)
7f9803072ff636 Lukas Wunner 2020-02-28 3457 up->rs485_stop_tx(up);
7f9803072ff636 Lukas Wunner 2020-02-28 3458 }
7f9803072ff636 Lukas Wunner 2020-02-28 3459
8d5b305484e8a3 Lukas Wunner 2020-03-27 3460 serial_port_out(port, UART_IER, ier);
8d5b305484e8a3 Lukas Wunner 2020-03-27 3461
b6830f6df8914f Peter Hurley 2015-06-27 3462 /*
b6830f6df8914f Peter Hurley 2015-06-27 3463 * The receive handling will happen properly because the
b6830f6df8914f Peter Hurley 2015-06-27 3464 * receive ready bit will still be set; it is not cleared
b6830f6df8914f Peter Hurley 2015-06-27 3465 * on read. However, modem control will not, we must
b6830f6df8914f Peter Hurley 2015-06-27 3466 * call it if we have saved something in the saved flags
b6830f6df8914f Peter Hurley 2015-06-27 3467 * while processing with interrupts off.
b6830f6df8914f Peter Hurley 2015-06-27 3468 */
b6830f6df8914f Peter Hurley 2015-06-27 3469 if (up->msr_saved_flags)
b6830f6df8914f Peter Hurley 2015-06-27 3470 serial8250_modem_status(up);
b6830f6df8914f Peter Hurley 2015-06-27 3471
b6830f6df8914f Peter Hurley 2015-06-27 3472 if (locked)
e8f87d3c335702 Thomas Gleixner 2023-09-14 3473 uart_port_unlock_irqrestore(port, flags);
b6830f6df8914f Peter Hurley 2015-06-27 3474 }
b6830f6df8914f Peter Hurley 2015-06-27 3475 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki