Skip to contentSkip to conversation

build: print out dependency names for clarity

PATCH Applied Bruce Richardson 3 participants 4 messages Sep 19, 2019 – Oct 23, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: print out dependency names for clarity

To help developers to get the correct dependency name e.g. when creating a new example that depends on a specific component, print out the dependency name for each lib/driver as it is processed.

---
 drivers/meson.build | 3 +++
 lib/meson.build     | 6 ++++--
 2 files changed, 7 insertions(+), 2 deletions(-)
drivers/meson.build +3 -0
index 2ed2e9541..c3f52d785 100644
@@ -157,6 +157,9 @@ foreach class:dpdk_driver_classes
 
 			set_variable('shared_@0@'.format(lib_name), shared_dep)
 			set_variable('static_@0@'.format(lib_name), static_dep)
+			dependency_name = ''.join(lib_name.split('rte_'))
+			message('drivers/@0@: Defining dependency "@1@"'.format(
+					drv_path, dependency_name))
 		endif # build
 	endforeach
 
lib/meson.build +4 -2
index e5ff83893..766d3b08e 100644
@@ -154,7 +154,9 @@ foreach l:libraries
 			dpdk_static_libraries = [static_lib] + dpdk_static_libraries
 		endif # sources.length() > 0
 
-		set_variable('shared_' + libname, shared_dep)
-		set_variable('static_' + libname, static_dep)
+		set_variable('shared_rte_' + name, shared_dep)
+		set_variable('static_rte_' + name, static_dep)
+		message('lib/@0@: Defining dependency "@1@"'.format(
+				dir_name, name))
 	endif # if build
 endforeach
Signature · 1 line
2.21.0
#2 lore raw

18/10/2019 18:54, Burakov, Anatoly:

Quoted 11 lines · Bruce Richardson
Quoted 6 lines

To help developers to get the correct dependency name e.g. when creating a new example that depends on a specific component, print out the dependency name for each lib/driver as it is processed.

---

Very nice change, +1!

Applied, thanks

It makes meson processing very verbose.
Is there way to filter meson messages?

#3 lore raw
Quoted 9 lines · Thomas Monjalon

18/10/2019 18:54, Burakov, Anatoly:

Quoted 8 lines · Bruce Richardson
Quoted 6 lines

To help developers to get the correct dependency name e.g. when creating a new example that depends on a specific component, print out the dependency name for each lib/driver as it is processed.

---

Quoted 9 lines
Quoted 3 lines

Very nice change, +1!

Applied, thanks

It makes meson processing very verbose.
Is there way to filter meson messages?

Well, we can look to make it build configurable, or only add them for particular build types. However, I think for developers the info it provides is really useful, so I'd like to keep it on by default initially anyway.

A good feature to add in 20.02 might be to have settings like this controlled as in make - where we check for the presence of a .git folder, for example.

/Bruce