DRM: urgent v4.9-rc6 build regression: master build: 2 failures 1 warnings (v4.9-rc5-213-g961b708)
A message that is not in the archive (sent off-list or not yet received): E1c7E60-0002LY-05@optimist
Quoted 7 lines · CET Build bot for Mark Brown
arm64-allmodconfig
../drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c:126:36: error: 'OD_CFG' undeclared (first use in this function)../drivers/gpu/drm/mediatek/mtk_drm_drv.c:220:5: error: 'structdrm_device' has no member named 'vblank_disable_allowed'arm-allmodconfig
../drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c:126:36: error: 'OD_CFG' undeclared (first use in this function)../drivers/gpu/drm/mediatek/mtk_drm_drv.c:220:5: error: 'structdrm_device' has no member named 'vblank_disable_allowed'
These two patches need to be reverted or fixed:
f752fff ("drm/mediatek: set vblank_disable_allowed to true") 83ba62b ("drm/mediatek: fix a typo of OD_CFG to OD_RELAYMODE")
Both of them seem to work fine on linux-next, but were accidentally sent to Linus yesterday through:
Merge tag 'drm-fixes-for-v4.9-rc6' of git://people.freedesktop.org/~airlied/linux
Merge branch 'mediatek-drm-fixes-2016-11-11' of https://github.com/ckhu-mediatek/linux.git-tags into drm-fixes
Clearly that branch has never been build-tested by itself. Unfortunately the dependency on "HAVE_ARM_SMCCC" caused the driver to not be no longer included in x86 allmodconfig builds despite the COMPILE_TEST check, so neither David Airlie nor Linus Torvalds caught it before it got merged.
Arnd
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 2 lines · Arnd Bergmann
On Thursday, November 17, 2016 4:14:44 AM CET Build bot for Mark Brown
Quoted 2 lines · wrote:
Quoted 2 lines
arm64-allmodconfig
../drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c:126:36: error: 'OD_CFG'
undeclared (first use in this function)
Quoted 1 line
Quoted 1 line
../drivers/gpu/drm/mediatek/mtk_drm_drv.c:220:5: error: 'struct
drm_device' has no member named 'vblank_disable_allowed'
Quoted 3 lines
Quoted 3 lines
arm-allmodconfig
../drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c:126:36: error: 'OD_CFG'
undeclared (first use in this function)
Quoted 1 line
Quoted 1 line
../drivers/gpu/drm/mediatek/mtk_drm_drv.c:220:5: error: 'struct
drm_device' has no member named 'vblank_disable_allowed'
Quoted 10 lines
These two patches need to be reverted or fixed:
f752fff ("drm/mediatek: set
vblank_disable_allowedto true") 83ba62b ("drm/mediatek: fix a typo ofOD_CFGtoOD_RELAYMODE")Both of them seem to work fine on linux-next, but were accidentally sent to Linus yesterday through:
Merge tag 'drm-fixes-for-v4.9-rc6' of git://
people.freedesktop.org/~airlied/linux
Quoted 1 line
Merge branch 'mediatek-drm-fixes-2016-11-11' of
https://github.com/ckhu-mediatek/linux.git-tags into drm-fixes
Quoted 5 lines
Clearly that branch has never been build-tested by itself. Unfortunately the dependency on "
HAVE_ARM_SMCCC" caused the driver to not be no longer included in x86 allmodconfig builds despite theCOMPILE_TESTcheck, so neither David Airlie nor Linus Torvalds caught it before it got merged.
oops bad dependency, I normally have a cross compile on -next, but -fixes I don't always do it, since who would send broken -fixes,
Arnd could you send a git pull with the two reverts, with my Acked-by on it? I won't be in a place to do it for 8-9hrs.
Dave.
Quoted 6 lines
Arnd
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 3 lines · CET Dave Airlie
Arnd could you send a git pull with the two reverts, with my Acked-by on it? I won't be in a place to do it for 8-9hrs.
I don't think it's that urgent, as long as we make sure it's fixed in the next -rc. I've sent out the reverts as patches with a little more information in the changelog: it turns out that they are actually broken on linux-next too, they had just not made it in there, and one of the two actually did build on older kernels.
I think what happened here is that the fixes were tested on a v4.4 kernel and blindly forward-ported. It probably makes sense to look at the entire series again in case another one of them is broken.
Philipp, Hu, Bibby, could one of you have another look?
Arnd
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi, Arnd:
I've made a mistake that I've tried to build these patches on v4.9-rc1, but I does not set CONFIG_DRM_MEDIATEK=y, therefore I didn't find out these build fails. Now I fix the config problem, and I think I should build these patches on latest kernel version even though patch's owner test on old kernel version. I wish this flow would make things better.
It's ok that you just revert these two patches. I've fixed build fail and will request pull later.
Regards,
CK
Quoted 11 lines · Arnd Bergmann
Quoted 3 lines · CET Dave Airlie
Arnd could you send a git pull with the two reverts, with my Acked-by on it? I won't be in a place to do it for 8-9hrs.
I don't think it's that urgent, as long as we make sure it's fixed in the next -rc. I've sent out the reverts as patches with a little more information in the changelog: it turns out that they are actually broken on linux-next too, they had just not made it in there, and one of the two actually did build on older kernels.
Quoted 7 lines
I think what happened here is that the fixes were tested on a v4.4 kernel and blindly forward-ported. It probably makes sense to look at the entire series again in case another one of them is broken.
Philipp, Hu, Bibby, could one of you have another look?
Arnd
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel