Skip to contentSkip to conversation

Invalid argument on writing to scaling_governor

BUG cpufreq Fengguang Wu 3 participants 3 messages Aug 1, 2014

lore
Share & tools
lore
#0 lore raw

Hi Prarit,

I noticed that commit dbcbfe6aa0d61ae5e13cab43b30802482007c199 ("cpufreq: hold policy->rwsem for duration of changing governors") will cause this problem:

root@nhm4 ~# echo performance > /sys/devices/system/cpu/cpu3/cpufreq/scaling_governor -bash: echo: write error: Invalid argument

root@nhm4 ~# cat /sys/devices/system/cpu/cpu3/cpufreq/scaling_available_governors conservative userspace powersave ondemand performance

Thanks,
Fengguang

#1 lore raw
Quoted 11 lines · Fengguang Wu

Hi Prarit,

I noticed that commit dbcbfe6aa0d61ae5e13cab43b30802482007c199 ("cpufreq: hold policy->rwsem for duration of changing governors") will cause this problem:

root@nhm4 ~# echo performance > /sys/devices/system/cpu/cpu3/cpufreq/scaling_governor -bash: echo: write error: Invalid argument

root@nhm4 ~# cat /sys/devices/system/cpu/cpu3/cpufreq/scaling_available_governors conservative userspace powersave ondemand performance

Rafael, this patch needs to be rejected based on my previous comments, most notably Saravana was able to reproduce the original problem. I'm going to wait for his reproducer and see what I can do.

Thanks,

P.

Quoted 3 lines

Thanks,
Fengguang

#2 lore raw
Quoted 10 lines · Prarit Bhargava
Quoted 8 lines · Fengguang Wu

Hi Prarit,

I noticed that commit dbcbfe6aa0d61ae5e13cab43b30802482007c199 ("cpufreq: hold policy->rwsem for duration of changing governors") will cause this problem:

root@nhm4 ~# echo performance > /sys/devices/system/cpu/cpu3/cpufreq/scaling_governor -bash: echo: write error: Invalid argument

Quoted 7 lines
Quoted 3 lines

root@nhm4 ~# cat /sys/devices/system/cpu/cpu3/cpufreq/scaling_available_governors conservative userspace powersave ondemand performance

Rafael, this patch needs to be rejected based on my previous comments, most notably Saravana was able to reproduce the original problem. I'm going to wait for his reproducer and see what I can do.

I've dropped it already. At least as far as I can say it shouldn't be there in my linux-next branch any more. Can you double check, please?

Rafael