mmc: sdhci-of-dwcmshc: fix init for AXI clock and DMA 128MB boundary
PATCH 1/1 mmc: sdhci-of-dwcmshc: fix init for AXI clock and DMA 128MB boundary
From: Huan He <[email protected]>
1.Accessing the High-Speed registers requires the AXI clock to be enabled. 2.This DWC MSHC has a 128MB limitation where the data buffer size and
start address must not exceed the 128MB boundary. Registering the missing 'adma_write_desc' callback function.
--- drivers/mmc/host/sdhci-of-dwcmshc.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/mmc/host/sdhci-of-dwcmshc.c +7 -0
@@ -1588,6 +1588,7 @@ static int eic7700_init(struct device *dev, struct sdhci_host *host, struct dwcm {u32 emmc_caps =MMC_CAP2_NO_SD |MMC_CAP2_NO_SDIO ;unsigned int val, hsp_int_status, hsp_pwr_ctrl; +static const char *const clk_ids[] = {"axi" };struct of_phandle_args args;struct eic7700_priv *priv;struct regmap *hsp_regmap;
@@ -1605,6 +1606,11 @@ static int eic7700_init(struct device *dev, struct sdhci_host *host, struct dwcmreturn ret; } + ret =dwcmshc_get_enable_other_clks (mmc_dev (host->mmc), dwc_priv, +ARRAY_SIZE (clk_ids), clk_ids); +if (ret) +return ret; + ret =of_parse_phandle_with_fixed_args (dev->of_node,"eswin,hsp-sp-csr" ,2 ,0 , &args);if (ret) {dev_err (dev,"Fail to parse 'eswin,hsp-sp-csr' phandle (%d)\n" , ret);
@@ -1726,6 +1732,7 @@ static const struct sdhci_ops sdhci_dwcmshc_eic7700_ops = { .set_uhs_signaling = sdhci_eic7700_set_uhs_wrapper, .set_power = sdhci_set_power_and_bus_voltage, .irq = dwcmshc_cqe_irq_handler, + .adma_write_desc = dwcmshc_adma_write_desc, .platform_execute_tuning = sdhci_eic7700_executing_tuning, };
Signature · 1 line
2.25.1
Quoted 7 lines · 在 2026/01/09 星期五 11:28, [email protected] 写道:
From: Huan He <[email protected]>
1.Accessing the High-Speed registers requires the AXI clock to be enabled. 2.This DWC MSHC has a 128MB limitation where the data buffer size and
start address must not exceed the 128MB boundary. Registering the missing 'adma_write_desc' callback function.
This looks like you should split it into two patches with proper Fixes tags.
Quoted 37 lines
Signed-off-by Huan He <[email protected]>--- drivers/mmc/host/sdhci-of-dwcmshc.c | 7 +++++++ 1 file changed, 7 insertions(+)drivers/mmc/host/sdhci-of-dwcmshc.c +7
-0@@ -1588,6 +1588,7 @@ static int eic7700_init(struct device *dev, struct sdhci_host *host, struct dwcm {u32 emmc_caps =MMC_CAP2_NO_SD |MMC_CAP2_NO_SDIO ;unsigned int val, hsp_int_status, hsp_pwr_ctrl; +static const char *const clk_ids[] = {"axi" };struct of_phandle_args args;struct eic7700_priv *priv;struct regmap *hsp_regmap;@@ -1605,6 +1606,11 @@ static int eic7700_init(struct device *dev, struct sdhci_host *host, struct dwcmreturn ret; } + ret =dwcmshc_get_enable_other_clks (mmc_dev (host->mmc), dwc_priv, +ARRAY_SIZE (clk_ids), clk_ids); +if (ret) +return ret; + ret =of_parse_phandle_with_fixed_args (dev->of_node,"eswin,hsp-sp-csr" ,2 ,0 , &args);if (ret) {dev_err (dev,"Fail to parse 'eswin,hsp-sp-csr' phandle (%d)\n" , ret);@@ -1726,6 +1732,7 @@ static const struct sdhci_ops sdhci_dwcmshc_eic7700_ops = { .set_uhs_signaling = sdhci_eic7700_set_uhs_wrapper, .set_power = sdhci_set_power_and_bus_voltage, .irq = dwcmshc_cqe_irq_handler, + .adma_write_desc = dwcmshc_adma_write_desc, .platform_execute_tuning = sdhci_eic7700_executing_tuning, };
Quoted 25 lines · On 09/01/2026 04:28, [email protected] wrote:
From: Huan He <[email protected]>
1.Accessing the High-Speed registers requires the AXI clock to be enabled. 2.This DWC MSHC has a 128MB limitation where the data buffer size and
start address must not exceed the 128MB boundary. Registering the missing 'adma_write_desc' callback function.Signed-off-by Huan He <[email protected]>--- drivers/mmc/host/sdhci-of-dwcmshc.c | 7 +++++++ 1 file changed, 7 insertions(+)drivers/mmc/host/sdhci-of-dwcmshc.c +1
-0@@ -1588,6 +1588,7 @@ static int eic7700_init(struct device *dev, struct sdhci_host *host, struct dwcm {u32 emmc_caps =MMC_CAP2_NO_SD |MMC_CAP2_NO_SDIO ;unsigned int val, hsp_int_status, hsp_pwr_ctrl; +static const char *const clk_ids[] = {"axi" };struct of_phandle_args args;struct eic7700_priv *priv;struct regmap *hsp_regmap;
drivers/mmc/host/sdhci-of-dwcmshc.c static int eic7700_init(struct device *dev, struct sdhci_host *host, struct dwcm · line 1610
Quoted 5 lines
drivers/mmc/host/sdhci-of-dwcmshc.c +2
-0@@ -1605,6 +1606,11 @@ static int eic7700_init(struct device *dev, struct sdhci_host *host, struct dwcmreturn ret; } + ret =dwcmshc_get_enable_other_clks (mmc_dev (host->mmc), dwc_priv, +ARRAY_SIZE (clk_ids), clk_ids);
Is this clock (ABI) already documented?
Best regards,
Krzysztof
Quoted 27 lines
Quoted 27 lines
1.Accessing the High-Speed registers requires the AXI clock to be enabled. 2.This DWC MSHC has a 128MB limitation where the data buffer size and
start address must not exceed the 128MB boundary. Registering the missing 'adma_write_desc' callback function.Signed-off-by Huan He <[email protected]>--- drivers/mmc/host/sdhci-of-dwcmshc.c | 7 +++++++ 1 file changed, 7 insertions(+)drivers/mmc/host/sdhci-of-dwcmshc.c +1
-0@@ -1588,6 +1588,7 @@ static int eic7700_init(struct device *dev, struct sdhci_host *host, struct dwcm {u32 emmc_caps =MMC_CAP2_NO_SD |MMC_CAP2_NO_SDIO ;unsigned int val, hsp_int_status, hsp_pwr_ctrl; +static const char *const clk_ids[] = {"axi" };struct of_phandle_args args;struct eic7700_priv *priv;struct regmap *hsp_regmap;@@ -1605,6 +1606,11 @@ static int eic7700_init(struct device *dev, struct sdhci_host *host, struct dwcmreturn ret; }
Quoted 4 lines
drivers/mmc/host/sdhci-of-dwcmshc.c static int eic7700_init(struct device *dev, struct sdhci_host *host, struct dwcm · line 1610
Quoted 2 lines
drivers/mmc/host/sdhci-of-dwcmshc.c +2
-0+ ret =dwcmshc_get_enable_other_clks (mmc_dev (host->mmc), dwc_priv, +ARRAY_SIZE (clk_ids), clk_ids);Is this clock (ABI) already documented?
Yes, this clock (AXI clock) is already documented in the Device Tree binding specification.
In the snps,dwcmshc-sdhci.yaml binding document, the AXI clock is included in the clock definitions:
properties:
clocks:
minItems: 1
items:
- description: core clock
- description: bus clock for optional
- description: axi clock for rockchip specified
- description: block clock for rockchip specified
- description: timer clock for rockchip specified clock-names:
minItems: 1
items:
- const: core
- const: bus
- const: axi
- const: block
- const: timer
Best regards,
Huan He