Skip to contentSkip to conversation

apalis_imx6: fix set_emmcargs wrapper

PATCH New Igor Opaniuk 3 participants 4 messages Jun 25, 2019 – Jun 27, 2019 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 apalis_imx6: fix set_emmcargs wrapper

From: Igor Opaniuk <[email protected]>

Fix set_emmcargs wrapper, which prepares proper bootargs for booting from eMMC.

---
 include/configs/apalis_imx6.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/configs/apalis_imx6.h +2 -2
index 4b0a3fb26b..cffb90a690 100644
@@ -121,8 +121,8 @@
 	"imx6q-apalis-cam-eval.dtb fat 0 1"
 
 #define EMMC_BOOTCMD \
-	"set_emmcargs emmcargs ip=off root=PARTUUID=${uuid} ro,noatime " \
-		"rootfstype=ext4 rootwait\0" \
+	"set_emmcargs=setenv emmcargs ip=off root=PARTUUID=${uuid} " \
+		"ro,noatime rootfstype=ext4 rootwait\0" \
 	"emmcboot=run setup; run emmcfinduuid; run set_emmcargs; " \
 		"setenv bootargs ${defargs} ${emmcargs} ${setupargs} " \
 		"${vidargs}; echo Booting from internal eMMC chip...; "	\
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 apalis_imx6: fix set_emmcargs wrapper

Quoted 6 lines · Igor Opaniuk

From: Igor Opaniuk <[email protected]>

Fix set_emmcargs wrapper, which prepares proper bootargs for booting from eMMC.

Quoted 19 lines
---
 include/configs/apalis_imx6.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/configs/apalis_imx6.h +2 -2
index 4b0a3fb26b..cffb90a690 100644
@@ -121,8 +121,8 @@
 	"imx6q-apalis-cam-eval.dtb fat 0 1"
 
 #define EMMC_BOOTCMD \
-	"set_emmcargs emmcargs ip=off root=PARTUUID=${uuid} ro,noatime " \
-		"rootfstype=ext4 rootwait\0" \
+	"set_emmcargs=setenv emmcargs ip=off root=PARTUUID=${uuid} " \
+		"ro,noatime rootfstype=ext4 rootwait\0" \
 	"emmcboot=run setup; run emmcfinduuid; run set_emmcargs; " \
 		"setenv bootargs ${defargs} ${emmcargs} ${setupargs} " \
 		"${vidargs}; echo Booting from internal eMMC chip...; "	\
#2 lore raw

PATCH 1/1 apalis_imx6: fix set_emmcargs wrapper

Hi Stefano,

Quoted 22 lines · Philippe Schenker
Quoted 6 lines · Igor Opaniuk

From: Igor Opaniuk <[email protected]>

Fix set_emmcargs wrapper, which prepares proper bootargs for booting from eMMC.

Quoted 11 lines
---
 include/configs/apalis_imx6.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/configs/apalis_imx6.h +0 -0
index 4b0a3fb26b..cffb90a690 100644
@@ -121,8 +121,8 @@
      "imx6q-apalis-cam-eval.dtb fat 0 1"
 
Quoted 9 lines

include/configs/apalis_imx6.h line 128

Quoted 8 lines
include/configs/apalis_imx6.h +2 -2
 #define EMMC_BOOTCMD \
-     "set_emmcargs emmcargs ip=off root=PARTUUID=${uuid} ro,noatime " \
-             "rootfstype=ext4 rootwait\0" \
+     "set_emmcargs=setenv emmcargs ip=off root=PARTUUID=${uuid} " \
+             "ro,noatime rootfstype=ext4 rootwait\0" \
      "emmcboot=run setup; run emmcfinduuid; run set_emmcargs; " \
              "setenv bootargs ${defargs} ${emmcargs} ${setupargs} " \
              "${vidargs}; echo Booting from internal eMMC chip...; " \

This is a bug fix, currently boot on Apalis iMX6 is broken. could you please apply this patch so it's included in v2019.07 release?

Thanks!

Signature · 8 lines
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk
#3 lore raw

PATCH 1/1 apalis_imx6: fix set_emmcargs wrapper

Hi Igor,

Quoted 35 lines · Igor Opaniuk

Hi Stefano,

Quoted 22 lines · Philippe Schenker
Quoted 6 lines · Igor Opaniuk

From: Igor Opaniuk <[email protected]>

Fix set_emmcargs wrapper, which prepares proper bootargs for booting from eMMC.

Quoted 11 lines
---
 include/configs/apalis_imx6.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/configs/apalis_imx6.h +0 -0
index 4b0a3fb26b..cffb90a690 100644
@@ -121,8 +121,8 @@
      "imx6q-apalis-cam-eval.dtb fat 0 1"
 
Quoted 9 lines

include/configs/apalis_imx6.h line 128

Quoted 8 lines
include/configs/apalis_imx6.h +2 -2
 #define EMMC_BOOTCMD \
-     "set_emmcargs emmcargs ip=off root=PARTUUID=${uuid} ro,noatime " \
-             "rootfstype=ext4 rootwait\0" \
+     "set_emmcargs=setenv emmcargs ip=off root=PARTUUID=${uuid} " \
+             "ro,noatime rootfstype=ext4 rootwait\0" \
      "emmcboot=run setup; run emmcfinduuid; run set_emmcargs; " \
              "setenv bootargs ${defargs} ${emmcargs} ${setupargs} " \
              "${vidargs}; echo Booting from internal eMMC chip...; " \
Quoted 3 lines

This is a bug fix, currently boot on Apalis iMX6 is broken. could you please apply this patch so it's included in v2019.07 release?

I pick it up, I am sorting which fixes I should take for release. Thanks !

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================