Skip to contentSkip to conversation

drm/panfrost: Fix GEM handle creation UAF

PATCH In review Rob Clark 4 participants 10 messages Dec 16, 2022 – Jan 10, 2023

Subsystems (5)
lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 drm/panfrost: Fix GEM handle creation UAF

From: Rob Clark <[email protected]>

Relying on an unreturned handle to hold a reference to an object we dereference is not safe. Userspace can guess the handle and race us by closing the handle from another thread. The _create_with_handle() that returns an object ptr is pretty much a pattern to avoid. And ideally creating the handle would be done after any needed dererencing. But in this case creation of the mapping is tied to the handle creation. Fortunately the mapping is refcnt'd and holds a reference to the object, so we can drop the handle's reference once we hold a mapping reference.

---
 drivers/gpu/drm/panfrost/panfrost_drv.c |  7 +++++++
 drivers/gpu/drm/panfrost/panfrost_gem.c | 10 +++++++---
 2 files changed, 14 insertions(+), 3 deletions(-)
drivers/gpu/drm/panfrost/panfrost_drv.c +7 -0
index 2fa5afe21288..aa5848de647c 100644
@@ -98,6 +98,13 @@ static int panfrost_ioctl_create_bo(struct drm_device *dev, void *data,
 		return PTR_ERR(bo);
 
 	mapping = panfrost_gem_mapping_get(bo, priv);
+
+	/*
+	 * Now that the mapping holds a reference to the bo until we no longer
+	 * need it, we can safely drop the handle's reference.
+	 */
+	drm_gem_object_put(&bo->base.base);
+
 	if (!mapping) {
 		drm_gem_object_put(&bo->base.base);
 		return -EINVAL;
drivers/gpu/drm/panfrost/panfrost_gem.c +7 -3
index 293e799e2fe8..e3e21c500d24 100644
@@ -234,6 +234,10 @@ struct drm_gem_object *panfrost_gem_create_object(struct drm_device *dev, size_t
 	return &obj->base.base;
 }
 
+/*
+ * NOTE: if this succeeds, both the handle and the returned object have
+ * an outstanding reference.
+ */
 struct panfrost_gem_object *
 panfrost_gem_create_with_handle(struct drm_file *file_priv,
 				struct drm_device *dev, size_t size,
@@ -261,10 +265,10 @@ panfrost_gem_create_with_handle(struct drm_file *file_priv,
 	 * and handle has the id what user can see.
 	 */
 	ret = drm_gem_handle_create(file_priv, &shmem->base, handle);
-	/* drop reference from allocate - handle holds it now. */
-	drm_gem_object_put(&shmem->base);
-	if (ret)
+	if (ret) {
+		drm_gem_object_put(&shmem->base);
 		return ERR_PTR(ret);
+	}
 
 	return bo;
 }
Signature · 1 line
2.38.1
author
#1 lore raw

PATCH 1/1 drm/virtio: Fix GEM handle creation UAF

From: Rob Clark <[email protected]>

Userspace can guess the handle value and try to race GEM object creation with handle close, resulting in a use-after-free if we dereference the object after dropping the handle's reference. For that reason, dropping the handle's reference must be done *after* we are done dereferencing the object.

---
 drivers/gpu/drm/virtio/virtgpu_ioctl.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)
drivers/gpu/drm/virtio/virtgpu_ioctl.c +17 -2
index a5cccccb4998..f1c55c1630ca 100644
@@ -366,10 +366,18 @@ static int virtio_gpu_resource_create_ioctl(struct drm_device *dev, void *data,
 		drm_gem_object_release(obj);
 		return ret;
 	}
-	drm_gem_object_put(obj);
 
 	rc->res_handle = qobj->hw_res_handle; /* similiar to a VM address */
 	rc->bo_handle = handle;
+
+	/*
+	 * The handle owns the reference now.  But we must drop our
+	 * remaining reference *after* we no longer need to dereference
+	 * the obj.  Otherwise userspace could guess the handle and
+	 * race closing it from another thread.
+	 */
+	drm_gem_object_put(obj);
+
 	return 0;
 }
 
@@ -731,11 +739,18 @@ static int virtio_gpu_resource_create_blob_ioctl(struct drm_device *dev,
 		drm_gem_object_release(obj);
 		return ret;
 	}
-	drm_gem_object_put(obj);
 
 	rc_blob->res_handle = bo->hw_res_handle;
 	rc_blob->bo_handle = handle;
 
+	/*
+	 * The handle owns the reference now.  But we must drop our
+	 * remaining reference *after* we no longer need to dereference
+	 * the obj.  Otherwise userspace could guess the handle and
+	 * race closing it from another thread.
+	 */
+	drm_gem_object_put(obj);
+
 	return 0;
 }
 
Signature · 6 lines
2.38.1

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
reviewer Reviewed-by on v1 1/1
#2 lore raw

Re: [PATCH] drm/virtio: Fix GEM handle creation UAF

Quoted 10 lines · Rob Clark

From: Rob Clark <[email protected]>

Userspace can guess the handle value and try to race GEM object creation with handle close, resulting in a use-after-free if we dereference the object after dropping the handle's reference. For that reason, dropping the handle's reference must be done *after* we are done dereferencing the object.

maintainer
#3 lore raw

Re: [PATCH] drm/virtio: Fix GEM handle creation UAF

In reply to Rob Clark
Quoted 8 lines · Rob Clark

From: Rob Clark <[email protected]>

Userspace can guess the handle value and try to race GEM object creation with handle close, resulting in a use-after-free if we dereference the object after dropping the handle's reference. For that reason, dropping the handle's reference must be done *after* we are done dereferencing the object.

Quoted 4 lines
---
 drivers/gpu/drm/virtio/virtgpu_ioctl.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

Added fixes/stable tags and applied this virtio-gpu patch to misc-fixes. The Panfrost patch is untouched.

Signature · 2 lines
Best regards,
Dmitry
author
#4 lore raw

Re: [PATCH] drm/virtio: Fix GEM handle creation UAF

Quoted 10 lines · Dmitry Osipenko
Quoted 8 lines · Rob Clark

From: Rob Clark <[email protected]>

Userspace can guess the handle value and try to race GEM object creation with handle close, resulting in a use-after-free if we dereference the object after dropping the handle's reference. For that reason, dropping the handle's reference must be done *after* we are done dereferencing the object.

Quoted 7 lines
Quoted 4 lines
---
 drivers/gpu/drm/virtio/virtgpu_ioctl.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

Added fixes/stable tags and applied this virtio-gpu patch to misc-fixes. The Panfrost patch is untouched.

Thanks.. the panfrost patch was not intended to be part of the same series (but apparently that is what happens when I send them at the same time), and was superceded by a patch from Steven Price (commit 4217c6ac8174 ("drm/panfrost: Fix GEM handle creation ref-counting") already applied to misc-fixes

BR,
-R

maintainer
#5 lore raw

Re: [PATCH] drm/virtio: Fix GEM handle creation UAF

Quoted 17 lines · Rob Clark
Quoted 15 lines · Dmitry Osipenko
Quoted 12 lines · Rob Clark

From: Rob Clark <[email protected]>

Userspace can guess the handle value and try to race GEM object creation with handle close, resulting in a use-after-free if we dereference the object after dropping the handle's reference. For that reason, dropping the handle's reference must be done *after* we are done dereferencing the object.

---
 drivers/gpu/drm/virtio/virtgpu_ioctl.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)
Quoted 8 lines
Quoted 2 lines

Added fixes/stable tags and applied this virtio-gpu patch to misc-fixes. The Panfrost patch is untouched.

Thanks.. the panfrost patch was not intended to be part of the same series (but apparently that is what happens when I send them at the same time), and was superceded by a patch from Steven Price (commit 4217c6ac8174 ("drm/panfrost: Fix GEM handle creation ref-counting") already applied to misc-fixes

Okay, I wanted to make clear what has been applied.

Signature · 2 lines
Best regards,
Dmitry
reviewer
#6 lore raw
In reply to Rob Clark
Quoted 23 lines · Rob Clark

From: Rob Clark <[email protected]>

Relying on an unreturned handle to hold a reference to an object we dereference is not safe. Userspace can guess the handle and race us by closing the handle from another thread. The _create_with_handle() that returns an object ptr is pretty much a pattern to avoid. And ideally creating the handle would be done after any needed dererencing. But in this case creation of the mapping is tied to the handle creation. Fortunately the mapping is refcnt'd and holds a reference to the object, so we can drop the handle's reference once we hold a mapping reference.

---
 drivers/gpu/drm/panfrost/panfrost_drv.c |  7 +++++++
 drivers/gpu/drm/panfrost/panfrost_gem.c | 10 +++++++---
 2 files changed, 14 insertions(+), 3 deletions(-)
drivers/gpu/drm/panfrost/panfrost_drv.c +0 -0
index 2fa5afe21288..aa5848de647c 100644

drivers/gpu/drm/panfrost/panfrost_drv.c static int panfrost_ioctl_create_bo(struct drm_device *dev, void *data, · line 105

Quoted 8 lines
drivers/gpu/drm/panfrost/panfrost_drv.c +5 -0
@@ -98,6 +98,13 @@ static int panfrost_ioctl_create_bo(struct drm_device *dev, void *data,
                return PTR_ERR(bo);
 
        mapping = panfrost_gem_mapping_get(bo, priv);
+
+       /*
+        * Now that the mapping holds a reference to the bo until we no longer
+        * need it, we can safely drop the handle's reference.
+        */

Not too familiar with panfrost, but I don't see panfrost_gem_mapping_get hold a reference to the bo?

Quoted 10 lines
drivers/gpu/drm/panfrost/panfrost_drv.c +2 -0
+       drm_gem_object_put(&bo->base.base);
+
        if (!mapping) {
                drm_gem_object_put(&bo->base.base);
                return -EINVAL;
drivers/gpu/drm/panfrost/panfrost_gem.c +0 -0
index 293e799e2fe8..e3e21c500d24 100644

drivers/gpu/drm/panfrost/panfrost_gem.c struct drm_gem_object *panfrost_gem_create_object(struct drm_device *dev, size_t · line 240

Quoted 7 lines
drivers/gpu/drm/panfrost/panfrost_gem.c +4 -0
@@ -234,6 +234,10 @@ struct drm_gem_object *panfrost_gem_create_object(struct drm_device *dev, size_t
        return &obj->base.base;
 }
 
+/*
+ * NOTE: if this succeeds, both the handle and the returned object have
+ * an outstanding reference.
+ */

I might suggest dropping the "_with_handle" suffix.

The naming convention is used in several drivers. I think we should make it the case that the _with_handle variants always return the handle without the pointer. (And with the change, it immediately becomes clear that qxl and vmwgfx also have similar issues).

Quoted 20 lines
drivers/gpu/drm/panfrost/panfrost_gem.c +3 -4
 struct panfrost_gem_object *
 panfrost_gem_create_with_handle(struct drm_file *file_priv,
                                struct drm_device *dev, size_t size,
@@ -261,10 +265,10 @@ panfrost_gem_create_with_handle(struct drm_file *file_priv,
         * and handle has the id what user can see.
         */
        ret = drm_gem_handle_create(file_priv, &shmem->base, handle);
-       /* drop reference from allocate - handle holds it now. */
-       drm_gem_object_put(&shmem->base);
-       if (ret)
+       if (ret) {
+               drm_gem_object_put(&shmem->base);
                return ERR_PTR(ret);
+       }
 
        return bo;
 }
--

2.38.1

author
#7 lore raw
Quoted 27 lines · Chia-I Wu
Quoted 25 lines · Rob Clark

From: Rob Clark <[email protected]>

Relying on an unreturned handle to hold a reference to an object we dereference is not safe. Userspace can guess the handle and race us by closing the handle from another thread. The _create_with_handle() that returns an object ptr is pretty much a pattern to avoid. And ideally creating the handle would be done after any needed dererencing. But in this case creation of the mapping is tied to the handle creation. Fortunately the mapping is refcnt'd and holds a reference to the object, so we can drop the handle's reference once we hold a mapping reference.

---
 drivers/gpu/drm/panfrost/panfrost_drv.c |  7 +++++++
 drivers/gpu/drm/panfrost/panfrost_gem.c | 10 +++++++---
 2 files changed, 14 insertions(+), 3 deletions(-)
drivers/gpu/drm/panfrost/panfrost_drv.c +0 -0
index 2fa5afe21288..aa5848de647c 100644
@@ -98,6 +98,13 @@ static int panfrost_ioctl_create_bo(struct drm_device *dev, void *data,
                return PTR_ERR(bo);
 
Quoted 8 lines

drivers/gpu/drm/panfrost/panfrost_drv.c static int panfrost_ioctl_create_bo(struct drm_device *dev, void *data, · line 105

Quoted 6 lines
drivers/gpu/drm/panfrost/panfrost_drv.c +5 -0
        mapping = panfrost_gem_mapping_get(bo, priv);
+
+       /*
+        * Now that the mapping holds a reference to the bo until we no longer
+        * need it, we can safely drop the handle's reference.
+        */

Not too familiar with panfrost, but I don't see panfrost_gem_mapping_get hold a reference to the bo?

It doesn't directly, but the mapping already holds a reference, taken before the handle reference is dropped

It is all a bit too subtle for my taste.

Quoted 13 lines
Quoted 13 lines
drivers/gpu/drm/panfrost/panfrost_drv.c +2 -0
+       drm_gem_object_put(&bo->base.base);
+
        if (!mapping) {
                drm_gem_object_put(&bo->base.base);
                return -EINVAL;
drivers/gpu/drm/panfrost/panfrost_gem.c +0 -0
index 293e799e2fe8..e3e21c500d24 100644
@@ -234,6 +234,10 @@ struct drm_gem_object *panfrost_gem_create_object(struct drm_device *dev, size_t
        return &obj->base.base;
 }
 
Quoted 5 lines

drivers/gpu/drm/panfrost/panfrost_gem.c struct drm_gem_object *panfrost_gem_create_object(struct drm_device *dev, size_t · line 240

Quoted 4 lines
drivers/gpu/drm/panfrost/panfrost_gem.c +4 -0
+/*
+ * NOTE: if this succeeds, both the handle and the returned object have
+ * an outstanding reference.
+ */

I might suggest dropping the "_with_handle" suffix.

Maybe _and_handle would be a better name (for this and other cases that return both a handle and obj)?

Quoted 4 lines

The naming convention is used in several drivers. I think we should make it the case that the _with_handle variants always return the handle without the pointer. (And with the change, it immediately becomes clear that qxl and vmwgfx also have similar issues).

ugg, yeah, qxl does have the issue in the qxl_mode_dumb_create path. I overlooked that it returns an obj pointer by reference.

on the surface vmwgfx looked ok, but I could have overlooked something.

BR,
-R

Quoted 20 lines
Quoted 20 lines
drivers/gpu/drm/panfrost/panfrost_gem.c +3 -4
 struct panfrost_gem_object *
 panfrost_gem_create_with_handle(struct drm_file *file_priv,
                                struct drm_device *dev, size_t size,
@@ -261,10 +265,10 @@ panfrost_gem_create_with_handle(struct drm_file *file_priv,
         * and handle has the id what user can see.
         */
        ret = drm_gem_handle_create(file_priv, &shmem->base, handle);
-       /* drop reference from allocate - handle holds it now. */
-       drm_gem_object_put(&shmem->base);
-       if (ret)
+       if (ret) {
+               drm_gem_object_put(&shmem->base);
                return ERR_PTR(ret);
+       }
 
        return bo;
 }
--

2.38.1

reviewer
#8 lore raw
Quoted 38 lines · Rob Clark
Quoted 27 lines · Chia-I Wu
Quoted 25 lines · Rob Clark

From: Rob Clark <[email protected]>

Relying on an unreturned handle to hold a reference to an object we dereference is not safe. Userspace can guess the handle and race us by closing the handle from another thread. The _create_with_handle() that returns an object ptr is pretty much a pattern to avoid. And ideally creating the handle would be done after any needed dererencing. But in this case creation of the mapping is tied to the handle creation. Fortunately the mapping is refcnt'd and holds a reference to the object, so we can drop the handle's reference once we hold a mapping reference.

---
 drivers/gpu/drm/panfrost/panfrost_drv.c |  7 +++++++
 drivers/gpu/drm/panfrost/panfrost_gem.c | 10 +++++++---
 2 files changed, 14 insertions(+), 3 deletions(-)
drivers/gpu/drm/panfrost/panfrost_drv.c +0 -0
index 2fa5afe21288..aa5848de647c 100644
@@ -98,6 +98,13 @@ static int panfrost_ioctl_create_bo(struct drm_device *dev, void *data,
                return PTR_ERR(bo);
 
Quoted 8 lines

drivers/gpu/drm/panfrost/panfrost_drv.c static int panfrost_ioctl_create_bo(struct drm_device *dev, void *data, · line 105

Quoted 6 lines
drivers/gpu/drm/panfrost/panfrost_drv.c +5 -0
        mapping = panfrost_gem_mapping_get(bo, priv);
+
+       /*
+        * Now that the mapping holds a reference to the bo until we no longer
+        * need it, we can safely drop the handle's reference.
+        */

Not too familiar with panfrost, but I don't see panfrost_gem_mapping_get hold a reference to the bo?

Quoted 4 lines

It doesn't directly, but the mapping already holds a reference, taken before the handle reference is dropped

It is all a bit too subtle for my taste.

Ack.

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
drivers/gpu/drm/panfrost/panfrost_drv.c +2 -0
+       drm_gem_object_put(&bo->base.base);
+
        if (!mapping) {
                drm_gem_object_put(&bo->base.base);
                return -EINVAL;
drivers/gpu/drm/panfrost/panfrost_gem.c +0 -0
index 293e799e2fe8..e3e21c500d24 100644
@@ -234,6 +234,10 @@ struct drm_gem_object *panfrost_gem_create_object(struct drm_device *dev, size_t
        return &obj->base.base;
 }
 
Quoted 8 lines
Quoted 5 lines

drivers/gpu/drm/panfrost/panfrost_gem.c struct drm_gem_object *panfrost_gem_create_object(struct drm_device *dev, size_t · line 240

Quoted 4 lines
drivers/gpu/drm/panfrost/panfrost_gem.c +4 -0
+/*
+ * NOTE: if this succeeds, both the handle and the returned object have
+ * an outstanding reference.
+ */

I might suggest dropping the "_with_handle" suffix.

Maybe _and_handle would be a better name (for this and other cases that return both a handle and obj)?

Sounds good. We will want that for panfrost, qxl, and vmwgfx.

The other drivers and helpers only need the handle. Their _with_handle should be fixed to not return the pointer.

Quoted 34 lines
Quoted 5 lines

The naming convention is used in several drivers. I think we should make it the case that the _with_handle variants always return the handle without the pointer. (And with the change, it immediately becomes clear that qxl and vmwgfx also have similar issues).

ugg, yeah, qxl does have the issue in the qxl_mode_dumb_create path. I overlooked that it returns an obj pointer by reference.

on the surface vmwgfx looked ok, but I could have overlooked something.

BR,
-R

Quoted 20 lines
Quoted 20 lines
drivers/gpu/drm/panfrost/panfrost_gem.c +3 -4
 struct panfrost_gem_object *
 panfrost_gem_create_with_handle(struct drm_file *file_priv,
                                struct drm_device *dev, size_t size,
@@ -261,10 +265,10 @@ panfrost_gem_create_with_handle(struct drm_file *file_priv,
         * and handle has the id what user can see.
         */
        ret = drm_gem_handle_create(file_priv, &shmem->base, handle);
-       /* drop reference from allocate - handle holds it now. */
-       drm_gem_object_put(&shmem->base);
-       if (ret)
+       if (ret) {
+               drm_gem_object_put(&shmem->base);
                return ERR_PTR(ret);
+       }
 
        return bo;
 }
--

2.38.1

maintainer
#9 lore raw
In reply to Rob Clark
Quoted 10 lines · Rob Clark

From: Rob Clark <[email protected]>

Relying on an unreturned handle to hold a reference to an object we dereference is not safe. Userspace can guess the handle and race us by closing the handle from another thread. The _create_with_handle() that returns an object ptr is pretty much a pattern to avoid. And ideally creating the handle would be done after any needed dererencing. But in this case creation of the mapping is tied to the handle creation. Fortunately the mapping is refcnt'd and holds a reference to the object, so we can drop the handle's reference once we hold a mapping reference.

Thanks for spotting this, it's a small window but definitely a bug.

Quoted 13 lines
---
 drivers/gpu/drm/panfrost/panfrost_drv.c |  7 +++++++
 drivers/gpu/drm/panfrost/panfrost_gem.c | 10 +++++++---
 2 files changed, 14 insertions(+), 3 deletions(-)
drivers/gpu/drm/panfrost/panfrost_drv.c +0 -0
index 2fa5afe21288..aa5848de647c 100644
@@ -98,6 +98,13 @@ static int panfrost_ioctl_create_bo(struct drm_device *dev, void *data,
 		return PTR_ERR(bo);
 

drivers/gpu/drm/panfrost/panfrost_drv.c static int panfrost_ioctl_create_bo(struct drm_device *dev, void *data, · line 109

Quoted 10 lines
drivers/gpu/drm/panfrost/panfrost_drv.c +7 -0
 	mapping = panfrost_gem_mapping_get(bo, priv);
+
+	/*
+	 * Now that the mapping holds a reference to the bo until we no longer
+	 * need it, we can safely drop the handle's reference.
+	 */
+	drm_gem_object_put(&bo->base.base);
+
 	if (!mapping) {
 		drm_gem_object_put(&bo->base.base);

This !mapping call to drm_gem_object_put() is suspicious. It doesn't make any sense and if it can be reached is going to drive the reference count negative. So I don't think the bug is completely gone.

If user space does the trick of freeing the handle between the call to panfrost_gem_create_with_handle() and panfrost_gem_mapping_get() then even with the extra reference we now have the call to panfrost_gem_mapping_get() will fail and two references are dropped.

I think the whole _create_with_handle() approach was a bad idea and it's best to simply drop the _with_handle part. I'll post a patch tidying this up along with removing the drm_gem_object_put() in the !mapping case.

Thanks,

Steve

Quoted 30 lines
drivers/gpu/drm/panfrost/panfrost_drv.c +0 -0
 		return -EINVAL;
drivers/gpu/drm/panfrost/panfrost_gem.c +7 -3
index 293e799e2fe8..e3e21c500d24 100644
@@ -234,6 +234,10 @@ struct drm_gem_object *panfrost_gem_create_object(struct drm_device *dev, size_t
 	return &obj->base.base;
 }
 
+/*
+ * NOTE: if this succeeds, both the handle and the returned object have
+ * an outstanding reference.
+ */
 struct panfrost_gem_object *
 panfrost_gem_create_with_handle(struct drm_file *file_priv,
 				struct drm_device *dev, size_t size,
@@ -261,10 +265,10 @@ panfrost_gem_create_with_handle(struct drm_file *file_priv,
 	 * and handle has the id what user can see.
 	 */
 	ret = drm_gem_handle_create(file_priv, &shmem->base, handle);
-	/* drop reference from allocate - handle holds it now. */
-	drm_gem_object_put(&shmem->base);
-	if (ret)
+	if (ret) {
+		drm_gem_object_put(&shmem->base);
 		return ERR_PTR(ret);
+	}
 
 	return bo;
 }