Skip to contentSkip to conversation

davinci: fix build warnings

PATCH New Bartosz Golaszewski 3 participants 12 messages May 27, 2019 – Jul 4, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover davinci: fix build warnings

From: Bartosz Golaszewski <[email protected]>

There are several build warnings related to driver-model usage emitted when building u-boot for da850-evm and da850-lcdk. This series fixes them and - while we're at it - removes the i2c compatiblity layer as davinci was the last user of it.

Bartosz Golaszewski (4):
davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs
sandbox: remove CONFIG_DM_I2C_COMPAT from defconfigs
i2c: remove i2c driver-model compatibility layer
omapl138_lcdk_defconfig: don't build support for SPI

 Makefile                           |   7 --
 configs/da850_am18xxevm_defconfig  |   1 -
 configs/omapl138_lcdk_defconfig    |   7 +-
 configs/sandbox64_defconfig        |   1 -
 configs/sandbox_defconfig          |   1 -
 configs/sandbox_flattree_defconfig |   1 -
 configs/sandbox_noblk_defconfig    |   1 -
 configs/sandbox_spl_defconfig      |   1 -
 configs/tools-only_defconfig       |   1 -
 drivers/i2c/Kconfig                |  13 +--
 drivers/i2c/Makefile               |   1 -
 drivers/i2c/i2c-uclass-compat.c    | 128 -----------------------------
 include/_exports.h                 |   3 +-
 include/configs/am3517_evm.h       |   1 -
 include/configs/da850evm.h         |   8 --
 include/configs/omapl138_lcdk.h    |   8 --
 include/exports.h                  |   3 +-
 include/i2c.h                      |  80 ------------------
 18 files changed, 4 insertions(+), 262 deletions(-)
 delete mode 100644 drivers/i2c/i2c-uclass-compat.c
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/4 davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs

From: Bartosz Golaszewski <[email protected]>

This option is no longer used on any davinci board but still selected in defconfigs which causes the following warning:

===================== WARNING ====================== This board uses CONFIG_DM_I2C_COMPAT. Please remove (possibly in a subsequent patch in your series) before sending patches to the mailing list.
====================================================

Remove all references to CONFIG_DM_I2C_COMPAT from davinci.

---
 configs/da850_am18xxevm_defconfig | 1 -
 configs/omapl138_lcdk_defconfig   | 1 -
 include/configs/am3517_evm.h      | 1 -
 include/configs/da850evm.h        | 8 --------
 include/configs/omapl138_lcdk.h   | 8 --------
 5 files changed, 19 deletions(-)
configs/da850_am18xxevm_defconfig +0 -1
index f098222113..ad01957fa1 100644
@@ -44,7 +44,6 @@ CONFIG_DM=y
 CONFIG_SPL_DM=y
 CONFIG_DA8XX_GPIO=y
 CONFIG_DM_I2C=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_SYS_I2C_DAVINCI=y
 CONFIG_MTD_DEVICE=y
 CONFIG_DM_SPI_FLASH=y
configs/omapl138_lcdk_defconfig +0 -1
index e43141844a..b03d8160af 100644
@@ -37,7 +37,6 @@ CONFIG_ENV_IS_IN_NAND=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
 CONFIG_DM_I2C=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_SYS_I2C_DAVINCI=y
 CONFIG_DM_MMC=y
 CONFIG_NAND=y
include/configs/am3517_evm.h +0 -1
index 9475e9975d..11f8f6d213 100644
@@ -14,7 +14,6 @@
 
 #include <configs/ti_omap3_common.h>
 
-#undef CONFIG_DM_I2C_COMPAT
 #define CONFIG_REVISION_TAG
 
 /* Hardware drivers */
include/configs/da850evm.h +0 -8
index ccdac0abec..5d02c35279 100644
@@ -18,14 +18,6 @@
 #define CONFIG_USE_SPIFLASH
 #endif
 
-/*
-* Disable DM_* for SPL build and can be re-enabled after adding
-* DM support in SPL
-*/
-#ifdef CONFIG_SPL_BUILD
-#undef CONFIG_DM_I2C
-#undef CONFIG_DM_I2C_COMPAT
-#endif
 /*
  * SoC Configuration
  */
include/configs/omapl138_lcdk.h +0 -8
index da615e5063..db4a663c53 100644
@@ -16,14 +16,6 @@
 #undef CONFIG_USE_SPIFLASH
 #undef	CONFIG_SYS_USE_NOR
 
-/*
-* Disable DM_* for SPL build and can be re-enabled after adding
-* DM support in SPL
-*/
-#ifdef CONFIG_SPL_BUILD
-#undef CONFIG_DM_I2C
-#undef CONFIG_DM_I2C_COMPAT
-#endif
 /*
  * SoC Configuration
  */
Signature · 1 line
2.21.0
#2 lore raw

PATCH 1/4 davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs

Hello Bartosz,

Am 27.05.2019 um 10:57 schrieb Bartosz Golaszewski:

Quoted 13 lines

From: Bartosz Golaszewski <[email protected]>

This option is no longer used on any davinci board but still selected in defconfigs which causes the following warning:

===================== WARNING ====================== This board uses CONFIG_DM_I2C_COMPAT. Please remove (possibly in a subsequent patch in your series) before sending patches to the mailing list.
====================================================

Remove all references to CONFIG_DM_I2C_COMPAT from davinci.

Quoted 8 lines
---
  configs/da850_am18xxevm_defconfig | 1 -
  configs/omapl138_lcdk_defconfig   | 1 -
  include/configs/am3517_evm.h      | 1 -
  include/configs/da850evm.h        | 8 --------
  include/configs/omapl138_lcdk.h   | 8 --------
  5 files changed, 19 deletions(-)

Thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#3 lore raw

PATCH 2/4 sandbox: remove CONFIG_DM_I2C_COMPAT from defconfigs

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

There are no more "real" users of CONFIG_DM_I2C_COMPAT and we'll soon remove it altogether. Stop building it in sandbox mode.

---
 Makefile                           | 2 +-
 configs/sandbox64_defconfig        | 1 -
 configs/sandbox_defconfig          | 1 -
 configs/sandbox_flattree_defconfig | 1 -
 configs/sandbox_noblk_defconfig    | 1 -
 configs/sandbox_spl_defconfig      | 1 -
 configs/tools-only_defconfig       | 1 -
 7 files changed, 1 insertion(+), 7 deletions(-)
Makefile +1 -1
index 059978bfe6..ff38b5d19f 100644
@@ -918,7 +918,7 @@ cmd_cfgcheck = $(srctree)/scripts/check-config.sh $2 \
 		$(srctree)/scripts/config_whitelist.txt $(srctree)
 
 all:		$(ALL-y)
-ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
+ifeq ($(CONFIG_DM_I2C_COMPAT),y)
 	@echo >&2 "===================== WARNING ======================"
 	@echo >&2 "This board uses CONFIG_DM_I2C_COMPAT. Please remove"
 	@echo >&2 "(possibly in a subsequent patch in your series)"
configs/sandbox64_defconfig +0 -1
index 1bc3bd3801..85226f5009 100644
@@ -89,7 +89,6 @@ CONFIG_BOARD=y
 CONFIG_BOARD_SANDBOX=y
 CONFIG_PM8916_GPIO=y
 CONFIG_SANDBOX_GPIO=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_I2C_CROS_EC_TUNNEL=y
 CONFIG_I2C_CROS_EC_LDO=y
 CONFIG_DM_I2C_GPIO=y
configs/sandbox_defconfig +0 -1
index 4877f1099a..9bc567b672 100644
@@ -104,7 +104,6 @@ CONFIG_PM8916_GPIO=y
 CONFIG_SANDBOX_GPIO=y
 CONFIG_DM_HWSPINLOCK=y
 CONFIG_HWSPINLOCK_SANDBOX=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_I2C_CROS_EC_TUNNEL=y
 CONFIG_I2C_CROS_EC_LDO=y
 CONFIG_DM_I2C_GPIO=y
configs/sandbox_flattree_defconfig +0 -1
index 40593ee3a1..f78d45ad1c 100644
@@ -74,7 +74,6 @@ CONFIG_BOARD=y
 CONFIG_BOARD_SANDBOX=y
 CONFIG_PM8916_GPIO=y
 CONFIG_SANDBOX_GPIO=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_I2C_CROS_EC_TUNNEL=y
 CONFIG_I2C_CROS_EC_LDO=y
 CONFIG_DM_I2C_GPIO=y
configs/sandbox_noblk_defconfig +0 -1
index 24ff4b41da..653341699b 100644
@@ -81,7 +81,6 @@ CONFIG_BOARD=y
 CONFIG_BOARD_SANDBOX=y
 CONFIG_PM8916_GPIO=y
 CONFIG_SANDBOX_GPIO=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_I2C_CROS_EC_TUNNEL=y
 CONFIG_I2C_CROS_EC_LDO=y
 CONFIG_DM_I2C_GPIO=y
configs/sandbox_spl_defconfig +0 -1
index bebd78d55b..6b8b923dda 100644
@@ -95,7 +95,6 @@ CONFIG_BOARD=y
 CONFIG_BOARD_SANDBOX=y
 CONFIG_PM8916_GPIO=y
 CONFIG_SANDBOX_GPIO=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_I2C_CROS_EC_TUNNEL=y
 CONFIG_I2C_CROS_EC_LDO=y
 CONFIG_DM_I2C_GPIO=y
configs/tools-only_defconfig +0 -1
index fb06076785..e3b3018158 100644
@@ -11,7 +11,6 @@ CONFIG_OF_HOSTFILE=y
 CONFIG_DEFAULT_DEVICE_TREE="sandbox"
 # CONFIG_UDP_FUNCTION_FASTBOOT is not set
 CONFIG_SANDBOX_GPIO=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_PCI=y
 CONFIG_DM_PCI=y
 CONFIG_PCI_SANDBOX=y
Signature · 1 line
2.21.0
#4 lore raw

PATCH 2/4 sandbox: remove CONFIG_DM_I2C_COMPAT from defconfigs

Hello Bartosz,

Am 27.05.2019 um 10:57 schrieb Bartosz Golaszewski:

Quoted 6 lines

From: Bartosz Golaszewski <[email protected]>

There are no more "real" users of CONFIG_DM_I2C_COMPAT and we'll soon remove it altogether. Stop building it in sandbox mode.

Quoted 9 lines
---
  Makefile                           | 2 +-
  configs/sandbox64_defconfig        | 1 -
  configs/sandbox_defconfig          | 1 -
  configs/sandbox_flattree_defconfig | 1 -
  configs/sandbox_noblk_defconfig    | 1 -
  configs/sandbox_spl_defconfig      | 1 -
  configs/tools-only_defconfig       | 1 -
  7 files changed, 1 insertion(+), 7 deletions(-)

Thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#5 lore raw

PATCH 3/4 i2c: remove i2c driver-model compatibility layer

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

There are no more users of the compatibility layer for i2c. Remove the driver and all references to it.

---
 Makefile                        |   7 --
 drivers/i2c/Kconfig             |  13 +---
 drivers/i2c/Makefile            |   1 -
 drivers/i2c/i2c-uclass-compat.c | 128 --------------------------------
 include/_exports.h              |   3 +-
 include/exports.h               |   3 +-
 include/i2c.h                   |  80 --------------------
 7 files changed, 3 insertions(+), 232 deletions(-)
 delete mode 100644 drivers/i2c/i2c-uclass-compat.c
Makefile +0 -7
index ff38b5d19f..bc5774d975 100644
@@ -918,13 +918,6 @@ cmd_cfgcheck = $(srctree)/scripts/check-config.sh $2 \
 		$(srctree)/scripts/config_whitelist.txt $(srctree)
 
 all:		$(ALL-y)
-ifeq ($(CONFIG_DM_I2C_COMPAT),y)
-	@echo >&2 "===================== WARNING ======================"
-	@echo >&2 "This board uses CONFIG_DM_I2C_COMPAT. Please remove"
-	@echo >&2 "(possibly in a subsequent patch in your series)"
-	@echo >&2 "before sending patches to the mailing list."
-	@echo >&2 "===================================================="
-endif
 ifeq ($(CONFIG_MMC),y)
 ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
 	@echo >&2 "===================== WARNING ======================"
drivers/i2c/Kconfig +1 -12
index 095a9bc6a4..9c26471f94 100644
@@ -12,18 +12,7 @@ config DM_I2C
 	  write and speed, is implemented with the bus drivers operations,
 	  which provide methods for bus setting and data transfer. Each chip
 	  device (bus child) info is kept as parent platdata. The interface
-	  is defined in include/i2c.h. When i2c bus driver supports the i2c
-	  uclass, but the device drivers not, then DM_I2C_COMPAT config can
-	  be used as compatibility layer.
-
-config DM_I2C_COMPAT
-	bool "Enable I2C compatibility layer"
-	depends on DM
-	help
-	  Enable old-style I2C functions for compatibility with existing code.
-	  This option can be enabled as a temporary measure to avoid needing
-	  to convert all code for a board in a single commit. It should not
-	  be enabled for any board in an official release.
+	  is defined in include/i2c.h.
 
 config I2C_CROS_EC_TUNNEL
 	tristate "Chrome OS EC tunnel I2C bus"
drivers/i2c/Makefile +0 -1
index dc40055efb..c2f75d8755 100644
@@ -3,7 +3,6 @@
 # (C) Copyright 2000-2007
 # Wolfgang Denk, DENX Software Engineering, wd at denx.de.
 obj-$(CONFIG_DM_I2C) += i2c-uclass.o
-obj-$(CONFIG_DM_I2C_COMPAT) += i2c-uclass-compat.o
 obj-$(CONFIG_DM_I2C_GPIO) += i2c-gpio.o
 obj-$(CONFIG_$(SPL_)I2C_CROS_EC_TUNNEL) += cros_ec_tunnel.o
 obj-$(CONFIG_$(SPL_)I2C_CROS_EC_LDO) += cros_ec_ldo.o
drivers/i2c/i2c-uclass-compat.c deleted +0 -128

128 lines not on this page · raw message

include/_exports.h +1 -2
index c15050e30b..0dee05f077 100644
@@ -40,8 +40,7 @@
 	EXPORT_FUNC(simple_strtol, long, simple_strtol,
 		    const char *, char **, unsigned int)
 	EXPORT_FUNC(strcmp, int, strcmp, const char *cs, const char *ct)
-#if defined(CONFIG_CMD_I2C) && \
-		(!defined(CONFIG_DM_I2C) || defined(CONFIG_DM_I2C_COMPAT))
+#if defined(CONFIG_CMD_I2C) && !defined(CONFIG_DM_I2C)
 	EXPORT_FUNC(i2c_write, int, i2c_write, uchar, uint, int , uchar * , int)
 	EXPORT_FUNC(i2c_read, int, i2c_read, uchar, uint, int , uchar * , int)
 #else
include/exports.h +1 -2
index a4b862f191..bf8d53c6b0 100644
@@ -32,8 +32,7 @@ long simple_strtol(const char *cp, char **endp, unsigned int base);
 int strcmp(const char *cs, const char *ct);
 unsigned long ustrtoul(const char *cp, char **endp, unsigned int base);
 unsigned long long ustrtoull(const char *cp, char **endp, unsigned int base);
-#if defined(CONFIG_CMD_I2C) && \
-		(!defined(CONFIG_DM_I2C) || defined(CONFIG_DM_I2C_COMPAT))
+#if defined(CONFIG_CMD_I2C) && !defined(CONFIG_DM_I2C)
 int i2c_write (uchar, uint, int , uchar* , int);
 int i2c_read (uchar, uint, int , uchar* , int);
 #endif
include/i2c.h +0 -80

86 lines not on this page · raw message

Signature · 1 line
2.21.0
#6 lore raw

PATCH 3/4 i2c: remove i2c driver-model compatibility layer

Hello Bartosz,

Am 27.05.2019 um 10:57 schrieb Bartosz Golaszewski:

Quoted 15 lines

From: Bartosz Golaszewski <[email protected]>

There are no more users of the compatibility layer for i2c. Remove the driver and all references to it.

---
  Makefile                        |   7 --
  drivers/i2c/Kconfig             |  13 +---
  drivers/i2c/Makefile            |   1 -
  drivers/i2c/i2c-uclass-compat.c | 128 --------------------------------
  include/_exports.h              |   3 +-
  include/exports.h               |   3 +-
  include/i2c.h                   |  80 --------------------
  7 files changed, 3 insertions(+), 232 deletions(-)
Quoted 1 line

delete mode 100644 drivers/i2c/i2c-uclass-compat.c

Thanks!

bye,
Heiko

Signature · 4 lines
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#7 lore raw

PATCH 4/4 omapl138_lcdk_defconfig: don't build support for SPI

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

The following warning is emited when building u-boot for da850-lcdk:

===================== WARNING ====================== This board does not use CONFIG_DM_SPI. Please update the board before v2019.04 for no dm conversion
and v2019.07 for partially dm converted drivers. Failure to update can lead to driver/board removal See doc/driver-model/MIGRATION.txt for more info.
====================================================
===================== WARNING ====================== This board does not use CONFIG_DM_SPI_FLASH. Please update the board to use CONFIG_SPI_FLASH before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================

While we could fix it by selecting CONFIG_DM_SPI, there's no need to build it at all as SPI is disabled on da850-lcdk. Remove all unneeded options from the defconfig.

---
 configs/omapl138_lcdk_defconfig | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
configs/omapl138_lcdk_defconfig +1 -5
index b03d8160af..1c232b47f3 100644
@@ -27,6 +27,7 @@ CONFIG_CRC32_VERIFY=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_GPIO is not set
 CONFIG_CMD_NAND=y
+# CONFIG_CMD_SPI is not set
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_MTDPARTS=y
 CONFIG_CMD_DIAG=y
@@ -45,13 +46,8 @@ CONFIG_SYS_NAND_BUSWIDTH_16BIT=y
 CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y
 CONFIG_SYS_NAND_U_BOOT_OFFS=0x28000
 CONFIG_SPL_NAND_SIMPLE=y
-CONFIG_SPI_FLASH=y
 CONFIG_SF_DEFAULT_SPEED=30000000
-CONFIG_SPI_FLASH_STMICRO=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_MII=y
 CONFIG_DRIVER_TI_EMAC=y
 CONFIG_DM_SERIAL=y
 CONFIG_SYS_NS16550=y
-CONFIG_SPI=y
-CONFIG_DAVINCI_SPI=y
Signature · 1 line
2.21.0
#8 lore raw

PATCH 4/4 omapl138_lcdk_defconfig: don't build support for SPI

Hello Bartosz,

Am 27.05.2019 um 10:57 schrieb Bartosz Golaszewski:

Quoted 18 lines

From: Bartosz Golaszewski <[email protected]>

The following warning is emited when building u-boot for da850-lcdk:

===================== WARNING ====================== This board does not use CONFIG_DM_SPI. Please update the board before v2019.04 for no dm conversion
and v2019.07 for partially dm converted drivers. Failure to update can lead to driver/board removal See doc/driver-model/MIGRATION.txt for more info.
====================================================
===================== WARNING ====================== This board does not use CONFIG_DM_SPI_FLASH. Please update the board to use CONFIG_SPI_FLASH before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================

Quoted 8 lines

While we could fix it by selecting CONFIG_DM_SPI, there's no need to build it at all as SPI is disabled on da850-lcdk. Remove all unneeded options from the defconfig.

---
  configs/omapl138_lcdk_defconfig | 6 +-----
  1 file changed, 1 insertion(+), 5 deletions(-)

Thanks!

bye,
Heiko

Signature · 4 lines
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#9 lore raw

cover davinci: fix build warnings

In reply to Bartosz Golaszewski

pon., 27 maj 2019 o 10:57 Bartosz Golaszewski <[email protected]> napisaÅ‚(a):

Quoted 35 lines

From: Bartosz Golaszewski <[email protected]>

There are several build warnings related to driver-model usage emitted when building u-boot for da850-evm and da850-lcdk. This series fixes them and - while we're at it - removes the i2c compatiblity layer as davinci was the last user of it.

Bartosz Golaszewski (4):
davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs
sandbox: remove CONFIG_DM_I2C_COMPAT from defconfigs
i2c: remove i2c driver-model compatibility layer
omapl138_lcdk_defconfig: don't build support for SPI

 Makefile                           |   7 --
 configs/da850_am18xxevm_defconfig  |   1 -
 configs/omapl138_lcdk_defconfig    |   7 +-
 configs/sandbox64_defconfig        |   1 -
 configs/sandbox_defconfig          |   1 -
 configs/sandbox_flattree_defconfig |   1 -
 configs/sandbox_noblk_defconfig    |   1 -
 configs/sandbox_spl_defconfig      |   1 -
 configs/tools-only_defconfig       |   1 -
 drivers/i2c/Kconfig                |  13 +--
 drivers/i2c/Makefile               |   1 -
 drivers/i2c/i2c-uclass-compat.c    | 128 -----------------------------
 include/_exports.h                 |   3 +-
 include/configs/am3517_evm.h       |   1 -
 include/configs/da850evm.h         |   8 --
 include/configs/omapl138_lcdk.h    |   8 --
 include/exports.h                  |   3 +-
 include/i2c.h                      |  80 ------------------
 18 files changed, 4 insertions(+), 262 deletions(-)
 delete mode 100644 drivers/i2c/i2c-uclass-compat.c
Quoted 3 lines

--
2.21.0

Ping

Bart

#10 lore raw

cover davinci: fix build warnings

pon., 24 cze 2019 o 10:18 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 37 lines

pon., 27 maj 2019 o 10:57 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 35 lines

From: Bartosz Golaszewski <[email protected]>

There are several build warnings related to driver-model usage emitted when building u-boot for da850-evm and da850-lcdk. This series fixes them and - while we're at it - removes the i2c compatiblity layer as davinci was the last user of it.

Bartosz Golaszewski (4):
davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs
sandbox: remove CONFIG_DM_I2C_COMPAT from defconfigs
i2c: remove i2c driver-model compatibility layer
omapl138_lcdk_defconfig: don't build support for SPI

 Makefile                           |   7 --
 configs/da850_am18xxevm_defconfig  |   1 -
 configs/omapl138_lcdk_defconfig    |   7 +-
 configs/sandbox64_defconfig        |   1 -
 configs/sandbox_defconfig          |   1 -
 configs/sandbox_flattree_defconfig |   1 -
 configs/sandbox_noblk_defconfig    |   1 -
 configs/sandbox_spl_defconfig      |   1 -
 configs/tools-only_defconfig       |   1 -
 drivers/i2c/Kconfig                |  13 +--
 drivers/i2c/Makefile               |   1 -
 drivers/i2c/i2c-uclass-compat.c    | 128 -----------------------------
 include/_exports.h                 |   3 +-
 include/configs/am3517_evm.h       |   1 -
 include/configs/da850evm.h         |   8 --
 include/configs/omapl138_lcdk.h    |   8 --
 include/exports.h                  |   3 +-
 include/i2c.h                      |  80 ------------------
 18 files changed, 4 insertions(+), 262 deletions(-)
 delete mode 100644 drivers/i2c/i2c-uclass-compat.c
Quoted 7 lines
Quoted 3 lines

--
2.21.0

Ping

Bart

Hi Tom,

could you pick this one up as well post release?

Bart

#11 lore raw

cover davinci: fix build warnings

Quoted 42 lines · Bartosz Golaszewski

pon., 24 cze 2019 o 10:18 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 41 lines

pon., 27 maj 2019 o 10:57 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 38 lines

From: Bartosz Golaszewski <[email protected]>

There are several build warnings related to driver-model usage emitted when building u-boot for da850-evm and da850-lcdk. This series fixes them and - while we're at it - removes the i2c compatiblity layer as davinci was the last user of it.

Bartosz Golaszewski (4):
davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs
sandbox: remove CONFIG_DM_I2C_COMPAT from defconfigs
i2c: remove i2c driver-model compatibility layer
omapl138_lcdk_defconfig: don't build support for SPI

 Makefile                           |   7 --
 configs/da850_am18xxevm_defconfig  |   1 -
 configs/omapl138_lcdk_defconfig    |   7 +-
 configs/sandbox64_defconfig        |   1 -
 configs/sandbox_defconfig          |   1 -
 configs/sandbox_flattree_defconfig |   1 -
 configs/sandbox_noblk_defconfig    |   1 -
 configs/sandbox_spl_defconfig      |   1 -
 configs/tools-only_defconfig       |   1 -
 drivers/i2c/Kconfig                |  13 +--
 drivers/i2c/Makefile               |   1 -
 drivers/i2c/i2c-uclass-compat.c    | 128 -----------------------------
 include/_exports.h                 |   3 +-
 include/configs/am3517_evm.h       |   1 -
 include/configs/da850evm.h         |   8 --
 include/configs/omapl138_lcdk.h    |   8 --
 include/exports.h                  |   3 +-
 include/i2c.h                      |  80 ------------------
 18 files changed, 4 insertions(+), 262 deletions(-)
 delete mode 100644 drivers/i2c/i2c-uclass-compat.c

--
2.21.0

Quoted 7 lines
Quoted 3 lines

Ping

Bart

Hi Tom,

could you pick this one up as well post release?

Yes, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190704/5fd6e808/attachment.sig>