add rte_ring_reset and use it to flush a ring
cover add rte_ring_reset and use it to flush a ring
To flush a ring not in use, dequeue one by one is wasting cpu cycles. The patch is to just resetting the head and tail indices to save cpu cycle.
Gavin Hu (2):
ring: add rte_ring_reset api to flush the ring
hash: flush the rings instead of dequeuing one by one
lib/librte_hash/Makefile | 2 +- lib/librte_hash/rte_cuckoo_hash.c | 11 ++++------- lib/librte_ring/rte_ring.h | 20 ++++++++++++++++++++ lib/librte_ring/rte_ring_version.map | 7 +++++++ 4 files changed, 32 insertions(+), 8 deletions(-)
Signature · 1 line
2.11.0
PATCH 1/2 ring: add rte_ring_reset api to flush the ring
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
--- lib/librte_ring/rte_ring.h | 20 ++++++++++++++++++++ lib/librte_ring/rte_ring_version.map | 7 +++++++ 2 files changed, 27 insertions(+)
lib/librte_ring/rte_ring.h +20 -0
@@ -671,6 +671,26 @@ rte_ring_dequeue(struct rte_ring *r, void **obj_p) }/** +* Flush a ring. +* +* This function flush all the elements in a ring +* +* @b EXPERIMENTAL: this API may change without prior notice +* +* @warning +* Make sure the ring is not in use while calling this function. +* +* @param r +* A pointer to the ring structure. +*/ +static inline void __rte_experimental +rte_ring_reset (struct rte_ring *r) +{ + r->prod.head = r->cons.head =0 ; + r->prod.tail = r->cons.tail =0 ; +} + +/** * Return the number of entries in a ring. * * @param r
lib/librte_ring/rte_ring_version.map +7 -0
@@ -17,3 +17,10 @@ DPDK_2.2 { rte_ring_free; } DPDK_2.0; + +EXPERIMENTAL { + global: + + rte_ring_reset; + +};
Signature · 1 line
2.11.0
PATCH 2/2 hash: flush the rings instead of dequeuing one by one
In reply to Gavin HuWithin rte_hash_reset, calling a while loop to dequeue one by one from the ring, while not using them at all, is wasting cycles, The patch just flush the ring by resetting the indices can save cpu cycles.
--- lib/librte_hash/Makefile | 2 +- lib/librte_hash/rte_cuckoo_hash.c | 11 ++++------- 2 files changed, 5 insertions(+), 8 deletions(-)
lib/librte_hash/Makefile +1 -1
@@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk # library name LIB = librte_hash.a -CFLAGS += -O3 +CFLAGS += -O3 -DALLOW_EXPERIMENTAL_API CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) LDLIBS += -lrte_eal -lrte_ring
lib/librte_hash/rte_cuckoo_hash.c +4 -7
@@ -559,7 +559,6 @@ __hash_rw_reader_unlock(const struct rte_hash *h)void rte_hash_reset (struct rte_hash *h) { -void *ptr;uint32_t tot_ring_cnt, i;if (h ==NULL )
@@ -570,16 +569,14 @@ rte_hash_reset(struct rte_hash *h)memset (h->key_store,0 , h->key_entry_size * (h->entries +1 )); *h->tbl_chng_cnt =0 ; -/* clear the free ring */ -while (rte_ring_dequeue (h->free_slots, &ptr) ==0 ) -continue ; +/* reset the free ring */ +rte_ring_reset (h->free_slots); -/* clear free extendable bucket ring and memory */ +/* flush free extendable bucket ring and memory */ if (h->ext_table_support) {memset (h->buckets_ext,0 , h->num_buckets *sizeof (struct rte_hash_bucket )); -while (rte_ring_dequeue (h->free_ext_bkts, &ptr) ==0 ) -continue ; +rte_ring_reset (h->free_ext_bkts); }/* Repopulate the free slots ring. Entry zero is reserved for key misses */
Signature · 1 line
2.11.0
v2 cover add rte ring reset api and use it to flush a ring by hash
In reply to Gavin HuV2: fix the coding style issue(commit message line too long)
V1: To flush a ring not in use, dequeue one by one is wasting cpu cycles. The patch is to just resetting the head and tail indices to save cpu cycle.
Gavin Hu (2):
ring: add reset api to flush the ring when not in use
hash: flush the rings instead of dequeuing one by one
lib/librte_hash/Makefile | 2 +- lib/librte_hash/rte_cuckoo_hash.c | 11 ++++------- lib/librte_ring/rte_ring.h | 20 ++++++++++++++++++++ lib/librte_ring/rte_ring_version.map | 7 +++++++ 4 files changed, 32 insertions(+), 8 deletions(-)
Signature · 1 line
2.11.0
PATCH v2 1/2 ring: add reset api to flush the ring when not in use
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
--- lib/librte_ring/rte_ring.h | 20 ++++++++++++++++++++ lib/librte_ring/rte_ring_version.map | 7 +++++++ 2 files changed, 27 insertions(+)
lib/librte_ring/rte_ring.h +20 -0
@@ -671,6 +671,26 @@ rte_ring_dequeue(struct rte_ring *r, void **obj_p) }/** +* Flush a ring. +* +* This function flush all the elements in a ring +* +* @b EXPERIMENTAL: this API may change without prior notice +* +* @warning +* Make sure the ring is not in use while calling this function. +* +* @param r +* A pointer to the ring structure. +*/ +static inline void __rte_experimental +rte_ring_reset (struct rte_ring *r) +{ + r->prod.head = r->cons.head =0 ; + r->prod.tail = r->cons.tail =0 ; +} + +/** * Return the number of entries in a ring. * * @param r
lib/librte_ring/rte_ring_version.map +7 -0
@@ -17,3 +17,10 @@ DPDK_2.2 { rte_ring_free; } DPDK_2.0; + +EXPERIMENTAL { + global: + + rte_ring_reset; + +};
Signature · 1 line
2.11.0
PATCH v2 2/2 hash: flush the rings instead of dequeuing one by one
In reply to Gavin HuWithin rte_hash_reset, calling a while loop to dequeue one by one from the ring, while not using them at all, is wasting cycles, The patch just flush the ring by resetting the indices can save cpu cycles.
--- lib/librte_hash/Makefile | 2 +- lib/librte_hash/rte_cuckoo_hash.c | 11 ++++------- 2 files changed, 5 insertions(+), 8 deletions(-)
lib/librte_hash/Makefile +1 -1
@@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk # library name LIB = librte_hash.a -CFLAGS += -O3 +CFLAGS += -O3 -DALLOW_EXPERIMENTAL_API CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) LDLIBS += -lrte_eal -lrte_ring
lib/librte_hash/rte_cuckoo_hash.c +4 -7
@@ -559,7 +559,6 @@ __hash_rw_reader_unlock(const struct rte_hash *h)void rte_hash_reset (struct rte_hash *h) { -void *ptr;uint32_t tot_ring_cnt, i;if (h ==NULL )
@@ -570,16 +569,14 @@ rte_hash_reset(struct rte_hash *h)memset (h->key_store,0 , h->key_entry_size * (h->entries +1 )); *h->tbl_chng_cnt =0 ; -/* clear the free ring */ -while (rte_ring_dequeue (h->free_slots, &ptr) ==0 ) -continue ; +/* reset the free ring */ +rte_ring_reset (h->free_slots); -/* clear free extendable bucket ring and memory */ +/* flush free extendable bucket ring and memory */ if (h->ext_table_support) {memset (h->buckets_ext,0 , h->num_buckets *sizeof (struct rte_hash_bucket )); -while (rte_ring_dequeue (h->free_ext_bkts, &ptr) ==0 ) -continue ; +rte_ring_reset (h->free_ext_bkts); }/* Repopulate the free slots ring. Entry zero is reserved for key misses */
Signature · 1 line
2.11.0
Re: [PATCH v2 2/2] hash: flush the rings instead of dequeuing one by one
Quoted 21 lines · Gavin Hu
Within
rte_hash_reset, calling a while loop to dequeue one by one from the ring, while not using them at all, is wasting cycles, The patch just flush the ring by resetting the indices can save cpu cycles.Fixes b26473ff8f4a ("hash: add reset function")Fixes 75706568a7eb ("hash: add extendable bucket feature")Signed-off-by Gavin Hu <[email protected]>Reviewed-by Honnappa Nagarahalli <[email protected]>--- lib/librte_hash/Makefile | 2 +- lib/librte_hash/rte_cuckoo_hash.c | 11 ++++------- 2 files changed, 5 insertions(+), 8 deletions(-)lib/librte_hash/Makefile +0
-0
lib/librte_hash/Makefile include $(RTE_SDK)/mk/rte.vars.mk · line 12
Quoted 8 lines
lib/librte_hash/Makefile +1
-1@@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk # library name LIB = librte_hash.a -CFLAGS += -O3 +CFLAGS += -O3 -DALLOW_EXPERIMENTAL_API CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) LDLIBS += -lrte_eal -lrte_ring
Is a similar change needed to meson.build?
Re: [PATCH v2 2/2] hash: flush the rings instead of dequeuing one by one
In reply to Gavin HuQuoted 21 lines · Gavin Hu
Within
rte_hash_reset, calling a while loop to dequeue one by one from the ring, while not using them at all, is wasting cycles, The patch just flush the ring by resetting the indices can save cpu cycles.Fixes b26473ff8f4a ("hash: add reset function")Fixes 75706568a7eb ("hash: add extendable bucket feature")Signed-off-by Gavin Hu <[email protected]>Reviewed-by Honnappa Nagarahalli <[email protected]>--- lib/librte_hash/Makefile | 2 +- lib/librte_hash/rte_cuckoo_hash.c | 11 ++++------- 2 files changed, 5 insertions(+), 8 deletions(-)lib/librte_hash/Makefile +0
-0
lib/librte_hash/Makefile include $(RTE_SDK)/mk/rte.vars.mk · line 9
Quoted 5 lines
lib/librte_hash/Makefile +1
-1@@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk # library name LIB = librte_hash.a -CFLAGS += -O3 +CFLAGS += -O3 -DALLOW_EXPERIMENTAL_API
You need to update meson.build as well.
v7 cover new ring reset api and use it by hash
In reply to Gavin HuV1: To flush a ring not in use, dequeue one by one is wasting cpu cycles. The patch is to just resetting the head and tail indices to save cpu cycle.
V2: Fix the coding style issue(commit message line too long)
V3: Allow experimental API for meson build
V4:
- Include the ring perf test case enhancement patch in the series.
- Replace ARRAY_SIZE with RTE_DIM.
- Call memset to avoid clang compling complains.
V5:
- 1. Commit message tweaking for ring test case enhancement patch
- 2. Upper to lower for mails to make match/grep more easily
V6: Made upper case for the user name to comply with the convention.
V7: Leave the ring test case patch out to other series as it is not closely linked to this series in logic
Gavin Hu (2):
ring: add reset API to flush the ring when not in use
hash: flush the rings instead of dequeuing one by one
lib/librte_hash/Makefile | 2 +- lib/librte_hash/meson.build | 3 +++ lib/librte_hash/rte_cuckoo_hash.c | 11 ++++------- lib/librte_ring/rte_ring.h | 20 ++++++++++++++++++++ lib/librte_ring/rte_ring_version.map | 7 +++++++ 5 files changed, 35 insertions(+), 8 deletions(-)
Signature · 1 line
2.7.4
PATCH v7 1/2 ring: add reset API to flush the ring when not in use
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
--- lib/librte_ring/rte_ring.h | 20 ++++++++++++++++++++ lib/librte_ring/rte_ring_version.map | 7 +++++++ 2 files changed, 27 insertions(+)
lib/librte_ring/rte_ring.h +20 -0
@@ -671,6 +671,26 @@ rte_ring_dequeue(struct rte_ring *r, void **obj_p) }/** +* Flush a ring. +* +* This function flush all the elements in a ring +* +* @b EXPERIMENTAL: this API may change without prior notice +* +* @warning +* Make sure the ring is not in use while calling this function. +* +* @param r +* A pointer to the ring structure. +*/ +static inline void __rte_experimental +rte_ring_reset (struct rte_ring *r) +{ + r->prod.head = r->cons.head =0 ; + r->prod.tail = r->cons.tail =0 ; +} + +/** * Return the number of entries in a ring. * * @param r
lib/librte_ring/rte_ring_version.map +7 -0
@@ -17,3 +17,10 @@ DPDK_2.2 { rte_ring_free; } DPDK_2.0; + +EXPERIMENTAL { + global: + + rte_ring_reset; + +};
Signature · 1 line
2.7.4
Re: [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
Hi,
Quoted 63 lines · Gavin Hu
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
Fixes af75078fece3 ("first public release")Signed-off-by Gavin Hu <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Reviewed-by Honnappa Nagarahalli <[email protected]>--- lib/librte_ring/rte_ring.h | 20 ++++++++++++++++++++ lib/librte_ring/rte_ring_version.map | 7 +++++++ 2 files changed, 27 insertions(+)lib/librte_ring/rte_ring.h +20
-0@@ -671,6 +671,26 @@ rte_ring_dequeue(struct rte_ring *r, void **obj_p) }/** +* Flush a ring. +* +* This function flush all the elements in a ring +* +* @b EXPERIMENTAL: this API may change without prior notice +* +* @warning +* Make sure the ring is not in use while calling this function. +* +* @param r +* A pointer to the ring structure. +*/ +static inline void __rte_experimental +rte_ring_reset (struct rte_ring *r) +{ + r->prod.head = r->cons.head =0 ; + r->prod.tail = r->cons.tail =0 ; +} + +/** * Return the number of entries in a ring. * * @param r lib/librte_ring/rte_ring_version.map +7
-0@@ -17,3 +17,10 @@ DPDK_2.2 { rte_ring_free; } DPDK_2.0; + +EXPERIMENTAL { + global: + + rte_ring_reset; + +};Signature · 1 line
2.7.4
To me, a static inline function does not need to be added in rte_ring_version.map (or is it due to a check script checking the __rte_experimental tag ?). I found at least one commit where it is not the case:c277b34c1b3b ("mbuf: add function returning buffer address")
There are 2 options:
1- remove the rte_ring_version.map part of the patch. 2- change the static inline function into a standard function.
I would prefer 2-, because it allows to keep an api/abi compat layer in the future.
Regards
Olivier
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
29/03/2019 15:17, Olivier Matz:
Quoted 33 lines
Hi,
Quoted 13 lines · Gavin Hu
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
Fixes af75078fece3 ("first public release")Signed-off-by Gavin Hu <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Reviewed-by Honnappa Nagarahalli <[email protected]>---
lib/librte_ring/rte_ring_version.map DPDK_2.2 { · line 26
Quoted 10 lines
lib/librte_ring/rte_ring_version.map +7
-0@@ -17,3 +17,10 @@ DPDK_2.2 { rte_ring_free; } DPDK_2.0; + +EXPERIMENTAL { + global: + + rte_ring_reset; + +};To me, a static inline function does not need to be added in rte_ring_version.map (or is it due to a check script checking the
__rte_experimentaltag ?). I found at least one commit where it is not the case:c277b34c1b3b("mbuf: add function returning buffer address")
Quoted 6 lines
There are 2 options:
1- remove the rte_ring_version.map part of the patch. 2- change the static inline function into a standard function.I would prefer 2-, because it allows to keep an api/abi compat layer in the future.
There are no news about this patch.
I classify it as changes requested.
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
Hi Olivier and Thomas,
Quoted 50 lines
-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Thursday, July 4, 2019 10:42 PM
To: Gavin Hu (Arm Technology China) <[email protected]>
Cc: [email protected]; Olivier Matz <[email protected]>; nd <[email protected]>; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use29/03/2019 15:17, Olivier Matz:
Quoted 37 lines
Hi,
Quoted 13 lines · Gavin Hu
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
Fixes af75078fece3 ("first public release")Signed-off-by Gavin Hu <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Reviewed-by Honnappa Nagarahalli <[email protected]>---
lib/librte_ring/rte_ring_version.map DPDK_2.2 { · line 26
Quoted 10 lines
lib/librte_ring/rte_ring_version.map +7
-0@@ -17,3 +17,10 @@ DPDK_2.2 { rte_ring_free; } DPDK_2.0; + +EXPERIMENTAL { + global: + + rte_ring_reset; + +};To me, a static inline function does not need to be added in rte_ring_version.map (or is it due to a check script checking the
__rte_experimentaltag ?). I found at least one commit where it is not the case:c277b34c1b3b("mbuf: add function returning buffer address")There are 2 options:
1- remove the rte_ring_version.map part of the patch. 2- change the static inline function into a standard function.
Quoted 6 lines
Quoted 2 lines
I would prefer 2-, because it allows to keep an api/abi compat layer in the future.
There are no news about this patch.
I classify it as changes requested.
Sorry for missed your comments for long time, I just submitted v8.
I took the first option as it is in the data path and to keep consistent to its neighboring functions.
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
Hi Gavin,
Quoted 52 lines · Gavin Hu (Arm Technology China)
Hi Olivier and Thomas,
Quoted 50 lines
-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Thursday, July 4, 2019 10:42 PM
To: Gavin Hu (Arm Technology China) <[email protected]>
Cc: [email protected]; Olivier Matz <[email protected]>; nd <[email protected]>; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use29/03/2019 15:17, Olivier Matz:
Quoted 37 lines
Hi,
Quoted 13 lines · Gavin Hu
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
Fixes af75078fece3 ("first public release")Signed-off-by Gavin Hu <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Reviewed-by Honnappa Nagarahalli <[email protected]>---
lib/librte_ring/rte_ring_version.map DPDK_2.2 { · line 26
Quoted 10 lines
lib/librte_ring/rte_ring_version.map +7
-0@@ -17,3 +17,10 @@ DPDK_2.2 { rte_ring_free; } DPDK_2.0; + +EXPERIMENTAL { + global: + + rte_ring_reset; + +};To me, a static inline function does not need to be added in rte_ring_version.map (or is it due to a check script checking the
__rte_experimentaltag ?). I found at least one commit where it is not the case:c277b34c1b3b("mbuf: add function returning buffer address")There are 2 options:
1- remove the rte_ring_version.map part of the patch. 2- change the static inline function into a standard function.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
I would prefer 2-, because it allows to keep an api/abi compat layer in the future.
There are no news about this patch.
I classify it as changes requested.Sorry for missed your comments for long time, I just submitted v8.
I took the first option as it is in the data path and to keep consistent to its neighboring functions.
Could you give a little more context about why you need to reset the ring in the data path? I see that it is used in rte_hash_reset(), but in my thinking, this was more used at init/exit.
Thanks,
Olivier
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
Hi Olivier,
Quoted 73 lines
-----Original Message-----
From: Olivier Matz <[email protected]>
Sent: Friday, July 12, 2019 5:54 PM
To: Gavin Hu (Arm Technology China) <[email protected]>
Cc: [email protected]; [email protected]; nd <[email protected]>; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in useHi Gavin,
Quoted 58 lines · Gavin Hu (Arm Technology China)
Hi Olivier and Thomas,
Quoted 56 lines
-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Thursday, July 4, 2019 10:42 PM
To: Gavin Hu (Arm Technology China) <[email protected]>
Cc: [email protected]; Olivier Matz <[email protected]>; nd <[email protected]>; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use29/03/2019 15:17, Olivier Matz:
Quoted 33 lines
Hi,
Quoted 13 lines · Gavin Hu
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
Fixes af75078fece3 ("first public release")Signed-off-by Gavin Hu <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Reviewed-by Honnappa Nagarahalli <[email protected]>---
lib/librte_ring/rte_ring_version.map DPDK_2.2 { · line 26
Quoted 10 lines
lib/librte_ring/rte_ring_version.map +7
-0@@ -17,3 +17,10 @@ DPDK_2.2 { rte_ring_free; } DPDK_2.0; + +EXPERIMENTAL { + global: + + rte_ring_reset; + +};To me, a static inline function does not need to be added in rte_ring_version.map (or is it due to a check script checking the
__rte_experimentaltag ?). I found at least one commit where it is not the case:c277b34c1b3b("mbuf: add function returning buffer address")Quoted 6 lines
There are 2 options:
1- remove the rte_ring_version.map part of the patch. 2- change the static inline function into a standard function.I would prefer 2-, because it allows to keep an api/abi compat layer in the future.
There are no news about this patch.
I classify it as changes requested.
Quoted 7 lines
Quoted 2 lines
Sorry for missed your comments for long time, I just submitted v8. I took the first option as it is in the data path and to keep consistent to its
neighboring functions.
Could you give a little more context about why you need to reset the ring in the data path? I see that it is used in
rte_hash_reset(), but in my thinking, this was more used at init/exit.
Sorry,literally it is in the control path, but I was impressed it will impact the Data path performance when discussing this patch with Honnappa.
Quoted 3 lines
Thanks,
Olivier
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
Hi Gavin,
Quoted 77 lines · Gavin Hu (Arm Technology China)
Hi Olivier,
Quoted 75 lines
-----Original Message-----
From: Olivier Matz <[email protected]>
Sent: Friday, July 12, 2019 5:54 PM
To: Gavin Hu (Arm Technology China) <[email protected]>
Cc: [email protected]; [email protected]; nd <[email protected]>; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in useHi Gavin,
Quoted 60 lines · Gavin Hu (Arm Technology China)
Hi Olivier and Thomas,
Quoted 50 lines
-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Thursday, July 4, 2019 10:42 PM
To: Gavin Hu (Arm Technology China) <[email protected]>
Cc: [email protected]; Olivier Matz <[email protected]>; nd <[email protected]>; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use29/03/2019 15:17, Olivier Matz:
Quoted 37 lines
Hi,
Quoted 13 lines · Gavin Hu
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
Fixes af75078fece3 ("first public release")Signed-off-by Gavin Hu <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Reviewed-by Honnappa Nagarahalli <[email protected]>---
lib/librte_ring/rte_ring_version.map DPDK_2.2 { · line 26
Quoted 10 lines
lib/librte_ring/rte_ring_version.map +7
-0@@ -17,3 +17,10 @@ DPDK_2.2 { rte_ring_free; } DPDK_2.0; + +EXPERIMENTAL { + global: + + rte_ring_reset; + +};To me, a static inline function does not need to be added in rte_ring_version.map (or is it due to a check script checking the
__rte_experimentaltag ?). I found at least one commit where it is not the case:c277b34c1b3b("mbuf: add function returning buffer address")There are 2 options:
1- remove the rte_ring_version.map part of the patch. 2- change the static inline function into a standard function.Quoted 6 lines
Quoted 2 lines
I would prefer 2-, because it allows to keep an api/abi compat layer in the future.
There are no news about this patch.
I classify it as changes requested.Sorry for missed your comments for long time, I just submitted v8. I took the first option as it is in the data path and to keep consistent to its
Quoted 7 lines
Quoted 5 lines
neighboring functions.
Could you give a little more context about why you need to reset the ring in the data path? I see that it is used in
rte_hash_reset(), but in my thinking, this was more used at init/exit.Sorry,literally it is in the control path, but I was impressed it will impact the Data path performance when discussing this patch with Honnappa.
I'm asking this because given the recent discussions about ABI stability, I'd like to avoid defining a new static inline if it is not required.
Thanks,
Olivier
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
Hi Olivier,
Quoted 105 lines
-----Original Message-----
From: Olivier Matz <[email protected]>
Sent: Friday, July 12, 2019 7:49 PM
To: Gavin Hu (Arm Technology China) <[email protected]>
Cc: [email protected]; [email protected]; nd <[email protected]>; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; [email protected]; [email protected]; Ruifeng Wang (Arm Technology China) <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in useHi Gavin,
Quoted 11 lines · Gavin Hu (Arm Technology China)
Hi Olivier,
Quoted 9 lines
-----Original Message-----
From: Olivier Matz <[email protected]>
Sent: Friday, July 12, 2019 5:54 PM
To: Gavin Hu (Arm Technology China) <[email protected]>
Cc: [email protected]; [email protected]; nd <[email protected]>; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush thering
Quoted 5 lines
Quoted 5 lines
when not in use
Hi Gavin,
On Fri, Jul 12, 2019 at 09:32:39AM +0000, Gavin Hu (Arm Technology
China)
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines · wrote:
Hi Olivier and Thomas,
Quoted 10 lines
-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Thursday, July 4, 2019 10:42 PM
To: Gavin Hu (Arm Technology China) <[email protected]>
Cc: [email protected]; Olivier Matz <[email protected]>; nd <[email protected]>; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flushthe ring
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
when not in use
29/03/2019 15:17, Olivier Matz:
Quoted 4 lines
Hi,
Quoted 1 line · Gavin Hu
Currently, the flush is done by dequeuing the ring in a while loop.
It is
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
much simpler to flush the queue by resetting the head and tail
indices.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Fixes af75078fece3 ("first public release")Signed-off-by Gavin Hu <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Reviewed-by Honnappa NagarahalliQuoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 4 lines
---
lib/librte_ring/rte_ring_version.map DPDK_2.2 { · line 26
Quoted 10 lines
lib/librte_ring/rte_ring_version.map +7
-0@@ -17,3 +17,10 @@ DPDK_2.2 { rte_ring_free; } DPDK_2.0; + +EXPERIMENTAL { + global: + + rte_ring_reset; + +};To me, a static inline function does not need to be added in rte_ring_version.map (or is it due to a check script checking the
__rte_experimentaltag ?). I found at least one commit where it is not the case:c277b34c1b3b("mbuf: add function returning buffer address")There are 2 options:
1- remove the rte_ring_version.map part of the patch. 2- change the static inline function into a standard function.Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
I would prefer 2-, because it allows to keep an api/abi compat layer in the future.
There are no news about this patch.
I classify it as changes requested.Sorry for missed your comments for long time, I just submitted v8. I took the first option as it is in the data path and to keep consistent to
its
Quoted 5 lines
Quoted 5 lines
neighboring functions.
Could you give a little more context about why you need to reset the ring in the data path? I see that it is used in
rte_hash_reset(), but in my thinking, this was more used at init/exit.
Quoted 6 lines
Quoted 1 line
Sorry,literally it is in the control path, but I was impressed it will impact
the
Quoted 1 line
Data path performance when discussing this patch with Honnappa.
I'm asking this because given the recent discussions about ABI stability, I'd like to avoid defining a new static inline if it is not required.
Ok, will take 2nd option in V9, and squash the two patches into one, otherwise it reports the following error:
"error: ‘rte_ring_reset’ defined but not used [-Werror=unused-function]"
Best regards,
Gavin
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
<snip>
Quoted 61 lines
Quoted 61 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
29/03/2019 15:17, Olivier Matz:
Quoted 4 lines
Hi,
Quoted 1 line · Gavin Hu
Currently, the flush is done by dequeuing the ring in a while loop.
It is
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
much simpler to flush the queue by resetting the head and tail
indices.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Fixes af75078fece3 ("first public release")Signed-off-by Gavin Hu <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Reviewed-by Honnappa NagarahalliQuoted 28 lines
Quoted 28 lines
Quoted 28 lines
Quoted 28 lines
Quoted 27 lines
Quoted 4 lines
---
lib/librte_ring/rte_ring_version.map DPDK_2.2 { · line 26
Quoted 10 lines
lib/librte_ring/rte_ring_version.map +7
-0@@ -17,3 +17,10 @@ DPDK_2.2 { rte_ring_free; } DPDK_2.0; + +EXPERIMENTAL { + global: + + rte_ring_reset; + +};To me, a static inline function does not need to be added in rte_ring_version.map (or is it due to a check script checking the
__rte_experimentaltag ?). I found at least one commit where it is not the case:c277b34c1b3b("mbuf: add function returning buffer address")There are 2 options:
1- remove the rte_ring_version.map part of the patch. 2- change the static inline function into a standard function.I would prefer 2-, because it allows to keep an api/abi compat layer in the future.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
There are no news about this patch.
I classify it as changes requested.Sorry for missed your comments for long time, I just submitted v8. I took the first option as it is in the data path and to keep consistent to
its
Quoted 7 lines
Quoted 5 lines
neighboring functions.
Could you give a little more context about why you need to reset the ring in the data path? I see that it is used in
rte_hash_reset(), but in my thinking, this was more used at init/exit.Sorry,literally it is in the control path, but I was impressed it will impact
the
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Data path performance when discussing this patch with Honnappa.
I'm asking this because given the recent discussions about ABI stability, I'd like to avoid defining a new static inline if it is not required.
Ok, will take 2nd option in V9, and squash the two patches into one, otherwise it reports the following error:
"error: ‘rte_ring_reset’ defined but not used [-Werror=unused-function]"
Agree, it is a control path function, does not impact any data path performance. It should not be inline.
Quoted 3 lines
Best regards,
Gavin
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
Quoted 81 lines
-----Original Message-----
From: Honnappa Nagarahalli <[email protected]>
Sent: Friday, July 12, 2019 11:41 PM
To: Gavin Hu (Arm Technology China) <[email protected]>; Olivier Matz <[email protected]>
Cc: [email protected]; [email protected]; nd <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Ruifeng Wang (Arm Technology China) <[email protected]>; nd <[email protected]>
Subject: RE: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use<snip>
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
29/03/2019 15:17, Olivier Matz:
Quoted 4 lines
Hi,
Quoted 1 line · Gavin Hu
Currently, the flush is done by dequeuing the ring in a while
loop.
Quoted 60 lines
Quoted 59 lines
It is
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
much simpler to flush the queue by resetting the head and tail
indices.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Fixes af75078fece3 ("first public release")Signed-off-by Gavin Hu <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Reviewed-by Honnappa NagarahalliQuoted 28 lines
Quoted 28 lines
Quoted 28 lines
Quoted 28 lines
Quoted 27 lines
Quoted 4 lines
---
lib/librte_ring/rte_ring_version.map DPDK_2.2 { · line 26
Quoted 10 lines
lib/librte_ring/rte_ring_version.map +7
-0@@ -17,3 +17,10 @@ DPDK_2.2 { rte_ring_free; } DPDK_2.0; + +EXPERIMENTAL { + global: + + rte_ring_reset; + +};To me, a static inline function does not need to be added in rte_ring_version.map (or is it due to a check script checking the
__rte_experimentaltag ?). I found at least one commit where it is not the case:c277b34c1b3b("mbuf: add function returning buffer address")There are 2 options:
1- remove the rte_ring_version.map part of the patch. 2- change the static inline function into a standard function.I would prefer 2-, because it allows to keep an api/abi compat layer in the future.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
There are no news about this patch.
I classify it as changes requested.Sorry for missed your comments for long time, I just submitted v8. I took the first option as it is in the data path and to keep consistent to
its
Quoted 7 lines
Quoted 5 lines
neighboring functions.
Could you give a little more context about why you need to reset the ring in the data path? I see that it is used in
rte_hash_reset(), but in my thinking, this was more used at init/exit.Sorry,literally it is in the control path, but I was impressed it will impact
the
Quoted 1 line
Data path performance when discussing this patch with Honnappa.
I'm asking this because given the recent discussions about ABI stability, I'd like to avoid defining a new static inline if it is not required.
Quoted 6 lines
Quoted 1 line
Ok, will take 2nd option in V9, and squash the two patches into one,
otherwise
Quoted 2 lines
it reports the following error:
"error: ‘rte_ring_reset’ defined but not used [-Werror=unused-function]"Agree, it is a control path function, does not impact any data path performance. It should not be inline.
Thanks for your clarification, I submitted v9 for this.
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
In reply to Gavin HuQuoted 9 lines · Gavin Hu
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
Fixes af75078fece3 ("first public release")Signed-off-by Gavin Hu <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Reviewed-by Honnappa Nagarahalli <[email protected]>
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
Quoted 4 lines · Olivier Matz
Quoted 3 lines · Gavin Hu
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
Quoted 8 lines
Quoted 6 lines
Fixes af75078fece3 ("first public release")Signed-off-by Gavin Hu <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Reviewed-by Honnappa Nagarahalli <[email protected]>Acked-by Olivier Matz <[email protected]>
Sorry, I meant to ack the v9.
PATCH v7 2/2 hash: flush the rings instead of dequeuing one by one
In reply to Gavin HuWithin rte_hash_reset, calling a while loop to dequeue one by one from the ring, while not using them at all, is wasting cycles, The patch just flush the ring by resetting the indices can save cpu cycles.
--- lib/librte_hash/Makefile | 2 +- lib/librte_hash/meson.build | 3 +++ lib/librte_hash/rte_cuckoo_hash.c | 11 ++++------- 3 files changed, 8 insertions(+), 8 deletions(-)
lib/librte_hash/Makefile +1 -1
@@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk # library name LIB = librte_hash.a -CFLAGS += -O3 +CFLAGS += -O3 -DALLOW_EXPERIMENTAL_API CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) LDLIBS += -lrte_eal -lrte_ring
lib/librte_hash/meson.build +3 -0
@@ -14,3 +14,6 @@ headers = files('rte_cmp_arm64.h', sources = files('rte_cuckoo_hash.c', 'rte_fbk_hash.c') deps += ['ring'] + +# rte ring reset is not yet part of stable API +allow_experimental_apis = true
lib/librte_hash/rte_cuckoo_hash.c +4 -7
@@ -559,7 +559,6 @@ __hash_rw_reader_unlock(const struct rte_hash *h)void rte_hash_reset (struct rte_hash *h) { -void *ptr;uint32_t tot_ring_cnt, i;if (h ==NULL )
@@ -570,16 +569,14 @@ rte_hash_reset(struct rte_hash *h)memset (h->key_store,0 , h->key_entry_size * (h->entries +1 )); *h->tbl_chng_cnt =0 ; -/* clear the free ring */ -while (rte_ring_dequeue (h->free_slots, &ptr) ==0 ) -continue ; +/* reset the free ring */ +rte_ring_reset (h->free_slots); -/* clear free extendable bucket ring and memory */ +/* flush free extendable bucket ring and memory */ if (h->ext_table_support) {memset (h->buckets_ext,0 , h->num_buckets *sizeof (struct rte_hash_bucket )); -while (rte_ring_dequeue (h->free_ext_bkts, &ptr) ==0 ) -continue ; +rte_ring_reset (h->free_ext_bkts); }/* Repopulate the free slots ring. Entry zero is reserved for key misses */
Signature · 1 line
2.7.4
v8 cover new ring reset api and use it by hash
In reply to Gavin HuV2:
- fix the coding style issue(commit message line too long)
V3:
- allow experimental API for meson build
V4:
- include the ring perf test case enhancement patch in the series.
- replace ARRAY_SIZE with RTE_DIM.
- call memset to avoid clang compling complains.
V5:
- commit message tweaking for ring test case enhancement patch
- upper to lower for mails to make match/grep more easily
V6:
- make upper case for the user name to comply with the convention.
V7:
- leave the ring test case patch out as not closely linked to this series in logic
V8:
- change the static inline function into a standard function to keep an api/abi compat layer in the future
Gavin Hu (2):
ring: add reset API to flush the ring when not in use
hash: flush the rings instead of dequeuing one by one
lib/librte_hash/Makefile | 2 +- lib/librte_hash/meson.build | 3 +++ lib/librte_hash/rte_cuckoo_hash.c | 11 ++++------- lib/librte_ring/rte_ring.h | 21 +++++++++++++++++++++ 4 files changed, 29 insertions(+), 8 deletions(-)
Signature · 1 line
2.7.4
PATCH v8 1/2 ring: add reset API to flush the ring when not in use
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
--- lib/librte_ring/rte_ring.h | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
lib/librte_ring/rte_ring.h +21 -0
@@ -669,6 +669,27 @@ rte_ring_dequeue(struct rte_ring *r, void **obj_p) }/** +* Flush a ring. +* +* This function flush all the elements in a ring +* +* @b EXPERIMENTAL: this API may change without prior notice +* +* @warning +* Make sure the ring is not in use while calling this function. +* +* @param r +* A pointer to the ring structure. +*/ +__rte_experimental +static inline void +rte_ring_reset (struct rte_ring *r) +{ + r->prod.head = r->cons.head =0 ; + r->prod.tail = r->cons.tail =0 ; +} + +/** * Return the number of entries in a ring. * * @param r
Signature · 1 line
2.7.4
PATCH v8 2/2 hash: flush the rings instead of dequeuing one by one
In reply to Gavin HuWithin rte_hash_reset, calling a while loop to dequeue one by one from the ring, while not using them at all, is wasting cycles, The patch just flush the ring by resetting the indices can save cpu cycles.
--- lib/librte_hash/Makefile | 2 +- lib/librte_hash/meson.build | 3 +++ lib/librte_hash/rte_cuckoo_hash.c | 11 ++++------- 3 files changed, 8 insertions(+), 8 deletions(-)
lib/librte_hash/Makefile +1 -1
@@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk # library name LIB = librte_hash.a -CFLAGS += -O3 +CFLAGS += -O3 -DALLOW_EXPERIMENTAL_API CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) LDLIBS += -lrte_eal -lrte_ring
lib/librte_hash/meson.build +3 -0
@@ -14,3 +14,6 @@ headers = files('rte_cmp_arm64.h', sources = files('rte_cuckoo_hash.c', 'rte_fbk_hash.c') deps += ['ring'] + +# rte ring reset is not yet part of stable API +allow_experimental_apis = true
lib/librte_hash/rte_cuckoo_hash.c +4 -7
@@ -570,7 +570,6 @@ __hash_rw_reader_unlock(const struct rte_hash *h)void rte_hash_reset (struct rte_hash *h) { -void *ptr;uint32_t tot_ring_cnt, i;if (h ==NULL )
@@ -581,16 +580,14 @@ rte_hash_reset(struct rte_hash *h)memset (h->key_store,0 , h->key_entry_size * (h->entries +1 )); *h->tbl_chng_cnt =0 ; -/* clear the free ring */ -while (rte_ring_dequeue (h->free_slots, &ptr) ==0 ) -continue ; +/* reset the free ring */ +rte_ring_reset (h->free_slots); -/* clear free extendable bucket ring and memory */ +/* flush free extendable bucket ring and memory */ if (h->ext_table_support) {memset (h->buckets_ext,0 , h->num_buckets *sizeof (struct rte_hash_bucket )); -while (rte_ring_dequeue (h->free_ext_bkts, &ptr) ==0 ) -continue ; +rte_ring_reset (h->free_ext_bkts); }/* Repopulate the free slots ring. Entry zero is reserved for key misses */
Signature · 1 line
2.7.4
v9 cover new ring reset api and use it by hash
In reply to Gavin HuV2:
- fix the coding style issue(commit message line too long)
V3:
- allow experimental API for meson build
V4:
- include the ring perf test case enhancement patch in the series.
- replace ARRAY_SIZE with RTE_DIM.
- call memset to avoid clang compling complains.
V5:
- commit message tweaking for ring test case enhancement patch
- upper to lower for mails to make match/grep more easily
V6:
- make upper case for the user name to comply with the convention.
V7:
- leave the ring test case patch out as not closely linked to this series in logic
V8:
- the static inline function is removed from the rte_ring_version.map
V9:
- change the static inline function into a standard function to keep an api/abi compat layer in the future
- add back the change to the rte_ring_version.map file
Gavin Hu (2):
ring: add reset API to flush the ring when not in use
hash: flush the rings instead of dequeuing one by one
lib/librte_hash/Makefile | 2 +- lib/librte_hash/meson.build | 3 +++ lib/librte_hash/rte_cuckoo_hash.c | 11 ++++------- lib/librte_ring/rte_ring.c | 7 +++++++ lib/librte_ring/rte_ring.h | 17 +++++++++++++++++ lib/librte_ring/rte_ring_version.map | 7 +++++++ 6 files changed, 39 insertions(+), 8 deletions(-)
Signature · 1 line
2.7.4
PATCH v9 1/2 ring: add reset API to flush the ring when not in use
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
--- lib/librte_ring/rte_ring.c | 7 +++++++ lib/librte_ring/rte_ring.h | 17 +++++++++++++++++ lib/librte_ring/rte_ring_version.map | 7 +++++++ 3 files changed, 31 insertions(+)
lib/librte_ring/rte_ring.c +7 -0
@@ -63,6 +63,13 @@ rte_ring_get_memsize(unsigned count)return sz; } +void +rte_ring_reset (struct rte_ring *r) +{ + r->prod.head = r->cons.head =0 ; + r->prod.tail = r->cons.tail =0 ; +} +int rte_ring_init (struct rte_ring *r,const char *name,unsigned count,unsigned flags)
lib/librte_ring/rte_ring.h +17 -0
@@ -669,6 +669,23 @@ rte_ring_dequeue(struct rte_ring *r, void **obj_p) }/** +* Flush a ring. +* +* This function flush all the elements in a ring +* +* @b EXPERIMENTAL: this API may change without prior notice +* +* @warning +* Make sure the ring is not in use while calling this function. +* +* @param r +* A pointer to the ring structure. +*/ +__rte_experimental +void +rte_ring_reset (struct rte_ring *r); + +/** * Return the number of entries in a ring. * * @param r
lib/librte_ring/rte_ring_version.map +7 -0
@@ -17,3 +17,10 @@ DPDK_2.2 { rte_ring_free; } DPDK_2.0; + +EXPERIMENTAL { + global: + + rte_ring_reset; + +};
Signature · 1 line
2.7.4
Re: [dpdk-dev] [PATCH v9 1/2] ring: add reset API to flush the ring when not in use
Quoted 9 lines · Gavin Hu
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
Fixes af75078fece3 ("first public release")Signed-off-by Gavin Hu <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Reviewed-by Honnappa Nagarahalli <[email protected]>
Re: [dpdk-dev] [PATCH v9 1/2] ring: add reset API to flush the ring when not in use
Quoted 6 lines · Olivier Matz
Quoted 5 lines · Gavin Hu
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
Fixes af75078fece3 ("first public release")
Actually it's not a fix, it adds a new API.
Is the patch in hash library intended to be backported? If yes, as it seems to be a performance optimization, you'll need to describe what scenario you're fixing and what is the performance gain. If no, the Cc stable can be removed.
Thanks
Quoted 6 lines
Quoted 4 lines
Signed-off-by Gavin Hu <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Reviewed-by Honnappa Nagarahalli <[email protected]>Acked-by Olivier Matz <[email protected]>
Re: [dpdk-dev] [PATCH v9 1/2] ring: add reset API to flush the ring when not in use
Hi Olivier, Thomas,
Quoted 19 lines
-----Original Message-----
From: Olivier Matz <[email protected]>
Sent: Tuesday, July 16, 2019 6:32 AM
To: Gavin Hu (Arm Technology China) <[email protected]>
Cc: [email protected]; nd <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; [email protected]; [email protected]
Subject: Re: [PATCH v9 1/2] ring: add reset API to flush the ring when not in useQuoted 6 lines · Olivier Matz
Quoted 5 lines · Gavin Hu
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
Fixes af75078fece3 ("first public release")
Quoted 6 lines
Actually it's not a fix, it adds a new API.
Is the patch in hash library intended to be backported? If yes, as it seems to be a performance optimization, you'll need to describe what scenario you're fixing and what is the performance gain. If no, the Cc stable can be removed.
As this is not in the data plan, I don't intend to backport. Do I need to submit a new version to remove the CC: lines?
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Signed-off-by Gavin Hu <[email protected]>Reviewed-by Ruifeng Wang <[email protected]>Reviewed-by Honnappa Nagarahalli <[email protected]>Acked-by Olivier Matz <[email protected]>
Re: [dpdk-dev] [PATCH v9 1/2] ring: add reset API to flush the ring when not in use
16/07/2019 16:03, Gavin Hu (Arm Technology China):
Quoted 11 lines
From: Olivier Matz <[email protected]>
Quoted 10 lines · Olivier Matz
Quoted 6 lines · Gavin Hu
Quoted 5 lines
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
Fixes af75078fece3 ("first public release")Actually it's not a fix, it adds a new API.
Quoted 7 lines
Quoted 4 lines
Is the patch in hash library intended to be backported? If yes, as it seems to be a performance optimization, you'll need to describe what scenario you're fixing and what is the performance gain. If no, the Cc stable can be removed.
As this is not in the data plan, I don't intend to backport. Do I need to submit a new version to remove the CC: lines?
Yes please.
You can also remove the "fixes" line in the first patch.
Re: [dpdk-dev] [PATCH v9 1/2] ring: add reset API to flush the ring when not in use
Hi Thomas,
Quoted 30 lines
-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Tuesday, July 16, 2019 10:07 AM
To: Gavin Hu (Arm Technology China) <[email protected]>
Cc: Olivier Matz <[email protected]>; [email protected]; nd <[email protected]>; [email protected]; [email protected]; [email protected]; Honnappa Nagarahalli <[email protected]>; [email protected]; [email protected]
Subject: Re: [PATCH v9 1/2] ring: add reset API to flush the ring when not in use16/07/2019 16:03, Gavin Hu (Arm Technology China):
Quoted 5 lines
From: Olivier Matz <[email protected]>
Quoted 4 lines · Olivier Matz
Quoted 3 lines · Gavin Hu
Quoted 2 lines
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail
indices.
Quoted 11 lines
Quoted 10 lines
Quoted 3 lines
Quoted 3 lines
Fixes af75078fece3 ("first public release")Actually it's not a fix, it adds a new API.
Is the patch in hash library intended to be backported? If yes, as it seems to be a performance optimization, you'll need to describe what scenario you're fixing and what is the performance gain. If no, the Cc stable can be removed.
Quoted 5 lines
Quoted 2 lines
As this is not in the data plan, I don't intend to backport. Do I need to submit a new version to remove the CC: lines?
Yes please.
You can also remove the "fixes" line in the first patch.
Sure, just sent out V10, thanks!
PATCH v9 2/2 hash: flush the rings instead of dequeuing one by one
In reply to Gavin HuWithin rte_hash_reset, calling a while loop to dequeue one by one from the ring, while not using them at all, is wasting cycles, The patch just flush the ring by resetting the indices can save cpu cycles.
--- lib/librte_hash/Makefile | 2 +- lib/librte_hash/meson.build | 3 +++ lib/librte_hash/rte_cuckoo_hash.c | 11 ++++------- 3 files changed, 8 insertions(+), 8 deletions(-)
lib/librte_hash/Makefile +1 -1
@@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk # library name LIB = librte_hash.a -CFLAGS += -O3 +CFLAGS += -O3 -DALLOW_EXPERIMENTAL_API CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) LDLIBS += -lrte_eal -lrte_ring
lib/librte_hash/meson.build +3 -0
@@ -14,3 +14,6 @@ headers = files('rte_cmp_arm64.h', sources = files('rte_cuckoo_hash.c', 'rte_fbk_hash.c') deps += ['ring'] + +# rte ring reset is not yet part of stable API +allow_experimental_apis = true
lib/librte_hash/rte_cuckoo_hash.c +4 -7
@@ -570,7 +570,6 @@ __hash_rw_reader_unlock(const struct rte_hash *h)void rte_hash_reset (struct rte_hash *h) { -void *ptr;uint32_t tot_ring_cnt, i;if (h ==NULL )
@@ -581,16 +580,14 @@ rte_hash_reset(struct rte_hash *h)memset (h->key_store,0 , h->key_entry_size * (h->entries +1 )); *h->tbl_chng_cnt =0 ; -/* clear the free ring */ -while (rte_ring_dequeue (h->free_slots, &ptr) ==0 ) -continue ; +/* reset the free ring */ +rte_ring_reset (h->free_slots); -/* clear free extendable bucket ring and memory */ +/* flush free extendable bucket ring and memory */ if (h->ext_table_support) {memset (h->buckets_ext,0 , h->num_buckets *sizeof (struct rte_hash_bucket )); -while (rte_ring_dequeue (h->free_ext_bkts, &ptr) ==0 ) -continue ; +rte_ring_reset (h->free_ext_bkts); }/* Repopulate the free slots ring. Entry zero is reserved for key misses */
Signature · 1 line
2.7.4
v10 cover new ring reset api and use it by hash
In reply to Gavin HuV2:
- fix the coding style issue(commit message line too long)
V3:
- allow experimental API for meson build
V4:
- include the ring perf test case enhancement patch in the series.
- replace ARRAY_SIZE with RTE_DIM.
- call memset to avoid clang compling complains.
V5:
- commit message tweaking for ring test case enhancement patch
- upper to lower for mails to make match/grep more easily
V6:
- make upper case for the user name to comply with the convention.
V7:
- leave the ring test case patch out as not closely linked to this series in logic
V8:
- the static inline function is removed from the rte_ring_version.map
V9:
- change the static inline function into a standard function to keep an api/abi compat layer in the future
- add back the change to the rte_ring_version.map file
V10:
- remove the CC: lines as not in the data plane.
Gavin Hu (2):
ring: add reset API to flush the ring when not in use
hash: flush the rings instead of dequeuing one by one
lib/librte_hash/Makefile | 2 +- lib/librte_hash/meson.build | 3 +++ lib/librte_hash/rte_cuckoo_hash.c | 11 ++++------- lib/librte_ring/rte_ring.c | 7 +++++++ lib/librte_ring/rte_ring.h | 17 +++++++++++++++++ lib/librte_ring/rte_ring_version.map | 7 +++++++ 6 files changed, 39 insertions(+), 8 deletions(-)
Signature · 1 line
2.7.4
PATCH v10 1/2 ring: add reset API to flush the ring when not in use
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices.
--- lib/librte_ring/rte_ring.c | 7 +++++++ lib/librte_ring/rte_ring.h | 17 +++++++++++++++++ lib/librte_ring/rte_ring_version.map | 7 +++++++ 3 files changed, 31 insertions(+)
lib/librte_ring/rte_ring.c +7 -0
@@ -63,6 +63,13 @@ rte_ring_get_memsize(unsigned count)return sz; } +void +rte_ring_reset (struct rte_ring *r) +{ + r->prod.head = r->cons.head =0 ; + r->prod.tail = r->cons.tail =0 ; +} +int rte_ring_init (struct rte_ring *r,const char *name,unsigned count,unsigned flags)
lib/librte_ring/rte_ring.h +17 -0
@@ -669,6 +669,23 @@ rte_ring_dequeue(struct rte_ring *r, void **obj_p) }/** +* Flush a ring. +* +* This function flush all the elements in a ring +* +* @b EXPERIMENTAL: this API may change without prior notice +* +* @warning +* Make sure the ring is not in use while calling this function. +* +* @param r +* A pointer to the ring structure. +*/ +__rte_experimental +void +rte_ring_reset (struct rte_ring *r); + +/** * Return the number of entries in a ring. * * @param r
lib/librte_ring/rte_ring_version.map +7 -0
@@ -17,3 +17,10 @@ DPDK_2.2 { rte_ring_free; } DPDK_2.0; + +EXPERIMENTAL { + global: + + rte_ring_reset; + +};
Signature · 1 line
2.7.4
PATCH v10 2/2 hash: flush the rings instead of dequeuing one by one
In reply to Gavin HuWithin rte_hash_reset, calling a while loop to dequeue one by one from the ring, while not using them at all, is wasting cycles, The patch just flush the ring by resetting the indices can save cpu cycles.
--- lib/librte_hash/Makefile | 2 +- lib/librte_hash/meson.build | 3 +++ lib/librte_hash/rte_cuckoo_hash.c | 11 ++++------- 3 files changed, 8 insertions(+), 8 deletions(-)
lib/librte_hash/Makefile +1 -1
@@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk # library name LIB = librte_hash.a -CFLAGS += -O3 +CFLAGS += -O3 -DALLOW_EXPERIMENTAL_API CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) LDLIBS += -lrte_eal -lrte_ring
lib/librte_hash/meson.build +3 -0
@@ -14,3 +14,6 @@ headers = files('rte_cmp_arm64.h', sources = files('rte_cuckoo_hash.c', 'rte_fbk_hash.c') deps += ['ring'] + +# rte ring reset is not yet part of stable API +allow_experimental_apis = true
lib/librte_hash/rte_cuckoo_hash.c +4 -7
@@ -570,7 +570,6 @@ __hash_rw_reader_unlock(const struct rte_hash *h)void rte_hash_reset (struct rte_hash *h) { -void *ptr;uint32_t tot_ring_cnt, i;if (h ==NULL )
@@ -581,16 +580,14 @@ rte_hash_reset(struct rte_hash *h)memset (h->key_store,0 , h->key_entry_size * (h->entries +1 )); *h->tbl_chng_cnt =0 ; -/* clear the free ring */ -while (rte_ring_dequeue (h->free_slots, &ptr) ==0 ) -continue ; +/* reset the free ring */ +rte_ring_reset (h->free_slots); -/* clear free extendable bucket ring and memory */ +/* flush free extendable bucket ring and memory */ if (h->ext_table_support) {memset (h->buckets_ext,0 , h->num_buckets *sizeof (struct rte_hash_bucket )); -while (rte_ring_dequeue (h->free_ext_bkts, &ptr) ==0 ) -continue ; +rte_ring_reset (h->free_ext_bkts); }/* Repopulate the free slots ring. Entry zero is reserved for key misses */
Signature · 1 line
2.7.4
Thomas Monjalon
AppliedRe: [dpdk-dev] [PATCH v10 0/2] new ring reset api and use it by hash
In reply to Gavin HuQuoted 3 lines
Gavin Hu (2):
ring: add reset API to flush the ring when not in use
hash: flush the rings instead of dequeuing one by one
Applied, thanks