io_uring: replace zero-length array with flexible-array member
PATCH 1/1 io_uring: replace zero-length array with flexible-array member
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
--- include/uapi/linux/io_uring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/io_uring.h +1 -1
@@ -492,7 +492,7 @@ struct io_uring_probe {__u8 ops_len;/* length of ops[] array below */ __u16 resv;__u32 resv2[3 ]; -struct io_uring_probe_op ops[0 ]; +struct io_uring_probe_op ops[]; };struct io_uring_restriction {
Signature · 1 line
2.27.0
Jens Axboe
maintainerQuoted 8 lines · Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use ?flexible array members?[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
Thanks for sending this separately. As mentioned out-of-band, we already have it like this in the io_uring.h header in liburing.
Applied for 5.20.
Signature · 1 line
Jens Axboe
Quoted 4 lines · Jens Axboe
Thanks for sending this separately. As mentioned out-of-band, we already have it like this in the
io_uring.hheader in liburing.Applied for 5.20.
Great! :)
Thanks, Jens.
--
Gustavo