Skip to contentSkip to conversation

w1: Use kfree_sensitive() to clear memory safely

PATCH In review unassigned 2 participants 2 messages Jul 19 W1 dallas's 1-wire bus

lore
Share & tools
lore

unassigned

author
#0 lore raw

PATCH 2/2 w1: Use kfree_sensitive() to clear memory safely

---
 drivers/w1/w1.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/w1/w1.c +2 -6
index 486f321eadc8..5afc7d6cb6cf 100644
@@ -68,8 +68,7 @@ static void w1_master_release(struct device *dev)
 	struct w1_master *md = dev_to_w1_master(dev);
 
 	dev_dbg(dev, "%s: Releasing %s.\n", __func__, md->name);
-	memset(md, 0, sizeof(struct w1_master) + sizeof(struct w1_bus_master));
-	kfree(md);
+	kfree_sensitive(md);
 }
 
 static void w1_slave_release(struct device *dev)
@@ -793,10 +792,7 @@ int w1_unref_slave(struct w1_slave *sl)
 
 		w1_family_notify(BUS_NOTIFY_DEL_DEVICE, sl);
 		device_unregister(&sl->dev);
-		#ifdef DEBUG
-		memset(sl, 0, sizeof(*sl));
-		#endif
-		kfree(sl);
+		kfree_sensitive(sl);
 	}
 	atomic_dec(&dev->refcnt);
 	mutex_unlock(&dev->list_mutex);
Signature · 1 line
2.47.3
#1 lore raw
Quoted 2 lines · unassigned
---
 drivers/w1/w1.c | 8 ++------

Please follow submitting patches document.

Best regards,
Krzysztof