Skip to contentSkip to conversation

dm-integrity: fix double free on memory allocation failure

PATCH New Mikulas Patocka 1 participant 1 message Jul 3, 2023 Device mapper

lore
Share & tools
lore

Mikulas Patocka

author maintainer
#0 lore raw

PATCH 1/1 dm-integrity: fix double free on memory allocation failure

Hi

I found a bug in one of the patches that I submitted. Here I'm submitting the fix. Please send it to Linus before 6.5 is released.

Mikulas

From: Mikulas Patocka <[email protected]>

If the statement "recalc_tags = kvmalloc(recalc_tags_size, GFP_NOIO);" fails, we call "vfree(recalc_buffer)" and we jump to the label "oom".

If the condition "recalc_sectors >= 1U << ic->sb->log2_sectors_per_block" is false, we jump to the label "free_ret" and call "vfree(recalc_buffer)" again, on an already released memory block.

This commit fixes the bug by setting "recalc_buffer = NULL" after freeing it.

Fixes da8b4fc1f63a ("dm integrity: only allocate recalculate buffer when needed")
---
 drivers/md/dm-integrity.c |    1 +
 1 file changed, 1 insertion(+)
drivers/md/dm-integrity.c +1 -0
Index: linux-2.6/drivers/md/dm-integrity.c
===================================================================
@@ -2691,6 +2691,7 @@ oom:
 	recalc_tags = kvmalloc(recalc_tags_size, GFP_NOIO);
 	if (!recalc_tags) {
 		vfree(recalc_buffer);
+		recalc_buffer = NULL;
 		goto oom;
 	}
 

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel