Skip to contentSkip to conversation

USB Gadget Vendor ID

DISCUSSION Adriana Kobylak 2 participants 4 messages Apr 12, 2019

lore
Share & tools
lore
#0 lore raw

Hi Eddie,

I have a script to initialize the USB gadget for Virtual Media and there was a comment that the Vendor ID should be provided by the Linux Foundation - https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/17494 .

In your ikvm script you use a Vendor ID with the comment "Linux Foundation" - https://github.com/openbmc/obmc-ikvm/blob/fb6a8e1e727a8ece5eb0350d3962dd3056a6f608/create_usbhid.sh#L18

Is this an ID that came from the LF, and if so could I use it in my script?

As a side question, were there any discussions about the serial number value in the ikvm script? I have a similar hard-coded value for the virtual media one but there were questions in the review about how useful could it be having a non-generated value and to have it removed instead.

#1 lore raw
Quoted 7 lines · Adriana Kobylak

Hi Eddie,

I have a script to initialize the USB gadget for Virtual Media and there was a comment that the Vendor ID should be provided by the Linux Foundation - https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/17494 .

In your ikvm script you use a Vendor ID with the comment "Linux Foundation" - https://github.com/openbmc/obmc-ikvm/blob/fb6a8e1e727a8ece5eb0350d3962dd3056a6f608/create_usbhid.sh#L18

Is this an ID that came from the LF, and if so could I use it in my script?

Hi,

Since OpenBMC is a LF project, I just used their vendor ID... and I just invented a serial number. This might not be the proper way to do it... Since the devices are virtual, I'm not sure anyone will care though?

Quoted 2 lines

As a side question, were there any discussions about the serial number value in the ikvm script? I have a similar hard-coded value for the virtual media one but there were questions in the review about how useful could it be having a non-generated value and to have it removed instead.

I think there were similar comments about the serial number but in the end it was decided to worry about it later I think.

Thanks, Eddie

#2 lore raw
Quoted 10 lines · Eddie James
Quoted 7 lines · Adriana Kobylak

Hi Eddie,

I have a script to initialize the USB gadget for Virtual Media and there was a comment that the Vendor ID should be provided by the Linux Foundation - https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/17494 .

In your ikvm script you use a Vendor ID with the comment "Linux Foundation" - https://github.com/openbmc/obmc-ikvm/blob/fb6a8e1e727a8ece5eb0350d3962dd3056a6f608/create_usbhid.sh#L18

Is this an ID that came from the LF, and if so could I use it in my script?

Quoted 8 lines

Hi,

Since OpenBMC is a LF project, I just used their vendor ID... and I just invented a serial number. This might not be the proper way to do it... Since the devices are virtual, I'm not sure anyone will care though?

Thanks that helps. Forgot to ask about the the product id (echo 0x0104 > idProduct # Multifunction Composite Gadget), is it also a LF number or documented somewhere?

Quoted 8 lines
Quoted 2 lines

As a side question, were there any discussions about the serial number value in the ikvm script? I have a similar hard-coded value for the virtual media one but there were questions in the review about how useful could it be having a non-generated value and to have it removed instead.

I think there were similar comments about the serial number but in the end it was decided to worry about it later I think.

Thanks, Eddie

#3 lore raw
Quoted 19 lines · Adriana Kobylak
Quoted 10 lines · Eddie James
Quoted 7 lines · Adriana Kobylak

Hi Eddie,

I have a script to initialize the USB gadget for Virtual Media and there was a comment that the Vendor ID should be provided by the Linux Foundation - https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/17494 .

In your ikvm script you use a Vendor ID with the comment "Linux Foundation" - https://github.com/openbmc/obmc-ikvm/blob/fb6a8e1e727a8ece5eb0350d3962dd3056a6f608/create_usbhid.sh#L18

Is this an ID that came from the LF, and if so could I use it in my script?

Quoted 8 lines

Hi,

Since OpenBMC is a LF project, I just used their vendor ID... and I just invented a serial number. This might not be the proper way to do it... Since the devices are virtual, I'm not sure anyone will care though?

Quoted 3 lines

Thanks that helps. Forgot to ask about the the product id (echo 0x0104

Quoted 1 line

idProduct # Multifunction Composite Gadget), is it also a LF number

or documented somewhere?

Yes, here's the list I was using: http://www.linux-usb.org/usb.ids

Quoted 10 lines
Quoted 9 lines
Quoted 3 lines

As a side question, were there any discussions about the serial number value in the ikvm script? I have a similar hard-coded value for the virtual media one but there were questions in the review about how useful could it be having a non-generated value and to have it removed instead.

I think there were similar comments about the serial number but in the end it was decided to worry about it later I think.

Thanks, Eddie