Skip to contentSkip to conversation

platform: generic: allwinner: avoid buffer overrun

PATCH New Heinrich Schuchardt 5 participants 19 messages Dec 27, 2022 – Jan 13, 2023 Arm/Allwinner sunXi SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

plic_priority_save() and plic_priority_restore() access indexes 1 to num of the passed array. Avoid a buffer overrun by increasing the used array size by one.

Addresses-Coverity-ID: 1530251 ("Out-of-bounds access")
Addresses-Coverity-ID: 1530252 ("Out-of-bounds access")

Fixes 8509e46ca63a ("lib: utils/irqchip: plic: Ensure no out-of-bound access in priority save/restore helpers")
---
 platform/generic/allwinner/sun20i-d1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
platform/generic/allwinner/sun20i-d1.c +1 -1
index 1da9e5b..9891ad0 100644
@@ -72,7 +72,7 @@ static void sun20i_d1_csr_restore(void)
 #define PLIC_SOURCES			176
 #define PLIC_IE_WORDS			((PLIC_SOURCES + 31) / 32)
 
-static u8 plic_priority[PLIC_SOURCES];
+static u8 plic_priority[PLIC_SOURCES + 1];
 static u32 plic_sie[PLIC_IE_WORDS];
 static u32 plic_threshold;
 
Signature · 1 line
2.37.2
#1 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 7 lines · Heinrich Schuchardt

plic_priority_save() and plic_priority_restore() access indexes 1 to num of the passed array. Avoid a buffer overrun by increasing the used array size by one.

Addresses-Coverity-ID: 1530251 ("Out-of-bounds access")
Addresses-Coverity-ID: 1530252 ("Out-of-bounds access")

Where is the Coverity for OpenSBI project hosted?

Quoted 11 lines
Fixes 8509e46ca63a ("lib: utils/irqchip: plic: Ensure no out-of-bound access in priority save/restore helpers")
---
 platform/generic/allwinner/sun20i-d1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
platform/generic/allwinner/sun20i-d1.c +0 -0
index 1da9e5b..9891ad0 100644

platform/generic/allwinner/sun20i-d1.c static void sun20i_d1_csr_restore(void) · line 75

Quoted 5 lines
platform/generic/allwinner/sun20i-d1.c +1 -1
@@ -72,7 +72,7 @@ static void sun20i_d1_csr_restore(void)
 #define PLIC_SOURCES                   176
 #define PLIC_IE_WORDS                  ((PLIC_SOURCES + 31) / 32)
 
-static u8 plic_priority[PLIC_SOURCES];
+static u8 plic_priority[PLIC_SOURCES + 1];

This change could fix the Coverity, but IMHO we should not change this value. PLIC_SOURCES should be 176.

You probably are using a buggy DTB that contains a wrong "riscv,ndev", which I pointed out in the linux-riscv ML.

platform/generic/allwinner/sun20i-d1.c static void sun20i_d1_csr_restore(void) · line 78

Quoted 3 lines
platform/generic/allwinner/sun20i-d1.c +0 -0
 static u32 plic_sie[PLIC_IE_WORDS];
 static u32 plic_threshold;
 

My original patch [1] contains a size check against "riscv,ndev" in the DTB. But somehow that size check got dropped when the patch was applied.

[1] https://patchwork.ozlabs.org/project/opensbi/patch/20221211065424.806478-2-bmeng at tinylab.org/

Regards,
Bin

#2 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 11 lines · Bin Meng
Quoted 7 lines · Heinrich Schuchardt

plic_priority_save() and plic_priority_restore() access indexes 1 to num of the passed array. Avoid a buffer overrun by increasing the used array size by one.

Addresses-Coverity-ID: 1530251 ("Out-of-bounds access")
Addresses-Coverity-ID: 1530252 ("Out-of-bounds access")

Where is the Coverity for OpenSBI project hosted?

https://scan.coverity.com

Quoted 15 lines
Quoted 15 lines
Fixes 8509e46ca63a ("lib: utils/irqchip: plic: Ensure no out-of-bound access in priority save/restore helpers")
---
  platform/generic/allwinner/sun20i-d1.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
platform/generic/allwinner/sun20i-d1.c +0 -0
index 1da9e5b..9891ad0 100644
@@ -72,7 +72,7 @@ static void sun20i_d1_csr_restore(void)
  #define PLIC_SOURCES                   176
  #define PLIC_IE_WORDS                  ((PLIC_SOURCES + 31) / 32)
 
Quoted 8 lines

platform/generic/allwinner/sun20i-d1.c static void sun20i_d1_csr_restore(void) · line 75

Quoted 2 lines
platform/generic/allwinner/sun20i-d1.c +1 -1
-static u8 plic_priority[PLIC_SOURCES];
+static u8 plic_priority[PLIC_SOURCES + 1];

This change could fix the Coverity, but IMHO we should not change this value. PLIC_SOURCES should be 176.

You probably are using a buggy DTB that contains a wrong "riscv,ndev", which I pointed out in the linux-riscv ML.

The problem does not depend on any device-tree. PLIC_SOURCES is a constant that your code uses in

platform/generic/allwinner/sun20i-d1.c:82:
fdt_plic_priority_save(plic_priority, PLIC_SOURCES); platform/generic/allwinner/sun20i-d1.c:88:
fdt_plic_priority_restore(plic_priority, PLIC_SOURCES);

I wonder why plic_priority_save() and plic_priority_restore() start indexing at 1 and not at 0. This might deserve a code comment.

Quoted 10 lines

platform/generic/allwinner/sun20i-d1.c static void sun20i_d1_csr_restore(void) · line 78

Quoted 4 lines
platform/generic/allwinner/sun20i-d1.c +0 -0
  static u32 plic_sie[PLIC_IE_WORDS];
  static u32 plic_threshold;
 

My original patch [1] contains a size check against "riscv,ndev" in the DTB. But somehow that size check got dropped when the patch was applied.

[1] https://patchwork.ozlabs.org/project/opensbi/patch/20221211065424.806478-2-bmeng at tinylab.org/

"riscv,ndev" isn't used anywhere in your patch. Just the constant PLIC_SOURCES.

Best regards

Heinrich

Quoted 3 lines

Regards,
Bin

#3 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 45 lines · Heinrich Schuchardt
Quoted 11 lines · Bin Meng
Quoted 7 lines · Heinrich Schuchardt

plic_priority_save() and plic_priority_restore() access indexes 1 to num of the passed array. Avoid a buffer overrun by increasing the used array size by one.

Addresses-Coverity-ID: 1530251 ("Out-of-bounds access")
Addresses-Coverity-ID: 1530252 ("Out-of-bounds access")

Where is the Coverity for OpenSBI project hosted?

https://scan.coverity.com

Quoted 15 lines
Quoted 15 lines
Fixes 8509e46ca63a ("lib: utils/irqchip: plic: Ensure no out-of-bound access in priority save/restore helpers")
---
  platform/generic/allwinner/sun20i-d1.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
platform/generic/allwinner/sun20i-d1.c +0 -0
index 1da9e5b..9891ad0 100644
@@ -72,7 +72,7 @@ static void sun20i_d1_csr_restore(void)
  #define PLIC_SOURCES                   176
  #define PLIC_IE_WORDS                  ((PLIC_SOURCES + 31) / 32)
 
Quoted 8 lines

platform/generic/allwinner/sun20i-d1.c static void sun20i_d1_csr_restore(void) · line 75

Quoted 2 lines
platform/generic/allwinner/sun20i-d1.c +1 -1
-static u8 plic_priority[PLIC_SOURCES];
+static u8 plic_priority[PLIC_SOURCES + 1];

This change could fix the Coverity, but IMHO we should not change this value. PLIC_SOURCES should be 176.

You probably are using a buggy DTB that contains a wrong "riscv,ndev", which I pointed out in the linux-riscv ML.

The problem does not depend on any device-tree. PLIC_SOURCES is a constant that your code uses in

Quoted 7 lines

platform/generic/allwinner/sun20i-d1.c:82:
fdt_plic_priority_save(plic_priority, PLIC_SOURCES); platform/generic/allwinner/sun20i-d1.c:88:
fdt_plic_priority_restore(plic_priority, PLIC_SOURCES);

I wonder why plic_priority_save() and plic_priority_restore() start indexing at 1 and not at 0. This might deserve a code comment.

Please see the link I provided. In my original patch with the size check, this Coverity issue won't happen.

Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
platform/generic/allwinner/sun20i-d1.c +0 -0
  static u32 plic_sie[PLIC_IE_WORDS];
  static u32 plic_threshold;
 
Quoted 9 lines
Quoted 5 lines

My original patch [1] contains a size check against "riscv,ndev" in the DTB. But somehow that size check got dropped when the patch was applied.

[1] https://patchwork.ozlabs.org/project/opensbi/patch/20221211065424.806478-2-bmeng at tinylab.org/

"riscv,ndev" isn't used anywhere in your patch. Just the constant PLIC_SOURCES.

Changing the array size to PLIC_SOURCES + 1 does not make sense. The PLIC_SOURCES should be 176 which is correct as it includes source 0 on the Allwinner SoC. The "riscv,ndev" [1] should not be 176 otherwise it will create a buffer overrun.

[1] https://lore.kernel.org/linux-riscv/20221128133421.58614-1-bmeng at tinylab.org/

Regards,
Bin

#4 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 4 lines · Bin Meng

Changing the array size to PLIC_SOURCES + 1 does not make sense. The PLIC_SOURCES should be 176 which is correct as it includes source 0 on the Allwinner SoC. The "riscv,ndev" [1] should not be 176 otherwise it will create a buffer overrun.

The range check will always allow that overrrun.

Signature · 3 lines
Andreas Schwab, schwab at linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."
#5 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 10 lines · Andreas Schwab
Quoted 4 lines · Bin Meng

Changing the array size to PLIC_SOURCES + 1 does not make sense. The PLIC_SOURCES should be 176 which is correct as it includes source 0 on the Allwinner SoC. The "riscv,ndev" [1] should not be 176 otherwise it will create a buffer overrun.

The range check will always allow that overrrun.

Well, with a correct dtb it doesn't.

Strictly speaking, your proposed fix allows that overrun too, if the given num is an arbitrary larger value than the size of the priority array.

Regards,
Bin

#6 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 9 lines · Bin Meng
Quoted 8 lines · Andreas Schwab
Quoted 4 lines · Bin Meng

Changing the array size to PLIC_SOURCES + 1 does not make sense. The PLIC_SOURCES should be 176 which is correct as it includes source 0 on the Allwinner SoC. The "riscv,ndev" [1] should not be 176 otherwise it will create a buffer overrun.

Quoted 4 lines
Quoted 2 lines

The range check will always allow that overrrun.

Well, with a correct dtb it doesn't.

You cannot argue with the dtb, since this is externally controlled.

Quoted 1 line

Strictly speaking, your proposed fix allows that overrun too

How?

Signature · 3 lines
Andreas Schwab, schwab at linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."
#7 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 15 lines · Andreas Schwab
Quoted 12 lines · Bin Meng
Quoted 10 lines · Andreas Schwab
Quoted 4 lines · Bin Meng

Changing the array size to PLIC_SOURCES + 1 does not make sense. The PLIC_SOURCES should be 176 which is correct as it includes source 0 on the Allwinner SoC. The "riscv,ndev" [1] should not be 176 otherwise it will create a buffer overrun.

The range check will always allow that overrrun.

Quoted 8 lines
Quoted 1 line

Well, with a correct dtb it doesn't.

You cannot argue with the dtb, since this is externally controlled.

Quoted 1 line

Strictly speaking, your proposed fix allows that overrun too

How?

Passing num = 200 to plic_priority_save/restore.

You can argue my example is a misuse of the API, but I can argue a wrong dtb should not be in the first place too.

Regards,
Bin

#8 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 3 lines · Bin Meng

Passing num = 200 to plic_priority_save/restore.

You can argue my example is a misuse of the API,

It is a bug just like the bug in plic_priority_save/restore.

Quoted 1 line

but I can argue a wrong dtb should not be in the first place too.

The dtb is an external resource.

Signature · 3 lines
Andreas Schwab, schwab at linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."
maintainer
#9 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

In reply to Bin Meng
Quoted 9 lines · Bin Meng
Quoted 8 lines · Andreas Schwab
Quoted 4 lines · Bin Meng

Changing the array size to PLIC_SOURCES + 1 does not make sense. The PLIC_SOURCES should be 176 which is correct as it includes source 0 on the Allwinner SoC. The "riscv,ndev" [1] should not be 176 otherwise it will create a buffer overrun.

Quoted 4 lines
Quoted 2 lines

The range check will always allow that overrrun.

Well, with a correct dtb it doesn't.

No, the bug has nothing at all to do with the DTB. The bug is purely in the C code.

Quoted 3 lines

Strictly speaking, your proposed fix allows that overrun too, if the given num is an arbitrary larger value than the size of the priority array.

This is already what you are doing! You have:

	static u8 plic_priority[PLIC_SOURCES];

and

	fdt_plic_priority_save(plic_priority, PLIC_SOURCES);

The combination of those two lines is necessarily incorrect. Because you dereference priority[num], the number of elements in the array *must* be greater than num.

Since the range of external interrupt sources is [1, 175], the definitions need to be:

#define PLIC_SOURCES 175
#define PLIC_IE_WORDS ((PLIC_SOURCES / 32) + 1)

static u8 plic_priority[1 + PLIC_SOURCES];

Anything else is either wrong or wasting space.

Regards,
Samuel

#10 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 1 line · Samuel Holland

Anything else is either wrong or wasting space.

Not wasting space:

lib/utils/irqchip/plic.c +2 -2
index d633514..901ffaa 100644
@@ -39,14 +39,14 @@ static void plic_set_priority(const struct plic_data *plic, u32 source, u32 val)
 void plic_priority_save(const struct plic_data *plic, u8 *priority, u32 num)
 {
 	for (u32 i = 1; i <= num; i++)
-		priority[i] = plic_get_priority(plic, i);
+		priority[i - 1] = plic_get_priority(plic, i);
 }
 
 void plic_priority_restore(const struct plic_data *plic, const u8 *priority,
 			   u32 num)
 {
 	for (u32 i = 1; i <= num; i++)
-		plic_set_priority(plic, i, priority[i]);
+		plic_set_priority(plic, i, priority[i - 1]);
 }
 
 static u32 plic_get_thresh(const struct plic_data *plic, u32 cntxid)
Signature · 3 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."
maintainer
#11 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 5 lines · Andreas Schwab
Quoted 1 line · Samuel Holland

Anything else is either wrong or wasting space.

Not wasting space:

I am aware. However, this sort of change is not feasible for plic_context_save()/plic_context_restore(). It would severely complicate those functions with extra bit manipulation (thus wasting even more space in code size). So I am happy to pay one byte here for consistency between the two sets of functions.

Regards,
Samuel

Quoted 22 lines
lib/utils/irqchip/plic.c +2 -2
index d633514..901ffaa 100644
@@ -39,14 +39,14 @@ static void plic_set_priority(const struct plic_data *plic, u32 source, u32 val)
 void plic_priority_save(const struct plic_data *plic, u8 *priority, u32 num)
 {
 	for (u32 i = 1; i <= num; i++)
-		priority[i] = plic_get_priority(plic, i);
+		priority[i - 1] = plic_get_priority(plic, i);
 }
 
 void plic_priority_restore(const struct plic_data *plic, const u8 *priority,
 			   u32 num)
 {
 	for (u32 i = 1; i <= num; i++)
-		plic_set_priority(plic, i, priority[i]);
+		plic_set_priority(plic, i, priority[i - 1]);
 }
 
 static u32 plic_get_thresh(const struct plic_data *plic, u32 cntxid)
#12 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 4 lines · Samuel Holland

I am aware. However, this sort of change is not feasible for plic_context_save()/plic_context_restore(). It would severely complicate those functions with extra bit manipulation (thus wasting even more space in code size).

If your compiler is so dumb you have a much bigger problem.

Signature · 3 lines
Andreas Schwab, schwab at linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."
maintainer
#13 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 8 lines · Andreas Schwab
Quoted 4 lines · Samuel Holland

I am aware. However, this sort of change is not feasible for plic_context_save()/plic_context_restore(). It would severely complicate those functions with extra bit manipulation (thus wasting even more space in code size).

If your compiler is so dumb you have a much bigger problem.

I'm disappointed that I even have to explain this...

"This sort of change" to avoid using space for IRQ 0, thus saving one *bit* in the array used by plic_context_save(), would require combining two registers into one array element with shifts:

	enable[i] = plic_get_ie(plic, context_id, i) >> 1 |
	            plic_get_ie(plic, context_id, i + 1) << 31;

and doing the opposite transformation in plic_context_restore(). The compiler is not going to optimize that out.

If you really care about shaving off bytes, there is plenty of low-hanging fruit elsewhere in OpenSBI. This bikeshed really does not need painting.

Regards,
Samuel

#14 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 2 lines · Samuel Holland

"This sort of change" to avoid using space for IRQ 0, thus saving one *bit* in the array

??? *byte*

Quoted 1 line

used by plic_context_save(),

??? plic_priority_save/restore

Quoted 2 lines
	enable[i] = plic_get_ie(plic, context_id, i) >> 1 |
	            plic_get_ie(plic, context_id, i + 1) << 31;

??? Nothing at all changes here.

Signature · 3 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."
#15 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

In reply to Heinrich Schuchardt

The actual bug is in plic_priority_save/restore.

lib/utils/irqchip/plic.c +2 -2
index d633514..901ffaa 100644
@@ -39,14 +39,14 @@ static void plic_set_priority(const struct plic_data *plic, u32 source, u32 val)
 void plic_priority_save(const struct plic_data *plic, u8 *priority, u32 num)
 {
 	for (u32 i = 1; i <= num; i++)
-		priority[i] = plic_get_priority(plic, i);
+		priority[i - 1] = plic_get_priority(plic, i);
 }
 
 void plic_priority_restore(const struct plic_data *plic, const u8 *priority,
 			   u32 num)
 {
 	for (u32 i = 1; i <= num; i++)
-		plic_set_priority(plic, i, priority[i]);
+		plic_set_priority(plic, i, priority[i - 1]);
 }
 
 static u32 plic_get_thresh(const struct plic_data *plic, u32 cntxid)
Signature · 3 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."
#16 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 1 line · Andreas Schwab

The actual bug is in plic_priority_save/restore.

The problem really starts at include/sbi_utils/irqchip/plic.h where there is no comment at all describing the usage of the function and its parameters. So we don't know what the different authors of these functions intended to use index 0 for.

It would be great if we could move the project to follow the kernel documentation style (https://docs.kernel.org/doc-guide/kernel-doc.html)

lib/utils/irqchip/plic.c static void plic_set_priority(const struct plic_data *plic, u32 source, u32 val) · line 41

Quoted 9 lines
lib/utils/irqchip/plic.c +0 -0
index d633514..901ffaa 100644
@@ -39,14 +39,14 @@ static void plic_set_priority(const struct plic_data *plic, u32 source, u32 val)
  void plic_priority_save(const struct plic_data *plic, u8 *priority, u32 num)
  {
  	for (u32 i = 1; i <= num; i++)

In patch 34da6638 ("lib: utils/irqchip: plic: Fix the off-by-one error in priority save/restore helpers") Bin wrote

Interrupt source 0 is reserved. Hence the irq should start from 1.

Why was the the upper limit changed?

- for (u32 i = 0; i < plic->num_src; i++)
+ for (u32 i = 1; i <= plic->num_src; i++)

Best regards

Heinrich

Quoted 14 lines
lib/utils/irqchip/plic.c +2 -2
-		priority[i] = plic_get_priority(plic, i);
+		priority[i - 1] = plic_get_priority(plic, i);
  }
 
  void plic_priority_restore(const struct plic_data *plic, const u8 *priority,
  			   u32 num)
  {
  	for (u32 i = 1; i <= num; i++)
-		plic_set_priority(plic, i, priority[i]);
+		plic_set_priority(plic, i, priority[i - 1]);
  }
 
  static u32 plic_get_thresh(const struct plic_data *plic, u32 cntxid)
#17 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

Quoted 27 lines · Heinrich Schuchardt
Quoted 1 line · Andreas Schwab

The actual bug is in plic_priority_save/restore.

The problem really starts at include/sbi_utils/irqchip/plic.h where there is no comment at all describing the usage of the function and its parameters. So we don't know what the different authors of these functions intended to use index 0 for.

It would be great if we could move the project to follow the kernel documentation style (https://docs.kernel.org/doc-guide/kernel-doc.html)

lib/utils/irqchip/plic.c static void plic_set_priority(const struct plic_data *plic, u32 source, u32 val) · line 41

Quoted 9 lines
lib/utils/irqchip/plic.c +0 -0
index d633514..901ffaa 100644
@@ -39,14 +39,14 @@ static void plic_set_priority(const struct plic_data *plic, u32 source, u32 val)
  void plic_priority_save(const struct plic_data *plic, u8 *priority, u32 num)
  {
      for (u32 i = 1; i <= num; i++)

In patch 34da6638 ("lib: utils/irqchip: plic: Fix the off-by-one error in priority save/restore helpers") Bin wrote

Quoted 4 lines

Interrupt source 0 is reserved. Hence the irq should start from 1.

Why was the the upper limit changed?

Both lower and upper limits are changed because the irq number range is really [1, plic->num_src].

Previously the author had a wrong understanding of the irq number hence that's what the patch 34da6638 tried to fix.

Regards,
Bin

#18 lore raw

PATCH 1/1 platform: generic: allwinner: avoid buffer overrun

In reply to Heinrich Schuchardt

Hi Heinrich,

Quoted 9 lines · Heinrich Schuchardt

plic_priority_save() and plic_priority_restore() access indexes 1 to num of the passed array. Avoid a buffer overrun by increasing the used array size by one.

Addresses-Coverity-ID: 1530251 ("Out-of-bounds access")
Addresses-Coverity-ID: 1530252 ("Out-of-bounds access")

Fixes 8509e46ca63a ("lib: utils/irqchip: plic: Ensure no out-of-bound access in priority save/restore helpers")

Do you plan to send a v2 for this ?

Regards,
Anup

Quoted 20 lines
---
 platform/generic/allwinner/sun20i-d1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
platform/generic/allwinner/sun20i-d1.c +1 -2
index 1da9e5b..9891ad0 100644
@@ -72,7 +72,7 @@ static void sun20i_d1_csr_restore(void)
 #define PLIC_SOURCES                   176
 #define PLIC_IE_WORDS                  ((PLIC_SOURCES + 31) / 32)
 
-static u8 plic_priority[PLIC_SOURCES];
+static u8 plic_priority[PLIC_SOURCES + 1];
 static u32 plic_sie[PLIC_IE_WORDS];
 static u32 plic_threshold;
 
--

2.37.2