Skip to contentSkip to conversation

a question about kernel copy userspace data

DISCUSSION [email protected] 2 participants 2 messages Mar 29, 2007

lore
Share & tools
lore
#0 lore raw

hello ,
i am programming a trial firewall based on netfilter ,which needs the module to access the data of user space ,so i use copy_from_user() but it can't work ,the code(simple test code) is like this:
-------user space program-----
#include <stdlib.h>
#include <stdio.h>

int main(int argc ,char *argv[]) {
char para[100]="insmod test.ko ";
int c=24;
unsigned int point=&c;
printf("%u\n",point);
char b[11]="0000000000"; /*convert the unsigned to chars */ int j=10;
int siz=0;
while(point>0) {
b[--j]=point%10+48;
point=point/10;
siz++;
}
char ips[30]="point=";
strcat(ips,&b[10-siz]);
strcat(para,ips);
puts(para);
system("make");
system(para);
}
-------kernel module-----------
#include <linux/module.h>
#include <linux/netfilter_ipv4.h>
#include <linux/tcp.h>
#include <linux/moduleparam.h>

MODULE_LICENSE("Dual BSD/GPL");

static unsigned int *point;
module_param(point, uint , S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP); MODULE_PARM_DESC(point, "the pointer of user space");

static unsigned int
linuxmag_hook(unsigned int hook, struct sk_buff **pskb, const struct net_device *indev, const
struct net_device *outdev, int
(*okfn)(struct sk_buff *))
{
printk("world\n");
printk(" %u\n",point);
int *b;
b=kmalloc(sizeof(int),GFP_KERNEL); copy_from_user(b,(int *)point,sizeof(int)); printk("user space's value=%u\n",*b);
}

static struct nf_hook_ops linuxmag_ops
= { .hook = linuxmag_hook,
.owner = THIS_MODULE,
.pf = PF_INET,
.hooknum = NF_IP_LOCAL_OUT,
.priority = NF_IP_PRI_FILTER-1
};

static int __init init(void)
{
return nf_register_hook(&linuxmag_ops);
}

static void __exit fini(void)
{
nf_unregister_hook(&linuxmag_ops);
}
module_init(init);
module_exit(fini);

i check the /var/log/messages.
the user space's value is 0
not the right value 24 which i defined in main().
this question puzzled me for a few days,and i am a fresh man about kernel.is there anyone can help me?
any answer would be appreciated very much .

#1 lore raw

2007/3/29, [email protected] <[email protected]>:

Quoted 8 lines

hello ,
i am programming a trial firewall based on netfilter ,which needs the module to access the data of user space ,so i use copy_from_user() but it can't work ,the code(simple test code) is like this:
-------user space program-----
#include <stdlib.h>
#include <stdio.h>

You forgot to #include <string.h>, because you used 'strcat' below.

Quoted 4 lines

int main(int argc ,char *argv[]) {
char para[100]="insmod test.ko ";
int c=24;
unsigned int point=&c;

Bad code. 'unsigned int' is _not_ enough to hold a pointer on 64-bit machines. Try 'unsigned long' please.

Quoted 7 lines

printf("%u\n",point);
char b[11]="0000000000"; /*convert the unsigned to chars */ int j=10;
int siz=0;
while(point>0) {
b[--j]=point%10+48;
point=point/10;

Quoted 8 lines

siz++;
}
char ips[30]="point=";
strcat(ips,&b[10-siz]);
strcat(para,ips);
puts(para);
system("make");
system(para);

return 0;

Quoted 1 line

}

Why don't you try to use a shell/Perl/Python script instead? C is _not_ good at this.

Quoted 12 lines

-------kernel module-----------
#include <linux/module.h>
#include <linux/netfilter_ipv4.h>
#include <linux/tcp.h>
#include <linux/moduleparam.h>

MODULE_LICENSE("Dual BSD/GPL");

static unsigned int *point;
module_param(point, uint , S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP); MODULE_PARM_DESC(point, "the pointer of user space");

Quoted 10 lines

static unsigned int
linuxmag_hook(unsigned int hook, struct sk_buff **pskb, const struct net_device *indev, const
struct net_device *outdev, int
(*okfn)(struct sk_buff *))
{
printk("world\n");
printk(" %u\n",point);
int *b;
b=kmalloc(sizeof(int),GFP_KERNEL);

Please ALWAYS check the return value of 'kmalloc'.
ps. What prevents you to define an 'int' instead of defining a pointer first then alloc memory?

Quoted 31 lines

copy_from_user(b,(int *)point,sizeof(int));
printk("user space's value=%u\n",*b);
}

static struct nf_hook_ops linuxmag_ops
= { .hook = linuxmag_hook,
.owner = THIS_MODULE,
.pf = PF_INET,
.hooknum = NF_IP_LOCAL_OUT,
.priority = NF_IP_PRI_FILTER-1
};

static int __init init(void)
{
return nf_register_hook(&linuxmag_ops);
}

static void __exit fini(void)
{
nf_unregister_hook(&linuxmag_ops);
}
module_init(init);
module_exit(fini);

i check the /var/log/messages.
the user space's value is 0
not the right value 24 which i defined in main().
this question puzzled me for a few days,and i am a fresh man about kernel.is there anyone can help me?
any answer would be appreciated very much .

Signature · 1 line
So Dark The Con Of Man.