ALSA: hda/realtek: Enable speakers on further Samsung Galaxy Book2 Pro
PATCH 1/1 ALSA: hda/realtek: Enable speakers on further Samsung Galaxy Book2 Pro
There is a further NP950QED variant of the Samsung Galaxy Book2 Pro which has two speakers. Use the appropriate two speaker quirk for it.
---
Note that I didn't really manage to test this directly. Trying to do a reconfigure resulted in a hang and I didn't figure out how to use the patch= option with a firmware file.
However, the machine does work fine when configuring the two speakers from userspace, so I am confident that this patch is correct.
--- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)
sound/pci/hda/patch_realtek.c +1 -0
@@ -10758,6 +10758,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x144d ,0xca06 ,"Samsung Galaxy Book3 360 (NP730QFG)" ,ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET ),SND_PCI_QUIRK (0x144d ,0xc868 ,"Samsung Galaxy Book2 Pro (NP930XED)" ,ALC298_FIXUP_SAMSUNG_AMP ),SND_PCI_QUIRK (0x144d ,0xc870 ,"Samsung Galaxy Book2 Pro (NP950XED)" ,ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS ), +SND_PCI_QUIRK (0x144d ,0xc01d ,"Samsung Galaxy Book2 Pro (NP950QED)" ,ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS ),SND_PCI_QUIRK (0x144d ,0xc872 ,"Samsung Galaxy Book2 Pro (NP950XEE)" ,ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS ),SND_PCI_QUIRK (0x144d ,0xc886 ,"Samsung Galaxy Book3 Pro (NP964XFG)" ,ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS ), SND_PCI_QUIRK(0x144d, 0xc1ca, "Samsung Galaxy Book3 Pro 360 (NP960QFG)", ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS),
Signature · 1 line
2.49.0
Quoted 5 lines · Benjamin Berg
Note that I didn't really manage to test this directly. Trying to do a reconfigure resulted in a hang and I didn't figure out how to use the patch= option with a firmware file.
However, the machine does work fine when configuring the two speakers from userspace, so I am confident that this patch is correct.
FYI, the equivalent can be achieved with model option, too. e.g. passing model=144d:c870 will apply the same existing quirk as SSID 144d:c870. If your target is the secondary codec, pass like "model=,144d:c870" instead.
Quoted 9 lines
--- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)sound/pci/hda/patch_realtek.c +0
-0
sound/pci/hda/patch_realtek.c static const struct hda_quirk alc269_fixup_tbl[] = { · line 10764
Quoted 7 lines
sound/pci/hda/patch_realtek.c +1
-0@@ -10758,6 +10758,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x144d ,0xca06 ,"Samsung Galaxy Book3 360 (NP730QFG)" ,ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET ),SND_PCI_QUIRK (0x144d ,0xc868 ,"Samsung Galaxy Book2 Pro (NP930XED)" ,ALC298_FIXUP_SAMSUNG_AMP ),SND_PCI_QUIRK (0x144d ,0xc870 ,"Samsung Galaxy Book2 Pro (NP950XED)" ,ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS ), +SND_PCI_QUIRK (0x144d ,0xc01d ,"Samsung Galaxy Book2 Pro (NP950QED)" ,ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS ),SND_PCI_QUIRK (0x144d ,0xc872 ,"Samsung Galaxy Book2 Pro (NP950XEE)" ,ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS ),SND_PCI_QUIRK (0x144d ,0xc886 ,"Samsung Galaxy Book3 Pro (NP964XFG)" ,ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS ), SND_PCI_QUIRK(0x144d, 0xc1ca, "Samsung Galaxy Book3 Pro 360 (NP960QFG)", ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS),
The table is sorted in PCI SSID order. Could you try to put at the right position?
thanks,
Takashi
Quoted 11 lines · Takashi Iwai
Quoted 8 lines · Benjamin Berg
Note that I didn't really manage to test this directly. Trying to do a
reconfigure resulted in a hang and I didn't figure out how to use the
patch= option with a firmware file.
However, the machine does work fine when configuring the two speakers
from userspace, so I am confident that this patch is correct.
Quoted 4 lines
FYI, the equivalent can be achieved with model option, too. e.g. passing model=144d:c870 will apply the same existing quirk as SSID 144d:c870. If your target is the secondary codec, pass like "model=,144d:c870" instead.
Hmm, it is probably really straight forward, but I didn't grasp the documentation in Documentation/sound/hd-audio/notes.rst on a quick read. I am not sure anymore what I did (and I don't have access to the machine anymore). It might be I tried putting the model= line into a firmware file instead of just passing it on the kernel command line.
How do I even know whether it is the first or second codec? Is that what the D0 in hwC0D0 is?
Quoted 5 lines
Quoted 5 lines
---
sound/pci/hda/patch_realtek.c | 1 +1 file changed, 1 insertion(+)
Quoted 15 lines
sound/pci/hda/patch_realtek.c static const struct hda_quirk alc269_fixup_tbl[] = { · line 10764
Quoted 12 lines
sound/pci/hda/patch_realtek.c +1
-0@@ -10758,6 +10758,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x144d, 0xca06, "Samsung Galaxy Book3 360 (NP730QFG)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET), SND_PCI_QUIRK(0x144d, 0xc868, "Samsung Galaxy Book2 Pro (NP930XED)", ALC298_FIXUP_SAMSUNG_AMP), SND_PCI_QUIRK(0x144d, 0xc870, "Samsung Galaxy Book2 Pro (NP950XED)", ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS), +SND_PCI_QUIRK (0x144d ,0xc01d ,"Samsung Galaxy Book2 Pro (NP950QED)" ,ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS ), SND_PCI_QUIRK(0x144d, 0xc872, "Samsung Galaxy Book2 Pro (NP950XEE)", ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS), SND_PCI_QUIRK(0x144d, 0xc886, "Samsung Galaxy Book3 Pro (NP964XFG)", ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS), SND_PCI_QUIRK(0x144d, 0xc1ca, "Samsung Galaxy Book3 Pro 360 (NP960QFG)", ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS),The table is sorted in PCI SSID order. Could you try to put at the right position?
Sorry, will fix and resend.
Benjamin
Quoted 13 lines · Benjamin Berg
Quoted 11 lines · Takashi Iwai
Quoted 8 lines · Benjamin Berg
Note that I didn't really manage to test this directly. Trying to do a
reconfigure resulted in a hang and I didn't figure out how to use the
patch= option with a firmware file.
However, the machine does work fine when configuring the two speakers
from userspace, so I am confident that this patch is correct.
Quoted 8 lines
Quoted 4 lines
FYI, the equivalent can be achieved with model option, too. e.g. passing model=144d:c870 will apply the same existing quirk as SSID 144d:c870. If your target is the secondary codec, pass like "model=,144d:c870" instead.
Hmm, it is probably really straight forward, but I didn't grasp the documentation in
Documentation/sound/hd-audio/notes.rston a quick read.
It's mentioned in "Model Option" subsection of that document.
``` A new style for the model option that was introduced since 5.15 kernel is to pass the PCI or codec SSID in the form of ``model=XXXX:YYYY`` where XXXX and YYYY are the sub-vendor and sub-device IDs in hex numbers, respectively. This is a kind of aliasing to another device; when this form is given, the driver will refer to that SSID as a reference to the quirk table. It'd be useful especially when the target quirk isn't listed in the model table. For example, passing model=103c:8862 will apply the quirk for HP ProBook 445 G8 (which isn't found in the model table as of writing) as long as the device is handled equivalently by the same driver. ```
Quoted 6 lines
I am not sure anymore what I did (and I don't have access to the machine anymore). It might be I tried putting the model= line into a firmware file instead of just passing it on the kernel command line.
How do I even know whether it is the first or second codec? Is that what the D0 in hwC0D0 is?
I meant the device probe order, so card#0 device#0 must be the very first one :)
Quoted 20 lines
Quoted 4 lines
Quoted 4 lines
---
sound/pci/hda/patch_realtek.c | 1 +1 file changed, 1 insertion(+)Quoted 15 lines
sound/pci/hda/patch_realtek.c static const struct hda_quirk alc269_fixup_tbl[] = { · line 10764
Quoted 12 lines
sound/pci/hda/patch_realtek.c +1
-0@@ -10758,6 +10758,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x144d, 0xca06, "Samsung Galaxy Book3 360 (NP730QFG)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET), SND_PCI_QUIRK(0x144d, 0xc868, "Samsung Galaxy Book2 Pro (NP930XED)", ALC298_FIXUP_SAMSUNG_AMP), SND_PCI_QUIRK(0x144d, 0xc870, "Samsung Galaxy Book2 Pro (NP950XED)", ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS), +SND_PCI_QUIRK (0x144d ,0xc01d ,"Samsung Galaxy Book2 Pro (NP950QED)" ,ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS ), SND_PCI_QUIRK(0x144d, 0xc872, "Samsung Galaxy Book2 Pro (NP950XEE)", ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS), SND_PCI_QUIRK(0x144d, 0xc886, "Samsung Galaxy Book3 Pro (NP964XFG)", ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS), SND_PCI_QUIRK(0x144d, 0xc1ca, "Samsung Galaxy Book3 Pro 360 (NP960QFG)", ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS),The table is sorted in PCI SSID order. Could you try to put at the right position?
Quoted 1 line
Sorry, will fix and resend.
Thanks!
Takashi
Quoted 42 lines · Takashi Iwai
Quoted 13 lines · Benjamin Berg
Quoted 11 lines · Takashi Iwai
Quoted 8 lines · Benjamin Berg
Note that I didn't really manage to test this directly. Trying to do a
reconfigure resulted in a hang and I didn't figure out how to use the
patch= option with a firmware file.
However, the machine does work fine when configuring the two speakers
from userspace, so I am confident that this patch is correct.Quoted 8 lines
Quoted 4 lines
FYI, the equivalent can be achieved with model option, too. e.g. passing model=144d:c870 will apply the same existing quirk as SSID 144d:c870. If your target is the secondary codec, pass like "model=,144d:c870" instead.
Hmm, it is probably really straight forward, but I didn't grasp the documentation in
Documentation/sound/hd-audio/notes.rston a quick read.It's mentioned in "Model Option" subsection of that document.
``` A new style for the model option that was introduced since 5.15 kernel is to pass the PCI or codec SSID in the form of ``model=XXXX:YYYY`` where XXXX and YYYY are the sub-vendor and sub-device IDs in hex numbers, respectively. This is a kind of aliasing to another device; when this form is given, the driver will refer to that SSID as a reference to the quirk table. It'd be useful especially when the target quirk isn't listed in the model table. For example, passing model=103c:8862 will apply the quirk for HP ProBook 445 G8 (which isn't found in the model table as of writing) as long as the device is handled equivalently by the same driver. ```Quoted 3 lines
I am not sure anymore what I did (and I don't have access to the machine anymore). It might be I tried putting the model= line into a firmware file instead of just passing it on the kernel command line.
Quoted 5 lines
Quoted 2 lines
How do I even know whether it is the first or second codec? Is that what the D0 in hwC0D0 is?
I meant the device probe order, so card#0 device#0 must be the very first one :)
Right, that make sense, but wasn't obvious to me then.
Unfortunately, it seems that I messed something up and I cannot fully put it back together now.
I have one photo of the sysfs entries, and the subsystem_id is 0x144dc1ac there. So now I am not entirely certain that this is the correct ID, because I might have successfully overridden it to an incorrect value.
Lkely, it is correct, but I do not know where I got the 0xc01d from.
Sorry,
Benjamin
Quoted 27 lines
Quoted 20 lines
Quoted 4 lines
Quoted 4 lines
---
sound/pci/hda/patch_realtek.c | 1 +1 file changed, 1 insertion(+)Quoted 15 lines
sound/pci/hda/patch_realtek.c static const struct hda_quirk alc269_fixup_tbl[] = { · line 10764
Quoted 12 lines
sound/pci/hda/patch_realtek.c +1
-0@@ -10758,6 +10758,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x144d, 0xca06, "Samsung Galaxy Book3 360 (NP730QFG)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET), SND_PCI_QUIRK(0x144d, 0xc868, "Samsung Galaxy Book2 Pro (NP930XED)", ALC298_FIXUP_SAMSUNG_AMP), SND_PCI_QUIRK(0x144d, 0xc870, "Samsung Galaxy Book2 Pro (NP950XED)", ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS), +SND_PCI_QUIRK (0x144d ,0xc01d ,"Samsung Galaxy Book2 Pro (NP950QED)" ,ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS ), SND_PCI_QUIRK(0x144d, 0xc872, "Samsung Galaxy Book2 Pro (NP950XEE)", ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS), SND_PCI_QUIRK(0x144d, 0xc886, "Samsung Galaxy Book3 Pro (NP964XFG)", ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS), SND_PCI_QUIRK(0x144d, 0xc1ca, "Samsung Galaxy Book3 Pro 360 (NP960QFG)", ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS),The table is sorted in PCI SSID order. Could you try to put at the right position?
Quoted 1 line
Sorry, will fix and resend.
Thanks!
Takashi
Quoted 52 lines · Benjamin Berg
Quoted 42 lines · Takashi Iwai
Quoted 13 lines · Benjamin Berg
Quoted 11 lines · Takashi Iwai
Quoted 8 lines · Benjamin Berg
Note that I didn't really manage to test this directly. Trying to do a
reconfigure resulted in a hang and I didn't figure out how to use the
patch= option with a firmware file.
However, the machine does work fine when configuring the two speakers
from userspace, so I am confident that this patch is correct.Quoted 8 lines
Quoted 4 lines
FYI, the equivalent can be achieved with model option, too. e.g. passing model=144d:c870 will apply the same existing quirk as SSID 144d:c870. If your target is the secondary codec, pass like "model=,144d:c870" instead.
Hmm, it is probably really straight forward, but I didn't grasp the documentation in
Documentation/sound/hd-audio/notes.rston a quick read.It's mentioned in "Model Option" subsection of that document.
``` A new style for the model option that was introduced since 5.15 kernel is to pass the PCI or codec SSID in the form of ``model=XXXX:YYYY`` where XXXX and YYYY are the sub-vendor and sub-device IDs in hex numbers, respectively. This is a kind of aliasing to another device; when this form is given, the driver will refer to that SSID as a reference to the quirk table. It'd be useful especially when the target quirk isn't listed in the model table. For example, passing model=103c:8862 will apply the quirk for HP ProBook 445 G8 (which isn't found in the model table as of writing) as long as the device is handled equivalently by the same driver. ```Quoted 3 lines
I am not sure anymore what I did (and I don't have access to the machine anymore). It might be I tried putting the model= line into a firmware file instead of just passing it on the kernel command line.
Quoted 5 lines
Quoted 2 lines
How do I even know whether it is the first or second codec? Is that what the D0 in hwC0D0 is?
I meant the device probe order, so card#0 device#0 must be the very first one :)
Right, that make sense, but wasn't obvious to me then.
Quoted 8 lines
Unfortunately, it seems that I messed something up and I cannot fully put it back together now.
I have one photo of the sysfs entries, and the
subsystem_idis0x144dc1acthere. So now I am not entirely certain that this is the correct ID, because I might have successfully overridden it to an incorrect value.
Lkely, it is correct, but I do not know where I got the0xc01dfrom.
144d:c01d can be PCI SSID while 144d:c1ac is the codec SSID. Both are matched by the driver (PCI SSID is matched primarily). In many cases the vendor sets different ID numbers.
Takashi