Skip to contentSkip to conversation

mmc: stm32_sdmmc2: change the displayed config name

PATCH New Patrick Delaunay 2 participants 3 messages Apr 30, 2020 – May 14, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: stm32_sdmmc2: change the displayed config name

Change the mmc displayed name in U-Boot for stm32_sdmmc2 driver to ?STM32 SD/MMC?.

This stm32_sdmmc2 driver is for version 2 of the ST HW IP SDMMC but the displayed name "STM32 SDMMC2" is confusing for user, between the instance of SDMMC and the device identifier of MMC.

For example on EV1 board, we have:

STM32MP1> mmc list
STM32 SDMMC2: 0 (SD)
STM32 SDMMC2: 1 (eMMC)

Changed to more clear:

STM32MP1> mmc list
STM32 SD/MMC: 0 (SD)
STM32 SD/MMC: 1 (eMMC)

---

 drivers/mmc/stm32_sdmmc2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/stm32_sdmmc2.c +1 -1
index 6f3b2ad653..fa6fc94ad9 100644
@@ -674,7 +674,7 @@ static int stm32_sdmmc2_probe(struct udevice *dev)
 	cfg->f_max = dev_read_u32_default(dev, "max-frequency", 52000000);
 	cfg->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195;
 	cfg->b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT;
-	cfg->name = "STM32 SDMMC2";
+	cfg->name = "STM32 SD/MMC";
 
 	cfg->host_caps = 0;
 	if (cfg->f_max > 25000000)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 mmc: stm32_sdmmc2: change the displayed config name

Quoted 30 lines · Patrick Delaunay

Change the mmc displayed name in U-Boot for stm32_sdmmc2 driver to ?STM32 SD/MMC?.

This stm32_sdmmc2 driver is for version 2 of the ST HW IP SDMMC but the displayed name "STM32 SDMMC2" is confusing for user, between the instance of SDMMC and the device identifier of MMC.

For example on EV1 board, we have:

STM32MP1> mmc list
STM32 SDMMC2: 0 (SD)
STM32 SDMMC2: 1 (eMMC)

Changed to more clear:

STM32MP1> mmc list
STM32 SD/MMC: 0 (SD)
STM32 SD/MMC: 1 (eMMC)

---

 drivers/mmc/stm32_sdmmc2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/stm32_sdmmc2.c +0 -0
index 6f3b2ad653..fa6fc94ad9 100644

drivers/mmc/stm32_sdmmc2.c static int stm32_sdmmc2_probe(struct udevice *dev) · line 680

Quoted 8 lines
drivers/mmc/stm32_sdmmc2.c +1 -1
@@ -674,7 +674,7 @@ static int stm32_sdmmc2_probe(struct udevice *dev)
 	cfg->f_max = dev_read_u32_default(dev, "max-frequency", 52000000);
 	cfg->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195;
 	cfg->b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT;
-	cfg->name = "STM32 SDMMC2";
+	cfg->name = "STM32 SD/MMC";
 
 	cfg->host_caps = 0;
 	if (cfg->f_max > 25000000)

Thanks

Patrice

#2 lore raw

PATCH 1/1 mmc: stm32_sdmmc2: change the displayed config name

In reply to Patrick Delaunay

Hi,

Quoted 22 lines

From: Patrick DELAUNAY <[email protected]>
Sent: jeudi 30 avril 2020 09:52

Change the mmc displayed name in U-Boot for stm32_sdmmc2 driver to ?STM32 SD/MMC?.

This stm32_sdmmc2 driver is for version 2 of the ST HW IP SDMMC but the displayed name "STM32 SDMMC2" is confusing for user, between the instance of SDMMC and the device identifier of MMC.

For example on EV1 board, we have:

STM32MP1> mmc list
STM32 SDMMC2: 0 (SD)
STM32 SDMMC2: 1 (eMMC)

Changed to more clear:

STM32MP1> mmc list
STM32 SD/MMC: 0 (SD)
STM32 SD/MMC: 1 (eMMC)

Quoted 6 lines

---

 drivers/mmc/stm32_sdmmc2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-stm/master, thanks!

Regards

Patrick