Skip to contentSkip to conversation

security/dirtyc0w: Get and set umask in setup

PATCH Superseded Zou Wei 2 participants 2 messages Mar 28, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Zou Wei

author
#0 lore raw

PATCH 1/1 security/dirtyc0w: Get and set umask in setup

The case is only successful when system default umask is 0022. When umask is 0077, should change the value to 0022 in setup.

---
 testcases/kernel/security/dirtyc0w/dirtyc0w.c | 4 ++++
 1 file changed, 4 insertions(+)
testcases/kernel/security/dirtyc0w/dirtyc0w.c +4 -0
index a0a81b6..7abb5a2 100644
@@ -45,6 +45,10 @@ static void setup(void)
 {
 	struct passwd *pw;
 
+	if ((umask(0))==63){
+		umask(18);
+	}
+
 	pw = SAFE_GETPWNAM("nobody");
 
 	nobody_uid = pw->pw_uid;

--
2.6.2

#1 lore raw

PATCH 1/1 security/dirtyc0w: Get and set umask in setup

Quoted 13 lines · Zou Wei

The case is only successful when system default umask is 0022. When umask is 0077, should change the value to 0022 in setup.

---
  testcases/kernel/security/dirtyc0w/dirtyc0w.c | 4 ++++
  1 file changed, 4 insertions(+)
testcases/kernel/security/dirtyc0w/dirtyc0w.c +0 -0
index a0a81b6..7abb5a2 100644

testcases/kernel/security/dirtyc0w/dirtyc0w.c static void setup(void) · line 51

Quoted 7 lines
testcases/kernel/security/dirtyc0w/dirtyc0w.c +4 -0
@@ -45,6 +45,10 @@ static void setup(void)
  {
  	struct passwd *pw;
 
+	if ((umask(0))==63){
+		umask(18);
+	}
+

Hi Zou,

just clear current umask by umask(0) here if you want to exclude the impact of umask.

btw: it is readable to use otcal number(e.g. umask(0022) == 0022)

Thanks,

Xiao Yang

Quoted 7 lines
testcases/kernel/security/dirtyc0w/dirtyc0w.c +0 -1
  	pw = SAFE_GETPWNAM("nobody");
 
  	nobody_uid = pw->pw_uid;
--

2.6.2