batman-adv: use ether_addr_copy instead of memcpy in multicast code
PATCH v2 1/1 batman-adv: use ether_addr_copy instead of memcpy in multicast code
ether_addr_copy is supposed to be slightly more efficient for copying mac addresses, so let's use it. This makes recent versions of checkpatch happy, too.
Introduced by e368857f66620b8483166e8e6556d9c87f9b3e71 ("batman-adv: Multicast Listener Announcements via Translation Table")
Reported-by Antonio Quartulli <[email protected]>
Signed-off-by Linus Lüssing <[email protected]>
--- multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
multicast.c +1 -1
@@ -45,7 +45,7 @@ static int batadv_mcast_mla_softif_get(struct net_device *dev,break ; } -memcpy (&new->addr, &mc_list_entry->addr,ETH_ALEN ); +ether_addr_copy (&new->addr, &mc_list_entry->addr);hlist_add_head (&new->list, mcast_list); ret++; }
Signature · 1 line
1.7.10.4
Marek Lindner
AppliedQuoted 4 lines · On Tuesday 18 February 2014 09:14:05 Linus Lüssing wrote:
ether_addr_copyis supposed to be slightly more efficient for copying mac addresses, so let's use it. This makes recent versions of checkpatch happy, too.
Quoted 8 lines
Introduced by
e368857f66620b8483166e8e6556d9c87f9b3e71("batman-adv: Multicast Listener Announcements via Translation Table")Reported-by Antonio Quartulli <[email protected]>Signed-off-by Linus Lüssing <[email protected]>--- multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied in revision fb4756f.
Thanks,
Marek