btp: Update connect event structure
PATCH v2 1/1 btp: Update connect event structure
From: Tedd Ho-Jeong An <[email protected]>
This patch updates the connect event struct to align withe the btp spec.
Opcode 0x82 - Device Connected event
Controller Index: <controller id>
Event parameters: Address_Type (1 octet)
Address (6 octets) Connection Interval (2 octets) Connection Latency (2 octets) Supervision Timeout (2 octets)
--- src/shared/btp.h | 3 +++ 1 file changed, 3 insertions(+)
src/shared/btp.h +3 -0
@@ -259,6 +259,9 @@ struct btp_device_found_ev {struct btp_gap_device_connected_ev {uint8_t address_type;bdaddr_t address; +uint16_t connection_interval; +uint16_t connection_latency; +uint16_t supervision_timeout; } __packed;#define BTP_EV_GAP_DEVICE_DISCONNECTED 0x83
Signature · 1 line
2.17.1
Luiz Augusto von Dentz
maintainerHi Tedd,
Quoted 21 lines · Tedd Ho-Jeong An
From: Tedd Ho-Jeong An <[email protected]>
This patch updates the connect event struct to align withe the btp spec.
Opcode
0x82- Device Connected event
Controller Index: <controller id>
Event parameters:Address_Type(1 octet)
Address (6 octets) Connection Interval (2 octets) Connection Latency (2 octets) Supervision Timeout (2 octets)--- src/shared/btp.h | 3 +++ 1 file changed, 3 insertions(+)src/shared/btp.h +0
-0
src/shared/btp.h struct btp_device_found_ev { · line 265
Quoted 7 lines
src/shared/btp.h +3
-0@@ -259,6 +259,9 @@ struct btp_device_found_ev {struct btp_gap_device_connected_ev {uint8_t address_type;bdaddr_t address; +uint16_t connection_interval; +uint16_t connection_latency; +uint16_t supervision_timeout; } __packed;
This appears to be an API break, or we don't for BTP to be stable?
Quoted 5 lines
src/shared/btp.h +0
-1#define BTP_EV_GAP_DEVICE_DISCONNECTED 0x83 --2.17.1
Signature · 1 line
Luiz Augusto von Dentz
Hi Luiz
Quoted 19 lines · Luiz Augusto von Dentz
Hi Tedd,
Quoted 15 lines · Tedd Ho-Jeong An
From: Tedd Ho-Jeong An <[email protected]>
This patch updates the connect event struct to align withe the btp spec.
Opcode
0x82- Device Connected event
Controller Index: <controller id>
Event parameters:Address_Type(1 octet)
Address (6 octets) Connection Interval (2 octets) Connection Latency (2 octets) Supervision Timeout (2 octets)--- src/shared/btp.h | 3 +++ 1 file changed, 3 insertions(+)
Quoted 14 lines
src/shared/btp.h struct btp_device_found_ev { · line 265
Quoted 12 lines
src/shared/btp.h +3
-0@@ -259,6 +259,9 @@ struct btp_device_found_ev {struct btp_gap_device_connected_ev {uint8_t address_type;bdaddr_t address; +uint16_t connection_interval; +uint16_t connection_latency; +uint16_t supervision_timeout; } __packed;This appears to be an API break, or we don't for BTP to be stable?
It was old change and this patch was to align the change for BlueZ. All other projects using BTP such as Zephyr and Mynewt are already using new change.
Quoted 8 lines
Quoted 6 lines
src/shared/btp.h +0
-1#define BTP_EV_GAP_DEVICE_DISCONNECTED 0x83 --2.17.1