Skip to contentSkip to conversation

config.py: include qemux86-ptest-fast (32 bit) in a-quick

PATCH In review Alexander Kanavin 2 participants 4 messages Dec 13, 2022 – Dec 14, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 config.py: include qemux86-ptest-fast (32 bit) in a-quick

---
 config.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
config.py +2 -2
index 3c67351..e638099 100644
@@ -82,7 +82,7 @@ trigger_builders_wait_shared = [
 ]
 
 trigger_builders_wait_quick = trigger_builders_wait_shared + [
-    "oe-selftest", "qemux86-64-ptest-fast", "qemuarm64-ptest-fast"
+    "oe-selftest", "qemux86-64-ptest-fast", "qemuarm64-ptest-fast", "qemux86-ptest-fast"
 ]
 
 trigger_builders_wait_full = trigger_builders_wait_shared + [
@@ -117,7 +117,7 @@ builders_others = [
     "oe-selftest-arm",
     "metrics",
     "qemuriscv32", "qemuriscv64", "qemuriscv64-ptest", "qemuppc64",
-    "qemux86-ptest", "qemux86-ptest-fast",
+    "qemux86-ptest",
     "auh"
 ]
 
Signature · 1 line
2.38.1
#1 lore raw

PATCH 2/2 config.py: include 32 bit qemux86-ptest (full) into a-full

The manually triggered test result is here:
https://autobuilder.yoctoproject.org/typhoon/#/builders/141/builds/1

The execution time is similar to the 64 bit x86 full ptest, as valgrind has been excluded from the 32 bit set, so I believe we can afford to run this in the standard matrix for master-next tests.

---
 config.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
config.py +1 -2
index e638099..711dd98 100644
@@ -88,7 +88,7 @@ trigger_builders_wait_quick = trigger_builders_wait_shared + [
 trigger_builders_wait_full = trigger_builders_wait_shared + [
     "qemumips-alt", "edgerouter-alt", "qemuppc-alt", "qemux86-world-alt",
     "oe-selftest-ubuntu", "oe-selftest-debian", "oe-selftest-fedora", "oe-selftest-centos",
-    "qemux86-64-ptest", "qemux86-64-ltp", "qemuarm64-ptest", "qemuarm64-ltp", 
+    "qemux86-64-ptest", "qemux86-64-ltp", "qemuarm64-ptest", "qemuarm64-ltp", "qemux86-ptest",
     "meta-intel", "meta-arm", "meta-aws", "meta-agl-core", "meta-virt"
 ]
 
@@ -117,7 +117,6 @@ builders_others = [
     "oe-selftest-arm",
     "metrics",
     "qemuriscv32", "qemuriscv64", "qemuriscv64-ptest", "qemuppc64",
-    "qemux86-ptest",
     "auh"
 ]
 
Signature · 1 line
2.38.1
#2 lore raw

Re: [yocto] [yocto-autobuilder2][PATCH 2/2] config.py: include 32 bit qemux86-ptest (full) into a-full

Quoted 26 lines · Alexander Kanavin

The manually triggered test result is here:
https://autobuilder.yoctoproject.org/typhoon/#/builders/141/builds/1

The execution time is similar to the 64 bit x86 full ptest, as valgrind has been excluded from the 32 bit set, so I believe we can afford to run this in the standard matrix for master-next tests.

---
 config.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
config.py +1 -1
index e638099..711dd98 100644
@@ -88,7 +88,7 @@ trigger_builders_wait_quick = trigger_builders_wait_shared + [
 trigger_builders_wait_full = trigger_builders_wait_shared + [
     "qemumips-alt", "edgerouter-alt", "qemuppc-alt", "qemux86-world-alt",
     "oe-selftest-ubuntu", "oe-selftest-debian", "oe-selftest-fedora", "oe-selftest-centos",
-    "qemux86-64-ptest", "qemux86-64-ltp", "qemuarm64-ptest", "qemuarm64-ltp", 
+    "qemux86-64-ptest", "qemux86-64-ltp", "qemuarm64-ptest", "qemuarm64-ltp", "qemux86-ptest",
     "meta-intel", "meta-arm", "meta-aws", "meta-agl-core", "meta-virt"
 ]
 

config.py builders_others = [ · line 121

Quoted 6 lines
config.py +0 -1
@@ -117,7 +117,6 @@ builders_others = [
     "oe-selftest-arm",
     "metrics",
     "qemuriscv32", "qemuriscv64", "qemuriscv64-ptest", "qemuppc64",
-    "qemux86-ptest",
     "auh"
 ]

I'm not sure I agree. Yes, we can do it but I'm not sure we should.

This test doesn't seem to be one which is showing regressions, given we have a low number of issues despite never having run it. The day to day patch review struggles with the volume of tests we're running without adding the load this test needs to a-full.

We need to focus the tests on those which catch issues creeping into the project and I'm not convinced this is one of them. Running this test once or twice a month is probably all we need?

Cheers,

Richard

#3 lore raw

Re: [yocto] [yocto-autobuilder2][PATCH 2/2] config.py: include 32 bit qemux86-ptest (full) into a-full

Quoted 8 lines · Richard Purdie

This test doesn't seem to be one which is showing regressions, given we have a low number of issues despite never having run it. The day to day patch review struggles with the volume of tests we're running without adding the load this test needs to a-full.

We need to focus the tests on those which catch issues creeping into the project and I'm not convinced this is one of them. Running this test once or twice a month is probably all we need?

I don't have a strong opinion here. But what about qemux86-ptest-fast, should that be in a-quick only, a-quick+a-full, or neither?

Alex