Skip to contentSkip to conversation

ARP monitor for OVS bridge over bonding

Discuss Hangbin Liu 3 participants 4 messages Sep 10, 2024 – Sep 17, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi all,

Recently, our customer got an issue with OVS bridge over bonding. e.g.

eth0 eth1
| |
-- bond0 --

        |
      br-ex (ovs-vsctl add-port br-ex bond0; ip addr add 192.168.1.1/24 dev br-ex)

Before sending arp message for bond slave detecting, the bond need to check if the br-ex is in the same data path with bond0 via function bond_verify_device_path(), which using netdev_for_each_upper_dev_rcu() to check all upper devices. This works with normal bridge. But with ovs bridge, the upper device is "ovs-system" instead of br-ex.

After talking with OVS developers. It turned out the real upper OVS topology is looks like

              --------------------------------
              |                              |
  br-ex  -----+--      ovs-system            |
              |                              |
  br-int -----+--                            |
              |                              |
              |    bond0    eth2   veth42    |
              |      |       |       |       |
              |      |       |       |       |

-------+-------+-------+--------
| | |
+--+--+ physical |
| | link |
eth0 eth1 veth43

The br-ex is not upper link of bond0. ovs-system, instead, is the master of bond0. This make us unable to make sure the br-ex and bond0 is in the same datapath.

On the other hand, as Adrián Moreno said, the packets generated on br-ex could be routed anywhere using OpenFlow rules (including eth2 in the diagram). The same with normal bridge, with tc/netfilter rules, the packets could also be routed to other interface instead of bond0.

So the rt interface checking in bond_arp_send_all() is not always correct. Stanislas suggested adding a new parameter like 'arp monitor source interface' to binding that the user could supply. Then we can do like

	If (rt->dst.dev == arp_src_iface->dev)
		goto found;

What do you think?

Thanks
Hangbin

#1 lore raw
Quoted 35 lines · Hangbin Liu

Hi all,

Recently, our customer got an issue with OVS bridge over bonding. e.g.

eth0 eth1
| |
-- bond0 --

       |
     br-ex (ovs-vsctl add-port br-ex bond0; ip addr add 192.168.1.1/24 dev br-ex)

Before sending arp message for bond slave detecting, the bond need to check if the br-ex is in the same data path with bond0 via function bond_verify_device_path(), which using netdev_for_each_upper_dev_rcu() to check all upper devices. This works with normal bridge. But with ovs bridge, the upper device is "ovs-system" instead of br-ex.

After talking with OVS developers. It turned out the real upper OVS topology is looks like

             --------------------------------
             |                              |
 br-ex  -----+--      ovs-system            |
             |                              |
 br-int -----+--                            |
             |                              |
             |    bond0    eth2   veth42    |
             |      |       |       |       |
             |      |       |       |       |

-------+-------+-------+--------
| | |
+--+--+ physical |
| | link |
eth0 eth1 veth43

Quoted 3 lines

The br-ex is not upper link of bond0. ovs-system, instead, is the master of bond0. This make us unable to make sure the br-ex and bond0 is in the same datapath.

I'm guessing that this is in the context of an openstack
deployment, as "br-ex" and "br-int" are names commonly chosen for the OVS bridges in openstack.

But, yes, OVS bridge configuration is very different from the
linux bridge, and the ARP monitor was not designed with OVS in mind.

I'll also point out that OVS has its own bonding, although it
does not implement functionality equivalent to the ARP monitor.

However, OVS does provide an implementation of RFC 5880 BFD
(Bidirectional Forwarding Detection). The openstack deployments that I'm familiar with typically use the kernel bonding in LACP mode along with BFD. Is there a reason that OVS + BFD is unsuitable for your purposes?

Quoted 4 lines

On the other hand, as Adrián Moreno said, the packets generated on br-ex could be routed anywhere using OpenFlow rules (including eth2 in the diagram). The same with normal bridge, with tc/netfilter rules, the packets could also be routed to other interface instead of bond0.

True, and, at least in the openstack OVN/OVS deployments I'm
familiar with, heavy use of openflow rules is the usual configuration. Those deployments also make use of tc rules for various purposes.

Quoted 7 lines

So the rt interface checking in bond_arp_send_all() is not always correct. Stanislas suggested adding a new parameter like 'arp monitor source interface' to binding that the user could supply. Then we can do like

	If (rt->dst.dev == arp_src_iface->dev)
		goto found;

What do you think?

A single "arp_src_iface" parameter won't scale if there are
multiple ARP targets, as each target might need a different "arp_src_iface."

Also, the original purpose of bond_verify_device_path() is to
return VLAN tags in the device stack so that the ARP will be properly tagged.

I think what you're really asking for is a "I know what I'm
doing" option to bypass the checks in bond_arp_send_all(). That would also skip the VLAN tag search, so it's not necessarily a perfect solution.

Before considering such a change, I'd like to know why OVS + BFD
over a kernel bond attached to the OVS bridge is unsuitable for your use case, as that's a common configuration I've seen with OVS.

	-J

---
-Jay Vosburgh, [email protected]

#2 lore raw
Quoted 8 lines · Jay Vosburgh
Quoted 4 lines

The br-ex is not upper link of bond0. ovs-system, instead, is the master of bond0. This make us unable to make sure the br-ex and bond0 is in the same datapath.

I'm guessing that this is in the context of an openstack
deployment, as "br-ex" and "br-int" are names commonly chosen for the OVS bridges in openstack.

It's on a OCP (OpenShift Container Platform) that build with OVN Kubernetes.

Quoted 4 lines

But, yes, OVS bridge configuration is very different from the
linux bridge, and the ARP monitor was not designed with OVS in mind.

Quoted 8 lines

I'll also point out that OVS has its own bonding, although it
does not implement functionality equivalent to the ARP monitor.

However, OVS does provide an implementation of RFC 5880 BFD
(Bidirectional Forwarding Detection). The openstack deployments that I'm familiar with typically use the kernel bonding in LACP mode along with BFD. Is there a reason that OVS + BFD is unsuitable for your purposes?

LACP need switch config. While arp monitor doesn't need any switch config.

Quoted 7 lines

A single "arp_src_iface" parameter won't scale if there are
multiple ARP targets, as each target might need a different "arp_src_iface."

Also, the original purpose of bond_verify_device_path() is to
return VLAN tags in the device stack so that the ARP will be properly tagged.

Ah, yes, makes sense.

Quoted 5 lines

I think what you're really asking for is a "I know what I'm
doing" option to bypass the checks in bond_arp_send_all(). That would also skip the VLAN tag search, so it's not necessarily a perfect solution.

Yes.

Quoted 3 lines

Before considering such a change, I'd like to know why OVS + BFD
over a kernel bond attached to the OVS bridge is unsuitable for your use case, as that's a common configuration I've seen with OVS.

As upper comment, this need switch config.

Thanks
Hangbin

#3 lore raw
In reply to Jay Vosburgh
Quoted 78 lines · Jay Vosburgh
Quoted 35 lines · Hangbin Liu

Hi all,

Recently, our customer got an issue with OVS bridge over bonding. e.g.

eth0 eth1
| |
-- bond0 --

       |
     br-ex (ovs-vsctl add-port br-ex bond0; ip addr add 192.168.1.1/24 dev br-ex)

Before sending arp message for bond slave detecting, the bond need to check if the br-ex is in the same data path with bond0 via function bond_verify_device_path(), which using netdev_for_each_upper_dev_rcu() to check all upper devices. This works with normal bridge. But with ovs bridge, the upper device is "ovs-system" instead of br-ex.

After talking with OVS developers. It turned out the real upper OVS topology is looks like

             --------------------------------
             |                              |
 br-ex  -----+--      ovs-system            |
             |                              |
 br-int -----+--                            |
             |                              |
             |    bond0    eth2   veth42    |
             |      |       |       |       |
             |      |       |       |       |

-------+-------+-------+--------
| | |
+--+--+ physical |
| | link |
eth0 eth1 veth43

Quoted 3 lines

The br-ex is not upper link of bond0. ovs-system, instead, is the master of bond0. This make us unable to make sure the br-ex and bond0 is in the same datapath.

I'm guessing that this is in the context of an openstack
deployment, as "br-ex" and "br-int" are names commonly chosen for the OVS bridges in openstack.

But, yes, OVS bridge configuration is very different from the
linux bridge, and the ARP monitor was not designed with OVS in mind.

I'll also point out that OVS has its own bonding, although it
does not implement functionality equivalent to the ARP monitor.

However, OVS does provide an implementation of RFC 5880 BFD
(Bidirectional Forwarding Detection). The openstack deployments that I'm familiar with typically use the kernel bonding in LACP mode along with BFD. Is there a reason that OVS + BFD is unsuitable for your purposes?

Quoted 4 lines

On the other hand, as Adrián Moreno said, the packets generated on br-ex could be routed anywhere using OpenFlow rules (including eth2 in the diagram). The same with normal bridge, with tc/netfilter rules, the packets could also be routed to other interface instead of bond0.

True, and, at least in the openstack OVN/OVS deployments I'm
familiar with, heavy use of openflow rules is the usual configuration. Those deployments also make use of tc rules for various purposes.

Quoted 7 lines

So the rt interface checking in bond_arp_send_all() is not always correct. Stanislas suggested adding a new parameter like 'arp monitor source interface' to binding that the user could supply. Then we can do like

	If (rt->dst.dev == arp_src_iface->dev)
		goto found;

What do you think?

A single "arp_src_iface" parameter won't scale if there are
multiple ARP targets, as each target might need a different "arp_src_iface."

Quoted 8 lines

Also, the original purpose of bond_verify_device_path() is to
return VLAN tags in the device stack so that the ARP will be properly tagged.

I think what you're really asking for is a "I know what I'm
doing" option to bypass the checks in bond_arp_send_all(). That would also skip the VLAN tag search, so it's not necessarily a perfect solution.

I agree this is a better approach than "arp_src_iface" and that it's still not perfect. For OVS bridges, VLAN information is in userspace so we don't have a good way of retrieving it.

Also, this flag would apply to all ARP targets although I cannot think of any topology that would require monitoring addresses on OVS and non OVS interfaces.

Another possible approach would be to internally encode what interfaces types do honor the "stacking is datapath" assumption. I also dislike this given the flexibility netfilter and ebpf (and OpenFlow for that matter) have to create virtual datapaths independent from interface stacking, even on bridges.

Thanks.
Adrián

Quoted 10 lines

Before considering such a change, I'd like to know why OVS + BFD
over a kernel bond attached to the OVS bridge is unsuitable for your use case, as that's a common configuration I've seen with OVS.

	-J

---
-Jay Vosburgh, [email protected]