Skip to contentSkip to conversation

PM / Domains: mark genpd_poweron as __maybe_unused

PATCH In review Arnd Bergmann 2 participants 2 messages Feb 1, 2016

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PM / Domains: mark genpd_poweron as __maybe_unused

The rework of the power domain code has made the genpd_poweron() function local to the file it's defined in, and the only remaining caller is conditionally compiled based on CONFIG_PM_GENERIC_DOMAINS_OF, so we get a warning when that is disabled:

drivers/base/power/domain.c:234:12: error: 'genpd_poweron' defined but not used [-Werror=unused-function]

This adds a __maybe_unused annotation to the function so gcc can figure out by itself that it should silently remove the definition in this case.

Fixes ea823c7cbffa ("PM / Domains: Remove pm_genpd_poweron() API")
drivers/base/power/domain.c +1 -1
index 784dbe897a5e..a14b2f1ae085 100644
@@ -231,7 +231,7 @@ static int __genpd_poweron(struct generic_pm_domain *genpd, unsigned int depth)
  * genpd_poweron - Restore power to a given PM domain and its masters.
  * @genpd: PM domain to power up.
  */
-static int genpd_poweron(struct generic_pm_domain *genpd)
+static int __maybe_unused genpd_poweron(struct generic_pm_domain *genpd)
 {
 	int ret;
 
#1 lore raw
Quoted 5 lines · Arnd Bergmann

The rework of the power domain code has made the genpd_poweron() function local to the file it's defined in, and the only remaining caller is conditionally compiled based on CONFIG_PM_GENERIC_DOMAINS_OF, so we get a warning when that is disabled:

Quoted 8 lines

drivers/base/power/domain.c:234:12: error: 'genpd_poweron' defined but not used [-Werror=unused-function]

This adds a __maybe_unused annotation to the function so gcc can figure out by itself that it should silently remove the definition in this case.

Fixes ea823c7cbffa ("PM / Domains: Remove pm_genpd_poweron() API")

Arnd,

Thanks for fixing and reporting!

Looking a bit closer to the genpd code in this reagrds, made me realize that I think there's a better approach to fix this. Instead of going into the details for how, I decided to send a separate patch. You are on cc.

"[PATCH] PM / Domains: Silence compiler warning for an unused function".

Kind regards
Uffe