Skip to contentSkip to conversation

ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu()

PATCH New Heiko Stübner 2 participants 3 messages Jan 12, 2014 – Feb 13, 2014

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Heiko Stübner

author
#0 lore raw

PATCH 1/1 ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu()

The function is nearly empty and samsung_cpu_rev is static so already 0 making the function obsolete, therefore remove it.

Signed-off-by Heiko Stuebner <[email protected]>
---
 arch/arm/mach-s3c24xx/common.c           |    1 -
 arch/arm/plat-samsung/cpu.c              |    7 -------
 arch/arm/plat-samsung/include/plat/cpu.h |    1 -
 3 files changed, 9 deletions(-)
arch/arm/mach-s3c24xx/common.c +0 -1
index bf57d4c..97edd4d 100644
@@ -232,7 +232,6 @@ void __init s3c24xx_init_io(struct map_desc *mach_desc, int size)
 	} else {
 		samsung_cpu_id = s3c24xx_read_idcode_v4();
 	}
-	s3c24xx_init_cpu();
 
 	s3c_init_cpu(samsung_cpu_id, cpu_ids, ARRAY_SIZE(cpu_ids));
arch/arm/plat-samsung/cpu.c +0 -7
index 46b426e..364963a 100644
@@ -28,13 +28,6 @@ unsigned int samsung_rev(void)
 }
 EXPORT_SYMBOL(samsung_rev);
 
-void __init s3c24xx_init_cpu(void)
-{
-	/* nothing here yet */
-
-	samsung_cpu_rev = 0;
-}
-
 void __init s3c64xx_init_cpu(void)
 {
 	samsung_cpu_id = __raw_readl(S3C_VA_SYS + 0x118);
arch/arm/plat-samsung/include/plat/cpu.h +0 -1
index 8f09488..262ef86 100644
@@ -207,7 +207,6 @@ extern void s5p_init_irq(u32 *vic, u32 num_vic);
 
 extern void s3c24xx_init_io(struct map_desc *mach_desc, int size);
 
-extern void s3c24xx_init_cpu(void);
 extern void s3c64xx_init_cpu(void);
 extern void s5p_init_cpu(void __iomem *cpuid_addr);
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 1/1 ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu()

Am Sonntag, 12. Januar 2014, 21:34:29 schrieb Heiko St?bner:

Quoted 4 lines

The function is nearly empty and samsung_cpu_rev is static so already 0 making the function obsolete, therefore remove it.

Signed-off-by Heiko Stuebner <[email protected]>

ping :-)

Quoted 47 lines
---
 arch/arm/mach-s3c24xx/common.c           |    1 -
 arch/arm/plat-samsung/cpu.c              |    7 -------
 arch/arm/plat-samsung/include/plat/cpu.h |    1 -
 3 files changed, 9 deletions(-)
arch/arm/mach-s3c24xx/common.c +0 -1
index bf57d4c..97edd4d 100644
@@ -232,7 +232,6 @@ void __init s3c24xx_init_io(struct map_desc *mach_desc,
 int size) } else {
 		samsung_cpu_id = s3c24xx_read_idcode_v4();
 	}
-	s3c24xx_init_cpu();
 
 	s3c_init_cpu(samsung_cpu_id, cpu_ids, ARRAY_SIZE(cpu_ids));
arch/arm/plat-samsung/cpu.c +0 -7
index 46b426e..364963a 100644
@@ -28,13 +28,6 @@ unsigned int samsung_rev(void)
 }
 EXPORT_SYMBOL(samsung_rev);
 
-void __init s3c24xx_init_cpu(void)
-{
-	/* nothing here yet */
-
-	samsung_cpu_rev = 0;
-}
-
 void __init s3c64xx_init_cpu(void)
 {
 	samsung_cpu_id = __raw_readl(S3C_VA_SYS + 0x118);
(quoted diff) +0 -0

b/arch/arm/plat-samsung/include/plat/cpu.h index 8f09488..262ef86 100644

arch/arm/plat-samsung/include/plat/cpu.h +0 -1
@@ -207,7 +207,6 @@ extern void s5p_init_irq(u32 *vic, u32 num_vic);
 
 extern void s3c24xx_init_io(struct map_desc *mach_desc, int size);
 
-extern void s3c24xx_init_cpu(void);
 extern void s3c64xx_init_cpu(void);
 extern void s5p_init_cpu(void __iomem *cpuid_addr);
Applied
#2 lore raw

PATCH 1/1 ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu()

In reply to Heiko Stübner
Quoted 45 lines · Heiko St?bner

The function is nearly empty and samsung_cpu_rev is static so already 0 making the function obsolete, therefore remove it.

Signed-off-by Heiko Stuebner<[email protected]>
---
  arch/arm/mach-s3c24xx/common.c           |    1 -
  arch/arm/plat-samsung/cpu.c              |    7 -------
  arch/arm/plat-samsung/include/plat/cpu.h |    1 -
  3 files changed, 9 deletions(-)
arch/arm/mach-s3c24xx/common.c +0 -1
index bf57d4c..97edd4d 100644
@@ -232,7 +232,6 @@ void __init s3c24xx_init_io(struct map_desc *mach_desc, int size)
  	} else {
  		samsung_cpu_id = s3c24xx_read_idcode_v4();
  	}
-	s3c24xx_init_cpu();
 
  	s3c_init_cpu(samsung_cpu_id, cpu_ids, ARRAY_SIZE(cpu_ids));
arch/arm/plat-samsung/cpu.c +0 -7
index 46b426e..364963a 100644
@@ -28,13 +28,6 @@ unsigned int samsung_rev(void)
  }
  EXPORT_SYMBOL(samsung_rev);
 
-void __init s3c24xx_init_cpu(void)
-{
-	/* nothing here yet */
-
-	samsung_cpu_rev = 0;
-}
-
  void __init s3c64xx_init_cpu(void)
  {
  	samsung_cpu_id = __raw_readl(S3C_VA_SYS + 0x118);
arch/arm/plat-samsung/include/plat/cpu.h +0 -0
index 8f09488..262ef86 100644

arch/arm/plat-samsung/include/plat/cpu.h extern void s5p_init_irq(u32 *vic, u32 num_vic); · line 212

Quoted 7 lines
arch/arm/plat-samsung/include/plat/cpu.h +0 -1
@@ -207,7 +207,6 @@ extern void s5p_init_irq(u32 *vic, u32 num_vic);
 
  extern void s3c24xx_init_io(struct map_desc *mach_desc, int size);
 
-extern void s3c24xx_init_cpu(void);
  extern void s3c64xx_init_cpu(void);
  extern void s5p_init_cpu(void __iomem *cpuid_addr);

Applied, thanks.
- Kukjin