Skip to contentSkip to conversation

eal: tighten permissions on shared memory files

PATCH In review Bruce Richardson 2 participants 3 messages Apr 3, 2019 – Apr 4, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eal: tighten permissions on shared memory files

When creating files on disk, e.g. for EAL configuration or shared memory locks, etc., there is no need to grant any permissions on those files to other users. All directories are already created with 0700 permissions, so we should create all files with 0600 permissions.

---
 lib/librte_eal/freebsd/eal/eal.c               | 2 +-
 lib/librte_eal/freebsd/eal/eal_hugepage_info.c | 2 +-
 lib/librte_eal/linux/eal/eal.c                 | 2 +-
 lib/librte_eal/linux/eal/eal_hugepage_info.c   | 2 +-
 lib/librte_eal/linux/eal/eal_memory.c          | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)
lib/librte_eal/freebsd/eal/eal.c +1 -1
index 790c6afa7..c6ac9028f 100644
@@ -227,7 +227,7 @@ rte_eal_config_create(void)
 		return;
 
 	if (mem_cfg_fd < 0){
-		mem_cfg_fd = open(pathname, O_RDWR | O_CREAT, 0660);
+		mem_cfg_fd = open(pathname, O_RDWR | O_CREAT, 0600);
 		if (mem_cfg_fd < 0)
 			rte_panic("Cannot open '%s' for rte_mem_config\n", pathname);
 	}
lib/librte_eal/freebsd/eal/eal_hugepage_info.c +1 -1
index 1e8f5df23..32012e142 100644
@@ -22,7 +22,7 @@ static void *
 map_shared_memory(const char *filename, const size_t mem_size, int flags)
 {
 	void *retval;
-	int fd = open(filename, flags, 0666);
+	int fd = open(filename, flags, 0600);
 	if (fd < 0)
 		return NULL;
 	if (ftruncate(fd, mem_size) < 0) {
lib/librte_eal/linux/eal/eal.c +1 -1
index 75ed0cf10..f7ae62d7b 100644
@@ -320,7 +320,7 @@ rte_eal_config_create(void)
 		rte_mem_cfg_addr = NULL;
 
 	if (mem_cfg_fd < 0){
-		mem_cfg_fd = open(pathname, O_RDWR | O_CREAT, 0660);
+		mem_cfg_fd = open(pathname, O_RDWR | O_CREAT, 0600);
 		if (mem_cfg_fd < 0)
 			rte_panic("Cannot open '%s' for rte_mem_config\n", pathname);
 	}
lib/librte_eal/linux/eal/eal_hugepage_info.c +1 -1
index ce3e99256..91a4fede7 100644
@@ -45,7 +45,7 @@ static void *
 map_shared_memory(const char *filename, const size_t mem_size, int flags)
 {
 	void *retval;
-	int fd = open(filename, flags, 0666);
+	int fd = open(filename, flags, 0600);
 	if (fd < 0)
 		return NULL;
 	if (ftruncate(fd, mem_size) < 0) {
lib/librte_eal/linux/eal/eal_memory.c +1 -1
index 39cd359a0..319352521 100644
@@ -541,7 +541,7 @@ create_shared_memory(const char *filename, const size_t mem_size)
 		return retval;
 	}
 
-	fd = open(filename, O_CREAT | O_RDWR, 0666);
+	fd = open(filename, O_CREAT | O_RDWR, 0600);
 	if (fd < 0)
 		return NULL;
 	if (ftruncate(fd, mem_size) < 0) {
Signature · 1 line
2.20.1
#1 lore raw

Adding [email protected] since this is suitable for backporting

Quoted 5 lines · Bruce Richardson

When creating files on disk, e.g. for EAL configuration or shared memory locks, etc., there is no need to grant any permissions on those files to other users. All directories are already created with 0700 permissions, so we should create all files with 0600 permissions.

Quoted 77 lines
---
 lib/librte_eal/freebsd/eal/eal.c               | 2 +-
 lib/librte_eal/freebsd/eal/eal_hugepage_info.c | 2 +-
 lib/librte_eal/linux/eal/eal.c                 | 2 +-
 lib/librte_eal/linux/eal/eal_hugepage_info.c   | 2 +-
 lib/librte_eal/linux/eal/eal_memory.c          | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)
lib/librte_eal/freebsd/eal/eal.c +1 -1
index 790c6afa7..c6ac9028f 100644
@@ -227,7 +227,7 @@ rte_eal_config_create(void)
 		return;
 
 	if (mem_cfg_fd < 0){
-		mem_cfg_fd = open(pathname, O_RDWR | O_CREAT, 0660);
+		mem_cfg_fd = open(pathname, O_RDWR | O_CREAT, 0600);
 		if (mem_cfg_fd < 0)
 			rte_panic("Cannot open '%s' for rte_mem_config\n", pathname);
 	}
lib/librte_eal/freebsd/eal/eal_hugepage_info.c +1 -1
index 1e8f5df23..32012e142 100644
@@ -22,7 +22,7 @@ static void *
 map_shared_memory(const char *filename, const size_t mem_size, int flags)
 {
 	void *retval;
-	int fd = open(filename, flags, 0666);
+	int fd = open(filename, flags, 0600);
 	if (fd < 0)
 		return NULL;
 	if (ftruncate(fd, mem_size) < 0) {
lib/librte_eal/linux/eal/eal.c +1 -1
index 75ed0cf10..f7ae62d7b 100644
@@ -320,7 +320,7 @@ rte_eal_config_create(void)
 		rte_mem_cfg_addr = NULL;
 
 	if (mem_cfg_fd < 0){
-		mem_cfg_fd = open(pathname, O_RDWR | O_CREAT, 0660);
+		mem_cfg_fd = open(pathname, O_RDWR | O_CREAT, 0600);
 		if (mem_cfg_fd < 0)
 			rte_panic("Cannot open '%s' for rte_mem_config\n", pathname);
 	}
lib/librte_eal/linux/eal/eal_hugepage_info.c +1 -1
index ce3e99256..91a4fede7 100644
@@ -45,7 +45,7 @@ static void *
 map_shared_memory(const char *filename, const size_t mem_size, int flags)
 {
 	void *retval;
-	int fd = open(filename, flags, 0666);
+	int fd = open(filename, flags, 0600);
 	if (fd < 0)
 		return NULL;
 	if (ftruncate(fd, mem_size) < 0) {
lib/librte_eal/linux/eal/eal_memory.c +1 -1
index 39cd359a0..319352521 100644
@@ -541,7 +541,7 @@ create_shared_memory(const char *filename, const size_t mem_size)
 		return retval;
 	}
 
-	fd = open(filename, O_CREAT | O_RDWR, 0666);
+	fd = open(filename, O_CREAT | O_RDWR, 0600);
 	if (fd < 0)
 		return NULL;
 	if (ftruncate(fd, mem_size) < 0) {
Signature · 1 line
2.20.1
#2 lore raw

03/04/2019 18:02, Bruce Richardson:

Quoted 10 lines

Adding [email protected] since this is suitable for backporting

Quoted 5 lines · Bruce Richardson

When creating files on disk, e.g. for EAL configuration or shared memory locks, etc., there is no need to grant any permissions on those files to other users. All directories are already created with 0700 permissions, so we should create all files with 0600 permissions.

Quoted 1 line

It means the primary and secondary processes must have the same owner. Is it worth to document it?
I feel the mask could be an EAL option.

Anyway the directories have already a fixed tight mask, so Applied, thanks