Skip to contentSkip to conversation

selinux: rate-limit unrecognized netlink message warnings in selinux_nlmsg_perm()

PATCH Superseded Vladis Dronov 2 participants 3 messages Nov 4, 2015 – Nov 13, 2015 SELinux security module

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 selinux: rate-limit unrecognized netlink message warnings in selinux_nlmsg_perm()

Any process is able to send netlink messages with invalid types. Make the warning rate-limited to prevent too much log spam.

The warning is supposed to help to find misbehaving programs, so print the triggering command name and pid.

---
 security/selinux/hooks.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
security/selinux/hooks.c +5 -4
index e4369d8..3d8087d 100644
@@ -4787,11 +4787,12 @@ static int selinux_nlmsg_perm(struct sock *sk, struct sk_buff *skb)
 	err = selinux_nlmsg_lookup(sksec->sclass, nlh->nlmsg_type, &perm);
 	if (err) {
 		if (err == -EINVAL) {
-			printk(KERN_WARNING
-			       "SELinux: unrecognized netlink message:"
-			       " protocol=%hu nlmsg_type=%hu sclass=%s\n",
+			pr_warn_ratelimited("SELinux: unrecognized netlink"
+			       " message: protocol=%hu nlmsg_type=%hu sclass=%s"
+			       " from %s[%d]\n",
 			       sk->sk_protocol, nlh->nlmsg_type,
-			       secclass_map[sksec->sclass - 1].name);
+			       secclass_map[sksec->sclass - 1].name,
+			       current->comm, current->pid);
 			if (!selinux_enforcing || security_get_allow_unknown())
 				err = 0;
 		}
maintainer
#1 lore raw
Quoted 20 lines · Vladis Dronov

Any process is able to send netlink messages with invalid types. Make the warning rate-limited to prevent too much log spam.

The warning is supposed to help to find misbehaving programs, so print the triggering command name and pid.

---
 security/selinux/hooks.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
security/selinux/hooks.c +0 -0
index e4369d8..3d8087d 100644
@@ -4787,11 +4787,12 @@ static int selinux_nlmsg_perm(struct sock *sk,
 struct sk_buff *skb) err = selinux_nlmsg_lookup(sksec->sclass,
 nlh->nlmsg_type, &perm); if (err) {
 		if (err == -EINVAL) {

security/selinux/hooks.c static int selinux_nlmsg_perm(struct sock *sk, · line 4795

Quoted 10 lines
security/selinux/hooks.c +5 -4
-			printk(KERN_WARNING
-			       "SELinux: unrecognized netlink message:"
-			       " protocol=%hu nlmsg_type=%hu sclass=%s\n",
+			pr_warn_ratelimited("SELinux: unrecognized netlink"
+			       " message: protocol=%hu nlmsg_type=%hu sclass=%s"
+			       " from %s[%d]\n",
 			       sk->sk_protocol, nlh->nlmsg_type,
-			       secclass_map[sksec->sclass - 1].name);
+			       secclass_map[sksec->sclass - 1].name,
+			       current->comm, current->pid);

I should have looked at more closely at the actual changes earlier, but the other issues with your posting distracted me ... while this isn't an audit message, it tends to follow the audit-ish name=value format so let's stick with that in this message, I would also suggest using task_pid_nr() so the line should look something like this:

  pr_warn_ratelimited("SELinux: unrecognized netlink"
                      " message: protocol=%hu nlmsg_type=%hu sclass=%s"
                      " pig=%d comm=%s\n",
                      sk->sk_protocol, nlh->nlmsg_type,
                      secclass_map[sksec->sclass - 1].name,
                      task_pid_nr(current), current->comm);
Signature · 2 lines
paul moore
www.paul-moore.com
#2 lore raw

Hello, Paul,
Thank you for the corrections and your time. I've just sent a next patch version to the list. I hope it would be more acceptable.

Best regards,
Vladis Dronov | Red Hat, Inc. | Product Security Engineer

----- Original Message -----
From: "Paul Moore" <[email protected]>
To: "Vladis Dronov" <[email protected]>
Cc: [email protected], [email protected]
Sent: Wednesday, November 11, 2015 12:07:23 AM
Subject: Re: [PATCH v2] selinux: rate-limit unrecognized netlink message warnings in selinux_nlmsg_perm()

Quoted 20 lines · Vladis Dronov

Any process is able to send netlink messages with invalid types. Make the warning rate-limited to prevent too much log spam.

The warning is supposed to help to find misbehaving programs, so print the triggering command name and pid.

---
 security/selinux/hooks.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
security/selinux/hooks.c +0 -0
index e4369d8..3d8087d 100644
@@ -4787,11 +4787,12 @@ static int selinux_nlmsg_perm(struct sock *sk,
 struct sk_buff *skb) err = selinux_nlmsg_lookup(sksec->sclass,
 nlh->nlmsg_type, &perm); if (err) {
 		if (err == -EINVAL) {

security/selinux/hooks.c static int selinux_nlmsg_perm(struct sock *sk, · line 4795

Quoted 10 lines
security/selinux/hooks.c +5 -4
-			printk(KERN_WARNING
-			       "SELinux: unrecognized netlink message:"
-			       " protocol=%hu nlmsg_type=%hu sclass=%s\n",
+			pr_warn_ratelimited("SELinux: unrecognized netlink"
+			       " message: protocol=%hu nlmsg_type=%hu sclass=%s"
+			       " from %s[%d]\n",
 			       sk->sk_protocol, nlh->nlmsg_type,
-			       secclass_map[sksec->sclass - 1].name);
+			       secclass_map[sksec->sclass - 1].name,
+			       current->comm, current->pid);

I should have looked at more closely at the actual changes earlier, but the other issues with your posting distracted me ... while this isn't an audit message, it tends to follow the audit-ish name=value format so let's stick with that in this message, I would also suggest using task_pid_nr() so the line should look something like this:

  pr_warn_ratelimited("SELinux: unrecognized netlink"
                      " message: protocol=%hu nlmsg_type=%hu sclass=%s"
                      " pig=%d comm=%s\n",
                      sk->sk_protocol, nlh->nlmsg_type,
                      secclass_map[sksec->sclass - 1].name,
                      task_pid_nr(current), current->comm);
Signature · 2 lines
paul moore
www.paul-moore.com