phy: qcom: edp: Initialize swing_pre_emph_cfg for sc7280
Subsystems (2)
PATCH 1/1 phy: qcom: edp: Initialize swing_pre_emph_cfg for sc7280
Aux timeout is observed on few monitors like Benq BL2420-T due to missing swing_pre_emph_cfg.
--- drivers/phy/qualcomm/phy-qcom-edp.c | 1 + 1 file changed, 1 insertion(+)
drivers/phy/qualcomm/phy-qcom-edp.c +1 -0
@@ -571,6 +571,7 @@ static const struct qcom_edp_phy_cfg sa8775p_dp_phy_cfg = {static const struct qcom_edp_phy_cfg sc7280_dp_phy_cfg = { .aux_cfg = edp_phy_aux_cfg_v4, .vco_div_cfg = edp_phy_vco_div_cfg_v4, + .swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg, .ver_ops = &qcom_edp_phy_ops_v4, };
---
base-commit: 54f966f63b379d0c62bb044b7903319776443a4a
change-id: 20260403-phy_for_next-ce3aa0eb556f
Best regards,
Signature · 1 line
Vishnu Saini <[email protected]>
Quoted 7 lines · Vishnu Saini
Aux timeout is observed on few monitors like Benq BL2420-T due to missing
swing_pre_emph_cfg.Signed-off-by Vishnu Saini <[email protected]>--- drivers/phy/qualcomm/phy-qcom-edp.c | 1 + 1 file changed, 1 insertion(+)
Missing Fixes tag.
Signature · 2 lines
With best wishes Dmitry
Quoted 10 lines · Dmitry Baryshkov
Quoted 7 lines · Vishnu Saini
Aux timeout is observed on few monitors like Benq BL2420-T due to missing
swing_pre_emph_cfg.Signed-off-by Vishnu Saini <[email protected]>--- drivers/phy/qualcomm/phy-qcom-edp.c | 1 + 1 file changed, 1 insertion(+)Missing Fixes tag.
phy cfg is not initialized for sc7280 when it was added first time with:
https://lore.kernel.org/all/20220207161612.REPOST.v1.2.Iff75c0ea8499f0baf2aa5800f2c45c4128e2415a@changeid/
Shall i add this tag?
Later phy cfgs added first time with below patches:
https://lore.kernel.org/r/[email protected]
https://lore.kernel.org/r/[email protected]
Quoted 3 lines
Signature · 2 lines
With best wishes Dmitry
Quoted 5 lines · Vishnu Saini
Aux timeout is observed on few monitors like Benq BL2420-T due to missing
swing_pre_emph_cfg.Signed-off-by Vishnu Saini <[email protected]>---
We could take it as-is to get rid of the timeouts, but
https://lore.kernel.org/linux-arm-msm/[email protected]/
suggests that these values are not super correct.. I'm long overdue for re-reviewing that, I'll hopefully do so tomorrow or next week
Konrad