Skip to contentSkip to conversation

media: stm32: dcmi: Fill in remaining Bayer formats

PATCH In review Marek Vasut 2 participants 3 messages Jun 18, 2022 – Jun 27, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: stm32: dcmi: Fill in remaining Bayer formats

Fill in 10, 12, 14 bit Bayer formats into the DCMI driver. Those are useful e.g. when MT9P006 sensor is connected.

Cc Alain Volmat <[email protected]>
Cc Alexandre Torgue <[email protected]>
Cc Amelie DELAUNAY <[email protected]>
Cc Hugues FRUCHET <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Philippe CORNU <[email protected]>
---
 drivers/media/platform/st/stm32/stm32-dcmi.c | 48 ++++++++++++++++++++
 1 file changed, 48 insertions(+)
drivers/media/platform/st/stm32/stm32-dcmi.c +48 -0
index 09a743cd70040..5f08ba47ea96b 100644
@@ -1631,6 +1631,54 @@ static const struct dcmi_format dcmi_formats[] = {
 		.fourcc = V4L2_PIX_FMT_SRGGB8,
 		.mbus_code = MEDIA_BUS_FMT_SRGGB8_1X8,
 		.bpp = 1,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SBGGR10,
+		.mbus_code = MEDIA_BUS_FMT_SBGGR10_1X10,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SGBRG10,
+		.mbus_code = MEDIA_BUS_FMT_SGBRG10_1X10,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SGRBG10,
+		.mbus_code = MEDIA_BUS_FMT_SGRBG10_1X10,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SRGGB10,
+		.mbus_code = MEDIA_BUS_FMT_SRGGB10_1X10,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SBGGR12,
+		.mbus_code = MEDIA_BUS_FMT_SBGGR12_1X12,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SGBRG12,
+		.mbus_code = MEDIA_BUS_FMT_SGBRG12_1X12,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SGRBG12,
+		.mbus_code = MEDIA_BUS_FMT_SGRBG12_1X12,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SRGGB12,
+		.mbus_code = MEDIA_BUS_FMT_SRGGB12_1X12,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SBGGR14,
+		.mbus_code = MEDIA_BUS_FMT_SBGGR14_1X14,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SGBRG14,
+		.mbus_code = MEDIA_BUS_FMT_SGBRG14_1X14,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SGRBG14,
+		.mbus_code = MEDIA_BUS_FMT_SGRBG14_1X14,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SRGGB14,
+		.mbus_code = MEDIA_BUS_FMT_SRGGB14_1X14,
+		.bpp = 2,
 	},
 };
 
Signature · 1 line
2.35.1
maintainer Acked-by on v1 1/1
#1 lore raw

Hi Marek,

Thanks for the patch.

Please note that we have not tested parallel setup with more than 8 bits with this driver because of lack of hardware support. Which board are you using ?
Are the whole 12 bits of the MT9P006 parallel bus wired on your board ?

Best regards,
Hugues.

Quoted 75 lines · Marek Vasut

Fill in 10, 12, 14 bit Bayer formats into the DCMI driver. Those are useful e.g. when MT9P006 sensor is connected.

Cc Alain Volmat <[email protected]>
Cc Alexandre Torgue <[email protected]>
Cc Amelie DELAUNAY <[email protected]>
Cc Hugues FRUCHET <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Philippe CORNU <[email protected]>
---
  drivers/media/platform/st/stm32/stm32-dcmi.c | 48 ++++++++++++++++++++
  1 file changed, 48 insertions(+)
drivers/media/platform/st/stm32/stm32-dcmi.c +48 -0
index 09a743cd70040..5f08ba47ea96b 100644
@@ -1631,6 +1631,54 @@ static const struct dcmi_format dcmi_formats[] = {
  		.fourcc = V4L2_PIX_FMT_SRGGB8,
  		.mbus_code = MEDIA_BUS_FMT_SRGGB8_1X8,
  		.bpp = 1,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SBGGR10,
+		.mbus_code = MEDIA_BUS_FMT_SBGGR10_1X10,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SGBRG10,
+		.mbus_code = MEDIA_BUS_FMT_SGBRG10_1X10,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SGRBG10,
+		.mbus_code = MEDIA_BUS_FMT_SGRBG10_1X10,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SRGGB10,
+		.mbus_code = MEDIA_BUS_FMT_SRGGB10_1X10,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SBGGR12,
+		.mbus_code = MEDIA_BUS_FMT_SBGGR12_1X12,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SGBRG12,
+		.mbus_code = MEDIA_BUS_FMT_SGBRG12_1X12,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SGRBG12,
+		.mbus_code = MEDIA_BUS_FMT_SGRBG12_1X12,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SRGGB12,
+		.mbus_code = MEDIA_BUS_FMT_SRGGB12_1X12,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SBGGR14,
+		.mbus_code = MEDIA_BUS_FMT_SBGGR14_1X14,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SGBRG14,
+		.mbus_code = MEDIA_BUS_FMT_SGBRG14_1X14,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SGRBG14,
+		.mbus_code = MEDIA_BUS_FMT_SGRBG14_1X14,
+		.bpp = 2,
+	}, {
+		.fourcc = V4L2_PIX_FMT_SRGGB14,
+		.mbus_code = MEDIA_BUS_FMT_SRGGB14_1X14,
+		.bpp = 2,
  	},
  };
 
#2 lore raw
Quoted 1 line · Hugues FRUCHET

Hi Marek,

Hi,

Quoted 6 lines

Thanks for the patch.

Please note that we have not tested parallel setup with more than 8 bits with this driver because of lack of hardware support. Which board are you using ?

Custom one with MT9P006 sensor.

Quoted 1 line

Are the whole 12 bits of the MT9P006 parallel bus wired on your board ?

Yes