Skip to contentSkip to conversation

Speaker can't mute when HP was plugged

PATCH Applied Kailang 2 participants 2 messages Jan 24, 2024 Sound

lore
Share & tools
lore

Kailang

author
#0 lore raw

Hi Takashi,

Speaker can't mute when HP was plugged for Dell platform. I did disable speaker pass through and add verb to speaker pin.

Many Thinks.

BR,
Kailang

From e707dd76390cfdc8b8c656b9b8b8ea3863ed5c72 Mon Sep 17 00:00:00 2001
From: Kailang Yang <[email protected]>
Date: Wed, 24 Jan 2024 14:21:47 +0800
Subject: [PATCH] ALSA: hda/realtek - Add speaker pin verbtable for Dell dual speaker platform

SSID 0x0c0d platform. It can't mute speaker when HP plugged. This patch add quirk to fill speaker pin verbtable. And disable speaker passthrough.

Signed-off-by Kailang Yang <[email protected]>
sound/pci/hda/patch_realtek.c +5 -2
index f6f16622f9cc..67c58dd046f7 100644
@@ -439,6 +439,10 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
 		alc_update_coef_idx(codec, 0x67, 0xf000, 0x3000);
 		fallthrough;
 	case 0x10ec0215:
+	case 0x10ec0285:
+	case 0x10ec0289:
+		alc_update_coef_idx(codec, 0x36, 1<<13, 0);
+		fallthrough;
 	case 0x10ec0230:
 	case 0x10ec0233:
 	case 0x10ec0235:

@@ -452,9 +456,7 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
 	case 0x10ec0283:
 	case 0x10ec0286:
 	case 0x10ec0288:
-	case 0x10ec0285:
 	case 0x10ec0298:
-	case 0x10ec0289:
 	case 0x10ec0300:
 		alc_update_coef_idx(codec, 0x10, 1<<9, 0);
 		break;

@@ -9732,6 +9734,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1028, 0x0b71, "Dell Inspiron 16 Plus 7620", ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS),
 	SND_PCI_QUIRK(0x1028, 0x0beb, "Dell XPS 15 9530 (2023)", ALC289_FIXUP_DELL_CS35L41_SPI_2),
 	SND_PCI_QUIRK(0x1028, 0x0c03, "Dell Precision 5340", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x1028, 0x0c0d, "Dell Oasis", ALC289_FIXUP_RTK_AMP_DUAL_SPK),
 	SND_PCI_QUIRK(0x1028, 0x0c19, "Dell Precision 3340", ALC236_FIXUP_DELL_DUAL_CODECS),
 	SND_PCI_QUIRK(0x1028, 0x0c1a, "Dell Precision 3340", ALC236_FIXUP_DELL_DUAL_CODECS),
 	SND_PCI_QUIRK(0x1028, 0x0c1b, "Dell Precision 3440", ALC236_FIXUP_DELL_DUAL_CODECS),
Applied
#1 lore raw
Quoted 5 lines · Kailang

Hi Takashi,

Speaker can't mute when HP was plugged for Dell platform. I did disable speaker pass through and add verb to speaker pin.

Thanks, applied.

Takashi