selftests/filesystems/binderfs: Skip tests if user namespaces are unavailable
PATCH 1/1 selftests/filesystems/binderfs: Skip tests if user namespaces are unavailable
The binderfs selftests, specifically binderfs_stress and binderfs_test_unprivileged, depend on user namespaces to run.
On kernels built without user namespace support (CONFIG_USER_NS=n), these tests will fail.
To prevent these failures, add a check for the availability of user namespaces by testing for the existence of "/proc/self/ns/user". If the check fails, skip the tests and print an informative message.
--- .../selftests/filesystems/binderfs/binderfs_test.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
tools/testing/selftests/filesystems/binderfs/binderfs_test.c +10 -0
@@ -291,6 +291,11 @@ static int write_id_mapping(enum idmap_type type, pid_t pid, const char *buf,return 0 ; } +static bool has_userns (void ) +{ +return (access ("/proc/self/ns/user" ,F_OK ) ==0 ); +} +static void change_userns (struct __test_metadata *_metadata,int syncfds[2 ]) {int ret;
@@ -378,6 +383,9 @@ static void *binder_version_thread(void *data)*/ TEST (binderfs_stress) { +if (!has_userns ()) +SKIP (return,"%s: user namespace not supported\n" , __func__); +int fds[1000 ];int syncfds[2 ];pid_t pid;
@@ -502,6 +510,8 @@ TEST(binderfs_test_privileged)TEST (binderfs_test_unprivileged) { +if (!has_userns ()) +SKIP (return,"%s: user namespace not supported\n" , __func__);int ret;int syncfds[2 ];pid_t pid;
Signature · 1 line
2.50.1.703.g449372360f-goog
Shuah Khan
maintainerQuoted 5 lines · Wake Liu
The binderfs selftests, specifically
binderfs_stressandbinderfs_test_unprivileged, depend on user namespaces to run.On kernels built without user namespace support (
CONFIG_USER_NS=n), these tests will fail.
Why not add CONFIG_USER_NS to config file instead to indicate the dependency.
tools/testing/selftests/filesystems/binderfs/config which has these as dependencies at the moment.
CONFIG_ANDROID_BINDERFS=yCONFIG_ANDROID_BINDER_IPC=y
Quoted 4 lines
To prevent these failures, add a check for the availability of user namespaces by testing for the existence of "
/proc/self/ns/user". If the check fails, skip the tests and print an informative message.]
Can you try adding the dependency first?
thanks,
-- Shuah
PATCH v2 1/1 selftests/binderfs: Add CONFIG_USER_NS dependency
The binderfs selftests, specifically binderfs_stress and binderfs_test_unprivileged, depend on user namespaces to run.
On kernels built without user namespace support (CONFIG_USER_NS=n), these tests will fail.
Instead of adding a runtime check, indicate the dependency on CONFIG_USER_NS in the selftest config file. This allows the test runner to skip the tests if the required config is not enabled.
---
V1 -> V2: Use selftest config to declare dependency instead of a runtime check.
--- tools/testing/selftests/filesystems/binderfs/config | 1 + 1 file changed, 1 insertion(+)
tools/testing/selftests/filesystems/binderfs/config +1 -0
@@ -1,2 +1,3 @@ CONFIG_ANDROID_BINDERFS=y CONFIG_ANDROID_BINDER_IPC=y +CONFIG_USER_NS=y
Signature · 1 line
2.50.1.703.g449372360f-goog