0/3] Add SNVS clock gating and clock support to rtc-snvs driver

This patch adds support for clock gating of
the SNVS peripheral.

Signed-off-by Sanchayan Maity <[email protected]>

---
 arch/arm/mach-imx/clk-vf610.c           |    1 +
 include/dt-bindings/clock/vf610-clock.h |    3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

arch/arm/mach-imx/clk-vf610.c +0 -0

index 5937dde..bbf4785 100644

arch/arm/mach-imx/clk-vf610.c +0 -0

 	imx_check_clocks(clk, ARRAY_SIZE(clk));
 

include/dt-bindings/clock/vf610-clock.h +2 -1

index 801c0ac..979d24a 100644
@@ -192,6 +192,7 @@
 #define VF610_PLL5_BYPASS		179
 #define VF610_PLL6_BYPASS		180
 #define VF610_PLL7_BYPASS		181
-#define VF610_CLK_END			182
+#define VF610_CLK_SNVS			182
+#define VF610_CLK_END			183
 
 #endif /* __DT_BINDINGS_CLOCK_VF610_H */

Signature · 1 line

1.7.9.5

Quoted 14 lines · Sanchayan Maity

This patch adds support for clock gating of
the SNVS peripheral.

Signed-off-by Sanchayan Maity <[email protected]>

---
 arch/arm/mach-imx/clk-vf610.c           |    1 +
 include/dt-bindings/clock/vf610-clock.h |    3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

arch/arm/mach-imx/clk-vf610.c +0 -0

index 5937dde..bbf4785 100644

arch/arm/mach-imx/clk-vf610.c static void __init vf610_clocks_init(struct device_node *ccm_node) · line 382

Quoted 4 lines

arch/arm/mach-imx/clk-vf610.c +1 -0

@@ -379,6 +379,7 @@ static void __init vf610_clocks_init(struct device_node *ccm_node)
 	clk[VF610_CLK_DMAMUX1] = imx_clk_gate2("dmamux1", "platform_bus", CCM_CCGR0, CCM_CCGRx_CGn(5));
 	clk[VF610_CLK_DMAMUX2] = imx_clk_gate2("dmamux2", "platform_bus", CCM_CCGR6, CCM_CCGRx_CGn(1));
 	clk[VF610_CLK_DMAMUX3] = imx_clk_gate2("dmamux3", "platform_bus", CCM_CCGR6, CCM_CCGRx_CGn(2));
+	clk[VF610_CLK_SNVS] = imx_clk_gate2("snvs-rtc", "ipg_bus", CCM_CCGR6, CCM_CCGRx_CGn(7));

Stefan,

Would you confirm this register bits is the gating for SNVS clock? I cannot find it in my Vybrid Reference Manual.

Quoted 19 lines

arch/arm/mach-imx/clk-vf610.c +0 -0

 	imx_check_clocks(clk, ARRAY_SIZE(clk));
 

include/dt-bindings/clock/vf610-clock.h +2 -2

index 801c0ac..979d24a 100644
@@ -192,6 +192,7 @@
 #define VF610_PLL5_BYPASS		179
 #define VF610_PLL6_BYPASS		180
 #define VF610_PLL7_BYPASS		181
-#define VF610_CLK_END			182
+#define VF610_CLK_SNVS			182
+#define VF610_CLK_END			183
 
 #endif /* __DT_BINDINGS_CLOCK_VF610_H */
--

1.7.9.5

This patch adds support for clock gating of
the SNVS peripheral.

Signed-off-by Sanchayan Maity <[email protected]>

---
 arch/arm/mach-imx/clk-vf610.c           |    1 +
 include/dt-bindings/clock/vf610-clock.h |    3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

arch/arm/mach-imx/clk-vf610.c +0 -0

index 5937dde..bbf4785 100644
@@ -379,6 +379,7 @@ static void __init vf610_clocks_init(struct
 device_node *ccm_node)
 	clk[VF610_CLK_DMAMUX1] = imx_clk_gate2("dmamux1", "platform_bus",
 CCM_CCGR0, CCM_CCGRx_CGn(5));
 	clk[VF610_CLK_DMAMUX2] = imx_clk_gate2("dmamux2", "platform_bus",
 CCM_CCGR6, CCM_CCGRx_CGn(1));
 	clk[VF610_CLK_DMAMUX3] = imx_clk_gate2("dmamux3", "platform_bus",

CCM_CCGR6, CCM_CCGRx_CGn(2));

arch/arm/mach-imx/clk-vf610.c +1 -0

+	clk[VF610_CLK_SNVS] = imx_clk_gate2("snvs-rtc", "ipg_bus",

CCM_CCGR6, CCM_CCGRx_CGn(7));

arch/arm/mach-imx/clk-vf610.c +0 -0

 	imx_check_clocks(clk, ARRAY_SIZE(clk));

include/dt-bindings/clock/vf610-clock.h +0 -0

index 801c0ac..979d24a 100644

This patch adds a devicetree node for the Secure Non-Volatile Storage (SNVS) on the VF610 platform. The SNVS block also has a Real Time Counter (RTC).

Signed-off-by Sanchayan Maity <[email protected]>

---
 arch/arm/boot/dts/vfxxx.dtsi |   15 +++++++++++++++
 1 file changed, 15 insertions(+)

arch/arm/boot/dts/vfxxx.dtsi +0 -0

index 4e70833..bc131b0 100644
@@ -338,6 +338,21 @@
 				status = "disabled";
 			};
 

arch/arm/boot/dts/vfxxx.dtsi +5 -0

+					clocks = <&clks VF610_CLK_SNVS>;
+					clock-names = "snvs-rtc";
+				};
+			};
+
 			uart4: serial@400a9000 {
 				compatible = "fsl,vf610-lpuart";
 				reg = <0x400a9000 0x1000>;

Quoted 17 lines · Sanchayan Maity

This patch adds a devicetree node for the Secure Non-Volatile Storage (SNVS) on the VF610 platform. The SNVS block also has a Real Time Counter (RTC).

Signed-off-by Sanchayan Maity <[email protected]>

---
 arch/arm/boot/dts/vfxxx.dtsi |   15 +++++++++++++++
 1 file changed, 15 insertions(+)

arch/arm/boot/dts/vfxxx.dtsi +0 -0

index 4e70833..bc131b0 100644
@@ -338,6 +338,21 @@
 				status = "disabled";
 			};
 

arch/arm/boot/dts/vfxxx.dtsi line 350

Quoted 10 lines

arch/arm/boot/dts/vfxxx.dtsi +10 -0

+			snvs0: snvs at 400a7000 {
+				compatible = "fsl,sec-v4.0-mon", "simple-bus";
+				#address-cells = <1>;
+				#size-cells = <1>;
+				ranges = <0 0x400a7000 0x2000>;
+
+				snvs-rtc-lp at 34 {
+					compatible = "fsl,sec-v4.0-mon-rtc-lp";
+					reg = <0x34 0x58>;
+					interrupts = <0 100 IRQ_TYPE_LEVEL_HIGH>;

With the new device tree structure, the interrupt field needs to be part of the vf500.dtsi now. The vfxxx.dtsi will be the parent also for the Cortex-M4 device tree, which uses a different interrupt controller.

While at it, use the GIC_SPI macro for the first cell (so this will be blend into the other interrupt definitions).

arch/arm/boot/dts/vfxxx.dtsi line 358

Quoted 9 lines

arch/arm/boot/dts/vfxxx.dtsi +5 -0

+					clocks = <&clks VF610_CLK_SNVS>;
+					clock-names = "snvs-rtc";
+				};
+			};
+
 			uart4: serial at 400a9000 {
 				compatible = "fsl,vf610-lpuart";
 				reg = <0x400a9000 0x1000>;

This patch adds clock enable and disable support for the SNVS peripheral, which is required for using the RTC within the SNVS block.

Signed-off-by Sanchayan Maity <[email protected]>

---
 drivers/rtc/rtc-snvs.c |   34 ++++++++++++++++++++++++++++++++--
 1 file changed, 32 insertions(+), 2 deletions(-)

drivers/rtc/rtc-snvs.c +32 -2

index fa384fe..d4a6512 100644
@@ -17,6 +17,7 @@
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/rtc.h>
+#include <linux/clk.h>
 
 /* These register offsets are relative to LP (Low Power) range */
 #define SNVS_LPCR		0x04

@@ -39,6 +40,7 @@ struct snvs_rtc_data {
 	void __iomem *ioaddr;
 	int irq;
 	spinlock_t lock;
+	struct clk *clk;
 };
 
 static u32 rtc_read_lp_counter(void __iomem *ioaddr)

@@ -260,6 +262,18 @@ static int snvs_rtc_probe(struct platform_device *pdev)
 	if (data->irq < 0)
 		return data->irq;
 
+	data->clk = devm_clk_get(&pdev->dev, "snvs-rtc");
+	if (IS_ERR(data->clk)) {
+		data->clk = NULL;
+	} else {
+		ret = clk_prepare_enable(data->clk);
+		if (ret) {
+			dev_err(&pdev->dev,
+				"Could not prepare or enable the snvs clock\n");
+			return ret;
+		}
+	}
+
 	platform_set_drvdata(pdev, data);
 
 	spin_lock_init(&data->lock);

@@ -280,7 +294,7 @@ static int snvs_rtc_probe(struct platform_device *pdev)
 	if (ret) {
 		dev_err(&pdev->dev, "failed to request irq %d: %d\n",
 			data->irq, ret);
-		return ret;
+		goto error_rtc_device_register;
 	}
 
 	data->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,

@@ -288,10 +302,16 @@ static int snvs_rtc_probe(struct platform_device *pdev)
 	if (IS_ERR(data->rtc)) {
 		ret = PTR_ERR(data->rtc);
 		dev_err(&pdev->dev, "failed to register rtc: %d\n", ret);
-		return ret;
+		goto error_rtc_device_register;
 	}
 
 	return 0;
+
+error_rtc_device_register:
+	if (data->clk)
+		clk_disable_unprepare(data->clk);
+
+	return ret;
 }
 
 #ifdef CONFIG_PM_SLEEP

@@ -302,16 +322,26 @@ static int snvs_rtc_suspend(struct device *dev)
 	if (device_may_wakeup(dev))
 		enable_irq_wake(data->irq);
 
+	if (data->clk)
+		clk_disable_unprepare(data->clk);
+
 	return 0;
 }
 
 static int snvs_rtc_resume(struct device *dev)
 {
 	struct snvs_rtc_data *data = dev_get_drvdata(dev);
+	int ret;
 
 	if (device_may_wakeup(dev))
 		disable_irq_wake(data->irq);
 
+	if (data->clk) {
+		ret = clk_prepare_enable(data->clk);
+		if (ret)
+			return ret;
+	}
+
 	return 0;
 }
 #endif

Quoted 3 lines · Sanchayan Maity

This patch adds clock enable and disable support for the SNVS peripheral, which is required for using the RTC within the SNVS block.

What happens if the device tree node is there while this patch is not applied? I guess the driver would load, but since the clocks of the peripheral are not enabled the first register access would lead to bus error or similar. If this is the case, this would break bisectability. You should move the device tree patch to the end.

Other than that

Acked-by Stefan Agner <[email protected]>

--
Stefan

Quoted 99 lines

Signed-off-by Sanchayan Maity <[email protected]>

---
 drivers/rtc/rtc-snvs.c |   34 ++++++++++++++++++++++++++++++++--
 1 file changed, 32 insertions(+), 2 deletions(-)

drivers/rtc/rtc-snvs.c +32 -2

index fa384fe..d4a6512 100644
@@ -17,6 +17,7 @@
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/rtc.h>
+#include <linux/clk.h>
 
 /* These register offsets are relative to LP (Low Power) range */
 #define SNVS_LPCR		0x04

@@ -39,6 +40,7 @@ struct snvs_rtc_data {
 	void __iomem *ioaddr;
 	int irq;
 	spinlock_t lock;
+	struct clk *clk;
 };
 
 static u32 rtc_read_lp_counter(void __iomem *ioaddr)

@@ -260,6 +262,18 @@ static int snvs_rtc_probe(struct platform_device *pdev)
 	if (data->irq < 0)
 		return data->irq;
 
+	data->clk = devm_clk_get(&pdev->dev, "snvs-rtc");
+	if (IS_ERR(data->clk)) {
+		data->clk = NULL;
+	} else {
+		ret = clk_prepare_enable(data->clk);
+		if (ret) {
+			dev_err(&pdev->dev,
+				"Could not prepare or enable the snvs clock\n");
+			return ret;
+		}
+	}
+
 	platform_set_drvdata(pdev, data);
 
 	spin_lock_init(&data->lock);

@@ -280,7 +294,7 @@ static int snvs_rtc_probe(struct platform_device *pdev)
 	if (ret) {
 		dev_err(&pdev->dev, "failed to request irq %d: %d\n",
 			data->irq, ret);
-		return ret;
+		goto error_rtc_device_register;
 	}
 
 	data->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,

@@ -288,10 +302,16 @@ static int snvs_rtc_probe(struct platform_device *pdev)
 	if (IS_ERR(data->rtc)) {
 		ret = PTR_ERR(data->rtc);
 		dev_err(&pdev->dev, "failed to register rtc: %d\n", ret);
-		return ret;
+		goto error_rtc_device_register;
 	}
 
 	return 0;
+
+error_rtc_device_register:
+	if (data->clk)
+		clk_disable_unprepare(data->clk);
+
+	return ret;
 }
 
 #ifdef CONFIG_PM_SLEEP

@@ -302,16 +322,26 @@ static int snvs_rtc_suspend(struct device *dev)
 	if (device_may_wakeup(dev))
 		enable_irq_wake(data->irq);
 
+	if (data->clk)
+		clk_disable_unprepare(data->clk);
+
 	return 0;
 }
 
 static int snvs_rtc_resume(struct device *dev)
 {
 	struct snvs_rtc_data *data = dev_get_drvdata(dev);
+	int ret;
 
 	if (device_may_wakeup(dev))
 		disable_irq_wake(data->irq);
 
+	if (data->clk) {
+		ret = clk_prepare_enable(data->clk);
+		if (ret)
+			return ret;
+	}
+
 	return 0;
 }
 #endif

Quoted 11 lines · Stefan Agner

Quoted 3 lines · Sanchayan Maity

This patch adds clock enable and disable support for the SNVS peripheral, which is required for using the RTC within the SNVS block.

What happens if the device tree node is there while this patch is not applied? I guess the driver would load, but since the clocks of the peripheral are not enabled the first register access would lead to bus error or similar. If this is the case, this would break bisectability. You should move the device tree patch to the end.

If the DT node was present with this patch not applied, the driver would still crash with a bus error, since the clocks for SNVS are not explicitly enabled anywhere else. I had not thought about any problems which might occur later with git bisect. Will move this to the end with v3.

Thanks.

Regards,
Sanchayan.

Quoted 106 lines

Other than that

Acked-by Stefan Agner <[email protected]>

--
Stefan

Quoted 99 lines

Signed-off-by Sanchayan Maity <[email protected]>

---
 drivers/rtc/rtc-snvs.c |   34 ++++++++++++++++++++++++++++++++--
 1 file changed, 32 insertions(+), 2 deletions(-)

drivers/rtc/rtc-snvs.c +32 -2

index fa384fe..d4a6512 100644
@@ -17,6 +17,7 @@
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/rtc.h>
+#include <linux/clk.h>
 
 /* These register offsets are relative to LP (Low Power) range */
 #define SNVS_LPCR		0x04

@@ -39,6 +40,7 @@ struct snvs_rtc_data {
 	void __iomem *ioaddr;
 	int irq;
 	spinlock_t lock;
+	struct clk *clk;
 };
 
 static u32 rtc_read_lp_counter(void __iomem *ioaddr)

@@ -260,6 +262,18 @@ static int snvs_rtc_probe(struct platform_device *pdev)
 	if (data->irq < 0)
 		return data->irq;
 
+	data->clk = devm_clk_get(&pdev->dev, "snvs-rtc");
+	if (IS_ERR(data->clk)) {
+		data->clk = NULL;
+	} else {
+		ret = clk_prepare_enable(data->clk);
+		if (ret) {
+			dev_err(&pdev->dev,
+				"Could not prepare or enable the snvs clock\n");
+			return ret;
+		}
+	}
+
 	platform_set_drvdata(pdev, data);
 
 	spin_lock_init(&data->lock);

@@ -280,7 +294,7 @@ static int snvs_rtc_probe(struct platform_device *pdev)
 	if (ret) {
 		dev_err(&pdev->dev, "failed to request irq %d: %d\n",
 			data->irq, ret);
-		return ret;
+		goto error_rtc_device_register;
 	}
 
 	data->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,

@@ -288,10 +302,16 @@ static int snvs_rtc_probe(struct platform_device *pdev)
 	if (IS_ERR(data->rtc)) {
 		ret = PTR_ERR(data->rtc);
 		dev_err(&pdev->dev, "failed to register rtc: %d\n", ret);
-		return ret;
+		goto error_rtc_device_register;
 	}
 
 	return 0;
+
+error_rtc_device_register:
+	if (data->clk)
+		clk_disable_unprepare(data->clk);
+
+	return ret;
 }
 
 #ifdef CONFIG_PM_SLEEP

@@ -302,16 +322,26 @@ static int snvs_rtc_suspend(struct device *dev)
 	if (device_may_wakeup(dev))
 		enable_irq_wake(data->irq);
 
+	if (data->clk)
+		clk_disable_unprepare(data->clk);
+
 	return 0;
 }
 
 static int snvs_rtc_resume(struct device *dev)
 {
 	struct snvs_rtc_data *data = dev_get_drvdata(dev);
+	int ret;
 
 	if (device_may_wakeup(dev))
 		disable_irq_wake(data->irq);
 
+	if (data->clk) {
+		ret = clk_prepare_enable(data->clk);
+		if (ret)
+			return ret;
+	}
+
 	return 0;
 }
 #endif

Quoted 13 lines · Sanchayan Maity

Quoted 11 lines · Stefan Agner

Quoted 3 lines · Sanchayan Maity

This patch adds clock enable and disable support for the SNVS peripheral, which is required for using the RTC within the SNVS block.

What happens if the device tree node is there while this patch is not applied? I guess the driver would load, but since the clocks of the peripheral are not enabled the first register access would lead to bus error or similar. If this is the case, this would break bisectability. You should move the device tree patch to the end.

Quoted 4 lines

If the DT node was present with this patch not applied, the driver would still crash with a bus error, since the clocks for SNVS are not explicitly enabled anywhere else. I had not thought about any problems which might occur later with git bisect. Will move this to the end with v3.

Since changes on rtc-snvs.c will need to go through RTC subsystem tree, that means I cannot apply DTS changes until the driver patch gets mainlined and appears on my tree.

Shawn

Quoted 113 lines

Thanks.

Regards,
Sanchayan.

Quoted 106 lines

Other than that

Acked-by Stefan Agner <[email protected]>

--
Stefan

Quoted 99 lines

Signed-off-by Sanchayan Maity <[email protected]>

---
 drivers/rtc/rtc-snvs.c |   34 ++++++++++++++++++++++++++++++++--
 1 file changed, 32 insertions(+), 2 deletions(-)

drivers/rtc/rtc-snvs.c +32 -2

index fa384fe..d4a6512 100644
@@ -17,6 +17,7 @@
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/rtc.h>
+#include <linux/clk.h>
 
 /* These register offsets are relative to LP (Low Power) range */
 #define SNVS_LPCR		0x04

@@ -39,6 +40,7 @@ struct snvs_rtc_data {
 	void __iomem *ioaddr;
 	int irq;
 	spinlock_t lock;
+	struct clk *clk;
 };
 
 static u32 rtc_read_lp_counter(void __iomem *ioaddr)

@@ -260,6 +262,18 @@ static int snvs_rtc_probe(struct platform_device *pdev)
 	if (data->irq < 0)
 		return data->irq;
 
+	data->clk = devm_clk_get(&pdev->dev, "snvs-rtc");
+	if (IS_ERR(data->clk)) {
+		data->clk = NULL;
+	} else {
+		ret = clk_prepare_enable(data->clk);
+		if (ret) {
+			dev_err(&pdev->dev,
+				"Could not prepare or enable the snvs clock\n");
+			return ret;
+		}
+	}
+
 	platform_set_drvdata(pdev, data);
 
 	spin_lock_init(&data->lock);

@@ -280,7 +294,7 @@ static int snvs_rtc_probe(struct platform_device *pdev)
 	if (ret) {
 		dev_err(&pdev->dev, "failed to request irq %d: %d\n",
 			data->irq, ret);
-		return ret;
+		goto error_rtc_device_register;
 	}
 
 	data->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,

@@ -288,10 +302,16 @@ static int snvs_rtc_probe(struct platform_device *pdev)
 	if (IS_ERR(data->rtc)) {
 		ret = PTR_ERR(data->rtc);
 		dev_err(&pdev->dev, "failed to register rtc: %d\n", ret);
-		return ret;
+		goto error_rtc_device_register;
 	}
 
 	return 0;
+
+error_rtc_device_register:
+	if (data->clk)
+		clk_disable_unprepare(data->clk);
+
+	return ret;
 }
 
 #ifdef CONFIG_PM_SLEEP

@@ -302,16 +322,26 @@ static int snvs_rtc_suspend(struct device *dev)
 	if (device_may_wakeup(dev))
 		enable_irq_wake(data->irq);
 
+	if (data->clk)
+		clk_disable_unprepare(data->clk);
+
 	return 0;
 }
 
 static int snvs_rtc_resume(struct device *dev)
 {
 	struct snvs_rtc_data *data = dev_get_drvdata(dev);
+	int ret;
 
 	if (device_may_wakeup(dev))
 		disable_irq_wake(data->irq);
 
+	if (data->clk) {
+		ret = clk_prepare_enable(data->clk);
+		if (ret)
+			return ret;
+	}
+
 	return 0;
 }
 #endif

Quoted 23 lines · Shawn Guo

Quoted 13 lines · Sanchayan Maity

Quoted 11 lines · Stefan Agner

Quoted 3 lines · Sanchayan Maity

This patch adds clock enable and disable support for the SNVS peripheral, which is required for using the RTC within the SNVS block.

What happens if the device tree node is there while this patch is not applied? I guess the driver would load, but since the clocks of the peripheral are not enabled the first register access would lead to bus error or similar. If this is the case, this would break bisectability. You should move the device tree patch to the end.

Quoted 4 lines

If the DT node was present with this patch not applied, the driver would still crash with a bus error, since the clocks for SNVS are not explicitly enabled anywhere else. I had not thought about any problems which might occur later with git bisect. Will move this to the end with v3.

Since changes on rtc-snvs.c will need to go through RTC subsystem tree, that means I cannot apply DTS changes until the driver patch gets mainlined and appears on my tree.

Quoted 1 line

Shawn

Shawn

So the approach in this patch is OK and acceptable?

Since the DT changes cannot be applied by you, till this goes through the RTC subsystem tree, gets mainlined and appears on your tree, I will send out this patch by itself then and send the DT changes later once this gets mainlined?

I did not CC Alessandro Zummo, the maintainer of RTC subsystem by mistake. Once you ACK/OK this i will send out this patch in isolation then or just CC Alessandro Zummo.

Quoted 26 lines · Sanchayan Maity

Quoted 24 lines · Shawn Guo

Quoted 13 lines · Sanchayan Maity

Quoted 11 lines · Stefan Agner

Quoted 3 lines · Sanchayan Maity

This patch adds clock enable and disable support for the SNVS peripheral, which is required for using the RTC within the SNVS block.

What happens if the device tree node is there while this patch is not applied? I guess the driver would load, but since the clocks of the peripheral are not enabled the first register access would lead to bus error or similar. If this is the case, this would break bisectability. You should move the device tree patch to the end.

Quoted 4 lines

If the DT node was present with this patch not applied, the driver would still crash with a bus error, since the clocks for SNVS are not explicitly enabled anywhere else. I had not thought about any problems which might occur later with git bisect. Will move this to the end with v3.

Since changes on rtc-snvs.c will need to go through RTC subsystem tree, that means I cannot apply DTS changes until the driver patch gets mainlined and appears on my tree.

Shawn

Quoted 3 lines

Shawn

So the approach in this patch is OK and acceptable?

Yes, I'm fine with it.

Shawn

Quoted 10 lines

Since the DT changes cannot be applied by you, till this goes through the RTC subsystem tree, gets mainlined and appears on your tree, I will send out this patch by itself then and send the DT changes later once this gets mainlined?

I did not CC Alessandro Zummo, the maintainer of RTC subsystem by mistake. Once you ACK/OK this i will send out this patch in isolation then or just CC Alessandro Zummo.

Quoted 27 lines · Shawn Guo

Quoted 26 lines · Sanchayan Maity

Quoted 24 lines · Shawn Guo

Quoted 13 lines · Sanchayan Maity

Quoted 11 lines · Stefan Agner

Quoted 3 lines · Sanchayan Maity

This patch adds clock enable and disable support for the SNVS peripheral, which is required for using the RTC within the SNVS block.

What happens if the device tree node is there while this patch is not applied? I guess the driver would load, but since the clocks of the peripheral are not enabled the first register access would lead to bus error or similar. If this is the case, this would break bisectability. You should move the device tree patch to the end.

Quoted 4 lines

If the DT node was present with this patch not applied, the driver would still crash with a bus error, since the clocks for SNVS are not explicitly enabled anywhere else. I had not thought about any problems which might occur later with git bisect. Will move this to the end with v3.

Since changes on rtc-snvs.c will need to go through RTC subsystem tree, that means I cannot apply DTS changes until the driver patch gets mainlined and appears on my tree.

Shawn

Quoted 7 lines

Quoted 3 lines

Shawn

So the approach in this patch is OK and acceptable?

Yes, I'm fine with it.

Shawn

Hello Alessandro,

Sorry I missed adding you while sending this patch set.

Can you take this third patch, in this series through your RTC subsytem tree? Or should I resend this third patch separately?

Regards,
Sanchayan.

Quoted 10 lines

Quoted 10 lines

Since the DT changes cannot be applied by you, till this goes through the RTC subsystem tree, gets mainlined and appears on your tree, I will send out this patch by itself then and send the DT changes later once this gets mainlined?

I did not CC Alessandro Zummo, the maintainer of RTC subsystem by mistake. Once you ACK/OK this i will send out this patch in isolation then or just CC Alessandro Zummo.