Add Display Support for Qualcomm SDM845
Hi dri-devel,
Qualcomm has been working for the past few weeks on forward porting their downstream drm driver from 4.14 to mainline. Please consider this PR as a request for review, rather than an attempt at mainlining the code as it currently stands. The goal is get this driver in shape over the next coming months.
In the meantime, I'll be hosting a tree here [1] to stage the fixes. Patches will be posted and reviewed on [email protected]. Once things look good, I'll send another pull 4realz.
To get the ball rolling, I've done some review on the new connector code, my comments are below.
Thanks in advance for your constructive feedback :)
Sean
[1]- git://people.freedesktop.org/~seanpaul/dpu-staging
Review feedback:
----------------
- Solve the splash screen handling (or remove it)
- Simplify devicetree binding (remove register offsets)
feedback from reviewing sde_connector.c:
- Rationalize backlight implementation in sde_connector (display_count static)
- Sort out the dsi event passing between dsi/encoder/connector (move to encoder)
- include/uapi/drm/msm_drm_pp.h needs opensource userspace (or removal)
- connector->state access violations reading/writing mode_info
- s/sde_rect/drm_rect/
- sde_kms_info usage needs to be replaced with formal data structures (not stringified keypairs)
- sde_connector_ops needs to be trimmed, duplicates connector helpers, info hooks circumvent state, and other hooks should be stored in state or prepopulated (get_dst_format)
- sde_connector_get_dpms unused
- esd status check should migrate to encoder from connector
- backlight should be handled in panel drivers, not in the generic connector/dsi encoder
- sde_connector_helper_bridge_disable is called from encoder and calls back into set_power encoder function. if backlight, and esd status are removed, pre_kickoff can probably go away
- sde_connector_clk_ctrl is another example of encoder->connector->encoder call
- RETIRE_FENCE connector property should be removed, opting for the native atomic fences
- ROI (regions of interest) should be expressed per-plane instead of connector. there is work ongoing to support dirty_rects per-plane by Deepak Singh Rawat <[email protected]> and Lukasz Spintzyk <[email protected]>
- Uma Shankar <[email protected]> has proposed HDR source metadata properties on the list, we should pivot to those instead of hand-rolling them in the sde driver
- Convert HDCP implementation to upstream Content Protection property
- Merge dsi and dsi_staging into one driver
- Writeback connector has been proposed by ARM (Liviu Dudau and Brian Starkey), we should work with their proposal instead of rolling OUT_FB ourselves
- sde_connector_set_property should be replaced with atomic helper
- dsi hotplug can probably be punted to the panel driver
- dpms should switch to enable/disable (or at least use the atomic helpers)
- dsi mode handling should also defer to the panel driver
- SDE_WB_CONFIG ioctl should be removed in favor of the existing ioctl to add user-defined modes
- dp implementation should use the existing dp helpers wherever possible
- lots of duplicated structures in dsi_defs.h that can be replaced with existing drm structs
- mode_valid should be split up and implemented directly in connector/encoder as appropriate
- sde_connector->aspace seems like it's unused?
The following changes since commit 9afe236df559d0dc6818f64e728a3f931a0a2231:
drm/msm/dsi: Fix potential NULL pointer dereference in msm_dsi_modeset_init (2018-02-12 10:25:15 -0500)
are available in the Git repository at:
git://people.freedesktop.org/~seanpaul/dpu-staging for-next-compiles
for you to fetch changes up to 672005da148f82021a62d4fa658728e19f13097e:
ARM: dts: msm: add device tree changes for SDM845 (2018-02-13 13:14:43 -0500)
----------------------------------------------------------------
Jeykumar Sankaran (9):
dt-bindings: msm/dsi: Add mdp transfer time to msm dsi binding
dt-bindings: msm/disp: Add bindings for Snapdragon 845 DPU
drm: Core changes
drm/msm: add DPU DRM driver to support SDM845 drm/msm: Change mdp_get_format arguments
drm/msm: Core msm changes
drm/msm: Add DSI Staging driver
drm/msm: Add DisplayPort support
ARM: dts: msm: add device tree changes for SDM845
Manasi Navare (1):
drm/dp: Add HBR3 support in existing DRM DP helpers
Rob Clark (1):
drm/msm: rename mdp->disp
.../devicetree/bindings/display/msm/dpu-rsc.txt | 96 +
.../devicetree/bindings/display/msm/dpu.txt | 736 +++
.../devicetree/bindings/display/msm/dsi.txt | 16 +
.../devicetree/bindings/drm/msm/dpu-dp.txt | 217 +
.../devicetree/bindings/drm/msm/dpu-dsi.txt | 102 +
.../devicetree/bindings/drm/msm/dpu-wb.txt | 23 +
.../devicetree/bindings/drm/msm/mdss-dsi-panel.txt | 772 +++
.../devicetree/bindings/fb/mdss-dsi-panel.txt | 742 +++
Documentation/devicetree/bindings/fb/mdss-pll.txt | 103 +
.../devicetree/bindings/msm_hdcp/msm_hdcp.txt | 14 +
arch/arm64/boot/dts/qcom/sdm845-dpu-display.dtsi | 248 +
arch/arm64/boot/dts/qcom/sdm845-dpu.dtsi | 541 +++
drivers/clk/qcom/mdss/mdss-pll.h | 240 +
drivers/gpu/drm/drm_dp_helper.c | 4 +
drivers/gpu/drm/drm_dp_mst_topology.c | 3 +
drivers/gpu/drm/drm_edid.c | 77 +
drivers/gpu/drm/drm_framebuffer.c | 3 +-
drivers/gpu/drm/drm_mipi_dsi.c | 12 +-
drivers/gpu/drm/msm/Makefile | 98 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h | 99 +
.../gpu/drm/msm/disp/dpu1/dpu_color_processing.c | 1520 ++++++
.../gpu/drm/msm/disp/dpu1/dpu_color_processing.h | 120 +
drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c | 1381 ++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_connector.h | 581 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 640 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 192 +
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 818 ++++
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 144 +
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5076 ++++++++++++++++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 661 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3838 +++++++++++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 220 +
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 561 +++
.../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 1365 ++++++
.../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 1045 ++++
.../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 1369 ++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_fence.c | 404 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_fence.h | 190 +
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 1339 ++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 152 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c | 1443 ++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 155 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h | 53 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3287 +++++++++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1050 ++++
.../gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 182 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c | 329 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.h | 139 +
.../msm/disp/dpu1/dpu_hw_color_proc_common_v4.h | 69 +
.../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c | 242 +
.../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h | 40 +
.../drm/msm/disp/dpu1/dpu_hw_color_processing.h | 20 +
.../msm/disp/dpu1/dpu_hw_color_processing_v1_7.c | 565 +++
.../msm/disp/dpu1/dpu_hw_color_processing_v1_7.h | 92 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 657 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 275 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c | 149 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h | 111 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 252 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 100 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 209 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h | 220 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 1235 +++++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 289 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 373 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 132 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 331 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 136 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 538 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 409 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 182 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 759 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h | 27 +
.../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c | 943 ++++
.../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h | 75 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.c | 962 ++++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.h | 192 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 1063 ++++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 574 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 461 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 227 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 453 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 202 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c | 275 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h | 128 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 324 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.h | 187 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h | 60 +
drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c | 112 +
drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h | 59 +
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2099 ++++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 547 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c | 220 +
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4774 ++++++++++++++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 296 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c | 139 +
drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h | 310 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 1394 ++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 200 +
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 245 +
drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 385 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h | 94 +
drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c | 781 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_wb.h | 232 +
drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4.xml.h | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_crtc.c | 0
.../drm/msm/{mdp => disp}/mdp4/mdp4_dsi_encoder.c | 0
.../drm/msm/{mdp => disp}/mdp4/mdp4_dtv_encoder.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_irq.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.h | 2 +-
.../drm/msm/{mdp => disp}/mdp4/mdp4_lcdc_encoder.c | 0
.../msm/{mdp => disp}/mdp4/mdp4_lvds_connector.c | 0
.../gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lvds_pll.c | 0
.../gpu/drm/msm/{mdp => disp}/mdp4/mdp4_plane.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5.xml.h | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.h | 0
.../drm/msm/{mdp => disp}/mdp5/mdp5_cmd_encoder.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_crtc.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.h | 0
.../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_encoder.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_irq.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.h | 2 +-
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mdss.c | 0
.../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.c | 0
.../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.h | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.h | 0
.../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_plane.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.h | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp_common.xml.h | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp_format.c | 5 +-
drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.h | 2 +-
drivers/gpu/drm/msm/dp/dp_audio.c | 796 +++
drivers/gpu/drm/msm/dp/dp_audio.h | 81 +
drivers/gpu/drm/msm/dp/dp_aux.c | 570 +++
drivers/gpu/drm/msm/dp/dp_aux.h | 44 +
drivers/gpu/drm/msm/dp/dp_catalog.c | 1320 +++++
drivers/gpu/drm/msm/dp/dp_catalog.h | 163 +
drivers/gpu/drm/msm/dp/dp_ctrl.c | 1474 ++++++
drivers/gpu/drm/msm/dp/dp_ctrl.h | 50 +
drivers/gpu/drm/msm/dp/dp_debug.c | 503 ++
drivers/gpu/drm/msm/dp/dp_debug.h | 60 +
drivers/gpu/drm/msm/dp/dp_display.c | 1262 +++++
drivers/gpu/drm/msm/dp/dp_display.h | 52 +
drivers/gpu/drm/msm/dp/dp_drm.c | 538 +++
drivers/gpu/drm/msm/dp/dp_drm.h | 96 +
drivers/gpu/drm/msm/dp/dp_hdcp2p2.c | 927 ++++
drivers/gpu/drm/msm/dp/dp_link.c | 1548 ++++++
drivers/gpu/drm/msm/dp/dp_link.h | 184 +
drivers/gpu/drm/msm/dp/dp_panel.c | 531 ++
drivers/gpu/drm/msm/dp/dp_panel.h | 116 +
drivers/gpu/drm/msm/dp/dp_parser.c | 645 +++
drivers/gpu/drm/msm/dp/dp_parser.h | 200 +
drivers/gpu/drm/msm/dp/dp_power.c | 623 +++
drivers/gpu/drm/msm/dp/dp_power.h | 58 +
drivers/gpu/drm/msm/dp/dp_reg.h | 231 +
drivers/gpu/drm/msm/dp/dp_usbpd.c | 491 ++
drivers/gpu/drm/msm/dp/dp_usbpd.h | 101 +
drivers/gpu/drm/msm/dpu_dbg.c | 3325 +++++++++++++
drivers/gpu/drm/msm/dpu_dbg.h | 421 ++
drivers/gpu/drm/msm/dpu_dbg_evtlog.c | 306 ++
drivers/gpu/drm/msm/dpu_edid_parser.c | 657 +++
drivers/gpu/drm/msm/dpu_edid_parser.h | 166 +
drivers/gpu/drm/msm/dpu_hdcp.h | 74 +
drivers/gpu/drm/msm/dpu_hdcp_1x.c | 1579 ++++++
drivers/gpu/drm/msm/dpu_io_util.c | 507 ++
drivers/gpu/drm/msm/dpu_power_handle.c | 1128 +++++
drivers/gpu/drm/msm/dpu_power_handle.h | 334 ++
drivers/gpu/drm/msm/dpu_rsc.c | 1367 ++++++
drivers/gpu/drm/msm/dpu_rsc_hw.c | 818 ++++
drivers/gpu/drm/msm/dpu_rsc_priv.h | 191 +
drivers/gpu/drm/msm/dsi-staging/dsi_catalog.c | 241 +
drivers/gpu/drm/msm/dsi-staging/dsi_catalog.h | 201 +
drivers/gpu/drm/msm/dsi-staging/dsi_clk.h | 276 ++
drivers/gpu/drm/msm/dsi-staging/dsi_clk_manager.c | 1227 +++++
drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.c | 2862 +++++++++++
drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.h | 635 +++
drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw.h | 752 +++
drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_1_4.c | 480 ++
drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_0.c | 234 +
drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_2.c | 42 +
drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_cmn.c | 1312 +++++
drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_reg.h | 196 +
drivers/gpu/drm/msm/dsi-staging/dsi_defs.h | 581 +++
drivers/gpu/drm/msm/dsi-staging/dsi_display.c | 4325 +++++++++++++++++
drivers/gpu/drm/msm/dsi-staging/dsi_display.h | 557 +++
drivers/gpu/drm/msm/dsi-staging/dsi_display_test.c | 114 +
drivers/gpu/drm/msm/dsi-staging/dsi_display_test.h | 31 +
drivers/gpu/drm/msm/dsi-staging/dsi_drm.c | 708 +++
drivers/gpu/drm/msm/dsi-staging/dsi_drm.h | 129 +
drivers/gpu/drm/msm/dsi-staging/dsi_hw.h | 48 +
drivers/gpu/drm/msm/dsi-staging/dsi_panel.c | 3521 ++++++++++++++
drivers/gpu/drm/msm/dsi-staging/dsi_panel.h | 262 +
drivers/gpu/drm/msm/dsi-staging/dsi_phy.c | 935 ++++
drivers/gpu/drm/msm/dsi-staging/dsi_phy.h | 235 +
drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw.h | 260 +
drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v2_0.c | 252 +
drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v3_0.c | 447 ++
.../gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.c | 676 +++
.../gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.h | 144 +
.../gpu/drm/msm/dsi-staging/dsi_phy_timing_v2_0.c | 126 +
.../gpu/drm/msm/dsi-staging/dsi_phy_timing_v3_0.c | 107 +
drivers/gpu/drm/msm/dsi-staging/dsi_pwr.c | 365 ++
drivers/gpu/drm/msm/dsi-staging/dsi_pwr.h | 93 +
drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c | 26 +-
drivers/gpu/drm/msm/msm_atomic.c | 446 +-
drivers/gpu/drm/msm/msm_drv.c | 919 +++-
drivers/gpu/drm/msm/msm_drv.h | 486 +-
drivers/gpu/drm/msm/msm_fb.c | 10 +-
drivers/gpu/drm/msm/msm_kms.h | 90 +-
drivers/gpu/drm/msm/msm_prop.c | 688 +++
drivers/gpu/drm/msm/msm_prop.h | 438 ++
drivers/gpu/drm/msm/msm_rd.c | 58 +-
drivers/platform/msm/Kconfig | 21 +
drivers/platform/msm/Makefile | 4 +
drivers/platform/msm/msm_ext_display.c | 525 ++
include/drm/drm_connector.h | 19 +
include/drm/drm_dp_helper.h | 23 +
include/drm/drm_mipi_dsi.h | 4 +
include/drm/drm_mode_object.h | 2 +-
include/linux/dpu_io_util.h | 113 +
include/linux/dpu_rsc.h | 302 ++
include/linux/msm_ext_display.h | 182 +
include/uapi/drm/dpu_drm.h | 449 ++
include/uapi/drm/drm_fourcc.h | 32 +
include/uapi/drm/drm_mode.h | 5 +
include/uapi/drm/msm_drm.h | 79 +
include/uapi/drm/msm_drm_pp.h | 345 ++
include/uapi/media/msm_media_info.h | 1376 ++++++
include/video/mipi_display.h | 4 +
236 files changed, 110234 insertions(+), 159 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-rsc.txt
create mode 100644 Documentation/devicetree/bindings/display/msm/dpu.txt
create mode 100644 Documentation/devicetree/bindings/drm/msm/dpu-dp.txt
create mode 100644 Documentation/devicetree/bindings/drm/msm/dpu-dsi.txt
create mode 100644 Documentation/devicetree/bindings/drm/msm/dpu-wb.txt
create mode 100644 Documentation/devicetree/bindings/drm/msm/mdss-dsi-panel.txt
create mode 100644 Documentation/devicetree/bindings/fb/mdss-dsi-panel.txt
create mode 100644 Documentation/devicetree/bindings/fb/mdss-pll.txt
create mode 100644 Documentation/devicetree/bindings/msm_hdcp/msm_hdcp.txt
create mode 100644 arch/arm64/boot/dts/qcom/sdm845-dpu-display.dtsi
create mode 100644 arch/arm64/boot/dts/qcom/sdm845-dpu.dtsi
create mode 100644 drivers/clk/qcom/mdss/mdss-pll.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_connector.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_fence.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_fence.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_common_v4.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_wb.h
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4.xml.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_crtc.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_dsi_encoder.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_dtv_encoder.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_irq.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.h (99%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lcdc_encoder.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lvds_connector.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lvds_pll.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_plane.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5.xml.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cmd_encoder.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_crtc.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_encoder.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_irq.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.h (99%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mdss.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_plane.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp_common.xml.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp_format.c (98%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.h (99%)
create mode 100644 drivers/gpu/drm/msm/dp/dp_audio.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_audio.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_debug.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_debug.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_display.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_display.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_hdcp2p2.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_link.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_link.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_power.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_power.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_reg.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_usbpd.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_usbpd.h
create mode 100644 drivers/gpu/drm/msm/dpu_dbg.c
create mode 100644 drivers/gpu/drm/msm/dpu_dbg.h
create mode 100644 drivers/gpu/drm/msm/dpu_dbg_evtlog.c
create mode 100644 drivers/gpu/drm/msm/dpu_edid_parser.c
create mode 100644 drivers/gpu/drm/msm/dpu_edid_parser.h
create mode 100644 drivers/gpu/drm/msm/dpu_hdcp.h
create mode 100644 drivers/gpu/drm/msm/dpu_hdcp_1x.c
create mode 100644 drivers/gpu/drm/msm/dpu_io_util.c
create mode 100644 drivers/gpu/drm/msm/dpu_power_handle.c
create mode 100644 drivers/gpu/drm/msm/dpu_power_handle.h
create mode 100644 drivers/gpu/drm/msm/dpu_rsc.c
create mode 100644 drivers/gpu/drm/msm/dpu_rsc_hw.c
create mode 100644 drivers/gpu/drm/msm/dpu_rsc_priv.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_catalog.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_catalog.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_clk.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_clk_manager.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_1_4.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_0.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_2.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_cmn.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_reg.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_defs.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display_test.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display_test.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_drm.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_drm.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_hw.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_panel.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_panel.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v2_0.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v3_0.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_v2_0.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_v3_0.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_pwr.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_pwr.h
create mode 100644 drivers/gpu/drm/msm/msm_prop.c
create mode 100644 drivers/gpu/drm/msm/msm_prop.h
create mode 100644 drivers/platform/msm/Kconfig
create mode 100644 drivers/platform/msm/Makefile
create mode 100644 drivers/platform/msm/msm_ext_display.c
create mode 100644 include/linux/dpu_io_util.h
create mode 100644 include/linux/dpu_rsc.h
create mode 100644 include/linux/msm_ext_display.h
create mode 100644 include/uapi/drm/dpu_drm.h
create mode 100644 include/uapi/drm/msm_drm_pp.h
create mode 100644 include/uapi/media/msm_media_info.hSignature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 14 lines · Sean Paul
Hi dri-devel,
Qualcomm has been working for the past few weeks on forward porting their downstream drm driver from 4.14 to mainline. Please consider this PR as a request for review, rather than an attempt at mainlining the code as it currently stands. The goal is get this driver in shape over the next coming months.In the meantime, I'll be hosting a tree here [1] to stage the fixes. Patches will be posted and reviewed on [email protected]. Once things look good, I'll send another pull 4realz.
To get the ball rolling, I've done some review on the new connector code, my comments are below.
Quoted 8 lines
Thanks in advance for your constructive feedback :)
Sean
[1]-
git://people.freedesktop.org/~seanpaul/dpu-stagingReview feedback:
----------------
just so others aren't confused, s/sde/dpu/g in the list below (we did our DAL->DC rename before sending first RFC :-P)
Quoted 37 lines
- Solve the splash screen handling (or remove it)
- Simplify devicetree binding (remove register offsets)
feedback from reviewingsde_connector.c:
- Rationalize backlight implementation insde_connector(display_countstatic)
- Sort out the dsi event passing between dsi/encoder/connector (move to encoder)
-include/uapi/drm/msm_drm_pp.hneeds opensource userspace (or removal)
-connector->stateaccess violations reading/writingmode_info
- s/sde_rect/drm_rect/
-sde_kms_infousage needs to be replaced with formal data structures (not stringified keypairs)
-sde_connector_opsneeds to be trimmed, duplicates connector helpers, info hooks circumvent state, and other hooks should be stored in state or prepopulated (get_dst_format)
-sde_connector_get_dpmsunused
- esd status check should migrate to encoder from connector
- backlight should be handled in panel drivers, not in the generic connector/dsi encoder
-sde_connector_helper_bridge_disableis called from encoder and calls back intoset_powerencoder function. if backlight, and esd status are removed,pre_kickoffcan probably go away
-sde_connector_clk_ctrlis another example ofencoder->connector->encodercall
-RETIRE_FENCEconnector property should be removed, opting for the native atomic fences
- ROI (regions of interest) should be expressed per-plane instead of connector. there is work ongoing to supportdirty_rectsper-plane by Deepak Singh Rawat <[email protected]> and Lukasz Spintzyk <[email protected]>
- Uma Shankar <[email protected]> has proposed HDR source metadata properties on the list, we should pivot to those instead of hand-rolling them in the sde driver
- Convert HDCP implementation to upstream Content Protection property
- Merge dsi anddsi_staginginto one driver
- Writeback connector has been proposed by ARM (Liviu Dudau and Brian Starkey), we should work with their proposal instead of rollingOUT_FBourselves
-sde_connector_set_propertyshould be replaced with atomic helper
- dsi hotplug can probably be punted to the panel driver
- dpms should switch to enable/disable (or at least use the atomic helpers)
- dsi mode handling should also defer to the panel driver
Quoted 9 lines
-
SDE_WB_CONFIGioctl should be removed in favor of the existing ioctl to add user-defined modes
- dp implementation should use the existing dp helpers wherever possible
- lots of duplicated structures indsi_defs.hthat can be replaced with existing drm structs
-mode_validshould be split up and implemented directly in connector/encoder as appropriate
-sde_connector->aspaceseems like it's unused?
To add to that, a few things I've noticed (but I've mostly only gotten as far as the front-end of the pipeline, ie. dpu_plane):
- It looks like, as was the case with mdp4/mdp5 (and really most other hw) there are still unequal capabilities for planes (ie. some can do YUV, scaling, etc).
But drm-hwc (or weston) isn't going to know about that, so I think we'll need to add support for dynamically assigning dpu_plane::pipe, similar to what mdp5 does w/ plane<->hwpipe. (Which I actually added specifically for drm-hwc ;-))
- I *think* we also need the same trick for combining mixers under one CRTC for 4k modes too?
- in dpu_plane, and perhaps elsewhere, userspace pointers for things like CSC and scaling coefficients need to be annotated w/ __user. (Except the should probably be blob properties instead.. and we probably need to strip out the custom properties and re-introduce them separately with some userspace + review.)
- dpu_formats.c looks mostly like a superset of mdp_format.c, ie there is a similar concept to how you describe the format to hw as mdp4/mdp5. Probably the additions in dpu_formats should be folded back in mdp_format.
I'm not sure how we want to balance adding new features with cleanup and hopefully removing some code. I suspect a fair chunk of dpu_plane actually belongs in dpu_plane_state, so maybe we can handle that as part of that cleanup.
Few more below
Quoted 41 lines
The following changes since commit
9afe236df559d0dc6818f64e728a3f931a0a2231:drm/msm/dsi: Fix potential NULL pointer dereference in
msm_dsi_modeset_init(2018-02-12 10:25:15 -0500)are available in the Git repository at:
git://people.freedesktop.org/~seanpaul/dpu-stagingfor-next-compilesfor you to fetch changes up to
672005da148f82021a62d4fa658728e19f13097e:ARM: dts: msm: add device tree changes for SDM845 (2018-02-13 13:14:43 -0500)
----------------------------------------------------------------
Jeykumar Sankaran (9):
dt-bindings: msm/dsi: Add mdp transfer time to msm dsi binding
dt-bindings: msm/disp: Add bindings for Snapdragon 845 DPU
drm: Core changes
drm/msm: add DPU DRM driver to support SDM845 drm/msm: Changemdp_get_formatarguments
drm/msm: Core msm changes
drm/msm: Add DSI Staging driver
drm/msm: Add DisplayPort support
ARM: dts: msm: add device tree changes for SDM845Manasi Navare (1):
drm/dp: Add HBR3 support in existing DRM DP helpersRob Clark (1):
drm/msm: rename mdp->disp.../devicetree/bindings/display/msm/dpu-rsc.txt | 96 + .../devicetree/bindings/display/msm/dpu.txt | 736 +++ .../devicetree/bindings/display/msm/dsi.txt | 16 + .../devicetree/bindings/drm/msm/dpu-dp.txt | 217 + .../devicetree/bindings/drm/msm/dpu-dsi.txt | 102 + .../devicetree/bindings/drm/msm/dpu-wb.txt | 23 + .../devicetree/bindings/drm/msm/mdss-dsi-panel.txt | 772 +++ .../devicetree/bindings/fb/mdss-dsi-panel.txt | 742 +++ Documentation/devicetree/bindings/fb/mdss-pll.txt | 103 + .../devicetree/bindings/msm_hdcp/msm_hdcp.txt | 14 +
Quoted 8 lines
arch/arm64/boot/dts/qcom/sdm845-dpu-display.dtsi | 248 + arch/arm64/boot/dts/qcom/sdm845-dpu.dtsi | 541 +++ drivers/clk/qcom/mdss/mdss-pll.h | 240 + drivers/gpu/drm/drm_dp_helper.c | 4 + drivers/gpu/drm/drm_dp_mst_topology.c | 3 + drivers/gpu/drm/drm_edid.c | 77 + drivers/gpu/drm/drm_framebuffer.c | 3 +- drivers/gpu/drm/drm_mipi_dsi.c | 12 +-
Some of these changes in drm core need to be split out.
Quoted 143 lines
drivers/gpu/drm/msm/Makefile | 98 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h | 99 +
.../gpu/drm/msm/disp/dpu1/dpu_color_processing.c | 1520 ++++++
.../gpu/drm/msm/disp/dpu1/dpu_color_processing.h | 120 +
drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c | 1381 ++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_connector.h | 581 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 640 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 192 +
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 818 ++++
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 144 +
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5076 ++++++++++++++++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 661 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3838 +++++++++++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 220 +
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 561 +++
.../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 1365 ++++++
.../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 1045 ++++
.../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 1369 ++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_fence.c | 404 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_fence.h | 190 +
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 1339 ++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 152 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c | 1443 ++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 155 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h | 53 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3287 +++++++++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1050 ++++
.../gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 182 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c | 329 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.h | 139 +
.../msm/disp/dpu1/dpu_hw_color_proc_common_v4.h | 69 +
.../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c | 242 +
.../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h | 40 +
.../drm/msm/disp/dpu1/dpu_hw_color_processing.h | 20 +
.../msm/disp/dpu1/dpu_hw_color_processing_v1_7.c | 565 +++
.../msm/disp/dpu1/dpu_hw_color_processing_v1_7.h | 92 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 657 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 275 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c | 149 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h | 111 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 252 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 100 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 209 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h | 220 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 1235 +++++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 289 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 373 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 132 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 331 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 136 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 538 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 409 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 182 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 759 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h | 27 +
.../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c | 943 ++++
.../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h | 75 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.c | 962 ++++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.h | 192 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 1063 ++++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 574 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 461 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 227 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 453 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 202 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c | 275 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h | 128 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 324 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.h | 187 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h | 60 +
drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c | 112 +
drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h | 59 +
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2099 ++++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 547 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c | 220 +
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4774 ++++++++++++++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 296 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c | 139 +
drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h | 310 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 1394 ++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 200 +
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 245 +
drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 385 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h | 94 +
drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c | 781 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_wb.h | 232 +
drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4.xml.h | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_crtc.c | 0
.../drm/msm/{mdp => disp}/mdp4/mdp4_dsi_encoder.c | 0
.../drm/msm/{mdp => disp}/mdp4/mdp4_dtv_encoder.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_irq.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.h | 2 +-
.../drm/msm/{mdp => disp}/mdp4/mdp4_lcdc_encoder.c | 0
.../msm/{mdp => disp}/mdp4/mdp4_lvds_connector.c | 0
.../gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lvds_pll.c | 0
.../gpu/drm/msm/{mdp => disp}/mdp4/mdp4_plane.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5.xml.h | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.h | 0
.../drm/msm/{mdp => disp}/mdp5/mdp5_cmd_encoder.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_crtc.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.h | 0
.../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_encoder.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_irq.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.h | 2 +-
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mdss.c | 0
.../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.c | 0
.../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.h | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.h | 0
.../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_plane.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.h | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp_common.xml.h | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp_format.c | 5 +-
drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.c | 0
drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.h | 2 +-
drivers/gpu/drm/msm/dp/dp_audio.c | 796 +++
drivers/gpu/drm/msm/dp/dp_audio.h | 81 +
drivers/gpu/drm/msm/dp/dp_aux.c | 570 +++
drivers/gpu/drm/msm/dp/dp_aux.h | 44 +
drivers/gpu/drm/msm/dp/dp_catalog.c | 1320 +++++
drivers/gpu/drm/msm/dp/dp_catalog.h | 163 +
drivers/gpu/drm/msm/dp/dp_ctrl.c | 1474 ++++++
drivers/gpu/drm/msm/dp/dp_ctrl.h | 50 +
drivers/gpu/drm/msm/dp/dp_debug.c | 503 ++
drivers/gpu/drm/msm/dp/dp_debug.h | 60 +
drivers/gpu/drm/msm/dp/dp_display.c | 1262 +++++
drivers/gpu/drm/msm/dp/dp_display.h | 52 +
drivers/gpu/drm/msm/dp/dp_drm.c | 538 +++
drivers/gpu/drm/msm/dp/dp_drm.h | 96 +
drivers/gpu/drm/msm/dp/dp_hdcp2p2.c | 927 ++++
drivers/gpu/drm/msm/dp/dp_link.c | 1548 ++++++
drivers/gpu/drm/msm/dp/dp_link.h | 184 +
drivers/gpu/drm/msm/dp/dp_panel.c | 531 ++
drivers/gpu/drm/msm/dp/dp_panel.h | 116 +
drivers/gpu/drm/msm/dp/dp_parser.c | 645 +++
drivers/gpu/drm/msm/dp/dp_parser.h | 200 +
drivers/gpu/drm/msm/dp/dp_power.c | 623 +++
drivers/gpu/drm/msm/dp/dp_power.h | 58 +Quoted 8 lines
drivers/gpu/drm/msm/dp/dp_reg.h | 231 + drivers/gpu/drm/msm/dp/dp_usbpd.c | 491 ++ drivers/gpu/drm/msm/dp/dp_usbpd.h | 101 + drivers/gpu/drm/msm/dpu_dbg.c | 3325 +++++++++++++ drivers/gpu/drm/msm/dpu_dbg.h | 421 ++ drivers/gpu/drm/msm/dpu_dbg_evtlog.c | 306 ++ drivers/gpu/drm/msm/dpu_edid_parser.c | 657 +++ drivers/gpu/drm/msm/dpu_edid_parser.h | 166 +
let's not have our own edid parser ;-)
I guess this is a symptom of some enhancements needed in drm_edid
Quoted 31 lines
drivers/gpu/drm/msm/dpu_hdcp.h | 74 + drivers/gpu/drm/msm/dpu_hdcp_1x.c | 1579 ++++++ drivers/gpu/drm/msm/dpu_io_util.c | 507 ++ drivers/gpu/drm/msm/dpu_power_handle.c | 1128 +++++ drivers/gpu/drm/msm/dpu_power_handle.h | 334 ++ drivers/gpu/drm/msm/dpu_rsc.c | 1367 ++++++ drivers/gpu/drm/msm/dpu_rsc_hw.c | 818 ++++ drivers/gpu/drm/msm/dpu_rsc_priv.h | 191 + drivers/gpu/drm/msm/dsi-staging/dsi_catalog.c | 241 + drivers/gpu/drm/msm/dsi-staging/dsi_catalog.h | 201 + drivers/gpu/drm/msm/dsi-staging/dsi_clk.h | 276 ++ drivers/gpu/drm/msm/dsi-staging/dsi_clk_manager.c | 1227 +++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.c | 2862 +++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.h | 635 +++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw.h | 752 +++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_1_4.c | 480 ++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_0.c | 234 + drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_2.c | 42 + drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_cmn.c | 1312 +++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_reg.h | 196 + drivers/gpu/drm/msm/dsi-staging/dsi_defs.h | 581 +++ drivers/gpu/drm/msm/dsi-staging/dsi_display.c | 4325 +++++++++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_display.h | 557 +++ drivers/gpu/drm/msm/dsi-staging/dsi_display_test.c | 114 + drivers/gpu/drm/msm/dsi-staging/dsi_display_test.h | 31 + drivers/gpu/drm/msm/dsi-staging/dsi_drm.c | 708 +++ drivers/gpu/drm/msm/dsi-staging/dsi_drm.h | 129 + drivers/gpu/drm/msm/dsi-staging/dsi_hw.h | 48 + drivers/gpu/drm/msm/dsi-staging/dsi_panel.c | 3521 ++++++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_panel.h | 262 + drivers/gpu/drm/msm/dsi-staging/dsi_phy.c | 935 ++++
Quoted 8 lines
drivers/gpu/drm/msm/dsi-staging/dsi_phy.h | 235 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw.h | 260 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v2_0.c | 252 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v3_0.c | 447 ++ .../gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.c | 676 +++ .../gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.h | 144 + .../gpu/drm/msm/dsi-staging/dsi_phy_timing_v2_0.c | 126 + .../gpu/drm/msm/dsi-staging/dsi_phy_timing_v3_0.c | 107 +
getting rid of the 2nd dsi driver in dsi-staging will cut off a big chunk of code, it is just shy of 25kloc
Quoted 6 lines
drivers/gpu/drm/msm/dsi-staging/dsi_pwr.c | 365 ++ drivers/gpu/drm/msm/dsi-staging/dsi_pwr.h | 93 + drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c | 26 +- drivers/gpu/drm/msm/msm_atomic.c | 446 +- drivers/gpu/drm/msm/msm_drv.c | 919 +++- drivers/gpu/drm/msm/msm_drv.h | 486 +-
Quoted 8 lines
drivers/gpu/drm/msm/msm_fb.c | 10 +- drivers/gpu/drm/msm/msm_kms.h | 90 +- drivers/gpu/drm/msm/msm_prop.c | 688 +++ drivers/gpu/drm/msm/msm_prop.h | 438 ++ drivers/gpu/drm/msm/msm_rd.c | 58 +- drivers/platform/msm/Kconfig | 21 + drivers/platform/msm/Makefile | 4 + drivers/platform/msm/msm_ext_display.c | 525 ++
I guess msm_ext_display.c needs to go away
Quoted 5 lines
include/drm/drm_connector.h | 19 + include/drm/drm_dp_helper.h | 23 + include/drm/drm_mipi_dsi.h | 4 + include/drm/drm_mode_object.h | 2 +- include/linux/dpu_io_util.h | 113 +
Quoted 8 lines
include/linux/dpu_rsc.h | 302 ++ include/linux/msm_ext_display.h | 182 + include/uapi/drm/dpu_drm.h | 449 ++ include/uapi/drm/drm_fourcc.h | 32 + include/uapi/drm/drm_mode.h | 5 + include/uapi/drm/msm_drm.h | 79 + include/uapi/drm/msm_drm_pp.h | 345 ++ include/uapi/media/msm_media_info.h | 1376 ++++++
and this
Quoted 2 lines
include/video/mipi_display.h | 4 + 236 files changed, 110234 insertions(+), 159 deletions(-)
jfwiw, Sean an I have already cut out ~15k insertions from the inital version ;-)
BR,
-R
Quoted 215 lines
create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-rsc.txt
create mode 100644 Documentation/devicetree/bindings/display/msm/dpu.txt
create mode 100644 Documentation/devicetree/bindings/drm/msm/dpu-dp.txt
create mode 100644 Documentation/devicetree/bindings/drm/msm/dpu-dsi.txt
create mode 100644 Documentation/devicetree/bindings/drm/msm/dpu-wb.txt
create mode 100644 Documentation/devicetree/bindings/drm/msm/mdss-dsi-panel.txt
create mode 100644 Documentation/devicetree/bindings/fb/mdss-dsi-panel.txt
create mode 100644 Documentation/devicetree/bindings/fb/mdss-pll.txt
create mode 100644 Documentation/devicetree/bindings/msm_hdcp/msm_hdcp.txt
create mode 100644 arch/arm64/boot/dts/qcom/sdm845-dpu-display.dtsi
create mode 100644 arch/arm64/boot/dts/qcom/sdm845-dpu.dtsi
create mode 100644 drivers/clk/qcom/mdss/mdss-pll.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_connector.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_fence.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_fence.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_common_v4.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c
create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_wb.h
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4.xml.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_crtc.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_dsi_encoder.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_dtv_encoder.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_irq.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.h (99%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lcdc_encoder.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lvds_connector.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lvds_pll.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_plane.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5.xml.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cmd_encoder.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_crtc.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_encoder.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_irq.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.h (99%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mdss.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_plane.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp_common.xml.h (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp_format.c (98%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.c (100%)
rename drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.h (99%)
create mode 100644 drivers/gpu/drm/msm/dp/dp_audio.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_audio.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_debug.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_debug.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_display.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_display.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_hdcp2p2.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_link.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_link.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_power.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_power.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_reg.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_usbpd.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_usbpd.h
create mode 100644 drivers/gpu/drm/msm/dpu_dbg.c
create mode 100644 drivers/gpu/drm/msm/dpu_dbg.h
create mode 100644 drivers/gpu/drm/msm/dpu_dbg_evtlog.c
create mode 100644 drivers/gpu/drm/msm/dpu_edid_parser.c
create mode 100644 drivers/gpu/drm/msm/dpu_edid_parser.h
create mode 100644 drivers/gpu/drm/msm/dpu_hdcp.h
create mode 100644 drivers/gpu/drm/msm/dpu_hdcp_1x.c
create mode 100644 drivers/gpu/drm/msm/dpu_io_util.c
create mode 100644 drivers/gpu/drm/msm/dpu_power_handle.c
create mode 100644 drivers/gpu/drm/msm/dpu_power_handle.h
create mode 100644 drivers/gpu/drm/msm/dpu_rsc.c
create mode 100644 drivers/gpu/drm/msm/dpu_rsc_hw.c
create mode 100644 drivers/gpu/drm/msm/dpu_rsc_priv.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_catalog.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_catalog.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_clk.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_clk_manager.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_1_4.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_0.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_2.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_cmn.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_reg.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_defs.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display_test.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display_test.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_drm.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_drm.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_hw.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_panel.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_panel.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v2_0.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v3_0.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.h
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_v2_0.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_v3_0.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_pwr.c
create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_pwr.h
create mode 100644 drivers/gpu/drm/msm/msm_prop.c
create mode 100644 drivers/gpu/drm/msm/msm_prop.h
create mode 100644 drivers/platform/msm/Kconfig
create mode 100644 drivers/platform/msm/Makefile
create mode 100644 drivers/platform/msm/msm_ext_display.c
create mode 100644 include/linux/dpu_io_util.h
create mode 100644 include/linux/dpu_rsc.h
create mode 100644 include/linux/msm_ext_display.h
create mode 100644 include/uapi/drm/dpu_drm.h
create mode 100644 include/uapi/drm/msm_drm_pp.h
create mode 100644 include/uapi/media/msm_media_info.hQuoted 2 lines
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
A message that is not in the archive (sent off-list or not yet received): CAF6AEGtt6Eaw=pSOYUy2u0P7k_+Pepv-Ox-VKcC_9NF68kzoug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Hi Rob,
Quoted 9 lines · Rob Clark
Quoted 5 lines · Sean Paul
Qualcomm has been working for the past few weeks on forward porting their downstream drm driver from 4.14 to mainline. Please consider this PR as a request for review, rather than an attempt at mainlining the code as it currently stands. The goal is get this driver in shape over the next coming months.
just so others aren't confused, s/sde/dpu/g in the list below (we did our
DAL->DCrename before sending first RFC :-P)
Heh, and it is quite a bit of code to dig through. I haven't yet got a chance to fully check it out.
Quoted 1 line
Quoted 1 line
-
include/uapi/drm/msm_drm_pp.hneeds opensource userspace (or removal)
We don't really have a good story for pixel-processing API anywhere tbh.
Quoted 11 lines
To add to that, a few things I've noticed (but I've mostly only gotten as far as the front-end of the pipeline, ie.
dpu_plane):- It looks like, as was the case with mdp4/mdp5 (and really most other hw) there are still unequal capabilities for planes (ie. some can do YUV, scaling, etc).
But drm-hwc (or weston) isn't going to know about that, so I think we'll need to add support for dynamically assigning
dpu_plane::pipe, similar to what mdp5 does w/ plane<->hwpipe. (Which I actually added specifically for drm-hwc ;-))
Formats/modifiers we do at least get per-plane. We won't know about scaling, but at least Weston will go through trying each plane in sequence until it finds one which accepts the configuration. Could HWC do something like that with atomic, or does it rely on coming up with a plan first rather than the brute-force testing approach? I haven't seen its planner at all recently I'm afraid.
Quoted 2 lines
- I *think* we also need the same trick for combining mixers under one CRTC for 4k modes too?
This one I guess you can't get around though. Can they still run from the one plane, or do you secretly consume two planes?
Quoted 5 lines
- in
dpu_plane, and perhaps elsewhere, userspace pointers for things like CSC and scaling coefficients need to be annotated w/__user. (Except the should probably be blob properties instead.. and we probably need to strip out the custom properties and re-introduce them separately with some userspace + review.)
It'd be good to know if the CSC could use the CRTC GAMMA_LUT -> CTM -> DEGAMMA_LUT properties, if they were moved over to planes. (And if not, why not; if there's any functionality missing from those, what it is, etc.)
Cheers,
Daniel
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoted 39 lines · Daniel Stone
Hi Rob,
Quoted 9 lines · Rob Clark
Quoted 5 lines · Sean Paul
Qualcomm has been working for the past few weeks on forward porting their downstream drm driver from 4.14 to mainline. Please consider this PR as a request for review, rather than an attempt at mainlining the code as it currently stands. The goal is get this driver in shape over the next coming months.
just so others aren't confused, s/sde/dpu/g in the list below (we did our
DAL->DCrename before sending first RFC :-P)Heh, and it is quite a bit of code to dig through. I haven't yet got a chance to fully check it out.
Quoted 1 line
Quoted 1 line
-
include/uapi/drm/msm_drm_pp.hneeds opensource userspace (or removal)We don't really have a good story for pixel-processing API anywhere tbh.
Quoted 11 lines
To add to that, a few things I've noticed (but I've mostly only gotten as far as the front-end of the pipeline, ie.
dpu_plane):- It looks like, as was the case with mdp4/mdp5 (and really most other hw) there are still unequal capabilities for planes (ie. some can do YUV, scaling, etc).
But drm-hwc (or weston) isn't going to know about that, so I think we'll need to add support for dynamically assigning
dpu_plane::pipe, similar to what mdp5 does w/ plane<->hwpipe. (Which I actually added specifically for drm-hwc ;-))Formats/modifiers we do at least get per-plane. We won't know about scaling, but at least Weston will go through trying each plane in sequence until it finds one which accepts the configuration. Could HWC do something like that with atomic, or does it rely on coming up with a plan first rather than the brute-force testing approach? I haven't seen its planner at all recently I'm afraid.
Quoted 6 lines
Quoted 2 lines
- I *think* we also need the same trick for combining mixers under one CRTC for 4k modes too?
This one I guess you can't get around though. Can they still run from the one plane, or do you secretly consume two planes?
I think it is still the case, like mdp5, that you need two hw pipes.. but actually it gets more crazy, since there are some cases where two planes could share a hw pipe. Not sure that weston or drm-hwc is going to have much hope in being able to deal with that, so I think virtualizing the planes and crtcs is the better route.
BR,
-R
Quoted 6 lines
Quoted 5 lines
- in
dpu_plane, and perhaps elsewhere, userspace pointers for things like CSC and scaling coefficients need to be annotated w/__user. (Except the should probably be blob properties instead.. and we probably need to strip out the custom properties and re-introduce them separately with some userspace + review.)
Quoted 7 lines
It'd be good to know if the CSC could use the CRTC
GAMMA_LUT-> CTM ->DEGAMMA_LUTproperties, if they were moved over to planes. (And if not, why not; if there's any functionality missing from those, what it is, etc.)Cheers,
Daniel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 33 lines · Rob Clark
Quoted 32 lines · Daniel Stone
Hi Rob,
Quoted 9 lines · Rob Clark
Quoted 5 lines · Sean Paul
Qualcomm has been working for the past few weeks on forward porting their downstream drm driver from 4.14 to mainline. Please consider this PR as a request for review, rather than an attempt at mainlining the code as it currently stands. The goal is get this driver in shape over the next coming months.
just so others aren't confused, s/sde/dpu/g in the list below (we did our
DAL->DCrename before sending first RFC :-P)Heh, and it is quite a bit of code to dig through. I haven't yet got a chance to fully check it out.
Quoted 1 line
Quoted 1 line
-
include/uapi/drm/msm_drm_pp.hneeds opensource userspace (or removal)We don't really have a good story for pixel-processing API anywhere tbh.
Quoted 11 lines
To add to that, a few things I've noticed (but I've mostly only gotten as far as the front-end of the pipeline, ie.
dpu_plane):- It looks like, as was the case with mdp4/mdp5 (and really most other hw) there are still unequal capabilities for planes (ie. some can do YUV, scaling, etc).
But drm-hwc (or weston) isn't going to know about that, so I think we'll need to add support for dynamically assigning
dpu_plane::pipe, similar to what mdp5 does w/ plane<->hwpipe. (Which I actually added specifically for drm-hwc ;-))
Quoted 6 lines
Quoted 6 lines
Formats/modifiers we do at least get per-plane. We won't know about scaling, but at least Weston will go through trying each plane in sequence until it finds one which accepts the configuration. Could HWC do something like that with atomic, or does it rely on coming up with a plan first rather than the brute-force testing approach? I haven't seen its planner at all recently I'm afraid.
It could definitely build up a plan a la weston, it just doesn't atm.
Quoted 11 lines
Quoted 7 lines
Quoted 3 lines
- I *think* we also need the same trick for combining mixers under one CRTC for 4k modes too?
This one I guess you can't get around though. Can they still run from the one plane, or do you secretly consume two planes?
I think it is still the case, like mdp5, that you need two hw pipes.. but actually it gets more crazy, since there are some cases where two planes could share a hw pipe.
Right. Large fbs might require 2 pipes, and multiple overlapping or adjacent small fbs can be serviced with 1 pipe.
Quoted 3 lines
Not sure that weston or drm-hwc is
going to have much hope in being able to deal with that, so I think virtualizing the planes and crtcs is the better route.
Agreed. I think kernel is in the best place to make these decisions.
Sean
Quoted 17 lines
BR,
-RQuoted 13 lines
Quoted 5 lines
- in
dpu_plane, and perhaps elsewhere, userspace pointers for things like CSC and scaling coefficients need to be annotated w/__user. (Except the should probably be blob properties instead.. and we probably need to strip out the custom properties and re-introduce them separately with some userspace + review.)It'd be good to know if the CSC could use the CRTC
GAMMA_LUT-> CTM ->DEGAMMA_LUTproperties, if they were moved over to planes. (And if not, why not; if there's any functionality missing from those, what it is, etc.)Cheers,
Daniel
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi,
Quoted 11 lines · Sean Paul
Quoted 7 lines · Rob Clark
Quoted 2 lines · Daniel Stone
This one I guess you can't get around though. Can they still run from the one plane, or do you secretly consume two planes?
I think it is still the case, like mdp5, that you need two hw pipes.. but actually it gets more crazy, since there are some cases where two planes could share a hw pipe.
Right. Large fbs might require 2 pipes, and multiple overlapping or adjacent small fbs can be serviced with 1 pipe.
I didn't know about using a single pipe for multiple framebuffers. That's quite special indeed.
I think virtualising probably makes sense in that case: rather than just getting around limitations, it's seeming like more of a VC4 situation where they just really aren't actually planes in the first place.
Cheers,
Daniel
Quoted 95 lines · Rob Clark
Quoted 14 lines · Sean Paul
Hi dri-devel,
Qualcomm has been working for the past few weeks on forward porting their downstream drm driver from 4.14 to mainline. Please consider this PR as a request for review, rather than an attempt at mainlining the code as it currently stands. The goal is get this driver in shape over the next coming months.In the meantime, I'll be hosting a tree here [1] to stage the fixes. Patches will be posted and reviewed on [email protected]. Once things look good, I'll send another pull 4realz.
To get the ball rolling, I've done some review on the new connector code, my comments are below.
Quoted 8 lines
Thanks in advance for your constructive feedback :)
Sean
[1]-
git://people.freedesktop.org/~seanpaul/dpu-stagingReview feedback:
----------------just so others aren't confused, s/sde/dpu/g in the list below (we did our
DAL->DCrename before sending first RFC :-P)Quoted 37 lines
- Solve the splash screen handling (or remove it)
- Simplify devicetree binding (remove register offsets)
feedback from reviewingsde_connector.c:
- Rationalize backlight implementation insde_connector(display_countstatic)
- Sort out the dsi event passing between dsi/encoder/connector (move to encoder)
-include/uapi/drm/msm_drm_pp.hneeds opensource userspace (or removal)
-connector->stateaccess violations reading/writingmode_info
- s/sde_rect/drm_rect/
-sde_kms_infousage needs to be replaced with formal data structures (not stringified keypairs)
-sde_connector_opsneeds to be trimmed, duplicates connector helpers, info hooks circumvent state, and other hooks should be stored in state or prepopulated (get_dst_format)
-sde_connector_get_dpmsunused
- esd status check should migrate to encoder from connector
- backlight should be handled in panel drivers, not in the generic connector/dsi encoder
-sde_connector_helper_bridge_disableis called from encoder and calls back intoset_powerencoder function. if backlight, and esd status are removed,pre_kickoffcan probably go away
-sde_connector_clk_ctrlis another example ofencoder->connector->encodercall
-RETIRE_FENCEconnector property should be removed, opting for the native atomic fences
- ROI (regions of interest) should be expressed per-plane instead of connector. there is work ongoing to supportdirty_rectsper-plane by Deepak Singh Rawat <[email protected]> and Lukasz Spintzyk <[email protected]>
- Uma Shankar <[email protected]> has proposed HDR source metadata properties on the list, we should pivot to those instead of hand-rolling them in the sde driver
- Convert HDCP implementation to upstream Content Protection property
- Merge dsi anddsi_staginginto one driver
- Writeback connector has been proposed by ARM (Liviu Dudau and Brian Starkey), we should work with their proposal instead of rollingOUT_FBourselves
-sde_connector_set_propertyshould be replaced with atomic helper
- dsi hotplug can probably be punted to the panel driver
- dpms should switch to enable/disable (or at least use the atomic helpers)
- dsi mode handling should also defer to the panel driverQuoted 9 lines
-
SDE_WB_CONFIGioctl should be removed in favor of the existing ioctl to add user-defined modes
- dp implementation should use the existing dp helpers wherever possible
- lots of duplicated structures indsi_defs.hthat can be replaced with existing drm structs
-mode_validshould be split up and implemented directly in connector/encoder as appropriate
-sde_connector->aspaceseems like it's unused?To add to that, a few things I've noticed (but I've mostly only gotten as far as the front-end of the pipeline, ie.
dpu_plane):- It looks like, as was the case with mdp4/mdp5 (and really most other hw) there are still unequal capabilities for planes (ie. some can do YUV, scaling, etc).
But drm-hwc (or weston) isn't going to know about that, so I think we'll need to add support for dynamically assigning
dpu_plane::pipe, similar to what mdp5 does w/ plane<->hwpipe. (Which I actually added specifically for drm-hwc ;-))- I *think* we also need the same trick for combining mixers under one CRTC for 4k modes too?
- in
dpu_plane, and perhaps elsewhere, userspace pointers for things like CSC and scaling coefficients need to be annotated w/__user. (Except the should probably be blob properties instead.. and we probably need to strip out the custom properties and re-introduce them separately with some userspace + review.)
Quoted 8 lines
-
dpu_formats.clooks mostly like a superset ofmdp_format.c, ie there is a similar concept to how you describe the format to hw as mdp4/mdp5. Probably the additions indpu_formatsshould be folded back inmdp_format.I'm not sure how we want to balance adding new features with cleanup and hopefully removing some code. I suspect a fair chunk of
dpu_planeactually belongs indpu_plane_state, so maybe we can handle that as part of that cleanup.
one more to add to the TODO list:
- fix direct callers of msm_gem_free_object() to use drm_gem_object_put()
BR,
-R
Quoted 287 lines
Few more below
Quoted 41 lines
The following changes since commit
9afe236df559d0dc6818f64e728a3f931a0a2231:drm/msm/dsi: Fix potential NULL pointer dereference in
msm_dsi_modeset_init(2018-02-12 10:25:15 -0500)are available in the Git repository at:
git://people.freedesktop.org/~seanpaul/dpu-stagingfor-next-compilesfor you to fetch changes up to
672005da148f82021a62d4fa658728e19f13097e:ARM: dts: msm: add device tree changes for SDM845 (2018-02-13 13:14:43 -0500)
----------------------------------------------------------------
Jeykumar Sankaran (9):
dt-bindings: msm/dsi: Add mdp transfer time to msm dsi binding
dt-bindings: msm/disp: Add bindings for Snapdragon 845 DPU
drm: Core changes
drm/msm: add DPU DRM driver to support SDM845 drm/msm: Changemdp_get_formatarguments
drm/msm: Core msm changes
drm/msm: Add DSI Staging driver
drm/msm: Add DisplayPort support
ARM: dts: msm: add device tree changes for SDM845Manasi Navare (1):
drm/dp: Add HBR3 support in existing DRM DP helpersRob Clark (1):
drm/msm: rename mdp->disp.../devicetree/bindings/display/msm/dpu-rsc.txt | 96 + .../devicetree/bindings/display/msm/dpu.txt | 736 +++ .../devicetree/bindings/display/msm/dsi.txt | 16 + .../devicetree/bindings/drm/msm/dpu-dp.txt | 217 + .../devicetree/bindings/drm/msm/dpu-dsi.txt | 102 + .../devicetree/bindings/drm/msm/dpu-wb.txt | 23 + .../devicetree/bindings/drm/msm/mdss-dsi-panel.txt | 772 +++ .../devicetree/bindings/fb/mdss-dsi-panel.txt | 742 +++ Documentation/devicetree/bindings/fb/mdss-pll.txt | 103 + .../devicetree/bindings/msm_hdcp/msm_hdcp.txt | 14 +Quoted 8 lines
arch/arm64/boot/dts/qcom/sdm845-dpu-display.dtsi | 248 + arch/arm64/boot/dts/qcom/sdm845-dpu.dtsi | 541 +++ drivers/clk/qcom/mdss/mdss-pll.h | 240 + drivers/gpu/drm/drm_dp_helper.c | 4 + drivers/gpu/drm/drm_dp_mst_topology.c | 3 + drivers/gpu/drm/drm_edid.c | 77 + drivers/gpu/drm/drm_framebuffer.c | 3 +- drivers/gpu/drm/drm_mipi_dsi.c | 12 +-Some of these changes in drm core need to be split out.
Quoted 143 lines
drivers/gpu/drm/msm/Makefile | 98 +- drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h | 99 + .../gpu/drm/msm/disp/dpu1/dpu_color_processing.c | 1520 ++++++ .../gpu/drm/msm/disp/dpu1/dpu_color_processing.h | 120 + drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c | 1381 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_connector.h | 581 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 640 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 192 + drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 818 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 144 + drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5076 ++++++++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 661 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3838 +++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 220 + drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 561 +++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 1365 ++++++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 1045 ++++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 1369 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_fence.c | 404 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_fence.h | 190 + drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 1339 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 152 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c | 1443 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 155 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h | 53 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3287 +++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1050 ++++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 182 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c | 329 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.h | 139 + .../msm/disp/dpu1/dpu_hw_color_proc_common_v4.h | 69 + .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c | 242 + .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h | 40 + .../drm/msm/disp/dpu1/dpu_hw_color_processing.h | 20 + .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.c | 565 +++ .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.h | 92 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 657 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 275 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c | 149 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h | 111 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 252 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 100 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 209 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h | 220 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 1235 +++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 289 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 373 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 132 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 331 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 136 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 538 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 409 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 182 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 759 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h | 27 + .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c | 943 ++++ .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h | 75 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.c | 962 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.h | 192 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 1063 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 574 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 461 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 227 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 453 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 202 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c | 275 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h | 128 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 324 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.h | 187 + drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h | 60 + drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c | 112 + drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h | 59 + drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2099 ++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 547 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c | 220 + drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4774 ++++++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 296 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c | 139 + drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h | 310 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 1394 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 200 + drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 245 + drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 385 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h | 94 + drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c | 781 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_wb.h | 232 + drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4.xml.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_crtc.c | 0 .../drm/msm/{mdp => disp}/mdp4/mdp4_dsi_encoder.c | 0 .../drm/msm/{mdp => disp}/mdp4/mdp4_dtv_encoder.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_irq.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.h | 2 +- .../drm/msm/{mdp => disp}/mdp4/mdp4_lcdc_encoder.c | 0 .../msm/{mdp => disp}/mdp4/mdp4_lvds_connector.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lvds_pll.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp4/mdp4_plane.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5.xml.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.h | 0 .../drm/msm/{mdp => disp}/mdp5/mdp5_cmd_encoder.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_crtc.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.h | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_encoder.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_irq.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.h | 2 +- drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mdss.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.h | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_plane.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp_common.xml.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp_format.c | 5 +- drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.h | 2 +- drivers/gpu/drm/msm/dp/dp_audio.c | 796 +++ drivers/gpu/drm/msm/dp/dp_audio.h | 81 + drivers/gpu/drm/msm/dp/dp_aux.c | 570 +++ drivers/gpu/drm/msm/dp/dp_aux.h | 44 + drivers/gpu/drm/msm/dp/dp_catalog.c | 1320 +++++ drivers/gpu/drm/msm/dp/dp_catalog.h | 163 + drivers/gpu/drm/msm/dp/dp_ctrl.c | 1474 ++++++ drivers/gpu/drm/msm/dp/dp_ctrl.h | 50 + drivers/gpu/drm/msm/dp/dp_debug.c | 503 ++ drivers/gpu/drm/msm/dp/dp_debug.h | 60 + drivers/gpu/drm/msm/dp/dp_display.c | 1262 +++++ drivers/gpu/drm/msm/dp/dp_display.h | 52 + drivers/gpu/drm/msm/dp/dp_drm.c | 538 +++ drivers/gpu/drm/msm/dp/dp_drm.h | 96 + drivers/gpu/drm/msm/dp/dp_hdcp2p2.c | 927 ++++ drivers/gpu/drm/msm/dp/dp_link.c | 1548 ++++++ drivers/gpu/drm/msm/dp/dp_link.h | 184 + drivers/gpu/drm/msm/dp/dp_panel.c | 531 ++ drivers/gpu/drm/msm/dp/dp_panel.h | 116 + drivers/gpu/drm/msm/dp/dp_parser.c | 645 +++ drivers/gpu/drm/msm/dp/dp_parser.h | 200 + drivers/gpu/drm/msm/dp/dp_power.c | 623 +++ drivers/gpu/drm/msm/dp/dp_power.h | 58 +Quoted 8 lines
drivers/gpu/drm/msm/dp/dp_reg.h | 231 + drivers/gpu/drm/msm/dp/dp_usbpd.c | 491 ++ drivers/gpu/drm/msm/dp/dp_usbpd.h | 101 + drivers/gpu/drm/msm/dpu_dbg.c | 3325 +++++++++++++ drivers/gpu/drm/msm/dpu_dbg.h | 421 ++ drivers/gpu/drm/msm/dpu_dbg_evtlog.c | 306 ++ drivers/gpu/drm/msm/dpu_edid_parser.c | 657 +++ drivers/gpu/drm/msm/dpu_edid_parser.h | 166 +let's not have our own edid parser ;-)
I guess this is a symptom of some enhancements needed in
drm_edidQuoted 31 lines
drivers/gpu/drm/msm/dpu_hdcp.h | 74 + drivers/gpu/drm/msm/dpu_hdcp_1x.c | 1579 ++++++ drivers/gpu/drm/msm/dpu_io_util.c | 507 ++ drivers/gpu/drm/msm/dpu_power_handle.c | 1128 +++++ drivers/gpu/drm/msm/dpu_power_handle.h | 334 ++ drivers/gpu/drm/msm/dpu_rsc.c | 1367 ++++++ drivers/gpu/drm/msm/dpu_rsc_hw.c | 818 ++++ drivers/gpu/drm/msm/dpu_rsc_priv.h | 191 + drivers/gpu/drm/msm/dsi-staging/dsi_catalog.c | 241 + drivers/gpu/drm/msm/dsi-staging/dsi_catalog.h | 201 + drivers/gpu/drm/msm/dsi-staging/dsi_clk.h | 276 ++ drivers/gpu/drm/msm/dsi-staging/dsi_clk_manager.c | 1227 +++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.c | 2862 +++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.h | 635 +++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw.h | 752 +++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_1_4.c | 480 ++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_0.c | 234 + drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_2.c | 42 + drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_cmn.c | 1312 +++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_reg.h | 196 + drivers/gpu/drm/msm/dsi-staging/dsi_defs.h | 581 +++ drivers/gpu/drm/msm/dsi-staging/dsi_display.c | 4325 +++++++++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_display.h | 557 +++ drivers/gpu/drm/msm/dsi-staging/dsi_display_test.c | 114 + drivers/gpu/drm/msm/dsi-staging/dsi_display_test.h | 31 + drivers/gpu/drm/msm/dsi-staging/dsi_drm.c | 708 +++ drivers/gpu/drm/msm/dsi-staging/dsi_drm.h | 129 + drivers/gpu/drm/msm/dsi-staging/dsi_hw.h | 48 + drivers/gpu/drm/msm/dsi-staging/dsi_panel.c | 3521 ++++++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_panel.h | 262 + drivers/gpu/drm/msm/dsi-staging/dsi_phy.c | 935 ++++Quoted 8 lines
drivers/gpu/drm/msm/dsi-staging/dsi_phy.h | 235 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw.h | 260 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v2_0.c | 252 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v3_0.c | 447 ++ .../gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.c | 676 +++ .../gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.h | 144 + .../gpu/drm/msm/dsi-staging/dsi_phy_timing_v2_0.c | 126 + .../gpu/drm/msm/dsi-staging/dsi_phy_timing_v3_0.c | 107 +getting rid of the 2nd dsi driver in dsi-staging will cut off a big chunk of code, it is just shy of 25kloc
Quoted 6 lines
drivers/gpu/drm/msm/dsi-staging/dsi_pwr.c | 365 ++ drivers/gpu/drm/msm/dsi-staging/dsi_pwr.h | 93 + drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c | 26 +- drivers/gpu/drm/msm/msm_atomic.c | 446 +- drivers/gpu/drm/msm/msm_drv.c | 919 +++- drivers/gpu/drm/msm/msm_drv.h | 486 +-Quoted 8 lines
drivers/gpu/drm/msm/msm_fb.c | 10 +- drivers/gpu/drm/msm/msm_kms.h | 90 +- drivers/gpu/drm/msm/msm_prop.c | 688 +++ drivers/gpu/drm/msm/msm_prop.h | 438 ++ drivers/gpu/drm/msm/msm_rd.c | 58 +- drivers/platform/msm/Kconfig | 21 + drivers/platform/msm/Makefile | 4 + drivers/platform/msm/msm_ext_display.c | 525 ++I guess
msm_ext_display.cneeds to go awayQuoted 5 lines
include/drm/drm_connector.h | 19 + include/drm/drm_dp_helper.h | 23 + include/drm/drm_mipi_dsi.h | 4 + include/drm/drm_mode_object.h | 2 +- include/linux/dpu_io_util.h | 113 +Quoted 8 lines
include/linux/dpu_rsc.h | 302 ++ include/linux/msm_ext_display.h | 182 + include/uapi/drm/dpu_drm.h | 449 ++ include/uapi/drm/drm_fourcc.h | 32 + include/uapi/drm/drm_mode.h | 5 + include/uapi/drm/msm_drm.h | 79 + include/uapi/drm/msm_drm_pp.h | 345 ++ include/uapi/media/msm_media_info.h | 1376 ++++++and this
Quoted 226 lines
Quoted 2 lines
include/video/mipi_display.h | 4 + 236 files changed, 110234 insertions(+), 159 deletions(-)jfwiw, Sean an I have already cut out ~15k insertions from the inital version ;-)
BR,
-RQuoted 217 lines
create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-rsc.txt create mode 100644 Documentation/devicetree/bindings/display/msm/dpu.txt create mode 100644 Documentation/devicetree/bindings/drm/msm/dpu-dp.txt create mode 100644 Documentation/devicetree/bindings/drm/msm/dpu-dsi.txt create mode 100644 Documentation/devicetree/bindings/drm/msm/dpu-wb.txt create mode 100644 Documentation/devicetree/bindings/drm/msm/mdss-dsi-panel.txt create mode 100644 Documentation/devicetree/bindings/fb/mdss-dsi-panel.txt create mode 100644 Documentation/devicetree/bindings/fb/mdss-pll.txt create mode 100644 Documentation/devicetree/bindings/msm_hdcp/msm_hdcp.txt create mode 100644 arch/arm64/boot/dts/qcom/sdm845-dpu-display.dtsi create mode 100644 arch/arm64/boot/dts/qcom/sdm845-dpu.dtsi create mode 100644 drivers/clk/qcom/mdss/mdss-pll.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_connector.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_fence.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_fence.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_common_v4.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_wb.h rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4.xml.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_crtc.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_dsi_encoder.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_dtv_encoder.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_irq.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.h (99%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lcdc_encoder.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lvds_connector.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lvds_pll.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_plane.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5.xml.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cmd_encoder.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_crtc.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_encoder.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_irq.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.h (99%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mdss.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_plane.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp_common.xml.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp_format.c (98%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.h (99%) create mode 100644 drivers/gpu/drm/msm/dp/dp_audio.c create mode 100644 drivers/gpu/drm/msm/dp/dp_audio.h create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.c create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.h create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.c create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.h create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.c create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.h create mode 100644 drivers/gpu/drm/msm/dp/dp_debug.c create mode 100644 drivers/gpu/drm/msm/dp/dp_debug.h create mode 100644 drivers/gpu/drm/msm/dp/dp_display.c create mode 100644 drivers/gpu/drm/msm/dp/dp_display.h create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.c create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.h create mode 100644 drivers/gpu/drm/msm/dp/dp_hdcp2p2.c create mode 100644 drivers/gpu/drm/msm/dp/dp_link.c create mode 100644 drivers/gpu/drm/msm/dp/dp_link.h create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.c create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.h create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.c create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.h create mode 100644 drivers/gpu/drm/msm/dp/dp_power.c create mode 100644 drivers/gpu/drm/msm/dp/dp_power.h create mode 100644 drivers/gpu/drm/msm/dp/dp_reg.h create mode 100644 drivers/gpu/drm/msm/dp/dp_usbpd.c create mode 100644 drivers/gpu/drm/msm/dp/dp_usbpd.h create mode 100644 drivers/gpu/drm/msm/dpu_dbg.c create mode 100644 drivers/gpu/drm/msm/dpu_dbg.h create mode 100644 drivers/gpu/drm/msm/dpu_dbg_evtlog.c create mode 100644 drivers/gpu/drm/msm/dpu_edid_parser.c create mode 100644 drivers/gpu/drm/msm/dpu_edid_parser.h create mode 100644 drivers/gpu/drm/msm/dpu_hdcp.h create mode 100644 drivers/gpu/drm/msm/dpu_hdcp_1x.c create mode 100644 drivers/gpu/drm/msm/dpu_io_util.c create mode 100644 drivers/gpu/drm/msm/dpu_power_handle.c create mode 100644 drivers/gpu/drm/msm/dpu_power_handle.h create mode 100644 drivers/gpu/drm/msm/dpu_rsc.c create mode 100644 drivers/gpu/drm/msm/dpu_rsc_hw.c create mode 100644 drivers/gpu/drm/msm/dpu_rsc_priv.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_catalog.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_catalog.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_clk.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_clk_manager.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_1_4.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_0.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_2.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_cmn.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_reg.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_defs.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display_test.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display_test.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_drm.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_drm.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_hw.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_panel.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_panel.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v2_0.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v3_0.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_v2_0.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_v3_0.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_pwr.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_pwr.h create mode 100644 drivers/gpu/drm/msm/msm_prop.c create mode 100644 drivers/gpu/drm/msm/msm_prop.h create mode 100644 drivers/platform/msm/Kconfig create mode 100644 drivers/platform/msm/Makefile create mode 100644 drivers/platform/msm/msm_ext_display.c create mode 100644 include/linux/dpu_io_util.h create mode 100644 include/linux/dpu_rsc.h create mode 100644 include/linux/msm_ext_display.h create mode 100644 include/uapi/drm/dpu_drm.h create mode 100644 include/uapi/drm/msm_drm_pp.h create mode 100644 include/uapi/media/msm_media_info.h--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoted 75 lines · Rob Clark
Quoted 14 lines · Sean Paul
Hi dri-devel,
Qualcomm has been working for the past few weeks on forward porting their downstream drm driver from 4.14 to mainline. Please consider this PR as a request for review, rather than an attempt at mainlining the code as it currently stands. The goal is get this driver in shape over the next coming months.In the meantime, I'll be hosting a tree here [1] to stage the fixes. Patches will be posted and reviewed on [email protected]. Once things look good, I'll send another pull 4realz.
To get the ball rolling, I've done some review on the new connector code, my comments are below.
Quoted 8 lines
Thanks in advance for your constructive feedback :)
Sean
[1]-
git://people.freedesktop.org/~seanpaul/dpu-stagingReview feedback:
----------------just so others aren't confused, s/sde/dpu/g in the list below (we did our
DAL->DCrename before sending first RFC :-P)Quoted 37 lines
- Solve the splash screen handling (or remove it)
- Simplify devicetree binding (remove register offsets)
feedback from reviewingsde_connector.c:
- Rationalize backlight implementation insde_connector(display_countstatic)
- Sort out the dsi event passing between dsi/encoder/connector (move to encoder)
-include/uapi/drm/msm_drm_pp.hneeds opensource userspace (or removal)
-connector->stateaccess violations reading/writingmode_info
- s/sde_rect/drm_rect/
-sde_kms_infousage needs to be replaced with formal data structures (not stringified keypairs)
-sde_connector_opsneeds to be trimmed, duplicates connector helpers, info hooks circumvent state, and other hooks should be stored in state or prepopulated (get_dst_format)
-sde_connector_get_dpmsunused
- esd status check should migrate to encoder from connector
- backlight should be handled in panel drivers, not in the generic connector/dsi encoder
-sde_connector_helper_bridge_disableis called from encoder and calls back intoset_powerencoder function. if backlight, and esd status are removed,pre_kickoffcan probably go away
-sde_connector_clk_ctrlis another example ofencoder->connector->encodercall
-RETIRE_FENCEconnector property should be removed, opting for the native atomic fences
- ROI (regions of interest) should be expressed per-plane instead of connector. there is work ongoing to supportdirty_rectsper-plane by Deepak Singh Rawat <[email protected]> and Lukasz Spintzyk <[email protected]>
- Uma Shankar <[email protected]> has proposed HDR source metadata properties on the list, we should pivot to those instead of hand-rolling them in the sde driver
- Convert HDCP implementation to upstream Content Protection property
- Merge dsi anddsi_staginginto one driver
- Writeback connector has been proposed by ARM (Liviu Dudau and Brian Starkey), we should work with their proposal instead of rollingOUT_FBourselves
-sde_connector_set_propertyshould be replaced with atomic helper
- dsi hotplug can probably be punted to the panel driver
- dpms should switch to enable/disable (or at least use the atomic helpers)
- dsi mode handling should also defer to the panel driverQuoted 9 lines
-
SDE_WB_CONFIGioctl should be removed in favor of the existing ioctl to add user-defined modes
- dp implementation should use the existing dp helpers wherever possible
- lots of duplicated structures indsi_defs.hthat can be replaced with existing drm structs
-mode_validshould be split up and implemented directly in connector/encoder as appropriate
-sde_connector->aspaceseems like it's unused?To add to that, a few things I've noticed (but I've mostly only gotten as far as the front-end of the pipeline, ie.
dpu_plane):
Quoted 8 lines
- It looks like, as was the case with mdp4/mdp5 (and really most other hw) there are still unequal capabilities for planes (ie. some can do YUV, scaling, etc).
But drm-hwc (or weston) isn't going to know about that, so I think we'll need to add support for dynamically assigning
dpu_plane::pipe, similar to what mdp5 does w/ plane<->hwpipe. (Which I actually added specifically for drm-hwc ;-))
We are working on plane virtualization focused primarily to support 4K / wider displays which cannot be catered by one hwpipe. The plan is to gang up two *fixed* hwpipes of similar capabilities (in terms of formats, sub hw blocks like scalar, post processing ) and expose them as a single plane so that user space compositor ( drm-hwc or weston) need not worry about max pixel width supported by the planes. But mapping planes <-> hwpipe dynamically may need more than just virtualization. Kernel need to keep track of hwpipes especially when dealing with multiple displays. And it get complicated when planes start moving around CRTC's for different sized buffers.
Given that DRM exposes planes with its own list of format/modifiers, I think its not that big of a deal for a compositor to look up for plane to support the format and use it.
Quoted 3 lines
- I *think* we also need the same trick for combining mixers under one CRTC for 4k modes too?
The uploaded patch set handles this case. We attach two layer mixers under one CRTC. Kernel also takes care of dividing the given list of planes (and its hwpipes) to stage on the respective layer mixers based on the destination coordinates (CRTC_X, _Y, _W and _H)
Quoted 525 lines
- in
dpu_plane, and perhaps elsewhere, userspace pointers for things like CSC and scaling coefficients need to be annotated w/__user. (Except the should probably be blob properties instead.. and we probably need to strip out the custom properties and re-introduce them separately with some userspace + review.)-
dpu_formats.clooks mostly like a superset ofmdp_format.c, ie there is a similar concept to how you describe the format to hw as mdp4/mdp5. Probably the additions indpu_formatsshould be folded back inmdp_format.I'm not sure how we want to balance adding new features with cleanup and hopefully removing some code. I suspect a fair chunk of
dpu_planeactually belongs indpu_plane_state, so maybe we can handle that as part of that cleanup.Few more below
Quoted 40 lines
The following changes since commit
9afe236df559d0dc6818f64e728a3f931a0a2231:drm/msm/dsi: Fix potential NULL pointer dereference in msm_dsi_modeset_init (2018-02-12 10:25:15 -0500)are available in the Git repository at:
git://people.freedesktop.org/~seanpaul/dpu-stagingfor-next-compilesfor you to fetch changes up to
672005da148f82021a62d4fa658728e19f13097e:ARM: dts: msm: add device tree changes for SDM845 (2018-02-13 13:14:43 -0500)
----------------------------------------------------------------
Jeykumar Sankaran (9):
dt-bindings: msm/dsi: Add mdp transfer time to msm dsi binding
dt-bindings: msm/disp: Add bindings for Snapdragon 845 DPU
drm: Core changes
drm/msm: add DPU DRM driver to support SDM845 drm/msm: Changemdp_get_formatarguments
drm/msm: Core msm changes
drm/msm: Add DSI Staging driver
drm/msm: Add DisplayPort support
ARM: dts: msm: add device tree changes for SDM845Manasi Navare (1):
drm/dp: Add HBR3 support in existing DRM DP helpersRob Clark (1):
drm/msm: rename mdp->disp.../devicetree/bindings/display/msm/dpu-rsc.txt | 96 + .../devicetree/bindings/display/msm/dpu.txt | 736 +++ .../devicetree/bindings/display/msm/dsi.txt | 16 + .../devicetree/bindings/drm/msm/dpu-dp.txt | 217 + .../devicetree/bindings/drm/msm/dpu-dsi.txt | 102 + .../devicetree/bindings/drm/msm/dpu-wb.txt | 23 + .../devicetree/bindings/drm/msm/mdss-dsi-panel.txt | 772 +++ .../devicetree/bindings/fb/mdss-dsi-panel.txt | 742 +++ Documentation/devicetree/bindings/fb/mdss-pll.txt | 103 + .../devicetree/bindings/msm_hdcp/msm_hdcp.txt | 14 +Quoted 8 lines
arch/arm64/boot/dts/qcom/sdm845-dpu-display.dtsi | 248 + arch/arm64/boot/dts/qcom/sdm845-dpu.dtsi | 541 +++ drivers/clk/qcom/mdss/mdss-pll.h | 240 + drivers/gpu/drm/drm_dp_helper.c | 4 + drivers/gpu/drm/drm_dp_mst_topology.c | 3 + drivers/gpu/drm/drm_edid.c | 77 + drivers/gpu/drm/drm_framebuffer.c | 3 +- drivers/gpu/drm/drm_mipi_dsi.c | 12 +-Some of these changes in drm core need to be split out.
Quoted 143 lines
drivers/gpu/drm/msm/Makefile | 98 +- drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h | 99 + .../gpu/drm/msm/disp/dpu1/dpu_color_processing.c | 1520 ++++++ .../gpu/drm/msm/disp/dpu1/dpu_color_processing.h | 120 + drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c | 1381 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_connector.h | 581 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 640 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 192 + drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 818 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 144 + drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5076 ++++++++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 661 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3838 +++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 220 + drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 561 +++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 1365 ++++++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 1045 ++++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 1369 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_fence.c | 404 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_fence.h | 190 + drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 1339 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 152 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c | 1443 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 155 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h | 53 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3287 +++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1050 ++++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 182 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c | 329 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.h | 139 + .../msm/disp/dpu1/dpu_hw_color_proc_common_v4.h | 69 + .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c | 242 + .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h | 40 + .../drm/msm/disp/dpu1/dpu_hw_color_processing.h | 20 + .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.c | 565 +++ .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.h | 92 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 657 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 275 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c | 149 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h | 111 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 252 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 100 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 209 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h | 220 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 1235 +++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 289 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 373 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 132 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 331 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 136 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 538 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 409 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 182 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 759 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h | 27 + .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c | 943 ++++ .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h | 75 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.c | 962 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.h | 192 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 1063 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 574 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 461 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 227 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 453 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 202 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c | 275 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h | 128 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 324 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.h | 187 + drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h | 60 + drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c | 112 + drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h | 59 + drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2099 ++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 547 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c | 220 + drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4774 ++++++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 296 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c | 139 + drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h | 310 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 1394 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 200 + drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 245 + drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 385 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h | 94 + drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c | 781 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_wb.h | 232 + drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4.xml.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_crtc.c | 0 .../drm/msm/{mdp => disp}/mdp4/mdp4_dsi_encoder.c | 0 .../drm/msm/{mdp => disp}/mdp4/mdp4_dtv_encoder.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_irq.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.h | 2 +- .../drm/msm/{mdp => disp}/mdp4/mdp4_lcdc_encoder.c | 0 .../msm/{mdp => disp}/mdp4/mdp4_lvds_connector.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lvds_pll.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp4/mdp4_plane.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5.xml.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.h | 0 .../drm/msm/{mdp => disp}/mdp5/mdp5_cmd_encoder.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_crtc.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.h | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_encoder.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_irq.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.h | 2 +- drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mdss.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.h | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_plane.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp_common.xml.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp_format.c | 5 +- drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.h | 2 +- drivers/gpu/drm/msm/dp/dp_audio.c | 796 +++ drivers/gpu/drm/msm/dp/dp_audio.h | 81 + drivers/gpu/drm/msm/dp/dp_aux.c | 570 +++ drivers/gpu/drm/msm/dp/dp_aux.h | 44 + drivers/gpu/drm/msm/dp/dp_catalog.c | 1320 +++++ drivers/gpu/drm/msm/dp/dp_catalog.h | 163 + drivers/gpu/drm/msm/dp/dp_ctrl.c | 1474 ++++++ drivers/gpu/drm/msm/dp/dp_ctrl.h | 50 + drivers/gpu/drm/msm/dp/dp_debug.c | 503 ++ drivers/gpu/drm/msm/dp/dp_debug.h | 60 + drivers/gpu/drm/msm/dp/dp_display.c | 1262 +++++ drivers/gpu/drm/msm/dp/dp_display.h | 52 + drivers/gpu/drm/msm/dp/dp_drm.c | 538 +++ drivers/gpu/drm/msm/dp/dp_drm.h | 96 + drivers/gpu/drm/msm/dp/dp_hdcp2p2.c | 927 ++++ drivers/gpu/drm/msm/dp/dp_link.c | 1548 ++++++ drivers/gpu/drm/msm/dp/dp_link.h | 184 + drivers/gpu/drm/msm/dp/dp_panel.c | 531 ++ drivers/gpu/drm/msm/dp/dp_panel.h | 116 + drivers/gpu/drm/msm/dp/dp_parser.c | 645 +++ drivers/gpu/drm/msm/dp/dp_parser.h | 200 + drivers/gpu/drm/msm/dp/dp_power.c | 623 +++ drivers/gpu/drm/msm/dp/dp_power.h | 58 +Quoted 8 lines
drivers/gpu/drm/msm/dp/dp_reg.h | 231 + drivers/gpu/drm/msm/dp/dp_usbpd.c | 491 ++ drivers/gpu/drm/msm/dp/dp_usbpd.h | 101 + drivers/gpu/drm/msm/dpu_dbg.c | 3325 +++++++++++++ drivers/gpu/drm/msm/dpu_dbg.h | 421 ++ drivers/gpu/drm/msm/dpu_dbg_evtlog.c | 306 ++ drivers/gpu/drm/msm/dpu_edid_parser.c | 657 +++ drivers/gpu/drm/msm/dpu_edid_parser.h | 166 +let's not have our own edid parser ;-)
I guess this is a symptom of some enhancements needed in
drm_edidQuoted 31 lines
drivers/gpu/drm/msm/dpu_hdcp.h | 74 + drivers/gpu/drm/msm/dpu_hdcp_1x.c | 1579 ++++++ drivers/gpu/drm/msm/dpu_io_util.c | 507 ++ drivers/gpu/drm/msm/dpu_power_handle.c | 1128 +++++ drivers/gpu/drm/msm/dpu_power_handle.h | 334 ++ drivers/gpu/drm/msm/dpu_rsc.c | 1367 ++++++ drivers/gpu/drm/msm/dpu_rsc_hw.c | 818 ++++ drivers/gpu/drm/msm/dpu_rsc_priv.h | 191 + drivers/gpu/drm/msm/dsi-staging/dsi_catalog.c | 241 + drivers/gpu/drm/msm/dsi-staging/dsi_catalog.h | 201 + drivers/gpu/drm/msm/dsi-staging/dsi_clk.h | 276 ++ drivers/gpu/drm/msm/dsi-staging/dsi_clk_manager.c | 1227 +++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.c | 2862 +++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.h | 635 +++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw.h | 752 +++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_1_4.c | 480 ++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_0.c | 234 + drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_2.c | 42 + drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_cmn.c | 1312 +++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_reg.h | 196 + drivers/gpu/drm/msm/dsi-staging/dsi_defs.h | 581 +++ drivers/gpu/drm/msm/dsi-staging/dsi_display.c | 4325 +++++++++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_display.h | 557 +++ drivers/gpu/drm/msm/dsi-staging/dsi_display_test.c | 114 + drivers/gpu/drm/msm/dsi-staging/dsi_display_test.h | 31 + drivers/gpu/drm/msm/dsi-staging/dsi_drm.c | 708 +++ drivers/gpu/drm/msm/dsi-staging/dsi_drm.h | 129 + drivers/gpu/drm/msm/dsi-staging/dsi_hw.h | 48 + drivers/gpu/drm/msm/dsi-staging/dsi_panel.c | 3521 ++++++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_panel.h | 262 + drivers/gpu/drm/msm/dsi-staging/dsi_phy.c | 935 ++++Quoted 8 lines
drivers/gpu/drm/msm/dsi-staging/dsi_phy.h | 235 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw.h | 260 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v2_0.c | 252 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v3_0.c | 447 ++ .../gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.c | 676 +++ .../gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.h | 144 + .../gpu/drm/msm/dsi-staging/dsi_phy_timing_v2_0.c | 126 + .../gpu/drm/msm/dsi-staging/dsi_phy_timing_v3_0.c | 107 +getting rid of the 2nd dsi driver in dsi-staging will cut off a big chunk of code, it is just shy of 25kloc
Quoted 6 lines
drivers/gpu/drm/msm/dsi-staging/dsi_pwr.c | 365 ++ drivers/gpu/drm/msm/dsi-staging/dsi_pwr.h | 93 + drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c | 26 +- drivers/gpu/drm/msm/msm_atomic.c | 446 +- drivers/gpu/drm/msm/msm_drv.c | 919 +++- drivers/gpu/drm/msm/msm_drv.h | 486 +-Quoted 8 lines
drivers/gpu/drm/msm/msm_fb.c | 10 +- drivers/gpu/drm/msm/msm_kms.h | 90 +- drivers/gpu/drm/msm/msm_prop.c | 688 +++ drivers/gpu/drm/msm/msm_prop.h | 438 ++ drivers/gpu/drm/msm/msm_rd.c | 58 +- drivers/platform/msm/Kconfig | 21 + drivers/platform/msm/Makefile | 4 + drivers/platform/msm/msm_ext_display.c | 525 ++I guess
msm_ext_display.cneeds to go awayQuoted 5 lines
include/drm/drm_connector.h | 19 + include/drm/drm_dp_helper.h | 23 + include/drm/drm_mipi_dsi.h | 4 + include/drm/drm_mode_object.h | 2 +- include/linux/dpu_io_util.h | 113 +Quoted 8 lines
include/linux/dpu_rsc.h | 302 ++ include/linux/msm_ext_display.h | 182 + include/uapi/drm/dpu_drm.h | 449 ++ include/uapi/drm/drm_fourcc.h | 32 + include/uapi/drm/drm_mode.h | 5 + include/uapi/drm/msm_drm.h | 79 + include/uapi/drm/msm_drm_pp.h | 345 ++ include/uapi/media/msm_media_info.h | 1376 ++++++and this
Quoted 2 lines
include/video/mipi_display.h | 4 + 236 files changed, 110234 insertions(+), 159 deletions(-)jfwiw, Sean an I have already cut out ~15k insertions from the inital version ;-)
BR,
-RQuoted 215 lines
create mode 100644
Documentation/devicetree/bindings/display/msm/dpu-rsc.txtcreate mode 100644Documentation/devicetree/bindings/display/msm/dpu.txtcreate mode 100644Documentation/devicetree/bindings/drm/msm/dpu-dp.txtcreate mode 100644Documentation/devicetree/bindings/drm/msm/dpu-dsi.txtcreate mode 100644Documentation/devicetree/bindings/drm/msm/dpu-wb.txtcreate mode 100644Documentation/devicetree/bindings/drm/msm/mdss-dsi-panel.txtcreate mode 100644Documentation/devicetree/bindings/fb/mdss-dsi-panel.txtcreate mode 100644Documentation/devicetree/bindings/fb/mdss-pll.txtcreate mode 100644Documentation/devicetree/bindings/msm_hdcp/msm_hdcp.txtcreate mode 100644arch/arm64/boot/dts/qcom/sdm845-dpu-display.dtsicreate mode 100644arch/arm64/boot/dts/qcom/sdm845-dpu.dtsi
create mode 100644drivers/clk/qcom/mdss/mdss-pll.h
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_connector.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_connector.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_fence.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_fence.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_formats.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_formats.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_common_v4.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_plane.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_plane.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_trace.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_wb.h
renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4.xml.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_crtc.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_dsi_encoder.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_dtv_encoder.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_irq.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_kms.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_kms.h(99%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_lcdc_encoder.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_lvds_connector.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_lvds_pll.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_plane.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5.xml.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_cfg.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_cfg.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_cmd_encoder.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_crtc.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_ctl.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_ctl.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_encoder.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_irq.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_kms.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_kms.h(99%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_mdss.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_mixer.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_mixer.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_pipe.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_pipe.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_plane.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_smp.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_smp.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp_common.xml.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp_format.c(98%)
renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp_kms.c(100%)
renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp_kms.h(99%)
create mode 100644drivers/gpu/drm/msm/dp/dp_audio.c
create mode 100644drivers/gpu/drm/msm/dp/dp_audio.h
create mode 100644drivers/gpu/drm/msm/dp/dp_aux.c
create mode 100644drivers/gpu/drm/msm/dp/dp_aux.h
create mode 100644drivers/gpu/drm/msm/dp/dp_catalog.c
create mode 100644drivers/gpu/drm/msm/dp/dp_catalog.h
create mode 100644drivers/gpu/drm/msm/dp/dp_ctrl.c
create mode 100644drivers/gpu/drm/msm/dp/dp_ctrl.h
create mode 100644drivers/gpu/drm/msm/dp/dp_debug.c
create mode 100644drivers/gpu/drm/msm/dp/dp_debug.h
create mode 100644drivers/gpu/drm/msm/dp/dp_display.c
create mode 100644drivers/gpu/drm/msm/dp/dp_display.h
create mode 100644drivers/gpu/drm/msm/dp/dp_drm.c
create mode 100644drivers/gpu/drm/msm/dp/dp_drm.h
create mode 100644drivers/gpu/drm/msm/dp/dp_hdcp2p2.c
create mode 100644drivers/gpu/drm/msm/dp/dp_link.c
create mode 100644drivers/gpu/drm/msm/dp/dp_link.h
create mode 100644drivers/gpu/drm/msm/dp/dp_panel.c
create mode 100644drivers/gpu/drm/msm/dp/dp_panel.h
create mode 100644drivers/gpu/drm/msm/dp/dp_parser.c
create mode 100644drivers/gpu/drm/msm/dp/dp_parser.h
create mode 100644drivers/gpu/drm/msm/dp/dp_power.c
create mode 100644drivers/gpu/drm/msm/dp/dp_power.h
create mode 100644drivers/gpu/drm/msm/dp/dp_reg.h
create mode 100644drivers/gpu/drm/msm/dp/dp_usbpd.c
create mode 100644drivers/gpu/drm/msm/dp/dp_usbpd.h
create mode 100644drivers/gpu/drm/msm/dpu_dbg.c
create mode 100644drivers/gpu/drm/msm/dpu_dbg.h
create mode 100644drivers/gpu/drm/msm/dpu_dbg_evtlog.c
create mode 100644drivers/gpu/drm/msm/dpu_edid_parser.c
create mode 100644drivers/gpu/drm/msm/dpu_edid_parser.h
create mode 100644drivers/gpu/drm/msm/dpu_hdcp.h
create mode 100644drivers/gpu/drm/msm/dpu_hdcp_1x.c
create mode 100644drivers/gpu/drm/msm/dpu_io_util.c
create mode 100644drivers/gpu/drm/msm/dpu_power_handle.c
create mode 100644drivers/gpu/drm/msm/dpu_power_handle.h
create mode 100644drivers/gpu/drm/msm/dpu_rsc.c
create mode 100644drivers/gpu/drm/msm/dpu_rsc_hw.c
create mode 100644drivers/gpu/drm/msm/dpu_rsc_priv.h
create mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_catalog.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_catalog.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_clk.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_clk_manager.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_1_4.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_0.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_2.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_cmn.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_reg.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_defs.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_display.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_display.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_display_test.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_display_test.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_drm.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_drm.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_hw.h
create mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_panel.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_panel.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v2_0.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v3_0.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_v2_0.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_v3_0.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_pwr.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_pwr.hcreate mode 100644drivers/gpu/drm/msm/msm_prop.c
create mode 100644drivers/gpu/drm/msm/msm_prop.h
create mode 100644drivers/platform/msm/Kconfig
create mode 100644drivers/platform/msm/Makefile
create mode 100644drivers/platform/msm/msm_ext_display.c
create mode 100644include/linux/dpu_io_util.h
create mode 100644include/linux/dpu_rsc.h
create mode 100644include/linux/msm_ext_display.h
create mode 100644include/uapi/drm/dpu_drm.h
create mode 100644include/uapi/drm/msm_drm_pp.h
create mode 100644include/uapi/media/msm_media_info.hQuoted 2 lines
--
Sean Paul, Software Engineer, Google / Chromium OS_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 1 line
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 114 lines · jsanka
Quoted 104 lines · Rob Clark
Quoted 19 lines · Sean Paul
Hi dri-devel,
Qualcomm has been working for the past few weeks on forward porting their downstream drm driver from 4.14 to mainline. Please consider this PR as a request for review, rather than an attempt at mainlining the code as it currently stands. The goal is get this driver in shape over the next coming
months.In the meantime, I'll be hosting a tree here [1] to stage the fixes. Patches
will be posted and reviewed on [email protected]. Once things look
good, I'll send another pull 4realz.To get the ball rolling, I've done some review on the new connector code, my
comments are below.Quoted 8 lines
Thanks in advance for your constructive feedback :)
Sean
[1]-
git://people.freedesktop.org/~seanpaul/dpu-stagingReview feedback:
----------------just so others aren't confused, s/sde/dpu/g in the list below (we did our
DAL->DCrename before sending first RFC :-P)Quoted 54 lines
- Solve the splash screen handling (or remove it)
- Simplify devicetree binding (remove register offsets) feedback from reviewingsde_connector.c:
- Rationalize backlight implementation insde_connector(display_countstatic)
- Sort out the dsi event passing between dsi/encoder/connector (move to encoder)
-include/uapi/drm/msm_drm_pp.hneeds opensource userspace (or removal)
-connector->stateaccess violations reading/writingmode_info
- s/sde_rect/drm_rect/
-sde_kms_infousage needs to be replaced with formal data structures (not
stringified keypairs)
-sde_connector_opsneeds to be trimmed, duplicates connector helpers, info
hooks circumvent state, and other hooks should be stored in state or prepopulated (get_dst_format)
-sde_connector_get_dpmsunused
- esd status check should migrate to encoder from connector
- backlight should be handled in panel drivers, not in the generic connector/dsi
encoder
-sde_connector_helper_bridge_disableis called from encoder and calls back into
set_powerencoder function. if backlight, and esd status are removed,pre_kickoffcan probably go away
-sde_connector_clk_ctrlis another example ofencoder->connector->encodercall
-RETIRE_FENCEconnector property should be removed, opting for the native
atomic fences
- ROI (regions of interest) should be expressed per-plane instead of connector.
there is work ongoing to supportdirty_rectsper-plane by Deepak Singh
Rawat
<[email protected]> and Lukasz Spintzyk
<[email protected]>
- Uma Shankar <[email protected]> has proposed HDR source metadata properties on the list, we should pivot to those instead of
hand-rolling them
in the sde driver
- Convert HDCP implementation to upstream Content Protection property
- Merge dsi anddsi_staginginto one driver
- Writeback connector has been proposed by ARM (Liviu Dudau and Brian Starkey),
we should work with their proposal instead of rollingOUT_FBourselves
-sde_connector_set_propertyshould be replaced with atomic helper
- dsi hotplug can probably be punted to the panel driver
- dpms should switch to enable/disable (or at least use the atomic helpers)
- dsi mode handling should also defer to the panel driver
-SDE_WB_CONFIGioctl should be removed in favor of the existing ioctl to add
user-defined modesQuoted 9 lines
- dp implementation should use the existing dp helpers wherever possible
- lots of duplicated structures indsi_defs.hthat can be replaced with existing
drm structs
-mode_validshould be split up and implemented directly in connector/encoder as
appropriate
-sde_connector->aspaceseems like it's unused?To add to that, a few things I've noticed (but I've mostly only gotten as far as the front-end of the pipeline, ie.
dpu_plane):- It looks like, as was the case with mdp4/mdp5 (and really most other
hw)
there are still unequal capabilities for planes (ie. some can do YUV, scaling, etc).Quoted 6 lines
But drm-hwc (or weston) isn't going to know about that, so I think
we'll
need to add support for dynamically assigningdpu_plane::pipe, similar to what mdp5 does w/ plane<->hwpipe. (Which I actually added
specificallyfor drm-hwc ;-))
Quoted 13 lines
We are working on plane virtualization focused primarily to support 4K / wider displays which cannot
be catered by one hwpipe. The plan is to gang up two *fixed* hwpipes of similar capabilities (in terms of formats,
sub hw blocks like scalar, post processing ) and expose them as a single plane so that user space
compositor ( drm-hwc or weston) need not worry about max pixel width supported by the planes. But mapping
planes <-> hwpipe dynamically may need more than just virtualization. Kernel need to keep track of hwpipes
especially when dealing with multiple displays. And it get complicated when planes start moving around CRTC's
for different sized buffers.
Hmm, a fixed mapping of hw pipe to plane might be an ok stepping stone. I'm not sure it is a terribly good final solution, esp. when it comes to external displays, since you may never need 4k+ scanout, depending on what the user plugs in, so you end up wasting a lot of hw pipes.
Keeping track of the hwpipes as part of the driver global atomic state isn't actually *that* hard. Have a look at what mdp5 does. We still need to move mdp5 to drm_private_obj instead of subclassing drm_atomic_state (see Archit's RFC, "drm/msm/mdp5: Add global state as a private atomic object"), but other than that detail, I think something along those lines is a better approach.
Quoted 9 lines
Given that DRM exposes planes with its own list of format/modifiers, I think its not that big of a deal for a
compositor to look up for plane to support the format and use it.Quoted 5 lines
- I *think* we also need the same trick for combining mixers under one
CRTC
for 4k modes too?
Quoted 5 lines
The uploaded patch set handles this case. We attach two layer mixers under one CRTC. Kernel also
takes care of dividing the given list of planes (and its hwpipes) to stage on the respective layer mixers
based on the destination coordinates (CRTC_X, _Y, _W and _H)
ahh, ok, good to know.. from a quick look (I haven't gotten thru the dpu_crtc.c code very far yet), I think you probably want to move the state about which mixers/ctls are used by the crtc into the crtc's atomic state, so that they can be dynamically assigned and (if necessary) the atomic update rejected at the test phase if there are insufficient mixers avail. (I guess how much that matters depends on whether there is ever a case that there aren't enough mixers to assign 2 to every crtc/output..)
BR,
-R
Quoted 572 lines
Quoted 559 lines
- in
dpu_plane, and perhaps elsewhere, userspace pointers for things
like CSC
and scaling coefficients need to be annotated w/__user. (Except the
should
probably be blob properties instead.. and we probably need to strip
out the
custom properties and re-introduce them separately with some userspace
+
review.)-
dpu_formats.clooks mostly like a superset ofmdp_format.c, ie there
is a
similar concept to how you describe the format to hw as mdp4/mdp5.
Probably
the additions indpu_formatsshould be folded back inmdp_format.I'm not sure how we want to balance adding new features with cleanup and hopefully removing some code. I suspect a fair chunk of
dpu_planeactually belongs indpu_plane_state, so maybe we can handle that as part of that cleanup.Few more below
Quoted 43 lines
The following changes since commit
9afe236df559d0dc6818f64e728a3f931a0a2231:drm/msm/dsi: Fix potential NULL pointer dereference in
msm_dsi_modeset_init(2018-02-12 10:25:15 -0500)are available in the Git repository at:
git://people.freedesktop.org/~seanpaul/dpu-stagingfor-next-compilesfor you to fetch changes up to
672005da148f82021a62d4fa658728e19f13097e:ARM: dts: msm: add device tree changes for SDM845 (2018-02-13 13:14:43
-0500)----------------------------------------------------------------
Jeykumar Sankaran (9):
dt-bindings: msm/dsi: Add mdp transfer time to msm dsi binding
dt-bindings: msm/disp: Add bindings for Snapdragon 845 DPU
drm: Core changes
drm/msm: add DPU DRM driver to support SDM845 drm/msm: Changemdp_get_formatarguments
drm/msm: Core msm changes
drm/msm: Add DSI Staging driver
drm/msm: Add DisplayPort support
ARM: dts: msm: add device tree changes for SDM845Manasi Navare (1):
drm/dp: Add HBR3 support in existing DRM DP helpersRob Clark (1):
drm/msm: rename mdp->disp.../devicetree/bindings/display/msm/dpu-rsc.txt | 96 + .../devicetree/bindings/display/msm/dpu.txt | 736 +++ .../devicetree/bindings/display/msm/dsi.txt | 16 + .../devicetree/bindings/drm/msm/dpu-dp.txt | 217 + .../devicetree/bindings/drm/msm/dpu-dsi.txt | 102 + .../devicetree/bindings/drm/msm/dpu-wb.txt | 23 + .../devicetree/bindings/drm/msm/mdss-dsi-panel.txt | 772 +++ .../devicetree/bindings/fb/mdss-dsi-panel.txt | 742 +++ Documentation/devicetree/bindings/fb/mdss-pll.txt | 103 + .../devicetree/bindings/msm_hdcp/msm_hdcp.txt | 14 +Quoted 8 lines
arch/arm64/boot/dts/qcom/sdm845-dpu-display.dtsi | 248 + arch/arm64/boot/dts/qcom/sdm845-dpu.dtsi | 541 +++ drivers/clk/qcom/mdss/mdss-pll.h | 240 + drivers/gpu/drm/drm_dp_helper.c | 4 + drivers/gpu/drm/drm_dp_mst_topology.c | 3 + drivers/gpu/drm/drm_edid.c | 77 + drivers/gpu/drm/drm_framebuffer.c | 3 +- drivers/gpu/drm/drm_mipi_dsi.c | 12 +-Some of these changes in drm core need to be split out.
Quoted 146 lines
drivers/gpu/drm/msm/Makefile | 98 +- drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h | 99 + .../gpu/drm/msm/disp/dpu1/dpu_color_processing.c | 1520 ++++++ .../gpu/drm/msm/disp/dpu1/dpu_color_processing.h | 120 + drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c | 1381 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_connector.h | 581 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 640 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 192 + drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 818 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 144 + drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5076 ++++++++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 661 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3838 +++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 220 + drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 561 +++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 1365 ++++++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 1045 ++++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 1369 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_fence.c | 404 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_fence.h | 190 + drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 1339 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 152 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c | 1443 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 155 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h | 53 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3287 +++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1050 ++++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 182 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c | 329 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.h | 139 + .../msm/disp/dpu1/dpu_hw_color_proc_common_v4.h | 69 + .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c | 242 + .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h | 40 + .../drm/msm/disp/dpu1/dpu_hw_color_processing.h | 20 + .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.c | 565 +++ .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.h | 92 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 657 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 275 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c | 149 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h | 111 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 252 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 100 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 209 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h | 220 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 1235 +++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 289 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 373 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 132 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 331 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 136 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 538 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 409 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 182 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 759 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h | 27 + .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c | 943 ++++ .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h | 75 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.c | 962 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.h | 192 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 1063 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 574 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 461 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 227 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 453 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 202 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c | 275 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h | 128 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 324 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.h | 187 + drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h | 60 + drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c | 112 + drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h | 59 + drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2099 ++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 547 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c | 220 + drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4774 ++++++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 296 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c | 139 + drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h | 310 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 1394 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 200 + drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 245 + drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 385 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h | 94 + drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c | 781 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_wb.h | 232 + drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4.xml.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_crtc.c | 0 .../drm/msm/{mdp => disp}/mdp4/mdp4_dsi_encoder.c | 0 .../drm/msm/{mdp => disp}/mdp4/mdp4_dtv_encoder.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_irq.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.h | 2 +- .../drm/msm/{mdp => disp}/mdp4/mdp4_lcdc_encoder.c | 0 .../msm/{mdp => disp}/mdp4/mdp4_lvds_connector.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lvds_pll.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp4/mdp4_plane.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5.xml.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.h | 0 .../drm/msm/{mdp => disp}/mdp5/mdp5_cmd_encoder.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_crtc.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.h | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_encoder.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_irq.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.h | 2 +- drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mdss.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.h | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_plane.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp_common.xml.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp_format.c | 5 +- drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.h | 2 +- drivers/gpu/drm/msm/dp/dp_audio.c | 796 +++ drivers/gpu/drm/msm/dp/dp_audio.h | 81 + drivers/gpu/drm/msm/dp/dp_aux.c | 570 +++ drivers/gpu/drm/msm/dp/dp_aux.h | 44 + drivers/gpu/drm/msm/dp/dp_catalog.c | 1320 +++++ drivers/gpu/drm/msm/dp/dp_catalog.h | 163 + drivers/gpu/drm/msm/dp/dp_ctrl.c | 1474 ++++++ drivers/gpu/drm/msm/dp/dp_ctrl.h | 50 + drivers/gpu/drm/msm/dp/dp_debug.c | 503 ++ drivers/gpu/drm/msm/dp/dp_debug.h | 60 + drivers/gpu/drm/msm/dp/dp_display.c | 1262 +++++ drivers/gpu/drm/msm/dp/dp_display.h | 52 + drivers/gpu/drm/msm/dp/dp_drm.c | 538 +++ drivers/gpu/drm/msm/dp/dp_drm.h | 96 + drivers/gpu/drm/msm/dp/dp_hdcp2p2.c | 927 ++++ drivers/gpu/drm/msm/dp/dp_link.c | 1548 ++++++ drivers/gpu/drm/msm/dp/dp_link.h | 184 + drivers/gpu/drm/msm/dp/dp_panel.c | 531 ++ drivers/gpu/drm/msm/dp/dp_panel.h | 116 + drivers/gpu/drm/msm/dp/dp_parser.c | 645 +++ drivers/gpu/drm/msm/dp/dp_parser.h | 200 + drivers/gpu/drm/msm/dp/dp_power.c | 623 +++ drivers/gpu/drm/msm/dp/dp_power.h | 58 +Quoted 8 lines
drivers/gpu/drm/msm/dp/dp_reg.h | 231 + drivers/gpu/drm/msm/dp/dp_usbpd.c | 491 ++ drivers/gpu/drm/msm/dp/dp_usbpd.h | 101 + drivers/gpu/drm/msm/dpu_dbg.c | 3325 +++++++++++++ drivers/gpu/drm/msm/dpu_dbg.h | 421 ++ drivers/gpu/drm/msm/dpu_dbg_evtlog.c | 306 ++ drivers/gpu/drm/msm/dpu_edid_parser.c | 657 +++ drivers/gpu/drm/msm/dpu_edid_parser.h | 166 +let's not have our own edid parser ;-)
I guess this is a symptom of some enhancements needed in
drm_edidQuoted 33 lines
drivers/gpu/drm/msm/dpu_hdcp.h | 74 + drivers/gpu/drm/msm/dpu_hdcp_1x.c | 1579 ++++++ drivers/gpu/drm/msm/dpu_io_util.c | 507 ++ drivers/gpu/drm/msm/dpu_power_handle.c | 1128 +++++ drivers/gpu/drm/msm/dpu_power_handle.h | 334 ++ drivers/gpu/drm/msm/dpu_rsc.c | 1367 ++++++ drivers/gpu/drm/msm/dpu_rsc_hw.c | 818 ++++ drivers/gpu/drm/msm/dpu_rsc_priv.h | 191 + drivers/gpu/drm/msm/dsi-staging/dsi_catalog.c | 241 + drivers/gpu/drm/msm/dsi-staging/dsi_catalog.h | 201 + drivers/gpu/drm/msm/dsi-staging/dsi_clk.h | 276 ++ drivers/gpu/drm/msm/dsi-staging/dsi_clk_manager.c | 1227 +++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.c | 2862 +++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.h | 635 +++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw.h | 752 +++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_1_4.c | 480 ++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_0.c | 234 + drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_2.c | 42 + drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_cmn.c | 1312 +++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_reg.h | 196 + drivers/gpu/drm/msm/dsi-staging/dsi_defs.h | 581 +++ drivers/gpu/drm/msm/dsi-staging/dsi_display.c | 4325 +++++++++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_display.h | 557 +++ drivers/gpu/drm/msm/dsi-staging/dsi_display_test.c | 114 + drivers/gpu/drm/msm/dsi-staging/dsi_display_test.h | 31 + drivers/gpu/drm/msm/dsi-staging/dsi_drm.c | 708 +++ drivers/gpu/drm/msm/dsi-staging/dsi_drm.h | 129 + drivers/gpu/drm/msm/dsi-staging/dsi_hw.h | 48 + drivers/gpu/drm/msm/dsi-staging/dsi_panel.c | 3521 ++++++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_panel.h | 262 + drivers/gpu/drm/msm/dsi-staging/dsi_phy.c | 935 ++++Quoted 8 lines
drivers/gpu/drm/msm/dsi-staging/dsi_phy.h | 235 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw.h | 260 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v2_0.c | 252 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v3_0.c | 447 ++ .../gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.c | 676 +++ .../gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.h | 144 + .../gpu/drm/msm/dsi-staging/dsi_phy_timing_v2_0.c | 126 + .../gpu/drm/msm/dsi-staging/dsi_phy_timing_v3_0.c | 107 +getting rid of the 2nd dsi driver in dsi-staging will cut off a big chunk of code, it is just shy of 25kloc
Quoted 6 lines
drivers/gpu/drm/msm/dsi-staging/dsi_pwr.c | 365 ++ drivers/gpu/drm/msm/dsi-staging/dsi_pwr.h | 93 + drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c | 26 +- drivers/gpu/drm/msm/msm_atomic.c | 446 +- drivers/gpu/drm/msm/msm_drv.c | 919 +++- drivers/gpu/drm/msm/msm_drv.h | 486 +-Quoted 8 lines
drivers/gpu/drm/msm/msm_fb.c | 10 +- drivers/gpu/drm/msm/msm_kms.h | 90 +- drivers/gpu/drm/msm/msm_prop.c | 688 +++ drivers/gpu/drm/msm/msm_prop.h | 438 ++ drivers/gpu/drm/msm/msm_rd.c | 58 +- drivers/platform/msm/Kconfig | 21 + drivers/platform/msm/Makefile | 4 + drivers/platform/msm/msm_ext_display.c | 525 ++I guess
msm_ext_display.cneeds to go awayQuoted 5 lines
include/drm/drm_connector.h | 19 + include/drm/drm_dp_helper.h | 23 + include/drm/drm_mipi_dsi.h | 4 + include/drm/drm_mode_object.h | 2 +- include/linux/dpu_io_util.h | 113 +Quoted 8 lines
include/linux/dpu_rsc.h | 302 ++ include/linux/msm_ext_display.h | 182 + include/uapi/drm/dpu_drm.h | 449 ++ include/uapi/drm/drm_fourcc.h | 32 + include/uapi/drm/drm_mode.h | 5 + include/uapi/drm/msm_drm.h | 79 + include/uapi/drm/msm_drm_pp.h | 345 ++ include/uapi/media/msm_media_info.h | 1376 ++++++and this
Quoted 2 lines
include/video/mipi_display.h | 4 + 236 files changed, 110234 insertions(+), 159 deletions(-)jfwiw, Sean an I have already cut out ~15k insertions from the inital version ;-)
BR,
-RQuoted 234 lines
create mode 100644
Documentation/devicetree/bindings/display/msm/dpu-rsc.txt
create mode 100644Documentation/devicetree/bindings/display/msm/dpu.txt
create mode 100644Documentation/devicetree/bindings/drm/msm/dpu-dp.txtcreate mode 100644Documentation/devicetree/bindings/drm/msm/dpu-dsi.txt
create mode 100644Documentation/devicetree/bindings/drm/msm/dpu-wb.txtcreate mode 100644Documentation/devicetree/bindings/drm/msm/mdss-dsi-panel.txt
create mode 100644Documentation/devicetree/bindings/fb/mdss-dsi-panel.txt
create mode 100644Documentation/devicetree/bindings/fb/mdss-pll.txtcreate mode 100644Documentation/devicetree/bindings/msm_hdcp/msm_hdcp.txt
create mode 100644arch/arm64/boot/dts/qcom/sdm845-dpu-display.dtsicreate mode 100644arch/arm64/boot/dts/qcom/sdm845-dpu.dtsicreate mode 100644drivers/clk/qcom/mdss/mdss-pll.h
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_connector.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_connector.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_fence.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_fence.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_formats.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_formats.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_common_v4.h
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing.h
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.c
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.h
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h
create mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_irq.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_irq.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_kms.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_kms.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_plane.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_plane.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_rm.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_rm.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_trace.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.hcreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_wb.ccreate mode 100644drivers/gpu/drm/msm/disp/dpu1/dpu_wb.hrenamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4.xml.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_crtc.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_dsi_encoder.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_dtv_encoder.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_irq.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_kms.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_kms.h(99%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_lcdc_encoder.c
(100%)
renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_lvds_connector.c
(100%)
renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_lvds_pll.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp4/mdp4_plane.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5.xml.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_cfg.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_cfg.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_cmd_encoder.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_crtc.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_ctl.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_ctl.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_encoder.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_irq.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_kms.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_kms.h(99%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_mdss.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_mixer.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_mixer.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_pipe.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_pipe.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_plane.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_smp.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp5/mdp5_smp.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp_common.xml.h(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp_format.c(98%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp_kms.c(100%) renamedrivers/gpu/drm/msm/{mdp=>disp}/mdp_kms.h(99%) create mode 100644drivers/gpu/drm/msm/dp/dp_audio.c
create mode 100644drivers/gpu/drm/msm/dp/dp_audio.h
create mode 100644drivers/gpu/drm/msm/dp/dp_aux.c
create mode 100644drivers/gpu/drm/msm/dp/dp_aux.h
create mode 100644drivers/gpu/drm/msm/dp/dp_catalog.ccreate mode 100644drivers/gpu/drm/msm/dp/dp_catalog.hcreate mode 100644drivers/gpu/drm/msm/dp/dp_ctrl.c
create mode 100644drivers/gpu/drm/msm/dp/dp_ctrl.h
create mode 100644drivers/gpu/drm/msm/dp/dp_debug.c
create mode 100644drivers/gpu/drm/msm/dp/dp_debug.h
create mode 100644drivers/gpu/drm/msm/dp/dp_display.ccreate mode 100644drivers/gpu/drm/msm/dp/dp_display.hcreate mode 100644drivers/gpu/drm/msm/dp/dp_drm.c
create mode 100644drivers/gpu/drm/msm/dp/dp_drm.h
create mode 100644drivers/gpu/drm/msm/dp/dp_hdcp2p2.ccreate mode 100644drivers/gpu/drm/msm/dp/dp_link.c
create mode 100644drivers/gpu/drm/msm/dp/dp_link.h
create mode 100644drivers/gpu/drm/msm/dp/dp_panel.c
create mode 100644drivers/gpu/drm/msm/dp/dp_panel.h
create mode 100644drivers/gpu/drm/msm/dp/dp_parser.ccreate mode 100644drivers/gpu/drm/msm/dp/dp_parser.hcreate mode 100644drivers/gpu/drm/msm/dp/dp_power.c
create mode 100644drivers/gpu/drm/msm/dp/dp_power.h
create mode 100644drivers/gpu/drm/msm/dp/dp_reg.h
create mode 100644drivers/gpu/drm/msm/dp/dp_usbpd.c
create mode 100644drivers/gpu/drm/msm/dp/dp_usbpd.h
create mode 100644drivers/gpu/drm/msm/dpu_dbg.c
create mode 100644drivers/gpu/drm/msm/dpu_dbg.h
create mode 100644drivers/gpu/drm/msm/dpu_dbg_evtlog.ccreate mode 100644drivers/gpu/drm/msm/dpu_edid_parser.ccreate mode 100644drivers/gpu/drm/msm/dpu_edid_parser.hcreate mode 100644drivers/gpu/drm/msm/dpu_hdcp.h
create mode 100644drivers/gpu/drm/msm/dpu_hdcp_1x.c
create mode 100644drivers/gpu/drm/msm/dpu_io_util.c
create mode 100644drivers/gpu/drm/msm/dpu_power_handle.ccreate mode 100644drivers/gpu/drm/msm/dpu_power_handle.hcreate mode 100644drivers/gpu/drm/msm/dpu_rsc.c
create mode 100644drivers/gpu/drm/msm/dpu_rsc_hw.c
create mode 100644drivers/gpu/drm/msm/dpu_rsc_priv.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_catalog.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_catalog.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_clk.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_clk_manager.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_1_4.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_0.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_2.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_cmn.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_reg.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_defs.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_display.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_display.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_display_test.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_display_test.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_drm.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_drm.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_hw.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_panel.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_panel.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw.hcreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v2_0.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v3_0.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.c
create mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.h
create mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_v2_0.c
create mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_v3_0.c
create mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_pwr.ccreate mode 100644drivers/gpu/drm/msm/dsi-staging/dsi_pwr.hcreate mode 100644drivers/gpu/drm/msm/msm_prop.c
create mode 100644drivers/gpu/drm/msm/msm_prop.h
create mode 100644drivers/platform/msm/Kconfig
create mode 100644drivers/platform/msm/Makefile
create mode 100644drivers/platform/msm/msm_ext_display.ccreate mode 100644include/linux/dpu_io_util.h
create mode 100644include/linux/dpu_rsc.h
create mode 100644include/linux/msm_ext_display.h
create mode 100644include/uapi/drm/dpu_drm.h
create mode 100644include/uapi/drm/msm_drm_pp.h
create mode 100644include/uapi/media/msm_media_info.hQuoted 7 lines
Quoted 2 lines
--
Sean Paul, Software Engineer, Google / Chromium OS_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
A message that is not in the archive (sent off-list or not yet received): CAF6AEGsPTWFzaHTATeGAoQkCiOObZ4WzKr1yPFFd3k3wO1=AnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Quoted 35 lines · Rob Clark
Quoted 14 lines · jsanka
Quoted 6 lines · Rob Clark
- It looks like, as was the case with mdp4/mdp5 (and really most other
hw)
there are still unequal capabilities for planes (ie. some can do YUV, scaling, etc).Quoted 6 lines
But drm-hwc (or weston) isn't going to know about that, so I think
we'll
need to add support for dynamically assigningdpu_plane::pipe, similar to what mdp5 does w/ plane<->hwpipe. (Which I actually added
specificallyfor drm-hwc ;-))Quoted 13 lines
We are working on plane virtualization focused primarily to support 4K / wider displays which cannot
be catered by one hwpipe. The plan is to gang up two *fixed* hwpipes of similar capabilities (in terms of formats,
sub hw blocks like scalar, post processing ) and expose them as a single plane so that user space
compositor ( drm-hwc or weston) need not worry about max pixel width supported by the planes. But mapping
planes <-> hwpipe dynamically may need more than just virtualization. Kernel need to keep track of hwpipes
especially when dealing with multiple displays. And it get complicated when planes start moving around CRTC's
for different sized buffers.Hmm, a fixed mapping of hw pipe to plane might be an ok stepping stone. I'm not sure it is a terribly good final solution, esp. when it comes to external displays, since you may never need 4k+ scanout, depending on what the user plugs in, so you end up wasting a lot of hw pipes.
Quoted 7 lines
Keeping track of the hwpipes as part of the driver global atomic state isn't actually *that* hard. Have a look at what mdp5 does. We still need to move mdp5 to
drm_private_objinstead of subclassingdrm_atomic_state(see Archit's RFC, "drm/msm/mdp5: Add global state as a private atomic object"), but other than that detail, I think something along those lines is a better approach.
One additional point that I thought about, while implementing writeback on mdp5.. I think with a cmd-mode panel (and dp psr?) we could re-use idle hwpipes (ie. while not pushing an update out to the panel) with a different crtc (LM) and writeback connector to flatten all the layers to a single buffer while the screen is static, without having to remove the drm planes from the crtc. I think that would be a lot less confusing than figuring out somehow that removing a plane from a crtc shouldn't be flushed out to the panel.
BR,
-R
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoted 81 lines · Rob Clark
Quoted 14 lines · Sean Paul
Hi dri-devel,
Qualcomm has been working for the past few weeks on forward porting their downstream drm driver from 4.14 to mainline. Please consider this PR as a request for review, rather than an attempt at mainlining the code as it currently stands. The goal is get this driver in shape over the next coming months.In the meantime, I'll be hosting a tree here [1] to stage the fixes. Patches will be posted and reviewed on [email protected]. Once things look good, I'll send another pull 4realz.
To get the ball rolling, I've done some review on the new connector code, my comments are below.
Quoted 8 lines
Thanks in advance for your constructive feedback :)
Sean
[1]-
git://people.freedesktop.org/~seanpaul/dpu-stagingReview feedback:
----------------just so others aren't confused, s/sde/dpu/g in the list below (we did our
DAL->DCrename before sending first RFC :-P)Quoted 37 lines
- Solve the splash screen handling (or remove it)
- Simplify devicetree binding (remove register offsets)
feedback from reviewingsde_connector.c:
- Rationalize backlight implementation insde_connector(display_countstatic)
- Sort out the dsi event passing between dsi/encoder/connector (move to encoder)
-include/uapi/drm/msm_drm_pp.hneeds opensource userspace (or removal)
-connector->stateaccess violations reading/writingmode_info
- s/sde_rect/drm_rect/
-sde_kms_infousage needs to be replaced with formal data structures (not stringified keypairs)
-sde_connector_opsneeds to be trimmed, duplicates connector helpers, info hooks circumvent state, and other hooks should be stored in state or prepopulated (get_dst_format)
-sde_connector_get_dpmsunused
- esd status check should migrate to encoder from connector
- backlight should be handled in panel drivers, not in the generic connector/dsi encoder
-sde_connector_helper_bridge_disableis called from encoder and calls back intoset_powerencoder function. if backlight, and esd status are removed,pre_kickoffcan probably go away
-sde_connector_clk_ctrlis another example ofencoder->connector->encodercall
-RETIRE_FENCEconnector property should be removed, opting for the native atomic fences
- ROI (regions of interest) should be expressed per-plane instead of connector. there is work ongoing to supportdirty_rectsper-plane by Deepak Singh Rawat <[email protected]> and Lukasz Spintzyk <[email protected]>
- Uma Shankar <[email protected]> has proposed HDR source metadata properties on the list, we should pivot to those instead of hand-rolling them in the sde driver
- Convert HDCP implementation to upstream Content Protection property
- Merge dsi anddsi_staginginto one driver
- Writeback connector has been proposed by ARM (Liviu Dudau and Brian Starkey), we should work with their proposal instead of rollingOUT_FBourselves
-sde_connector_set_propertyshould be replaced with atomic helper
- dsi hotplug can probably be punted to the panel driver
- dpms should switch to enable/disable (or at least use the atomic helpers)
- dsi mode handling should also defer to the panel driverQuoted 9 lines
-
SDE_WB_CONFIGioctl should be removed in favor of the existing ioctl to add user-defined modes
- dp implementation should use the existing dp helpers wherever possible
- lots of duplicated structures indsi_defs.hthat can be replaced with existing drm structs
-mode_validshould be split up and implemented directly in connector/encoder as appropriate
-sde_connector->aspaceseems like it's unused?To add to that, a few things I've noticed (but I've mostly only gotten as far as the front-end of the pipeline, ie.
dpu_plane):- It looks like, as was the case with mdp4/mdp5 (and really most other hw) there are still unequal capabilities for planes (ie. some can do YUV, scaling, etc).
Quoted 7 lines
But drm-hwc (or weston) isn't going to know about that, so I think we'll need to add support for dynamically assigning
dpu_plane::pipe, similar to what mdp5 does w/ plane<->hwpipe. (Which I actually added specifically for drm-hwc ;-))- I *think* we also need the same trick for combining mixers under one CRTC for 4k modes too?
Sounds like this should reuse the mdp5 framework in msm, at least in parts? Reinventing the same virtualization will get boring :-)
Quoted 5 lines
- in
dpu_plane, and perhaps elsewhere, userspace pointers for things like CSC and scaling coefficients need to be annotated w/__user. (Except the should probably be blob properties instead.. and we probably need to strip out the custom properties and re-introduce them separately with some userspace + review.)
Just a general reminder: uapi is uapi, even if it's hidden behind pointers or properties, or other stuff. So usual rules apply:
- we need proper review of the stuff
- we need real open source userspace for it all
- where it makes sense, we really need to have it standardized across drivers (we've dug ourselves a bit a hole in that regard with the initial set of plane/crtc properties, which was a bit too much free for all).
My recommendation for new driver codebases is to just disable all the nonstandard stuff for the initial upstreaming (you can keep the back-end code, that's what we've done in parts with DC). This unblocks the basic enabling from the uapi discussions.
But most of it is highlighted in Sean's mail already.
Quoted 8 lines
-
dpu_formats.clooks mostly like a superset ofmdp_format.c, ie there is a similar concept to how you describe the format to hw as mdp4/mdp5. Probably the additions indpu_formatsshould be folded back inmdp_format.I'm not sure how we want to balance adding new features with cleanup and hopefully removing some code. I suspect a fair chunk of
dpu_planeactually belongs indpu_plane_state, so maybe we can handle that as part of that cleanup.
Wrt the precise balance between getting things upstream quickly and not ending up with a complete turd that reinvents everything I'll leave that to you and Sean to figure out. Imo the much more important part is whether the original authors want (and actually can, and have shown to) engage with upstream. That's what made me ack AMD's DC, not so much the state of the code itself - given how fast gpus move, that will always be in slight state of disrepair :-)
Cheers, Daniel
Quoted 517 lines
Few more below
Quoted 41 lines
The following changes since commit
9afe236df559d0dc6818f64e728a3f931a0a2231:drm/msm/dsi: Fix potential NULL pointer dereference in
msm_dsi_modeset_init(2018-02-12 10:25:15 -0500)are available in the Git repository at:
git://people.freedesktop.org/~seanpaul/dpu-stagingfor-next-compilesfor you to fetch changes up to
672005da148f82021a62d4fa658728e19f13097e:ARM: dts: msm: add device tree changes for SDM845 (2018-02-13 13:14:43 -0500)
----------------------------------------------------------------
Jeykumar Sankaran (9):
dt-bindings: msm/dsi: Add mdp transfer time to msm dsi binding
dt-bindings: msm/disp: Add bindings for Snapdragon 845 DPU
drm: Core changes
drm/msm: add DPU DRM driver to support SDM845 drm/msm: Changemdp_get_formatarguments
drm/msm: Core msm changes
drm/msm: Add DSI Staging driver
drm/msm: Add DisplayPort support
ARM: dts: msm: add device tree changes for SDM845Manasi Navare (1):
drm/dp: Add HBR3 support in existing DRM DP helpersRob Clark (1):
drm/msm: rename mdp->disp.../devicetree/bindings/display/msm/dpu-rsc.txt | 96 + .../devicetree/bindings/display/msm/dpu.txt | 736 +++ .../devicetree/bindings/display/msm/dsi.txt | 16 + .../devicetree/bindings/drm/msm/dpu-dp.txt | 217 + .../devicetree/bindings/drm/msm/dpu-dsi.txt | 102 + .../devicetree/bindings/drm/msm/dpu-wb.txt | 23 + .../devicetree/bindings/drm/msm/mdss-dsi-panel.txt | 772 +++ .../devicetree/bindings/fb/mdss-dsi-panel.txt | 742 +++ Documentation/devicetree/bindings/fb/mdss-pll.txt | 103 + .../devicetree/bindings/msm_hdcp/msm_hdcp.txt | 14 +Quoted 8 lines
arch/arm64/boot/dts/qcom/sdm845-dpu-display.dtsi | 248 + arch/arm64/boot/dts/qcom/sdm845-dpu.dtsi | 541 +++ drivers/clk/qcom/mdss/mdss-pll.h | 240 + drivers/gpu/drm/drm_dp_helper.c | 4 + drivers/gpu/drm/drm_dp_mst_topology.c | 3 + drivers/gpu/drm/drm_edid.c | 77 + drivers/gpu/drm/drm_framebuffer.c | 3 +- drivers/gpu/drm/drm_mipi_dsi.c | 12 +-Some of these changes in drm core need to be split out.
Quoted 143 lines
drivers/gpu/drm/msm/Makefile | 98 +- drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h | 99 + .../gpu/drm/msm/disp/dpu1/dpu_color_processing.c | 1520 ++++++ .../gpu/drm/msm/disp/dpu1/dpu_color_processing.h | 120 + drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c | 1381 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_connector.h | 581 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 640 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 192 + drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 818 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 144 + drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5076 ++++++++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 661 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3838 +++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 220 + drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 561 +++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 1365 ++++++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 1045 ++++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 1369 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_fence.c | 404 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_fence.h | 190 + drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 1339 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 152 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c | 1443 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 155 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h | 53 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3287 +++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1050 ++++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 182 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c | 329 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.h | 139 + .../msm/disp/dpu1/dpu_hw_color_proc_common_v4.h | 69 + .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c | 242 + .../gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h | 40 + .../drm/msm/disp/dpu1/dpu_hw_color_processing.h | 20 + .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.c | 565 +++ .../msm/disp/dpu1/dpu_hw_color_processing_v1_7.h | 92 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 657 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 275 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c | 149 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h | 111 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 252 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 100 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 209 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h | 220 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 1235 +++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 289 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 373 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 132 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 331 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 136 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 538 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 409 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 182 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 759 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h | 27 + .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c | 943 ++++ .../msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h | 75 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.c | 962 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.h | 192 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 1063 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 574 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 461 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 227 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 453 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 202 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c | 275 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h | 128 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 324 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.h | 187 + drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h | 60 + drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c | 112 + drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h | 59 + drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2099 ++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 547 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c | 220 + drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4774 ++++++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 296 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c | 139 + drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h | 310 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 1394 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 200 + drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 245 + drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 385 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h | 94 + drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c | 781 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_wb.h | 232 + drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4.xml.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_crtc.c | 0 .../drm/msm/{mdp => disp}/mdp4/mdp4_dsi_encoder.c | 0 .../drm/msm/{mdp => disp}/mdp4/mdp4_dtv_encoder.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_irq.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.h | 2 +- .../drm/msm/{mdp => disp}/mdp4/mdp4_lcdc_encoder.c | 0 .../msm/{mdp => disp}/mdp4/mdp4_lvds_connector.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lvds_pll.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp4/mdp4_plane.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5.xml.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.h | 0 .../drm/msm/{mdp => disp}/mdp5/mdp5_cmd_encoder.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_crtc.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.h | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_encoder.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_irq.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.h | 2 +- drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mdss.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.c | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.h | 0 .../gpu/drm/msm/{mdp => disp}/mdp5/mdp5_plane.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp_common.xml.h | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp_format.c | 5 +- drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.c | 0 drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.h | 2 +- drivers/gpu/drm/msm/dp/dp_audio.c | 796 +++ drivers/gpu/drm/msm/dp/dp_audio.h | 81 + drivers/gpu/drm/msm/dp/dp_aux.c | 570 +++ drivers/gpu/drm/msm/dp/dp_aux.h | 44 + drivers/gpu/drm/msm/dp/dp_catalog.c | 1320 +++++ drivers/gpu/drm/msm/dp/dp_catalog.h | 163 + drivers/gpu/drm/msm/dp/dp_ctrl.c | 1474 ++++++ drivers/gpu/drm/msm/dp/dp_ctrl.h | 50 + drivers/gpu/drm/msm/dp/dp_debug.c | 503 ++ drivers/gpu/drm/msm/dp/dp_debug.h | 60 + drivers/gpu/drm/msm/dp/dp_display.c | 1262 +++++ drivers/gpu/drm/msm/dp/dp_display.h | 52 + drivers/gpu/drm/msm/dp/dp_drm.c | 538 +++ drivers/gpu/drm/msm/dp/dp_drm.h | 96 + drivers/gpu/drm/msm/dp/dp_hdcp2p2.c | 927 ++++ drivers/gpu/drm/msm/dp/dp_link.c | 1548 ++++++ drivers/gpu/drm/msm/dp/dp_link.h | 184 + drivers/gpu/drm/msm/dp/dp_panel.c | 531 ++ drivers/gpu/drm/msm/dp/dp_panel.h | 116 + drivers/gpu/drm/msm/dp/dp_parser.c | 645 +++ drivers/gpu/drm/msm/dp/dp_parser.h | 200 + drivers/gpu/drm/msm/dp/dp_power.c | 623 +++ drivers/gpu/drm/msm/dp/dp_power.h | 58 +Quoted 8 lines
drivers/gpu/drm/msm/dp/dp_reg.h | 231 + drivers/gpu/drm/msm/dp/dp_usbpd.c | 491 ++ drivers/gpu/drm/msm/dp/dp_usbpd.h | 101 + drivers/gpu/drm/msm/dpu_dbg.c | 3325 +++++++++++++ drivers/gpu/drm/msm/dpu_dbg.h | 421 ++ drivers/gpu/drm/msm/dpu_dbg_evtlog.c | 306 ++ drivers/gpu/drm/msm/dpu_edid_parser.c | 657 +++ drivers/gpu/drm/msm/dpu_edid_parser.h | 166 +let's not have our own edid parser ;-)
I guess this is a symptom of some enhancements needed in
drm_edidQuoted 31 lines
drivers/gpu/drm/msm/dpu_hdcp.h | 74 + drivers/gpu/drm/msm/dpu_hdcp_1x.c | 1579 ++++++ drivers/gpu/drm/msm/dpu_io_util.c | 507 ++ drivers/gpu/drm/msm/dpu_power_handle.c | 1128 +++++ drivers/gpu/drm/msm/dpu_power_handle.h | 334 ++ drivers/gpu/drm/msm/dpu_rsc.c | 1367 ++++++ drivers/gpu/drm/msm/dpu_rsc_hw.c | 818 ++++ drivers/gpu/drm/msm/dpu_rsc_priv.h | 191 + drivers/gpu/drm/msm/dsi-staging/dsi_catalog.c | 241 + drivers/gpu/drm/msm/dsi-staging/dsi_catalog.h | 201 + drivers/gpu/drm/msm/dsi-staging/dsi_clk.h | 276 ++ drivers/gpu/drm/msm/dsi-staging/dsi_clk_manager.c | 1227 +++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.c | 2862 +++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.h | 635 +++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw.h | 752 +++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_1_4.c | 480 ++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_0.c | 234 + drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_2.c | 42 + drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_cmn.c | 1312 +++++ drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_reg.h | 196 + drivers/gpu/drm/msm/dsi-staging/dsi_defs.h | 581 +++ drivers/gpu/drm/msm/dsi-staging/dsi_display.c | 4325 +++++++++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_display.h | 557 +++ drivers/gpu/drm/msm/dsi-staging/dsi_display_test.c | 114 + drivers/gpu/drm/msm/dsi-staging/dsi_display_test.h | 31 + drivers/gpu/drm/msm/dsi-staging/dsi_drm.c | 708 +++ drivers/gpu/drm/msm/dsi-staging/dsi_drm.h | 129 + drivers/gpu/drm/msm/dsi-staging/dsi_hw.h | 48 + drivers/gpu/drm/msm/dsi-staging/dsi_panel.c | 3521 ++++++++++++++ drivers/gpu/drm/msm/dsi-staging/dsi_panel.h | 262 + drivers/gpu/drm/msm/dsi-staging/dsi_phy.c | 935 ++++Quoted 8 lines
drivers/gpu/drm/msm/dsi-staging/dsi_phy.h | 235 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw.h | 260 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v2_0.c | 252 + drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v3_0.c | 447 ++ .../gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.c | 676 +++ .../gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.h | 144 + .../gpu/drm/msm/dsi-staging/dsi_phy_timing_v2_0.c | 126 + .../gpu/drm/msm/dsi-staging/dsi_phy_timing_v3_0.c | 107 +getting rid of the 2nd dsi driver in dsi-staging will cut off a big chunk of code, it is just shy of 25kloc
Quoted 6 lines
drivers/gpu/drm/msm/dsi-staging/dsi_pwr.c | 365 ++ drivers/gpu/drm/msm/dsi-staging/dsi_pwr.h | 93 + drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c | 26 +- drivers/gpu/drm/msm/msm_atomic.c | 446 +- drivers/gpu/drm/msm/msm_drv.c | 919 +++- drivers/gpu/drm/msm/msm_drv.h | 486 +-Quoted 8 lines
drivers/gpu/drm/msm/msm_fb.c | 10 +- drivers/gpu/drm/msm/msm_kms.h | 90 +- drivers/gpu/drm/msm/msm_prop.c | 688 +++ drivers/gpu/drm/msm/msm_prop.h | 438 ++ drivers/gpu/drm/msm/msm_rd.c | 58 +- drivers/platform/msm/Kconfig | 21 + drivers/platform/msm/Makefile | 4 + drivers/platform/msm/msm_ext_display.c | 525 ++I guess
msm_ext_display.cneeds to go awayQuoted 5 lines
include/drm/drm_connector.h | 19 + include/drm/drm_dp_helper.h | 23 + include/drm/drm_mipi_dsi.h | 4 + include/drm/drm_mode_object.h | 2 +- include/linux/dpu_io_util.h | 113 +Quoted 8 lines
include/linux/dpu_rsc.h | 302 ++ include/linux/msm_ext_display.h | 182 + include/uapi/drm/dpu_drm.h | 449 ++ include/uapi/drm/drm_fourcc.h | 32 + include/uapi/drm/drm_mode.h | 5 + include/uapi/drm/msm_drm.h | 79 + include/uapi/drm/msm_drm_pp.h | 345 ++ include/uapi/media/msm_media_info.h | 1376 ++++++and this
Quoted 2 lines
include/video/mipi_display.h | 4 + 236 files changed, 110234 insertions(+), 159 deletions(-)jfwiw, Sean an I have already cut out ~15k insertions from the inital version ;-)
BR,
-RQuoted 215 lines
create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-rsc.txt create mode 100644 Documentation/devicetree/bindings/display/msm/dpu.txt create mode 100644 Documentation/devicetree/bindings/drm/msm/dpu-dp.txt create mode 100644 Documentation/devicetree/bindings/drm/msm/dpu-dsi.txt create mode 100644 Documentation/devicetree/bindings/drm/msm/dpu-wb.txt create mode 100644 Documentation/devicetree/bindings/drm/msm/mdss-dsi-panel.txt create mode 100644 Documentation/devicetree/bindings/fb/mdss-dsi-panel.txt create mode 100644 Documentation/devicetree/bindings/fb/mdss-pll.txt create mode 100644 Documentation/devicetree/bindings/msm_hdcp/msm_hdcp.txt create mode 100644 arch/arm64/boot/dts/qcom/sdm845-dpu-display.dtsi create mode 100644 arch/arm64/boot/dts/qcom/sdm845-dpu.dtsi create mode 100644 drivers/clk/qcom/mdss/mdss-pll.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_ad4.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_color_processing.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_connector.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_fence.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_fence.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ad4.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_common_v4.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_proc_v4.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_color_processing_v1_7.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1_color_proc.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_rot.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_wb.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_wb.h rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4.xml.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_crtc.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_dsi_encoder.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_dtv_encoder.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_irq.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_kms.h (99%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lcdc_encoder.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lvds_connector.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_lvds_pll.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp4/mdp4_plane.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5.xml.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cfg.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_cmd_encoder.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_crtc.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_ctl.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_encoder.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_irq.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_kms.h (99%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mdss.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_mixer.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_pipe.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_plane.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp5/mdp5_smp.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp_common.xml.h (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp_format.c (98%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.c (100%) rename drivers/gpu/drm/msm/{mdp => disp}/mdp_kms.h (99%) create mode 100644 drivers/gpu/drm/msm/dp/dp_audio.c create mode 100644 drivers/gpu/drm/msm/dp/dp_audio.h create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.c create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.h create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.c create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.h create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.c create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.h create mode 100644 drivers/gpu/drm/msm/dp/dp_debug.c create mode 100644 drivers/gpu/drm/msm/dp/dp_debug.h create mode 100644 drivers/gpu/drm/msm/dp/dp_display.c create mode 100644 drivers/gpu/drm/msm/dp/dp_display.h create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.c create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.h create mode 100644 drivers/gpu/drm/msm/dp/dp_hdcp2p2.c create mode 100644 drivers/gpu/drm/msm/dp/dp_link.c create mode 100644 drivers/gpu/drm/msm/dp/dp_link.h create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.c create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.h create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.c create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.h create mode 100644 drivers/gpu/drm/msm/dp/dp_power.c create mode 100644 drivers/gpu/drm/msm/dp/dp_power.h create mode 100644 drivers/gpu/drm/msm/dp/dp_reg.h create mode 100644 drivers/gpu/drm/msm/dp/dp_usbpd.c create mode 100644 drivers/gpu/drm/msm/dp/dp_usbpd.h create mode 100644 drivers/gpu/drm/msm/dpu_dbg.c create mode 100644 drivers/gpu/drm/msm/dpu_dbg.h create mode 100644 drivers/gpu/drm/msm/dpu_dbg_evtlog.c create mode 100644 drivers/gpu/drm/msm/dpu_edid_parser.c create mode 100644 drivers/gpu/drm/msm/dpu_edid_parser.h create mode 100644 drivers/gpu/drm/msm/dpu_hdcp.h create mode 100644 drivers/gpu/drm/msm/dpu_hdcp_1x.c create mode 100644 drivers/gpu/drm/msm/dpu_io_util.c create mode 100644 drivers/gpu/drm/msm/dpu_power_handle.c create mode 100644 drivers/gpu/drm/msm/dpu_power_handle.h create mode 100644 drivers/gpu/drm/msm/dpu_rsc.c create mode 100644 drivers/gpu/drm/msm/dpu_rsc_hw.c create mode 100644 drivers/gpu/drm/msm/dpu_rsc_priv.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_catalog.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_catalog.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_clk.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_clk_manager.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_1_4.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_0.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_2_2.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_hw_cmn.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_ctrl_reg.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_defs.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display_test.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_display_test.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_drm.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_drm.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_hw.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_panel.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_panel.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v2_0.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_hw_v3_0.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.h create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_v2_0.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_phy_timing_v3_0.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_pwr.c create mode 100644 drivers/gpu/drm/msm/dsi-staging/dsi_pwr.h create mode 100644 drivers/gpu/drm/msm/msm_prop.c create mode 100644 drivers/gpu/drm/msm/msm_prop.h create mode 100644 drivers/platform/msm/Kconfig create mode 100644 drivers/platform/msm/Makefile create mode 100644 drivers/platform/msm/msm_ext_display.c create mode 100644 include/linux/dpu_io_util.h create mode 100644 include/linux/dpu_rsc.h create mode 100644 include/linux/msm_ext_display.h create mode 100644 include/uapi/drm/dpu_drm.h create mode 100644 include/uapi/drm/msm_drm_pp.h create mode 100644 include/uapi/media/msm_media_info.hQuoted 2 lines
--
Sean Paul, Software Engineer, Google / Chromium OS_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Sean Paul
Hi dri-devel,
Qualcomm has been working for the past few weeks on forward porting their downstream drm driver from 4.14 to mainline. Please consider this PR as a request for review, rather than an attempt at mainlining the code as it currently stands. The goal is get this driver in shape over the next coming months.
Quoted 5 lines
In the meantime, I'll be hosting a tree here [1] to stage the fixes. Patches will be posted and reviewed on [email protected]. Once things look good, I'll send another pull 4realz.
drivers/gpu/drm/msm/msm_rd.c | 58 +-
These changes are somewhat overzealous pointer verification, If struct file * and/or struct inode * are NULL in a fops function your system is already having a bad day. The only check that might be somewhat reasonable is for gpu->funcs->get_param but that hook is defined on all targets so I don't think it is unreasonable to assume that it should be there (and if it isn't the unit test sure better catch it). We can safely drop these changes.
Jordan
Signature · 6 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoted 12 lines · Jordan Crouse
Quoted 11 lines · Sean Paul
Hi dri-devel,
Qualcomm has been working for the past few weeks on forward porting their downstream drm driver from 4.14 to mainline. Please consider this PR as a request for review, rather than an attempt at mainlining the code as it currently stands. The goal is get this driver in shape over the next coming months.In the meantime, I'll be hosting a tree here [1] to stage the fixes. Patches will be posted and reviewed on [email protected]. Once things look good, I'll send another pull 4realz.
Quoted 9 lines
Quoted 1 line
drivers/gpu/drm/msm/msm_rd.c | 58 +-These changes are somewhat overzealous pointer verification, If struct file * and/or struct inode * are NULL in a fops function your system is already having a bad day. The only check that might be somewhat reasonable is for
gpu->funcs->get_parambut that hook is defined on all targets so I don't think it is unreasonable to assume that it should be there (and if it isn't the unit test sure better catch it). We can safely drop these changes.
thanks, this was something I didn't notice (or test) yet.. a couple of the other 'elfring fixes' I encountered (I guess there are probably some coding standards or static analysis behind this?) actually broke things and I have already reverted in the course of unbreaking display/gpu on db410c..
But yeah, ->get_param() is mandatory in the ioctl path (which is something you don't need debugfs access for).. for the paranoid probably the better thing would be a WARN_ON(!gpu->get_param) in gpu init path.
BR,
-R
Quoted 93 lines · Sean Paul
Hi dri-devel,
Qualcomm has been working for the past few weeks on forward porting their downstream drm driver from 4.14 to mainline. Please consider this PR as a request for review, rather than an attempt at mainlining the code as it currently stands. The goal is get this driver in shape over the next coming months.In the meantime, I'll be hosting a tree here [1] to stage the fixes. Patches will be posted and reviewed on [email protected]. Once things look good, I'll send another pull 4realz.
To get the ball rolling, I've done some review on the new connector code, my comments are below.
Thanks in advance for your constructive feedback :)
Sean
[1]-
git://people.freedesktop.org/~seanpaul/dpu-stagingReview feedback:
----------------
- Solve the splash screen handling (or remove it)
- Simplify devicetree binding (remove register offsets)
feedback from reviewingsde_connector.c:
- Rationalize backlight implementation insde_connector(display_countstatic)
- Sort out the dsi event passing between dsi/encoder/connector (move to encoder)
-include/uapi/drm/msm_drm_pp.hneeds opensource userspace (or removal)
-connector->stateaccess violations reading/writingmode_info
- s/sde_rect/drm_rect/
-sde_kms_infousage needs to be replaced with formal data structures (not stringified keypairs)
-sde_connector_opsneeds to be trimmed, duplicates connector helpers, info hooks circumvent state, and other hooks should be stored in state or prepopulated (get_dst_format)
-sde_connector_get_dpmsunused
- esd status check should migrate to encoder from connector
- backlight should be handled in panel drivers, not in the generic connector/dsi encoder
-sde_connector_helper_bridge_disableis called from encoder and calls back intoset_powerencoder function. if backlight, and esd status are removed,pre_kickoffcan probably go away
-sde_connector_clk_ctrlis another example ofencoder->connector->encodercall
-RETIRE_FENCEconnector property should be removed, opting for the native atomic fences
- ROI (regions of interest) should be expressed per-plane instead of connector. there is work ongoing to supportdirty_rectsper-plane by Deepak Singh Rawat <[email protected]> and Lukasz Spintzyk <[email protected]>
- Uma Shankar <[email protected]> has proposed HDR source metadata properties on the list, we should pivot to those instead of hand-rolling them in the sde driver
- Convert HDCP implementation to upstream Content Protection property
- Merge dsi anddsi_staginginto one driver
- Writeback connector has been proposed by ARM (Liviu Dudau and Brian Starkey), we should work with their proposal instead of rollingOUT_FBourselves
-sde_connector_set_propertyshould be replaced with atomic helper
- dsi hotplug can probably be punted to the panel driver
- dpms should switch to enable/disable (or at least use the atomic helpers)
- dsi mode handling should also defer to the panel driver
-SDE_WB_CONFIGioctl should be removed in favor of the existing ioctl to add user-defined modes
- dp implementation should use the existing dp helpers wherever possible
- lots of duplicated structures indsi_defs.hthat can be replaced with existing drm structs
-mode_validshould be split up and implemented directly in connector/encoder as appropriate
-sde_connector->aspaceseems like it's unused?The following changes since commit
9afe236df559d0dc6818f64e728a3f931a0a2231:drm/msm/dsi: Fix potential NULL pointer dereference in
msm_dsi_modeset_init(2018-02-12 10:25:15 -0500)are available in the Git repository at:
git://people.freedesktop.org/~seanpaul/dpu-stagingfor-next-compilesfor you to fetch changes up to
672005da148f82021a62d4fa658728e19f13097e:ARM: dts: msm: add device tree changes for SDM845 (2018-02-13 13:14:43 -0500)
----------------------------------------------------------------
Jeykumar Sankaran (9):
dt-bindings: msm/dsi: Add mdp transfer time to msm dsi binding
dt-bindings: msm/disp: Add bindings for Snapdragon 845 DPU
drm: Core changes
drm/msm: add DPU DRM driver to support SDM845 drm/msm: Changemdp_get_formatarguments
drm/msm: Core msm changes
drm/msm: Add DSI Staging driver
drm/msm: Add DisplayPort support
ARM: dts: msm: add device tree changes for SDM845
Quoted 8 lines
Manasi Navare (1):
drm/dp: Add HBR3 support in existing DRM DP helpersRob Clark (1):
drm/msm: rename mdp->dispdrivers/gpu/drm/msm/dpu_io_util.c | 507 ++ include/linux/dpu_io_util.h | 113 +
This looks like it was borrowed from some older downstream code - its mostly a wrapper for iomem and clock operations and a goodly chuck of dead i2c and gpio code too. The header definitely doesn't need to be in include/linux and we might be able to save a bit of space by merging the iomem wrappers with the code we already have.
Jordan
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH 1/1 drm/msm/dpu: Remove unused code and move the header
Remove unused code from dpu_io_util.c. The functions are only used inside of the msm driver so remove the EXPORT_SYMBOL tags and move the header dpu_io_util.h from include/linux.
---
drivers/gpu/drm/msm/dp/dp_parser.h | 2 +-
drivers/gpu/drm/msm/dpu_io_util.c | 154 ++-------------------
.../linux => drivers/gpu/drm/msm}/dpu_io_util.h | 10 --
drivers/gpu/drm/msm/dpu_power_handle.c | 1 -
drivers/gpu/drm/msm/dpu_power_handle.h | 2 +-
drivers/gpu/drm/msm/dpu_rsc_priv.h | 1 -
drivers/gpu/drm/msm/msm_drv.h | 1 -
7 files changed, 14 insertions(+), 157 deletions(-)
rename {include/linux => drivers/gpu/drm/msm}/dpu_io_util.h (86%)drivers/gpu/drm/msm/dp/dp_parser.h +1 -1
@@ -15,7 +15,7 @@#ifndef _DP_PARSER_H_#define _DP_PARSER_H_ -#include <linux/dpu_io_util.h> +#include "dpu_io_util.h" #define DP_LABEL "MDSS DP DISPLAY"#define AUX_CFG_LEN 10
drivers/gpu/drm/msm/dpu_io_util.c +12 -142
225 lines not on this page · raw message
drivers/gpu/drm/msm/dpu_io_util.h renamed from include/linux/dpu_io_util.h +0 -10
@@ -35,7 +35,6 @@ struct dss_io_data {void dss_reg_w (struct dss_io_data *io,u32 offset,u32 value,u32 debug);u32 dss_reg_r (struct dss_io_data *io,u32 offset,u32 debug); -void dss_reg_dump (void __iomem *base,u32 len,const char *prefix,u32 debug);#define DSS_REG_W_ND (io, offset, val) dss_reg_w(io, offset, val, false)#define DSS_REG_W (io, offset, val) dss_reg_w(io, offset, val, true)
@@ -69,7 +68,6 @@ struct dss_gpio {enum dss_clk_type {DSS_CLK_AHB ,/* no set rate. rate controlled through rpm */ DSS_CLK_PCLK , -DSS_CLK_OTHER , };struct dss_clk {
@@ -93,9 +91,6 @@ int msm_dss_ioremap_byname(struct platform_device *pdev, struct dss_io_data *io_data, const char *name);void msm_dss_iounmap (struct dss_io_data *io_data); -int msm_dss_enable_gpio (struct dss_gpio *in_gpio,int num_gpio,int enable); -int msm_dss_gpio_enable (struct dss_gpio *in_gpio,int num_gpio,int enable); -int msm_dss_config_vreg (struct device *dev,struct dss_vreg *in_vreg,int num_vreg,int config);int msm_dss_enable_vreg (struct dss_vreg *in_vreg,int num_vreg,int enable);
@@ -105,9 +100,4 @@ void msm_dss_put_clk(struct dss_clk *clk_arry, int num_clk);int msm_dss_clk_set_rate (struct dss_clk *clk_arry,int num_clk);int msm_dss_enable_clk (struct dss_clk *clk_arry,int num_clk,int enable); -int dpu_i2c_byte_read (struct i2c_client *client,uint8_t slave_addr, -uint8_t reg_offset,uint8_t *read_buf); -int dpu_i2c_byte_write (struct i2c_client *client,uint8_t slave_addr, -uint8_t reg_offset,uint8_t *value); -#endif /* __DPU_IO_UTIL_H__ */
drivers/gpu/drm/msm/dpu_power_handle.c +0 -1
@@ -25,7 +25,6 @@#include <linux/msm-bus.h> #include <linux/msm-bus-board.h> #endif -#include <linux/dpu_io_util.h> #include <linux/dpu_rsc.h> #include "dpu_power_handle.h"
drivers/gpu/drm/msm/dpu_power_handle.h +1 -1
@@ -21,7 +21,7 @@#define DPU_POWER_HANDLE_ENABLE_BUS_IB_QUOTA 1600000000#define DPU_POWER_HANDLE_DISABLE_BUS_IB_QUOTA 0 -#include <linux/dpu_io_util.h> +#include "dpu_io_util.h" /* event will be triggered before power handler disable */ #define DPU_POWER_EVENT_PRE_DISABLE 0x1
drivers/gpu/drm/msm/dpu_rsc_priv.h +0 -1
@@ -15,7 +15,6 @@#define _DPU_RSC_PRIV_H_#include <linux/kernel.h> -#include <linux/dpu_io_util.h> #include <linux/dpu_rsc.h> #include <soc/qcom/tcs.h>
drivers/gpu/drm/msm/msm_drv.h +0 -1
@@ -33,7 +33,6 @@#include <linux/types.h> #include <linux/of_graph.h> #include <linux/of_device.h> -#include <linux/dpu_io_util.h> #include <asm/sizes.h> #include <linux/kthread.h>
Signature · 6 lines
2.16.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
A message that is not in the archive (sent off-list or not yet received): 20180215204535.29510-1-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Rob Clark
Reviewed-byRe: [PATCH] drm/msm/dpu: Remove unused code and move the header
Quoted 5 lines · Jordan Crouse
Remove unused code from
dpu_io_util.c. The functions are only used inside of the msm driver so remove theEXPORT_SYMBOLtags and move the headerdpu_io_util.hfrominclude/linux.Signed-off-by Jordan Crouse <[email protected]>
Thanks,
Quoted 358 lines
--- drivers/gpu/drm/msm/dp/dp_parser.h | 2 +- drivers/gpu/drm/msm/dpu_io_util.c | 154 ++------------------- .../linux => drivers/gpu/drm/msm}/dpu_io_util.h | 10 -- drivers/gpu/drm/msm/dpu_power_handle.c | 1 - drivers/gpu/drm/msm/dpu_power_handle.h | 2 +- drivers/gpu/drm/msm/dpu_rsc_priv.h | 1 - drivers/gpu/drm/msm/msm_drv.h | 1 - 7 files changed, 14 insertions(+), 157 deletions(-) rename {include/linux => drivers/gpu/drm/msm}/dpu_io_util.h (86%)drivers/gpu/drm/msm/dp/dp_parser.h +1
-1@@ -15,7 +15,7 @@#ifndef _DP_PARSER_H_#define _DP_PARSER_H_ -#include <linux/dpu_io_util.h> +#include "dpu_io_util.h" #define DP_LABEL "MDSS DP DISPLAY"#define AUX_CFG_LEN 10drivers/gpu/drm/msm/dpu_io_util.c +12
-142@@ -16,9 +16,9 @@#include <linux/io.h> #include <linux/regulator/consumer.h> #include <linux/delay.h> -#include <linux/dpu_io_util.h> -#define MAX_I2C_CMDS 16 +#include "dpu_io_util.h" +void dss_reg_w (struct dss_io_data *io,u32 offset,u32 value,u32 debug) {u32 in_val;@@ -42,8 +42,7 @@ void dss_reg_w(struct dss_io_data *io, u32 offset, u32 value, u32 debug) (u32 )(unsigned long )(io->base + offset), value, in_val); } -}/* dss_reg_w */ -EXPORT_SYMBOL (dss_reg_w); +}u32 dss_reg_r (struct dss_io_data *io,u32 offset,u32 debug) {@@ -67,30 +66,7 @@ u32 dss_reg_r(struct dss_io_data *io, u32 offset, u32 debug) (u32)(unsigned long)(io->base + offset), value);return value; -}/* dss_reg_r */ -EXPORT_SYMBOL (dss_reg_r); - -void dss_reg_dump (void __iomem *base,u32 length,const char *prefix, -u32 debug) -{ -if (debug) -print_hex_dump (KERN_INFO , prefix,DUMP_PREFIX_OFFSET ,32 ,4 , - (void *)base, length, false); -}/* dss_reg_dump */ -EXPORT_SYMBOL (dss_reg_dump); - -static struct resource *msm_dss_get_res_byname (struct platform_device *pdev, -unsigned int type,const char *name) -{ -struct resource *res =NULL ; - - res =platform_get_resource_byname (pdev, type, name); -if (!res) -DEV_ERR ("%s: '%s' resource not found\n" , __func__, name); - -return res; -}/* msm_dss_get_res_byname */ -EXPORT_SYMBOL (msm_dss_get_res_byname); +}int msm_dss_ioremap_byname (struct platform_device *pdev,struct dss_io_data *io_data,const char *name)@@ -103,7 +79,7 @@ int msm_dss_ioremap_byname(struct platform_device *pdev,return -EINVAL ; } - res =msm_dss_get_res_byname (pdev,IORESOURCE_MEM , name); + res =platform_get_resource_byname (pdev,IORESOURCE_MEM , name);if (!res) {DEV_ERR ("%pS->%s: '%s' msm_dss_get_res_byname failed\n" ,__builtin_return_address (0 ), __func__, name);@@ -119,8 +95,7 @@ int msm_dss_ioremap_byname(struct platform_device *pdev, }return 0 ; -}/* msm_dss_ioremap_byname */ -EXPORT_SYMBOL (msm_dss_ioremap_byname); +}void msm_dss_iounmap (struct dss_io_data *io_data) {@@ -135,8 +110,7 @@ void msm_dss_iounmap(struct dss_io_data *io_data) io_data->base =NULL ; } io_data->len =0 ; -}/* msm_dss_iounmap */ -EXPORT_SYMBOL (msm_dss_iounmap); +}int msm_dss_config_vreg (struct device *dev,struct dss_vreg *in_vreg,int num_vreg,int config)@@ -211,8 +185,7 @@ if (type == DSS_REG_LDO) goto vreg_unconfig; }return rc; -}/* msm_dss_config_vreg */ -EXPORT_SYMBOL (msm_dss_config_vreg); +}int msm_dss_enable_vreg (struct dss_vreg *in_vreg,int num_vreg,int enable) {@@ -283,48 +256,7 @@ int msm_dss_enable_vreg(struct dss_vreg *in_vreg, int num_vreg, int enable) }return rc; -}/* msm_dss_enable_vreg */ -EXPORT_SYMBOL (msm_dss_enable_vreg); - -int msm_dss_enable_gpio (struct dss_gpio *in_gpio,int num_gpio,int enable) -{ -int i =0 , rc =0 ; - -if (enable) { -for (i =0 ; i < num_gpio; i++) { -DEV_DBG ("%pS->%s: %s enable\n" , -__builtin_return_address (0 ), __func__, - in_gpio[i].gpio_name); - - rc =gpio_request (in_gpio[i].gpio, - in_gpio[i].gpio_name); -if (rc <0 ) { -DEV_ERR ("%pS->%s: %s enable failed\n" , -__builtin_return_address (0 ), __func__, - in_gpio[i].gpio_name); - goto disable_gpio; - } -gpio_set_value (in_gpio[i].gpio, in_gpio[i].value); - } - }else { -for (i = num_gpio-1 ; i >=0 ; i--) { -DEV_DBG ("%pS->%s: %s disable\n" , -__builtin_return_address (0 ), __func__, - in_gpio[i].gpio_name); -if (in_gpio[i].gpio) -gpio_free (in_gpio[i].gpio); - } - } -return rc; - -disable_gpio: -for (i--; i >=0 ; i--) -if (in_gpio[i].gpio) -gpio_free (in_gpio[i].gpio); - -return rc; -}/* msm_dss_enable_gpio */ -EXPORT_SYMBOL (msm_dss_enable_gpio); +}void msm_dss_put_clk (struct dss_clk *clk_arry,int num_clk) {@@ -335,8 +267,7 @@ void msm_dss_put_clk(struct dss_clk *clk_arry, int num_clk)clk_put (clk_arry[i].clk); clk_arry[i].clk =NULL ; } -}/* msm_dss_put_clk */ -EXPORT_SYMBOL (msm_dss_put_clk); +}int msm_dss_get_clk (struct device *dev,struct dss_clk *clk_arry,int num_clk) {@@ -363,8 +294,7 @@ int msm_dss_get_clk(struct device *dev, struct dss_clk *clk_arry, int num_clk) }return rc; -}/* msm_dss_get_clk */ -EXPORT_SYMBOL (msm_dss_get_clk); +}int msm_dss_clk_set_rate (struct dss_clk *clk_arry,int num_clk) {@@ -397,8 +327,7 @@ int msm_dss_clk_set_rate(struct dss_clk *clk_arry, int num_clk) }return rc; -}/* msm_dss_clk_set_rate */ -EXPORT_SYMBOL (msm_dss_clk_set_rate); +}int msm_dss_enable_clk (struct dss_clk *clk_arry,int num_clk,int enable) {@@ -445,63 +374,4 @@ int msm_dss_enable_clk(struct dss_clk *clk_arry, int num_clk, int enable) }return rc; -}/* msm_dss_enable_clk */ -EXPORT_SYMBOL (msm_dss_enable_clk); - - -int dpu_i2c_byte_read (struct i2c_client *client,uint8_t slave_addr, -uint8_t reg_offset,uint8_t *read_buf) -{ -struct i2c_msg msgs[2 ]; -int ret =-1 ; - -pr_debug ("%s: reading from slave_addr=[%x] and offset=[%x]\n" , - __func__, slave_addr, reg_offset); - - msgs[0 ].addr = slave_addr >>1 ; - msgs[0 ].flags =0 ; - msgs[0 ].buf = ®_offset; - msgs[0 ].len =1 ; - - msgs[1 ].addr = slave_addr >>1 ; - msgs[1 ].flags =I2C_M_RD ; - msgs[1 ].buf = read_buf; - msgs[1 ].len =1 ; - - ret =i2c_transfer (client->adapter, msgs,2 ); -if (ret <1 ) { -pr_err ("%s: I2C READ FAILED=[%d]\n" , __func__, ret); -return -EACCES ; - } -pr_debug ("%s: i2c buf is [%x]\n" , __func__, *read_buf); -return 0 ; -} -EXPORT_SYMBOL (dpu_i2c_byte_read); - -int dpu_i2c_byte_write (struct i2c_client *client,uint8_t slave_addr, -uint8_t reg_offset,uint8_t *value) -{ -struct i2c_msg msgs[1 ]; -uint8_t data[2 ]; -int status = -EACCES ; - -pr_debug ("%s: writing from slave_addr=[%x] and offset=[%x]\n" , - __func__, slave_addr, reg_offset); - - data[0 ] = reg_offset; - data[1 ] = *value; - - msgs[0 ].addr = slave_addr >>1 ; - msgs[0 ].flags =0 ; - msgs[0 ].len =2 ; - msgs[0 ].buf = data; - - status =i2c_transfer (client->adapter, msgs,1 ); -if (status <1 ) { -pr_err ("I2C WRITE FAILED=[%d]\n" , status); -return -EACCES ; - } -pr_debug ("%s: I2C write status=%x\n" , __func__, status); -return status; } -EXPORT_SYMBOL (dpu_i2c_byte_write);drivers/gpu/drm/msm/dpu_io_util.h renamed from include/linux/dpu_io_util.h +0
-10@@ -35,7 +35,6 @@ struct dss_io_data {void dss_reg_w (struct dss_io_data *io,u32 offset,u32 value,u32 debug);u32 dss_reg_r (struct dss_io_data *io,u32 offset,u32 debug); -void dss_reg_dump (void __iomem *base,u32 len,const char *prefix,u32 debug);#define DSS_REG_W_ND (io, offset, val) dss_reg_w(io, offset, val, false)#define DSS_REG_W (io, offset, val) dss_reg_w(io, offset, val, true)@@ -69,7 +68,6 @@ struct dss_gpio {enum dss_clk_type {DSS_CLK_AHB ,/* no set rate. rate controlled through rpm */ DSS_CLK_PCLK , -DSS_CLK_OTHER , };struct dss_clk {@@ -93,9 +91,6 @@ int msm_dss_ioremap_byname(struct platform_device *pdev, struct dss_io_data *io_data, const char *name);void msm_dss_iounmap (struct dss_io_data *io_data); -int msm_dss_enable_gpio (struct dss_gpio *in_gpio,int num_gpio,int enable); -int msm_dss_gpio_enable (struct dss_gpio *in_gpio,int num_gpio,int enable); -int msm_dss_config_vreg (struct device *dev,struct dss_vreg *in_vreg,int num_vreg,int config);int msm_dss_enable_vreg (struct dss_vreg *in_vreg,int num_vreg,int enable);@@ -105,9 +100,4 @@ void msm_dss_put_clk(struct dss_clk *clk_arry, int num_clk);int msm_dss_clk_set_rate (struct dss_clk *clk_arry,int num_clk);int msm_dss_enable_clk (struct dss_clk *clk_arry,int num_clk,int enable); -int dpu_i2c_byte_read (struct i2c_client *client,uint8_t slave_addr, -uint8_t reg_offset,uint8_t *read_buf); -int dpu_i2c_byte_write (struct i2c_client *client,uint8_t slave_addr, -uint8_t reg_offset,uint8_t *value); -#endif /* __DPU_IO_UTIL_H__ */ drivers/gpu/drm/msm/dpu_power_handle.c +0
-1@@ -25,7 +25,6 @@#include <linux/msm-bus.h> #include <linux/msm-bus-board.h> #endif -#include <linux/dpu_io_util.h> #include <linux/dpu_rsc.h> #include "dpu_power_handle.h" drivers/gpu/drm/msm/dpu_power_handle.h +1
-1@@ -21,7 +21,7 @@#define DPU_POWER_HANDLE_ENABLE_BUS_IB_QUOTA 1600000000#define DPU_POWER_HANDLE_DISABLE_BUS_IB_QUOTA 0 -#include <linux/dpu_io_util.h> +#include "dpu_io_util.h" /* event will be triggered before power handler disable */ #define DPU_POWER_EVENT_PRE_DISABLE 0x1drivers/gpu/drm/msm/dpu_rsc_priv.h +0
-1@@ -15,7 +15,6 @@#define _DPU_RSC_PRIV_H_#include <linux/kernel.h> -#include <linux/dpu_io_util.h> #include <linux/dpu_rsc.h> #include <soc/qcom/tcs.h> drivers/gpu/drm/msm/msm_drv.h +0
-2@@ -33,7 +33,6 @@#include <linux/types.h> #include <linux/of_graph.h> #include <linux/of_device.h> -#include <linux/dpu_io_util.h> #include <asm/sizes.h> #include <linux/kthread.h> --
Quoted 2 lines
2.16.1
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoted 17 lines · Sean Paul
Hi dri-devel,
Qualcomm has been working for the past few weeks on forward porting their downstream drm driver from 4.14 to mainline. Please consider this PR as a request for review, rather than an attempt at mainlining the code as it currently stands. The goal is get this driver in shape over the next coming months.In the meantime, I'll be hosting a tree here [1] to stage the fixes. Patches will be posted and reviewed on [email protected]. Once things look good, I'll send another pull 4realz.
To get the ball rolling, I've done some review on the new connector code, my comments are below.
Thanks in advance for your constructive feedback :)
Quoted 8 lines
.../devicetree/bindings/display/msm/dpu-rsc.txt | 96 + .../devicetree/bindings/display/msm/dpu.txt | 736 +++ .../devicetree/bindings/display/msm/dsi.txt | 16 +.../devicetree/bindings/drm/msm/dpu-dp.txt | 217 + .../devicetree/bindings/drm/msm/dpu-dsi.txt | 102 + .../devicetree/bindings/drm/msm/dpu-wb.txt | 23 + .../devicetree/bindings/drm/msm/mdss-dsi-panel.txt | 772 +++
Not a correct path with /drm/.
772 lines for a panel or DSI!? I look at it when it is shorter...
Quoted 1 line
.../devicetree/bindings/fb/mdss-dsi-panel.txt | 742 +++
Hopefully just duplicated?
Quoted 1 line
Documentation/devicetree/bindings/fb/mdss-pll.txt | 103 +
Not a correct path either.
Quoted 1 line
.../devicetree/bindings/msm_hdcp/msm_hdcp.txt | 14 +
ditto.
Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel