f2fs: add error checking in do_write_page()
PATCH v3 1/1 f2fs: add error checking in do_write_page()
Otherwise, the filesystem may unaware of potential file corruption.
Signed-off-by mason.zhang <[email protected]>
--- fs/f2fs/segment.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
fs/f2fs/segment.c +8 -2
@@ -3936,12 +3936,18 @@ static void do_write_page(struct f2fs_summary *sum, struct f2fs_io_info *fio)int seg_type =log_type_to_seg_type (type);bool keep_order = (f2fs_lfs_mode (fio->sbi) && seg_type ==CURSEG_COLD_DATA ); +int err;if (keep_order)f2fs_down_read (&fio->sbi->io_order_lock); -if (f2fs_allocate_data_block (fio->sbi, fio->page, fio->old_blkaddr, - &fio->new_blkaddr, sum, type, fio)) { + err =f2fs_allocate_data_block (fio->sbi, fio->page, fio->old_blkaddr, + &fio->new_blkaddr, sum, type, fio); +if (unlikely (err)) { +f2fs_err_ratelimited (fio->sbi, +"%s Failed to allocate data block, ino:%u, index:%lu, type:%d, old_blkaddr:0x%x, new_blkaddr:0x%x, err:%d" , + __func__, fio->ino, folio->index, type, + fio->old_blkaddr, fio->new_blkaddr, err);if (fscrypt_inode_uses_fs_layer_crypto (folio->mapping->host))fscrypt_finalize_bounce_page (&fio->encrypted_page);folio_end_writeback (folio);
Signature · 1 line
2.48.1
Quoted 1 line
Otherwise, the filesystem may unaware of potential file corruption.
I find that the change description should be improved considerably.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n45
Regards,
Markus
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 3 lines · mason.zhang
Otherwise, the filesystem may unaware of potential file corruption.
Signed-off-by mason.zhang <[email protected]>
Reviewed-by Chao Yu <[email protected]>
Thanks,