Skip to contentSkip to conversation

sched/deadline: support dl task migration during cpu hotplug

PATCH Kirill Tkhai 1 participant 1 message Nov 17, 2014

lore
Share & tools
lore
#0 lore raw
Quoted 27 lines

Hi Kirill,

Quoted 22 lines · Kirill Tkhai
Quoted 15 lines
Quoted 15 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
(quoted diff) +0 -0
@@ -1185,8 +1223,9 @@ static int find_later_rq(struct task_struct *task)
 * We have to consider system topology and task affinity
 * first, then we can look for a suitable cpu.
 */
Quoted 8 lines
Quoted 8 lines

Review static int find_later_rq(struct task_struct *task) · line 1231

Quoted 8 lines
(quoted diff) +3 -2
- cpumask_copy(later_mask, task_rq(task)->rd->span);
- cpumask_and(later_mask, later_mask, cpu_active_mask);
+ cpumask_copy(later_mask, cpu_active_mask);
+ if (likely(task_rq(task)->online))
+ cpumask_and(later_mask, later_mask, task_rq(task)->rd->span);
 cpumask_and(later_mask, later_mask, &task->cpus_allowed);
 best_cpu = cpudl_find(&task_rq(task)->rd->cpudl,
 task, later_mask);

Also, we should think about the following situation.

Quoted 4 lines
Quoted 2 lines

DL task is left on dead rq. In your scheme it will be moved by the timer. But what will be if somebody changes the class of the task (before timer)?

I think timer will be cancelled in switched_from_dl().

Yeah, but nobody will move this task to alive rq.

Quoted 8 lines
Quoted 6 lines
Quoted 6 lines

Regards,
Wanpeng Li

Quoted 3 lines

In this case the task still remains on dead rq.

We should handle this situation in some way.

Your proposal is a great appreciated.

Sadly, I‘m travelling at the moment, I‘m not able to do something till december.

Quoted 16 lines

Regards,
Wanpeng Li

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Kirill

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/