Skip to contentSkip to conversation

tests/kms_color_chamelium: Skip CTM test if property is not present

PATCH Superseded Bhanuprakash Modem 3 participants 4 messages Sep 14, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/kms_color_chamelium: Skip CTM test if property is not present

CRTC property "CTM" is required for all CTM tests.

---
 tests/kms_color_chamelium.c | 2 ++
 1 file changed, 2 insertions(+)
tests/kms_color_chamelium.c +2 -0
index bc4356bfa..7173bc69e 100644
@@ -398,6 +398,8 @@ static void test_pipe_limited_range_ctm(data_t *data,
 	struct chamelium_port *port;
 	char *connected_ports[4];
 
+	igt_require(igt_pipe_obj_has_prop(primary->pipe, IGT_CRTC_CTM));
+
 	degamma_linear = generate_table(data->degamma_lut_size, 1.0);
 	gamma_linear = generate_table(data->gamma_lut_size, 1.0);
 
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw

LGTM. However, we need to add fixes tag. Once bug is filed; can you please float another version with that tag?

Quoted 23 lines · Bhanuprakash Modem

CRTC property "CTM" is required for all CTM tests.

---
  tests/kms_color_chamelium.c | 2 ++
  1 file changed, 2 insertions(+)
tests/kms_color_chamelium.c +2 -0
index bc4356bfa..7173bc69e 100644
@@ -398,6 +398,8 @@ static void test_pipe_limited_range_ctm(data_t *data,
  	struct chamelium_port *port;
  	char *connected_ports[4];
 
+	igt_require(igt_pipe_obj_has_prop(primary->pipe, IGT_CRTC_CTM));
+
  	degamma_linear = generate_table(data->degamma_lut_size, 1.0);
  	gamma_linear = generate_table(data->gamma_lut_size, 1.0);
 
Signature · 1 line
~Swati Sharma
#2 lore raw

[igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_color_chamelium: Skip CTM test if property is not present

In reply to Bhanuprakash Modem
== Series Details ==

== Series Details ==

Series: tests/kms_color_chamelium: Skip CTM test if property is not present
URL : https://patchwork.freedesktop.org/series/94653/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/401308 for the overview.

containers:igt has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/13661606):
51b1c785e099b311e58a16ee57543174ba648e2b1d8ab81d4930dd89acd3354c
STEP 4: ENV PATH="/opt/igt/bin:${PATH}"
8c7ef5b0d50764c5e49ed7bf8780044dfdc74cfdc7af250c9111dc48cf72e844
STEP 5: ENV LD_LIBRARY_PATH="/opt/igt/lib:/opt/igt/lib64:${LD_LIBRARY_PATH}" 61e4640b8010f25f5e69ae7e5275ea90be7035c8c9aa9b4a81733b71d0611f06
STEP 6: ENV IGT_TEST_ROOT="/opt/igt/libexec/igt-gpu-tools" 08d1703808112e6f020b2dea9e6a82dce3bdb102151e8333629bfa8f228a1eeb
STEP 7: CMD docker-help.sh
STEP 8: COMMIT registry.freedesktop.org/gfx-ci/igt-ci-tags/igt:commit-5cf4432aaf8bd3fc59592b9f04e4d71b45963f55 4c847802204e14d25cafeb23231291e3c4123c91855f2078954dc061df15bf39
Getting image source signatures
Copying blob sha256:6be3187573680d6b55d973c8dc10842518ec3e558a729aa313e5fbcdd76a771e
Copying blob sha256:bd9cb1c13a8ad644597c3c327500644c12f915cc29673945152a18bca00d263c
Copying blob sha256:3504a8337d3b7eaabfd338d6a971d02441d28ebef8bd81f730d87f936ed58079
Error: Error copying image to the remote destination: Error writing blob: Error determining upload URL: http: no Location header in response section_end:1631626518:step_script
section_start:1631626518:cleanup_file_variables
Cleaning up file based variables
section_end:1631626519:cleanup_file_variables
ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/401308

#3 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_color_chamelium: Skip CTM test if property is not present

In reply to Bhanuprakash Modem
== Series Details ==

== Series Details ==

Series: tests/kms_color_chamelium: Skip CTM test if property is not present
URL : https://patchwork.freedesktop.org/series/94653/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10582 -> IGTPW_6218
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6218 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6218, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6218:

### IGT changes ###

#### Possible regressions ####

* igt@core_hotunplug@unbind-rebind:
- fi-kbl-7500u: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10582/fi-kbl-7500u/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-kbl-7500u/igt@[email protected]
- fi-cfl-8109u: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10582/fi-cfl-8109u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-cfl-8109u/igt@[email protected]

* igt@i915_module_load@reload:
- fi-kbl-guc: NOTRUN -> [INCOMPLETE][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-kbl-guc/igt@[email protected]
- fi-icl-y: [PASS][6] -> [TIMEOUT][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10582/fi-icl-y/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-icl-y/igt@[email protected]

* igt@i915_selftest@live@mman:
- fi-icl-u2: NOTRUN -> [INCOMPLETE][8]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-icl-u2/igt@i915_selftest@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_module_load@reload:
- {fi-jsl-1}: [INCOMPLETE][9] -> [TIMEOUT][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10582/fi-jsl-1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-jsl-1/igt@[email protected]

* igt@i915_selftest@live@mman:
- {fi-jsl-1}: NOTRUN -> [INCOMPLETE][11]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-jsl-1/igt@i915_selftest@[email protected]

Known issues
------------

Here are the changes found in IGTPW_6218 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s0:
- fi-kbl-soraka: [PASS][12] -> [INCOMPLETE][13] ([i915#155])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10582/fi-kbl-soraka/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-kbl-soraka/igt@[email protected]

* igt@i915_selftest@live@mman:
- fi-skl-6700k2: NOTRUN -> [INCOMPLETE][14] ([i915#3796])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-skl-6700k2/igt@i915_selftest@[email protected]

* igt@kms_chamelium@vga-hpd-fast:
- fi-kbl-guc: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827]) +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-kbl-guc/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-guc: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#533])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-kbl-guc/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-kbl-guc: NOTRUN -> [SKIP][17] ([fdo#109271]) +41 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-kbl-guc/igt@[email protected]

* igt@runner@aborted:
- fi-icl-u2: NOTRUN -> [FAIL][18] ([i915#2426] / [i915#3363] / [i915#3690])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-icl-u2/igt@[email protected]
- fi-skl-6700k2: NOTRUN -> [FAIL][19] ([i915#1436] / [i915#2426] / [i915#3363])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-skl-6700k2/igt@[email protected]

#### Possible fixes ####

* igt@core_hotunplug@unbind-rebind:
- fi-skl-6700k2: [INCOMPLETE][20] -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10582/fi-skl-6700k2/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-skl-6700k2/igt@[email protected]

* igt@i915_module_load@reload:
- fi-icl-u2: [INCOMPLETE][22] -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10582/fi-icl-u2/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/fi-icl-u2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2932]: https://gitlab.freedesktop.org/drm/intel/issues/2932
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3690]: https://gitlab.freedesktop.org/drm/intel/issues/3690
[i915#3796]: https://gitlab.freedesktop.org/drm/intel/issues/3796
[i915#3970]: https://gitlab.freedesktop.org/drm/intel/issues/3970
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533

Participating hosts (42 -> 36)
------------------------------

Additional (1): fi-kbl-guc
Missing (7): bat-adls-5 bat-dg1-6 bat-dg1-5 fi-tgl-1115g4 fi-bsw-cyan fi-bdw-samus bat-jsl-1

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6209 -> IGTPW_6218

CI-20190529: 20190529
CI_DRM_10582: c8e353c92ace792f7032cb5e002148604c027e4e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6218: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/index.html
IGT_6209: 07d6594ed02f55b68d64fa6dd7f80cfbc1ce4ef8 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6218/index.html