Skip to contentSkip to conversation

package/pkg-kernel-module.mk: module build fails

PATCH New Doug Kehn 5 participants 6 messages Sep 2, 2015 – Sep 4, 2015

lore
Share & tools
lore

Doug Kehn

author
#0 lore raw

PATCH 1/1 package/pkg-kernel-module.mk: module build fails

Observed the following when building cryptodev-linux:

Quoted 1 line
Quoted 1 line
Quoted 1 line

cryptodev-linux 1.7 Building kernel module(s)

grep: /.config: No such file or directory
ERROR: Kernel does not support loadable modules

Fix LINUX_DIR reference when determining if kernel configuration supports loadable modules.

---
 package/pkg-kernel-module.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-kernel-module.mk +1 -1
index 6fb7704..7628352 100644
@@ -60,7 +60,7 @@ $(2)_MODULE_SUBDIRS ?= .
 # includes and other support files (Booo!)
 define $(2)_KERNEL_MODULES_BUILD
 	@$$(call MESSAGE,"Building kernel module(s)")
-	@if ! grep -Fqx 'CONFIG_MODULES=y' $(LINUX_DIR)/.config; then \
+	@if ! grep -Fqx 'CONFIG_MODULES=y' $$(LINUX_DIR)/.config; then \
 		echo "ERROR: Kernel does not support loadable modules"; \
 		exit 1; \
 	fi
Signature · 1 line
2.5.0
#1 lore raw

PATCH 1/1 package/pkg-kernel-module.mk: module build fails

Dear Doug Kehn,

Quoted 9 lines · Doug Kehn

Observed the following when building cryptodev-linux:

Quoted 1 line
Quoted 1 line
Quoted 1 line

cryptodev-linux 1.7 Building kernel module(s)

grep: /.config: No such file or directory
ERROR: Kernel does not support loadable modules

Fix LINUX_DIR reference when determining if kernel configuration supports loadable modules.

Indeed:

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 package/pkg-kernel-module.mk: module build fails

In reply to Doug Kehn

Doug, All,

On 2015-09-01 20:37 -0500, Doug Kehn spake thusly:

Quoted 7 lines

Observed the following when building cryptodev-linux:

Quoted 1 line
Quoted 1 line
Quoted 1 line

cryptodev-linux 1.7 Building kernel module(s)

grep: /.config: No such file or directory
ERROR: Kernel does not support loadable modules

Fix LINUX_DIR reference when determining if kernel configuration supports loadable modules.

Dang.. I let that skip before the release...

Quoted 1 line

On principle:

However, there's a series that did not have time to make it to master before the release, and that is an improvement over the current situation, which would render this patch moot:

    https://patchwork.ozlabs.org/patch/510186/
    https://patchwork.ozlabs.org/patch/510187/
    https://patchwork.ozlabs.org/patch/510188/

So, even though this patch is good, I'd prefer we aply the series instead.

Still, the kernel-module infra is indeed broken in the release, thus making all kernel module packages broken. I'll Oeter and Thomas decide whether we want to put out a .1 release to fix just that.

Regards,
Yann E. MORIN.

Quoted 24 lines
---
 package/pkg-kernel-module.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-kernel-module.mk +1 -1
index 6fb7704..7628352 100644
@@ -60,7 +60,7 @@ $(2)_MODULE_SUBDIRS ?= .
 # includes and other support files (Booo!)
 define $(2)_KERNEL_MODULES_BUILD
 	@$$(call MESSAGE,"Building kernel module(s)")
-	@if ! grep -Fqx 'CONFIG_MODULES=y' $(LINUX_DIR)/.config; then \
+	@if ! grep -Fqx 'CONFIG_MODULES=y' $$(LINUX_DIR)/.config; then \
 		echo "ERROR: Kernel does not support loadable modules"; \
 		exit 1; \
 	fi
Signature · 6 lines
2.5.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/pkg-kernel-module.mk: module build fails

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Hi,

Quoted 15 lines
Quoted 2 lines

Fix LINUX_DIR reference when determining if kernel configuration supports loadable modules.

Dang.. I let that skip before the release...

Quoted 1 line

On principle:

However, there's a series that did not have time to make it to master before the release, and that is an improvement over the current situation, which would render this patch moot:

Quoted 6 lines
    https://patchwork.ozlabs.org/patch/510186/
    https://patchwork.ozlabs.org/patch/510187/
    https://patchwork.ozlabs.org/patch/510188/

So, even though this patch is good, I'd prefer we aply the series instead.

Yes, I'll do so shortly for master.

Quoted 3 lines

Still, the kernel-module infra is indeed broken in the release, thus making all kernel module packages broken. I'll Oeter and Thomas decide whether we want to put out a .1 release to fix just that.

I've created a 2015.08.x branch and applied it. I'll wait a few days and see if anything else shows up before releasing 2015.08.1.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 package/pkg-kernel-module.mk: module build fails

Hi Peter,

----- Mail original -----

Quoted 32 lines

De: "Peter Korsgaard" <[email protected]>
?: "Yann E. MORIN" <[email protected]>
Cc: "buildroot" <[email protected]>
Envoy?: Vendredi 4 Septembre 2015 12:08:32
Objet: Re: [Buildroot] [PATCH 1/1] package/pkg-kernel-module.mk: module build fails

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Hi,

Quoted 15 lines
Quoted 2 lines

Fix LINUX_DIR reference when determining if kernel configuration supports loadable modules.

Dang.. I let that skip before the release...

Quoted 1 line

On principle:

However, there's a series that did not have time to make it to master before the release, and that is an improvement over the current situation, which would render this patch moot:

Quoted 6 lines
    https://patchwork.ozlabs.org/patch/510186/
    https://patchwork.ozlabs.org/patch/510187/
    https://patchwork.ozlabs.org/patch/510188/

So, even though this patch is good, I'd prefer we aply the series instead.

Quoted 8 lines

Yes, I'll do so shortly for master.

Quoted 3 lines

Still, the kernel-module infra is indeed broken in the release, thus making all kernel module packages broken. I'll Oeter and Thomas decide whether we want to put out a .1 release to fix just that.

I've created a 2015.08.x branch and applied it. I'll wait a few days and see if anything else shows up before releasing 2015.08.1.

Since you are preparing a bug fix release, can you backport this little patch ? ;-)
http://patchwork.ozlabs.org/patch/512785/

Thanks!

Best regards,
Romain

Quoted 7 lines

--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#5 lore raw

PATCH 1/1 package/pkg-kernel-module.mk: module build fails

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

Hi,

Quoted 8 lines

Hi Peter,

Quoted 2 lines

I've created a 2015.08.x branch and applied it. I'll wait a few days and see if anything else shows up before releasing 2015.08.1.

Since you are preparing a bug fix release, can you backport this little patch ? ;-)
http://patchwork.ozlabs.org/patch/512785/

Cherrypicked, thanks. Please let me know if there are any other fixes that should go in 2015.08.1.

Signature · 2 lines
Venlig hilsen,
Peter Korsgaard