Skip to contentSkip to conversation

phy: add dm816x dependency on USB_PHY

PATCH In review Arnd Bergmann 2 participants 2 messages May 19, 2015 Generic PHY framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: add dm816x dependency on USB_PHY

The newly added phy-dm816x-usb driver depends on the usb phy API and fails to link if that is disabled:

drivers/built-in.o: In function `dm816x_usb_phy_remove':
:(.text+0x3a28): undefined reference to usb_remove_phy' drivers/built-in.o: In function dm816x_usb_phy_probe':
:(.text+0x3c18): undefined reference to `usb_add_phy_dev'

This adds an explicit dependency in Kconfig to avoid the build error in randconfig tests.

Fixes 609adde838f4 ("phy: Add a driver for dm816x USB PHY")
drivers/phy/Kconfig +1 -1
index fceac96c2a31..1b5c235562c9 100644
@@ -37,7 +37,7 @@ config ARMADA375_USBCLUSTER_PHY
 
 config PHY_DM816X_USB
 	tristate "TI dm816x USB PHY driver"
-	depends on ARCH_OMAP2PLUS
+	depends on ARCH_OMAP2PLUS && USB_PHY
 	select GENERIC_PHY
 	help
 	  Enable this for dm816x USB to work.
#1 lore raw

Hi Arnd,

Quoted 7 lines · Arnd Bergmann

The newly added phy-dm816x-usb driver depends on the usb phy API and fails to link if that is disabled:

drivers/built-in.o: In function `dm816x_usb_phy_remove':
:(.text+0x3a28): undefined reference to usb_remove_phy' drivers/built-in.o: In function dm816x_usb_phy_probe':
:(.text+0x3c18): undefined reference to `usb_add_phy_dev'

A patch to fix this has already been queued in the fixes branch
https://git.kernel.org/cgit/linux/kernel/git/kishon/linux-phy.git/commit/?h=fixes&id=7f7a4d306ff87502dc26860f54e798693cf9b1e1

Thanks
Kishon

Quoted 21 lines

This adds an explicit dependency in Kconfig to avoid the build error in randconfig tests.

Fixes 609adde838f4 ("phy: Add a driver for dm816x USB PHY")
drivers/phy/Kconfig +1 -1
index fceac96c2a31..1b5c235562c9 100644
@@ -37,7 +37,7 @@ config ARMADA375_USBCLUSTER_PHY
 
  config PHY_DM816X_USB
  	tristate "TI dm816x USB PHY driver"
-	depends on ARCH_OMAP2PLUS
+	depends on ARCH_OMAP2PLUS && USB_PHY
  	select GENERIC_PHY
  	help
  	  Enable this for dm816x USB to work.