Skip to contentSkip to conversation

x86-64: Make uaccess_err unsigned

PATCH Bart Van Assche 1 participant 1 message Jan 10, 2012 x86

lore
Share & tools
lore
#0 lore raw

In commit 4fc3490114bb159bd4fff1b3c96f4320fe6fb08f uaccess_err was changed from an int into a one bit bitfield. The values that can be represented by a one bit bitfield are 0 and -1. Since only values 0 and 1 are ever assigned to uaccess_err, make that bitfield unsigned. Also change the one bit bitfield sig_on_uaccess from signed into unsigned. This patch makes two annoying sparse warnings about signed one bit bitfields disappear.

Cc Andy Lutomirski <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc richard -rw- weinberger <[email protected]>
Cc H. Peter Anvin <[email protected]>
---
 arch/x86/include/asm/thread_info.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/include/asm/thread_info.h +2 -2
index 7404715..ea3b445 100644
@@ -40,8 +40,8 @@ struct thread_info {
 						*/
 	__u8			supervisor_stack[0];
 #endif
-	int			sig_on_uaccess_error:1;
-	int			uaccess_err:1;	/* uaccess failed */
+	unsigned		sig_on_uaccess_error:1;
+	unsigned		uaccess_err:1;	/* uaccess failed */
 };
 
 #define INIT_THREAD_INFO(tsk)			\
Signature · 1 line
1.7.7