Skip to contentSkip to conversation

multiple jffs_file_write calls

DISCUSSION Rogelio M. Serrano Jr. 2 participants 2 messages Jul 19, 2000 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

Does the VFS layer do the subdivision of large file writes such that it calls jffs_file_write multiple times with count exactly equal to MAX_CHUNK_SIZE? When jffs_file_write writes the chunk it appends the name and header to it and we end up with a chunk bigger than MAX_CHUNK_SIZE. Should we make VFS aware of mtd like what I think should be done or handle it in another way? What do you think?

To unsubscribe, send "unsubscribe mtd" to [email protected]

#1 lore raw
Quoted 3 lines · Rogelio M. Serrano Jr.

Does the VFS layer do the subdivision of large file writes such that it calls jffs_file_write multiple times with count exactly equal to MAX_CHUNK_SIZE?

That was what I thought from the beginning as well. (Or instead of MAX_CHUNK_SIZE perhaps a page size of two.) But no. Right now there is no check whether the chunk of data is too large or not. The code just assumes that the data chunk is not big. As I stated in the last mail, this is something that's about to be changed.

Quoted 3 lines

When jffs_file_write writes the chunk it appends the name and header to it and we end up with a chunk bigger than MAX_CHUNK_SIZE.

Correct. This is a thing I will look into.

Quoted 2 lines

Should we make VFS aware of mtd like what I think should be done or handle it in another way? What do you think?

I think this is something JFFS should handle.

/Finn

To unsubscribe, send "unsubscribe mtd" to [email protected]