Skip to contentSkip to conversation

libnotify: upgrade 0.7.8 -> 0.7.9 / port to meson

PATCH In review Andreas M?ller 4 participants 13 messages Apr 30, 2020 – May 15, 2020 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 libnotify: upgrade 0.7.8 -> 0.7.9 / port to meson

From [1]:
New in 0.7.9
============
* Fixed linking in darwin [Iain, Marco; !5]
* Added man page for notify-send [Jan; !6]
* Dropped autotools [Jan; !11]

[1] http://ftp.gnome.org/pub/gnome/sources/libnotify/0.7/libnotify-0.7.9.news

---
 .../{libnotify_0.7.8.bb => libnotify_0.7.9.bb}     | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)
 rename meta/recipes-gnome/libnotify/{libnotify_0.7.8.bb => libnotify_0.7.9.bb} (59%)
meta/recipes-gnome/libnotify/libnotify_0.7.9.bb renamed from meta/recipes-gnome/libnotify/libnotify_0.7.8.bb +11 -3
similarity index 59%
rename from meta/recipes-gnome/libnotify/libnotify_0.7.8.bb
rename to meta/recipes-gnome/libnotify/libnotify_0.7.9.bb
index 0306b04f4e..38da41639b 100644
@@ -7,12 +7,20 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=7fbc338309ac38fefcd64b04bb903e34"
 
 DEPENDS = "dbus gtk+3 glib-2.0"
 
-inherit gnomebase gtk-doc features_check gobject-introspection
+GNOMEBASEBUILDCLASS = "meson"
+
+inherit gnomebase gtk-doc features_check gobject-introspection manpages
 # depends on gtk+3
 ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
 
-SRC_URI[archive.md5sum] = "babb4b07b5f21bef42a386d3d7019599"
-SRC_URI[archive.sha256sum] = "69209e0b663776a00c7b6c0e560302a8dbf66b2551d55616304f240bba66e18c"
+SRC_URI[archive.md5sum] = "ccd9c53364174cc8d13e18a1988faa76"
+SRC_URI[archive.sha256sum] = "66c0517ed16df7af258e83208faaf5069727dfd66995c4bbc51c16954d674761"
+
+GIR_MESON_ENABLE_FLAG = 'enabled'
+GIR_MESON_DISABLE_FLAG = 'disabled'
+GTKDOC_MESON_OPTION = 'gtk_doc'
+
+PACKAGECONFIG[manpages] = "-Dman=true,-Dman=false,libxslt-native xmlto-native"
 
 # there were times, we had two versions of libnotify (oe-core libnotify:0.6.x /
 # meta-gnome libnotify3: 0.7.x)
Signature · 1 line
2.21.1
#1 lore raw

PATCH 2/2 libsecret: upgrade 0.20.1 -> 0.20.3 / port to meson

From [1]:

0.20.3
* secret-file-backend: Fix use-after-free in flatpak [!52]
* docs: Add man subdir only if manpage is enabled [!51]

From [2]:

0.20.2
* secret-file-collection: force little-endian in GVariant [!49, #42]
* Prefer g_info() over g_message() [!48, #40]
* meson: Don't specify shared_library() [!47]
* docs: Make sure to set install: true [!46]

[1] http://ftp.gnome.org/pub/gnome/sources/libsecret/0.20/libsecret-0.20.3.news
[2] http://ftp.gnome.org/pub/gnome/sources/libsecret/0.20/libsecret-0.20.2.news

---
 ...ibsecret_0.20.1.bb => libsecret_0.20.3.bb} | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)
 rename meta/recipes-gnome/libsecret/{libsecret_0.20.1.bb => libsecret_0.20.3.bb} (63%)
meta/recipes-gnome/libsecret/libsecret_0.20.3.bb renamed from meta/recipes-gnome/libsecret/libsecret_0.20.1.bb +11 -8
similarity index 63%
rename from meta/recipes-gnome/libsecret/libsecret_0.20.1.bb
rename to meta/recipes-gnome/libsecret/libsecret_0.20.3.bb
index 72511af02d..d3a0c2ff54 100644
@@ -7,21 +7,24 @@ LICENSE = "LGPLv2.1"
 BUGTRACKER = "https://gitlab.gnome.org/GNOME/libsecret/issues"
 LIC_FILES_CHKSUM = "file://COPYING;md5=23c2a5e0106b99d75238986559bb5fc6"
 
+GNOMEBASEBUILDCLASS = "meson"
+
 inherit gnomebase gtk-doc vala gobject-introspection manpages
 
 DEPENDS += "glib-2.0 libgcrypt gettext-native"
 
-PACKAGECONFIG[manpages] = "--enable-manpages, --disable-manpages, libxslt-native xmlto-native"
+SRC_URI[archive.md5sum] = "47c3fdfeb111a87b509ad271e4a6f496"
+SRC_URI[archive.sha256sum] = "4fcb3c56f8ac4ab9c75b66901fb0104ec7f22aa9a012315a14c0d6dffa5290e4"
+
+GTKDOC_MESON_OPTION = 'gtk_doc'
 
-SRC_URI[archive.md5sum] = "d2dd660a8d502099317bc8af9f30302e"
-SRC_URI[archive.sha256sum] = "57f73e94ec6263a17a077fb809cf8cf424637a897a7f15b4eec42ce4aef52447"
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
+UNKNOWN_CONFIGURE_WHITELIST_append = " introspection"
+
+PACKAGECONFIG[manpages] = "-Dmanpage=true,-Dmanpage=false,libxslt-native xmlto-native"
 
 # http://errors.yoctoproject.org/Errors/Details/20228/
 ARM_INSTRUCTION_SET_armv4 = "arm"
 ARM_INSTRUCTION_SET_armv5 = "arm"
 ARM_INSTRUCTION_SET_armv6 = "arm"
-
-# vapigen.m4 bundled with the tarball does not yet have our cross-compilation fixes
-do_configure_prepend() {
-    rm -f ${S}/build/m4/vapigen.m4
-}
Signature · 1 line
2.21.1
#2 lore raw

Re: [OE-core] [PATCH 2/2] libsecret: upgrade 0.20.1 -> 0.20.3 / port to meson

This seems to be missing features_check inherit, so
that REQUIRED_DISTRO_FEATURES doesn't prevent it failing in my builds.

Will send patch shortly.

Quoted 77 lines · Andreas M?ller

From [1]:

0.20.3
* secret-file-backend: Fix use-after-free in flatpak [!52]
* docs: Add man subdir only if manpage is enabled [!51]

From [2]:

0.20.2
* secret-file-collection: force little-endian in GVariant [!49, #42]
* Prefer g_info() over g_message() [!48, #40]
* meson: Don't specify shared_library() [!47]
* docs: Make sure to set install: true [!46]

[1]
http://ftp.gnome.org/pub/gnome/sources/libsecret/0.20/libsecret-0.20.3.news
[2]
http://ftp.gnome.org/pub/gnome/sources/libsecret/0.20/libsecret-0.20.2.news

---
 ...ibsecret_0.20.1.bb => libsecret_0.20.3.bb} | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)
 rename meta/recipes-gnome/libsecret/{libsecret_0.20.1.bb =>

libsecret_0.20.3.bb} (63%)

meta/recipes-gnome/libsecret/libsecret_0.20.3.bb renamed from meta/recipes-gnome/libsecret/libsecret_0.20.1.bb +2 -1
similarity index 63%
rename from meta/recipes-gnome/libsecret/libsecret_0.20.1.bb
rename to meta/recipes-gnome/libsecret/libsecret_0.20.3.bb
index 72511af02d..d3a0c2ff54 100644
@@ -7,21 +7,24 @@ LICENSE = "LGPLv2.1"
 BUGTRACKER = "https://gitlab.gnome.org/GNOME/libsecret/issues"
 LIC_FILES_CHKSUM = "file://COPYING;md5=23c2a5e0106b99d75238986559bb5fc6"
 
+GNOMEBASEBUILDCLASS = "meson"
+
 inherit gnomebase gtk-doc vala gobject-introspection manpages
 
 DEPENDS += "glib-2.0 libgcrypt gettext-native"
 
-PACKAGECONFIG[manpages] = "--enable-manpages, --disable-manpages,

libxslt-native xmlto-native"

meta/recipes-gnome/libsecret/libsecret_0.20.3.bb renamed from meta/recipes-gnome/libsecret/libsecret_0.20.1.bb +2 -0
+SRC_URI[archive.md5sum] = "47c3fdfeb111a87b509ad271e4a6f496"
+SRC_URI[archive.sha256sum] =

"4fcb3c56f8ac4ab9c75b66901fb0104ec7f22aa9a012315a14c0d6dffa5290e4"

meta/recipes-gnome/libsecret/libsecret_0.20.3.bb renamed from meta/recipes-gnome/libsecret/libsecret_0.20.1.bb +2 -2
+
+GTKDOC_MESON_OPTION = 'gtk_doc'
 
-SRC_URI[archive.md5sum] = "d2dd660a8d502099317bc8af9f30302e"
-SRC_URI[archive.sha256sum] =

"57f73e94ec6263a17a077fb809cf8cf424637a897a7f15b4eec42ce4aef52447"

meta/recipes-gnome/libsecret/libsecret_0.20.3.bb renamed from meta/recipes-gnome/libsecret/libsecret_0.20.1.bb +5 -0
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
+UNKNOWN_CONFIGURE_WHITELIST_append = " introspection"
+
+PACKAGECONFIG[manpages] = "-Dmanpage=true,-Dmanpage=false,libxslt-native

xmlto-native"

# http://errors.yoctoproject.org/Errors/Details/20228/
ARM_INSTRUCTION_SET_armv4 = "arm" ARM_INSTRUCTION_SET_armv5 = "arm" ARM_INSTRUCTION_SET_armv6 = "arm"

meta/recipes-gnome/libsecret/libsecret_0.20.3.bb renamed from meta/recipes-gnome/libsecret/libsecret_0.20.1.bb +0 -2
-
-# vapigen.m4 bundled with the tarball does not yet have our

cross-compilation fixes

meta/recipes-gnome/libsecret/libsecret_0.20.3.bb renamed from meta/recipes-gnome/libsecret/libsecret_0.20.1.bb +0 -4
-do_configure_prepend() {
-    rm -f ${S}/build/m4/vapigen.m4
-}
--

2.21.1

#3 lore raw

Re: [OE-core] [PATCH 2/2] libsecret: upgrade 0.20.1 -> 0.20.3 / port to meson

Quoted 4 lines · Martin Jansa

This seems to be missing features_check inherit, so that REQUIRED_DISTRO_FEATURES doesn't prevent it failing in my builds.

Will send patch shortly.

Do I miss something? It was never applied

Andreas

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

Re: [OE-core] [PATCH 2/2] libsecret: upgrade 0.20.1 -> 0.20.3 / port to meson

Quoted 9 lines · Andreas M?ller via lists.openembedded.org
Quoted 4 lines · Martin Jansa

This seems to be missing features_check inherit, so that REQUIRED_DISTRO_FEATURES doesn't prevent it failing in my builds.

Will send patch shortly.

Do I miss something? It was never applied

Andreas

Ahh I did not find it due to Umlaut in my name - it was applied indeed. Author is now Andreas M?ller now.

Andreas

A message that is not in the archive (sent off-list or not yet received): [email protected]

#7 lore raw

Re: [OE-core] [PATCH 2/2] libsecret: upgrade 0.20.1 -> 0.20.3 / port to meson

Quoted 9 lines · Andreas M?ller via lists.openembedded.org
Quoted 5 lines · Andreas M?ller via lists.openembedded.org
Quoted 3 lines · Martin Jansa

This seems to be missing features_check inherit, so that REQUIRED_DISTRO_FEATURES doesn't prevent it failing in my builds.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Will send patch shortly.

Do I miss something? It was never applied

Andreas

Ahh I did not find it due to Umlaut in my name - it was applied indeed. Author is now Andreas M?ller now.

Andreas

And to turn this completely off-topic: on each mail I send to the list I get an email on extra thread with 'Andreas M?ller via lists.openembedded.org' in it's title.

This is since we moved to new mailing system (forgot details). Did send a mail here and there nothing happened... Should look for a different name...

Andreas

#8 lore raw

Re: [OE-core] [PATCH 2/2] libsecret: upgrade 0.20.1 -> 0.20.3 / port to meson

Quoted 16 lines · Andreas M?ller
Quoted 13 lines · Andreas M?ller via lists.openembedded.org
Quoted 9 lines · Andreas M?ller via lists.openembedded.org
Quoted 4 lines · Martin Jansa

This seems to be missing features_check inherit, so that REQUIRED_DISTRO_FEATURES doesn't prevent it failing in my builds.

Will send patch shortly.

Do I miss something? It was never applied

Andreas

Quoted 8 lines
Quoted 4 lines

Ahh I did not find it due to Umlaut in my name - it was applied indeed. Author is now Andreas M?ller now.

Andreas

And to turn this completely off-topic: on each mail I send to the list I get an email on extra thread with 'Andreas M?ller via lists.openembedded.org' in it's title.

https://en.wikipedia.org/wiki/DMARC
https://wiki.list.org/DEV/DMARC

Quoted 5 lines

This is since we moved to new mailing system (forgot details). Did send a mail here and there nothing happened... Should look for a different name...

Andreas

#9 lore raw

Re: [OE-core] [PATCH 2/2] libsecret: upgrade 0.20.1 -> 0.20.3 / port to meson

Quoted 21 lines · Denys Dmytriyenko
Quoted 19 lines · Andreas M?ller
Quoted 16 lines · Andreas M?ller via lists.openembedded.org
Quoted 9 lines · Andreas M?ller via lists.openembedded.org
Quoted 4 lines · Martin Jansa

This seems to be missing features_check inherit, so that REQUIRED_DISTRO_FEATURES doesn't prevent it failing in my builds.

Will send patch shortly.

Do I miss something? It was never applied

Andreas

Ahh I did not find it due to Umlaut in my name - it was applied indeed. Author is now Andreas M?ller now.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Andreas

And to turn this completely off-topic: on each mail I send to the list I get an email on extra thread with 'Andreas M?ller via lists.openembedded.org' in it's title.

https://en.wikipedia.org/wiki/DMARC
https://wiki.list.org/DEV/DMARC

what do yo expect me to do

1. read gazillion of lines just to sen emails to a mailing list
2. change my name
3. stop sending emails

Since it had worked for decades I prefer 3.

Andreas

#10 lore raw

Re: [OE-core] [PATCH 2/2] libsecret: upgrade 0.20.1 -> 0.20.3 / port to meson

Quoted 24 lines · Andreas Müller
Quoted 23 lines · Denys Dmytriyenko
Quoted 21 lines · Andreas M?ller
Quoted 17 lines · Andreas M?ller via lists.openembedded.org
Quoted 9 lines · Andreas M?ller via lists.openembedded.org
Quoted 4 lines · Martin Jansa

This seems to be missing features_check inherit, so that REQUIRED_DISTRO_FEATURES doesn't prevent it failing in my builds.

Will send patch shortly.

Do I miss something? It was never applied

Andreas

Ahh I did not find it due to Umlaut in my name - it was applied indeed. Author is now Andreas M?ller now.

Andreas

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

And to turn this completely off-topic: on each mail I send to the list I get an email on extra thread with 'Andreas M?ller via lists.openembedded.org' in it's title.

https://en.wikipedia.org/wiki/DMARC
https://wiki.list.org/DEV/DMARC

what do yo expect me to do

Has nothing to do with your name, but with your mail server and DMARC policy.

Many of us are in the same situation, and we learned to live with it, if cannot change it. Moreover, layer maintainers actually have to change names like that back to normal manually before applying patches...

Quoted 8 lines

1. read gazillion of lines just to sen emails to a mailing list
2. change my name
3. stop sending emails

Since it had worked for decades I prefer 3.

Andreas

#11 lore raw

Re: [OE-core] [PATCH 2/2] libsecret: upgrade 0.20.1 -> 0.20.3 / port to meson

Quoted 33 lines · Denys Dmytriyenko
Quoted 31 lines · Andreas Müller
Quoted 29 lines · Denys Dmytriyenko
Quoted 16 lines · Andreas M?ller
Quoted 13 lines · Andreas M?ller via lists.openembedded.org
Quoted 9 lines · Andreas M?ller via lists.openembedded.org
Quoted 4 lines · Martin Jansa

This seems to be missing features_check inherit, so that REQUIRED_DISTRO_FEATURES doesn't prevent it failing in my builds.

Will send patch shortly.

Do I miss something? It was never applied

Andreas

Quoted 8 lines
Quoted 4 lines

Ahh I did not find it due to Umlaut in my name - it was applied indeed. Author is now Andreas M?ller now.

Andreas

And to turn this completely off-topic: on each mail I send to the list I get an email on extra thread with 'Andreas M?ller via lists.openembedded.org' in it's title.

https://en.wikipedia.org/wiki/DMARC
https://wiki.list.org/DEV/DMARC

Quoted 7 lines
Quoted 1 line

what do yo expect me to do

Has nothing to do with your name, but with your mail server and DMARC policy.

Many of us are in the same situation, and we learned to live with it, if cannot change it. Moreover, layer maintainers actually have to change names like that back to normal manually before applying patches...

I consider this a a not acceptable waste of time and not acceptable - so I'll go 3. for oe-core.

@Khem Should I stop contributing in meta-openembedded either due to extra efforts caused?

Andreas

#12 lore raw

Re: [OE-core] [PATCH 2/2] libsecret: upgrade 0.20.1 -> 0.20.3 / port to meson

Quoted 11 lines · Andreas M?ller
Quoted 9 lines · Denys Dmytriyenko

Has nothing to do with your name, but with your mail server and DMARC policy.

Many of us are in the same situation, and we learned to live with it, if
cannot change it. Moreover, layer maintainers actually have to change names
like that back to normal manually before applying patches...

Quoted 5 lines

I consider this a a not acceptable waste of time and not acceptable - so I'll go 3. for oe-core.

@Khem Should I stop contributing in meta-openembedded either due to extra efforts caused?

I think there are two potential issues. I suspect the missing Umlaut is configuration of your groups.io account. I did reply about it once before and was surprised you hadn't fixed it. If you login in there and set your name correctly I think that should fix part of the issue.

The "via lists.openembedded.org" is something only you see, not the rest of us and is due to DMARC and other anti-spam and anti-spoofing measures most email systems are now requiring. I see the same thing for my own posts on mailing lists. There is nothing we can do about that, it depends on the settings for the domain you're sending from and you won't control the gmail.com policy!

Cheers,

Richard

#13 lore raw
In reply to Andreas M?ller
Quoted 10 lines · Andreas M?ller

From [1]:
New in 0.7.9
============
* Fixed linking in darwin [Iain, Marco; !5]
* Added man page for notify-send [Jan; !6]
* Dropped autotools [Jan; !11]

[1]
http://ftp.gnome.org/pub/gnome/sources/libnotify/0.7/libnotify-0.7.9.news

Quoted 7 lines
---
 .../{libnotify_0.7.8.bb => libnotify_0.7.9.bb}     | 14 +++++++++++-
--
 1 file changed, 11 insertions(+), 3 deletions(-)
 rename meta/recipes-gnome/libnotify/{libnotify_0.7.8.bb =>

libnotify_0.7.9.bb} (59%)

Looks like there is something that needs tweaking when api-documention is enabled as a DISTRO_FEATURE:

https://autobuilder.yoctoproject.org/typhoon/#/builders/108/builds/470

Cheers,

Richard

#14 lore raw
Quoted 20 lines · Richard Purdie
Quoted 10 lines · Andreas M?ller

From [1]:
New in 0.7.9
============
* Fixed linking in darwin [Iain, Marco; !5]
* Added man page for notify-send [Jan; !6]
* Dropped autotools [Jan; !11]

[1]
http://ftp.gnome.org/pub/gnome/sources/libnotify/0.7/libnotify-0.7.9.news

Quoted 7 lines
---
 .../{libnotify_0.7.8.bb => libnotify_0.7.9.bb}     | 14 +++++++++++-
--
 1 file changed, 11 insertions(+), 3 deletions(-)
 rename meta/recipes-gnome/libnotify/{libnotify_0.7.8.bb =>

libnotify_0.7.9.bb} (59%)

Quoted 8 lines

Looks like there is something that needs tweaking when api-documention is enabled as a DISTRO_FEATURE:

https://autobuilder.yoctoproject.org/typhoon/#/builders/108/builds/470

Cheers,

Richard

Alex has just sent similar patch that seems to address this. I suggest to take that one

Andreas