Skip to contentSkip to conversation

wil6210: remove obsolete msm platform code

PATCH In review Arnd Bergmann 2 participants 3 messages Sep 30, 2014 – Oct 2, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wil6210: remove obsolete msm platform code

The wil6210 driver has a glue layer for the Qualcomm MSM platform code, which apparently could never build and is unlikely to ever be able to in the future, as the MSM platform is being phased out in favor of the new QCOM platform, and the driver relies on out-of-tree infrastructure. Trying to build it currently results in this error:

drivers/net/wireless/ath/wil6210/wil_platform_msm.c:19:27: fatal error: linux/msm-bus.h: No such file or directory

Removing the driver fixes the build and makes it possible to build an allmodconfig kernel for MSM.

---

drivers/net/wireless/ath/wil6210/Kconfig +0 -9
index 481680a3aa55..ce8c0381825e 100644
@@ -39,12 +39,3 @@ config WIL6210_TRACING
 	  option if you are interested in debugging the driver.
 
 	  If unsure, say Y to make it easier to debug problems.
-
-config WIL6210_PLATFORM_MSM
-	bool "wil6210 MSM platform specific support"
-	depends on WIL6210
-	depends on ARCH_MSM
-	default y
-	---help---
-	  Say Y here to enable wil6210 driver support for MSM
-	  platform specific features
drivers/net/wireless/ath/wil6210/Makefile +0 -1
index a471d74ae409..944f300e2979 100644
@@ -13,7 +13,6 @@ wil6210-y += rx_reorder.o
 wil6210-y += fw.o
 wil6210-$(CONFIG_WIL6210_TRACING) += trace.o
 wil6210-y += wil_platform.o
-wil6210-$(CONFIG_WIL6210_PLATFORM_MSM) += wil_platform_msm.o
 
 # for tracing framework to find trace.h
 CFLAGS_trace.o := -I$(src)
drivers/net/wireless/ath/wil6210/wil_platform_msm.c deleted +0 -257

257 lines not on this page · raw message

drivers/net/wireless/ath/wil6210/wil_platform_msm.h deleted +0 -24
deleted file mode 100644
index 2f2229edb498..000000000000
@@ -1,24 +0,0 @@
-/*
- * Copyright (c) 2014 Qualcomm Atheros, Inc.
- *
- * Permission to use, copy, modify, and/or distribute this software for any
- * purpose with or without fee is hereby granted, provided that the above
- * copyright notice and this permission notice appear in all copies.
- *
- * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
- */
-
-#ifndef __WIL_PLATFORM__MSM_H__
-#define __WIL_PLATFORM_MSM_H__
-
-#include "wil_platform.h"
-
-void *wil_platform_msm_init(struct device *dev, struct wil_platform_ops *ops);
-
-#endif /* __WIL_PLATFORM__MSM_H__ */
#1 lore raw
Quoted 7 lines · Arnd Bergmann

The wil6210 driver has a glue layer for the Qualcomm MSM platform code, which apparently could never build and is unlikely to ever be able to in the future, as the MSM platform is being phased out in favor of the new QCOM platform, and the driver relies on out-of-tree infrastructure. Trying to build it currently results in this error:

Quoted 7 lines

drivers/net/wireless/ath/wil6210/wil_platform_msm.c:19:27: fatal error: linux/msm-bus.h: No such file or directory

Removing the driver fixes the build and makes it possible to build an allmodconfig kernel for MSM.

We are investigating this, looking for the appropriate solution. Thanks for pointing to this.

Thanks, Vladimir

#2 lore raw
Quoted 10 lines · On Thursday 02 October 2014 14:29:06 Vladimir Kondratiev wrote:
Quoted 9 lines · Arnd Bergmann

The wil6210 driver has a glue layer for the Qualcomm MSM platform code, which apparently could never build and is unlikely to ever be able to in the future, as the MSM platform is being phased out in favor of the new QCOM platform, and the driver relies on out-of-tree infrastructure. Trying to build it currently results in this error:

drivers/net/wireless/ath/wil6210/wil_platform_msm.c:19:27: fatal error: linux/msm-bus.h: No such file or directory

Quoted 8 lines
Quoted 5 lines

Removing the driver fixes the build and makes it possible to build an allmodconfig kernel for MSM.

We are investigating this, looking for the appropriate solution. Thanks for pointing to this.

FWIW, I took a closer look at the actual driver code now. It's actually worse than I thought and I don't see any possible way out other than removing this driver completely and starting a new one, if you want to use it for mach-qcom. I hadn't realized before that this is actually new code rather than ancient bitrot that suddenly started causing problems.

Some of the worst problems are:

- the driver scans for DT properties that are completely undocumented and have not been reviewed

- if they had been reviewed, the first comment you would have received is that the binding makes no sense: you scan for another node rather than taking the node you already have for the PCI device, then pass data into a random soc-specific driver API that is not part of the upstream kernel.

- as mentioned in the my patch above, the code has never been compiled on a mainline kernel and now breaks builds.

I think the only way forward is to have the platform support for whatever chip this is meant for reviewed and merged first and then you can write a new glue driver for the interfaces we end up putting into the kernel.
My guess is that with proper interfaces between the platform bus driver and the wil driver glue, there would be very little left in terms of interface and you can just call a generic interface from the PCI driver, passing the 'struct device' for the PCI dev in to an exported interface when provided.

Arnd