Skip to contentSkip to conversation

test/crypto: fix non ASCII character

PATCH Applied Anoob Joseph 5 participants 5 messages Mar 5, 2024

lore
Share & tools
lore

Anoob Joseph

author
#0 lore raw

PATCH 1/1 test/crypto: fix non ASCII character

Fix non ASCII character in the comment. Revert to original text.

Bugzilla ID: 1396

Fixes f97c63f4f445 ("test/crypto: add AES-GCM external mbuf case")
Signed-off-by Anoob Joseph <[email protected]>
---
 app/test/test_cryptodev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
app/test/test_cryptodev.c +1 -1
index c3c3f587b4..754fab39c5 100644
@@ -1615,7 +1615,7 @@ ext_mbuf_create(struct rte_mempool *mbuf_pool, int pkt_len,
 			goto fail;
 		}
 
-		/* Save shared data (like callback function) in external buffer’s end */
+		/* Save shared data (like callback function) in external buffer's end */
 		ret_shinfo = rte_pktmbuf_ext_shinfo_init_helper(ext_buf_addr, &buf_len,
 			ext_mbuf_callback_fn_free, &freed);
 		if (ret_shinfo == NULL) {
Signature · 1 line
2.25.1
Tested-by on v1 1/1
#1 lore raw
Quoted 8 lines

-----Original Message-----
From: Anoob Joseph <[email protected]>
Sent: Tuesday, March 5, 2024 1:34 PM
To: Akhil Goyal <[email protected]>; David Marchand <[email protected]>
Cc: Aakash Sasidharan <[email protected]>; [email protected]
Subject: [PATCH] test/crypto: fix non ASCII character

Quoted 7 lines

Fix non ASCII character in the comment. Revert to original text.

Bugzilla ID: 1396

Fixes f97c63f4f445 ("test/crypto: add AES-GCM external mbuf case")
Signed-off-by Anoob Joseph <[email protected]>

---

Build passes with this patch, thanks!

Tested-by Ali Alnubani <[email protected]>
Applied
#2 lore raw

05/03/2024 13:14, Ali Alnubani:

Quoted 7 lines
Quoted 7 lines

Subject: [PATCH] test/crypto: fix non ASCII character

Fix non ASCII character in the comment. Revert to original text.

Bugzilla ID: 1396

Fixes f97c63f4f445 ("test/crypto: add AES-GCM external mbuf case")
Quoted 6 lines
Quoted 2 lines
Signed-off-by Anoob Joseph <[email protected]>

---

Build passes with this patch, thanks!

Tested-by Ali Alnubani <[email protected]>
Reported-by Ali Alnubani <[email protected]>

Applied, thanks.

The script buildtools/get-test-suites.py is not tolerant with Unicode. We may be more flexible probably.
Bruce, Robin, what do you think about allowing Unicode characters in this script?

#3 lore raw
Quoted 16 lines · Thomas Monjalon

05/03/2024 13:14, Ali Alnubani:

Quoted 7 lines
Quoted 7 lines

Subject: [PATCH] test/crypto: fix non ASCII character

Fix non ASCII character in the comment. Revert to original text.

Bugzilla ID: 1396

Fixes f97c63f4f445 ("test/crypto: add AES-GCM external mbuf case")
Quoted 6 lines
Quoted 2 lines
Signed-off-by Anoob Joseph <[email protected]>

---

Build passes with this patch, thanks!

Tested-by Ali Alnubani <[email protected]>
Quoted 8 lines
Reported-by Ali Alnubani <[email protected]>

Applied, thanks.

The script buildtools/get-test-suites.py is not tolerant with Unicode. We may be more flexible probably.
Bruce, Robin, what do you think about allowing Unicode characters in this script?

Note: I could reproduce this issue with a Ubuntu 18.04 container, but not with my fedora 38.
Maybe something to do with a python version.. ?

Signature · 1 line
David Marchand
#4 lore raw

David Marchand, Mar 05, 2024 at 14:27:

Quoted 7 lines
Quoted 3 lines

The script buildtools/get-test-suites.py is not tolerant with Unicode. We may be more flexible probably.
Bruce, Robin, what do you think about allowing Unicode characters in this script?

Note: I could reproduce this issue with a Ubuntu 18.04 container, but not with my fedora 38.
Maybe something to do with a python version.. ?

The files are opened without specifying an encoding. So it depends on the LC_ALL environment variable.

https://git.dpdk.org/dpdk/tree/buildtools/get-test-suites.py#n22

I will send a patch to fix this.