new package : jquery-mobile
PATCH v2 1/1 new package : jquery-mobile
V2 : simplified file copying.
Thanks for the hints Thomas !
Jquery mobile is a unified, HTML5-based user interface system for all popular mobile device platforms, built on the rock-solid jQuery and jQuery UI foundation.
Its lightweight code is built with progressive enhancement, and has a flexible, easily themeable design.
--- package/Config.in | 1 + package/jquery-mobile/Config.in | 24 +++++++++++++++++ package/jquery-mobile/jquery-mobile.mk | 48 ++++++++++++++++++++++++++++++++++ 3 files changed, 73 insertions(+) create mode 100644 package/jquery-mobile/Config.in create mode 100644 package/jquery-mobile/jquery-mobile.mk
package/Config.in +1 -0
@@ -576,6 +576,7 @@ source "package/explorercanvas/Config.in" source "package/flot/Config.in" source "package/jquery/Config.in" source "package/jquery-keyboard/Config.in" +source "package/jquery-mobile/Config.in" source "package/jquery-sparkline/Config.in" source "package/jquery-ui/Config.in" source "package/jquery-ui-themes/Config.in"
package/jquery-mobile/Config.in new file +24 -0
@@ -0,0 +1,24 @@ +config BR2_PACKAGE_JQUERY_MOBILE + bool "jQuery-Mobile" + help + jQuery-Mobile is a unified, HTML5-based user interface system + for all popular mobile device platforms, built on the rock-solid + jQuery and jQuery UI foundation. + Its lightweight code is built with progressive enhancement, + and has a flexible, easily themeable design. + + http://jquerymobile.com + +if BR2_PACKAGE_JQUERY_MOBILE +config BR2_PACKAGE_JQUERY_MOBILE_FULL + bool "jquery mobile development files" + help + Installs the development versions. + +config BR2_PACKAGE_JQUERY_MOBILE_DEMOS + bool "jquery mobile demo files" + help + Installs the demo files. + The main demo page is http://hostname/demo.html +endif +
package/jquery-mobile/jquery-mobile.mk new file +48 -0
48 lines not on this page · raw message
Signature · 1 line
1.8.4.474.g128a96c
PATCH v2 1/1 new package : jquery-mobile
Dear Sagaert Johan,
Quoted 3 lines · Sagaert Johan
V2 : simplified file copying.
Thanks for the hints Thomas !
This "personal" comment and changelog should go below the "---" so it doesn't become part of the git history. See
http://buildroot.org/downloads/manual/manual.html#_patch_revision_changelog.
Also, you sent many versions of this patch, without changing the title to contain a version number. It'd be great to avoid that in the future :-)
package/jquery-mobile/Config.in line 2
Quoted 8 lines
package/jquery-mobile/Config.in new file +2
-0@@ -0,0 +1,24 @@ +config BR2_PACKAGE_JQUERY_MOBILE + bool "jQuery-Mobile"
All lower-case for the prompt, I suggest.
Also, still no select BR2_PACKAGE_JQUERY ? You don't need jquery to be installed? jquery-mobile is completely standalone?
Quoted 4 lines
package/jquery-mobile/Config.in new file +4
-0+ help + jQuery-Mobile is a unified, HTML5-based user interface system + for all popular mobile device platforms, built on the rock-solid + jQuery and jQuery UI foundation.
package/jquery-mobile/Config.in line 16
Quoted 10 lines
package/jquery-mobile/Config.in new file +10
-0+ Its lightweight code is built with progressive enhancement, + and has a flexible, easily themeable design. + + http://jquerymobile.com + +if BR2_PACKAGE_JQUERY_MOBILE +config BR2_PACKAGE_JQUERY_MOBILE_FULL + bool "jquery mobile development files" + help + Installs the development versions.
Wrong indentation. See my previous review.
package/jquery-mobile/Config.in line 22
Quoted 6 lines
package/jquery-mobile/Config.in new file +6
-0+ +config BR2_PACKAGE_JQUERY_MOBILE_DEMOS + bool "jquery mobile demo files" + help + Installs the demo files. + The main demo page is http://hostname/demo.html
Wrong indentation. See my previous review.
Quoted 46 lines
package/jquery-mobile/Config.in new file +2
-0+endif +package/jquery-mobile/jquery-mobile.mk new file +38
-0@@ -0,0 +1,48 @@ +################################################################################ +# +# jquery-mobile +# +################################################################################ + +JQUERY_MOBILE_VERSION = 1.3.2 +JQUERY_MOBILE_SITE = http://jquerymobile.com/resources/download +JQUERY_MOBILE_SOURCE = jquery.mobile-$(JQUERY_MOBILE_VERSION).zip +JQUERY_MOBILE_LICENSE = MIT + +define JQUERY_MOBILE_EXTRACT_CMDS + unzip -d $(@D) $(DL_DIR)/$(JQUERY_MOBILE_SOURCE) +endef + +JQUERY_MOBILE_INSTALLED_FILES = \ + jquery.mobile.structure-$(JQUERY_MOBILE_VERSION).min.css \ + jquery.mobile.theme-$(JQUERY_MOBILE_VERSION).min.css \ + jquery.mobile-$(JQUERY_MOBILE_VERSION).min.css \ + jquery.mobile-$(JQUERY_MOBILE_VERSION).min.map \ + jquery.mobile-$(JQUERY_MOBILE_VERSION).min.js + +ifeq ($(BR2_PACKAGE_JQUERY_MOBILE_FULL),y) +JQUERY_MOBILE_INSTALLED_FILES += \ + jquery.mobile.structure-$(JQUERY_MOBILE_VERSION).css \ + jquery.mobile.theme-$(JQUERY_MOBILE_VERSION).css \ + jquery.mobile-$(JQUERY_MOBILE_VERSION).css \ + jquery.mobile-$(JQUERY_MOBILE_VERSION).js +endif + +ifeq ($(BR2_PACKAGE_JQUERY_MOBILE_DEMOS),y) +define JQUERY_MOBILE_INSTALL_DEMOS + mkdir -p $(TARGET_DIR)/var/www/demos + cp -r $(@D)/demos/* $(TARGET_DIR)/var/www/demos + $(INSTALL) -m 0644 -D $(@D)/index.html $(TARGET_DIR)/var/www/demo.html +endef +endif +
package/jquery-mobile/jquery-mobile.mk line 48
Quoted 10 lines
package/jquery-mobile/jquery-mobile.mk new file +10
-0+define JQUERY_MOBILE_INSTALL_TARGET_CMDS + for f in $(JQUERY_MOBILE_INSTALLED_FILES) ; do \ + $(INSTALL) -m 0644 -D $(@D)/$$f $(TARGET_DIR)/var/www/$$f || break ; \ + done + mkdir -p $(TARGET_DIR)/var/www/images + cp -r $(@D)/images/* $(TARGET_DIR)/var/www/images + $(JQUERY_MOBILE_INSTALL_DEMOS) +endef + +$(eval $(generic-package))
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 new package : jquery-mobile
Dear Thomas;
Ok will make it lower-case name and send it as V3 patch.
Jquery-mobile is based on Jquery, I have installed the demos on a local http server to check it (with no other jquery tools installed.)
I see that the example pages are working.So it can rbe used standalone.
Regards ,Johan
-----Oorspronkelijk bericht-----
Van: Thomas Petazzoni [mailto:thomas.petazzoni at free-electrons.com]
Verzonden: dinsdag 15 oktober 2013 11:31
Aan: Sagaert Johan
CC: buildroot at busybox.net
Onderwerp: Re: [Buildroot] [PATCH 1/1 V2] new package : jquery-mobile
Dear Sagaert Johan,
Quoted 3 lines · Sagaert Johan
V2 : simplified file copying.
Thanks for the hints Thomas !
This "personal" comment and changelog should go below the "---" so it doesn't become part of the git history. See
http://buildroot.org/downloads/manual/manual.html#_patch_revision_changelog.
Also, you sent many versions of this patch, without changing the title to contain a version number. It'd be great to avoid that in the future :-)
package/jquery-mobile/Config.in line 2
Quoted 8 lines
(quoted diff) +0
-0b/package/jquery-mobile/Config.in new file mode 100644 index 0000000..2f2e30f
package/jquery-mobile/Config.in new file +2
-0@@ -0,0 +1,24 @@ +config BR2_PACKAGE_JQUERY_MOBILE + bool "jQuery-Mobile"
All lower-case for the prompt, I suggest.
Also, still no select BR2_PACKAGE_JQUERY ? You don't need jquery to be installed? jquery-mobile is completely standalone?
Quoted 4 lines
package/jquery-mobile/Config.in new file +4
-0+ help + jQuery-Mobile is a unified, HTML5-based user interface system + for all popular mobile device platforms, built on the rock-solid + jQuery and jQuery UI foundation.
package/jquery-mobile/Config.in line 16
Quoted 10 lines
package/jquery-mobile/Config.in new file +10
-0+ Its lightweight code is built with progressive enhancement, + and has a flexible, easily themeable design. + + http://jquerymobile.com + +if BR2_PACKAGE_JQUERY_MOBILE +config BR2_PACKAGE_JQUERY_MOBILE_FULL + bool "jquery mobile development files" + help + Installs the development versions.
Wrong indentation. See my previous review.
package/jquery-mobile/Config.in line 22
Quoted 6 lines
package/jquery-mobile/Config.in new file +6
-0+ +config BR2_PACKAGE_JQUERY_MOBILE_DEMOS + bool "jquery mobile demo files" + help + Installs the demo files. + The main demo page is http://hostname/demo.html
Wrong indentation. See my previous review.
Quoted 47 lines
package/jquery-mobile/Config.in new file +2
-0+endif +package/jquery-mobile/jquery-mobile.mk new file +38
-0@@ -0,0 +1,48 @@ +##################################################################### +########### +# +# jquery-mobile +# +##################################################################### +########### + +JQUERY_MOBILE_VERSION = 1.3.2 +JQUERY_MOBILE_SITE = http://jquerymobile.com/resources/download +JQUERY_MOBILE_SOURCE = jquery.mobile-$(JQUERY_MOBILE_VERSION).zip +JQUERY_MOBILE_LICENSE = MIT + +define JQUERY_MOBILE_EXTRACT_CMDS + unzip -d $(@D) $(DL_DIR)/$(JQUERY_MOBILE_SOURCE) endef + +JQUERY_MOBILE_INSTALLED_FILES = \ + jquery.mobile.structure-$(JQUERY_MOBILE_VERSION).min.css \ + jquery.mobile.theme-$(JQUERY_MOBILE_VERSION).min.css \ + jquery.mobile-$(JQUERY_MOBILE_VERSION).min.css \ + jquery.mobile-$(JQUERY_MOBILE_VERSION).min.map \ + jquery.mobile-$(JQUERY_MOBILE_VERSION).min.js + +ifeq ($(BR2_PACKAGE_JQUERY_MOBILE_FULL),y) +JQUERY_MOBILE_INSTALLED_FILES += \ + jquery.mobile.structure-$(JQUERY_MOBILE_VERSION).css \ + jquery.mobile.theme-$(JQUERY_MOBILE_VERSION).css \ + jquery.mobile-$(JQUERY_MOBILE_VERSION).css \ + jquery.mobile-$(JQUERY_MOBILE_VERSION).js +endif + +ifeq ($(BR2_PACKAGE_JQUERY_MOBILE_DEMOS),y) +define JQUERY_MOBILE_INSTALL_DEMOS + mkdir -p $(TARGET_DIR)/var/www/demos + cp -r $(@D)/demos/* $(TARGET_DIR)/var/www/demos + $(INSTALL) -m 0644 -D $(@D)/index.html +$(TARGET_DIR)/var/www/demo.html endef endif +
package/jquery-mobile/jquery-mobile.mk line 48
Quoted 10 lines
package/jquery-mobile/jquery-mobile.mk new file +10
-0+define JQUERY_MOBILE_INSTALL_TARGET_CMDS + for f in $(JQUERY_MOBILE_INSTALLED_FILES) ; do \ + $(INSTALL) -m 0644 -D $(@D)/$$f $(TARGET_DIR)/var/www/$$f || break ; \ + done + mkdir -p $(TARGET_DIR)/var/www/images + cp -r $(@D)/images/* $(TARGET_DIR)/var/www/images + $(JQUERY_MOBILE_INSTALL_DEMOS) +endef + +$(eval $(generic-package))
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering http://free-electrons.com