asm-ppc/elf.h error

In asm-ppc/elf.h, <asm/types.h> is not included. This breaks compilations of anything that compiles it (e.g. binutils) because the vector registers for Altivec aren't defined elsewhere. Included is a quick diff. I didn't know which PPC maintainer to send this to, so I posted it to the linuxppc-dev list.

Thanks,
David

@@ -4,6 +4,7 @@
 /*
  * ELF register definitions..
  */
+#include <linux/config.h>
 #include <asm/ptrace.h>
 
 #define ELF_NGREG	48	/* includes nip, msr, lr, etc. */

@@ -25,9 +26,11 @@
 typedef double elf_fpreg_t;
 typedef elf_fpreg_t elf_fpregset_t[ELF_NFPREG];
 
+#ifdef CONFIG_ALTIVEC
 /* Altivec registers */
 typedef __vector128 elf_vrreg_t;
 typedef elf_vrreg_t elf_vrregset_t[ELF_NVRREG];
+#endif
 
 #ifdef __KERNEL__
 

(Looking at the correct patch)

Why do you need that? Your claim that binutils needs that is simply wrong, I compiled CVS binutils without problems against bk 2.4.0-t11. In any case, glibc-2.1.3 and glibc-2.2 have this stuff in sys/procfs.h, so you should use that instead I guess. That's at least what gdb uses.

Franz.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/