Skip to contentSkip to conversation

test12-pre4 drivers/net/dummy

DISCUSSION Garst R. Reese 3 participants 6 messages Dec 4, 2000 – Dec 5, 2000 Module support

lore
Share & tools
lore
#1 lore raw

Patch posted here...
http://marc.theaimsgroup.com/?l=linux-kernel&m=97590235825341&w=2

Quoted 9 lines · Garst R. Reese

Fails to compile module at line 103,
invalid type argument of ->
Sorry if this well known.
Garst
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

Signature · 12 lines
=====================================================================
Mohammad A. Haque                              http://www.haque.net/ 
                                               [email protected]

  "Alcohol and calculus don't mix.             Project Lead
   Don't drink and derive." --Unknown          http://wm.themes.org/
                                               [email protected]
=====================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
#2 lore raw

the fix is in module.h which needs extra parens in the def of set_module_owner...

Jeff

Quoted 5 lines · Mohammad A. Haque

Patch posted here...
http://marc.theaimsgroup.com/?l=linux-kernel&m=97590235825341&w=2

Quoted 1 line · Garst R. Reese
Quoted 24 lines
Quoted 8 lines

Fails to compile module at line 103,
invalid type argument of ->
Sorry if this well known.
Garst
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

Signature · 12 lines
=====================================================================
Mohammad A. Haque                              http://www.haque.net/ 
                                               [email protected]

  "Alcohol and calculus don't mix.             Project Lead
   Don't drink and derive." --Unknown          http://wm.themes.org/
                                               [email protected]
=====================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#3 lore raw

Ok, so here's the proper patch for those who dont want to wait for t5 =) Ignore previous.

Quoted 4 lines · Jeff Garzik

the fix is in module.h which needs extra parens in the def of set_module_owner...

Jeff

Signature · 8 lines
=====================================================================
Mohammad A. Haque                              http://www.haque.net/
                                               [email protected]

  "Alcohol and calculus don't mix.             Project Lead
   Don't drink and derive." --Unknown          http://wm.themes.org/
                                               [email protected]
=====================================================================
include/linux/module.h renamed from include/linux/module.h.orig +1 -1
@@ -345,7 +345,7 @@
 #endif /* MODULE */
 
 #ifdef CONFIG_MODULES
-#define SET_MODULE_OWNER(some_struct) do { some_struct->owner = THIS_MODULE; } while (0)
+#define SET_MODULE_OWNER(some_struct) do { (some_struct)->owner = THIS_MODULE; } while (0)
 #else
 #define SET_MODULE_OWNER(some_struct) do { } while (0)
 #endif
author
#4 lore raw

Did you send it Linus?
It is not in pre5
Garst

Quoted 8 lines · Mohammad A. Haque

Ok, so here's the proper patch for those who dont want to wait for t5 =) Ignore previous.

Quoted 3 lines · Jeff Garzik

the fix is in module.h which needs extra parens in the def of set_module_owner...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#5 lore raw
In reply to Mohammad A. Haque

Alan has it and Linus hasn't applied Alan's patch yet...

Linus said.....
"[ Alan - I ahve your patches in my incoming queue still, I wanted to get
an interim version out to check with Al on the block list and the VM stuff with Rik and people. ]"

Quoted 4 lines · Garst R. Reese

Did you send it Linus?
It is not in pre5
Garst

Signature · 12 lines
=====================================================================
Mohammad A. Haque                              http://www.haque.net/ 
                                               [email protected]

  "Alcohol and calculus don't mix.             Project Lead
   Don't drink and derive." --Unknown          http://wm.themes.org/
                                               [email protected]
=====================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/