Skip to contentSkip to conversation

Patch: test13-pre2 fails "make xconfig" in isdn/Config.in

PATCH Gunther Mayer 3 participants 3 messages Dec 16, 2000

lore
Share & tools
lore

Gunther Mayer

author
#0 lore raw

Hi Linus,
apply this patch if like to fix this obvious error with "make xconfig" on plain tree:

	./tkparse < ../arch/i386/config.in >> kconfig.tk
	drivers/isdn/Config.in: 98: can't handle dep_bool/dep_mbool/dep_tristate condition
	make[1]: *** [kconfig.tk] Error 1
	make[1]: Leaving directory `/usr/src/linux/scripts'

-
Gunther

drivers/isdn/Config.in Sat Dec 16 12:21:48 2000 renamed from drivers/isdn/Config.in-240t13pre2-orig Sat Dec 16 12:20:59 2000 +1 -1
@@ -95,7 +95,7 @@
       dep_bool  '    Eicon PCI DIVA Server BRI/PRI/4BRI support' CONFIG_ISDN_DRV_EICON_PCI $CONFIG_PCI
       bool      '    Eicon S,SX,SCOM,Quadro,S2M support' CONFIG_ISDN_DRV_EICON_ISA
    fi
-   dep_tristate '  Build Eicon driver type standalone' CONFIG_ISDN_DRV_EICON_DIVAS
+   bool '  Build Eicon driver type standalone' CONFIG_ISDN_DRV_EICON_DIVAS
 fi
 
 # CAPI subsystem

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#1 lore raw
Quoted 10 lines · Gunther Mayer

apply this patch if like to fix this obvious error with "make xconfig" on plain tree:

	./tkparse < ../arch/i386/config.in >> kconfig.tk
	drivers/isdn/Config.in: 98: can't handle dep_bool/dep_mbool/dep_tristate condition
	make[1]: *** [kconfig.tk] Error 1
	make[1]: Leaving directory `/usr/src/linux/scripts'

drivers/isdn/Config.in Sat Dec 16 12:21:48 2000 line 101

Quoted 8 lines
drivers/isdn/Config.in Sat Dec 16 12:21:48 2000 renamed from drivers/isdn/Config.in-240t13pre2-orig Sat Dec 16 12:20:59 2000 +1 -1
@@ -95,7 +95,7 @@
       dep_bool  '    Eicon PCI DIVA Server BRI/PRI/4BRI support' CONFIG_ISDN_DRV_EICON_PCI $CONFIG_PCI
       bool      '    Eicon S,SX,SCOM,Quadro,S2M support' CONFIG_ISDN_DRV_EICON_ISA
    fi
-   dep_tristate '  Build Eicon driver type standalone' CONFIG_ISDN_DRV_EICON_DIVAS
+   bool '  Build Eicon driver type standalone' CONFIG_ISDN_DRV_EICON_DIVAS
 fi
 
 # CAPI subsystem

Sorry, my bad. (Note to myself: Always test changes before submitting with make menuconfig and make xconfig).

However, the correct fix is:

Only in linux-2.4.0-test13-pre2.work/: .menuconfig.log

drivers/isdn/Config.in +1 -1
diff -ur linux-2.4.0-test13-pre2/drivers/isdn/Config.in linux-2.4.0-test13-pre2.work/drivers/isdn/Config.in
@@ -95,7 +95,7 @@
       dep_bool  '    Eicon PCI DIVA Server BRI/PRI/4BRI support' CONFIG_ISDN_DRV_EICON_PCI $CONFIG_PCI
       bool      '    Eicon S,SX,SCOM,Quadro,S2M support' CONFIG_ISDN_DRV_EICON_ISA
    fi
-   dep_tristate '  Build Eicon driver type standalone' CONFIG_ISDN_DRV_EICON_DIVAS
+   tristate '  Build Eicon driver type standalone' CONFIG_ISDN_DRV_EICON_DIVAS
 fi
 
 # CAPI subsystem

BTW: There's probably issues with ISDN built non-modular, because that patch didn't have much testing yet. I'll go through different cases now.

--Kai

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
In reply to Gunther Mayer

On Sat, 16 Dec 2000, Gunther Mayer wrote:

This patch does not fix all problems in isdn/eicon.

A bigger patch is on the way.

Thanx,
Armin

Quoted 26 lines

Hi Linus,
apply this patch if like to fix this obvious error with "make xconfig" on plain tree:

	./tkparse < ../arch/i386/config.in >> kconfig.tk
	drivers/isdn/Config.in: 98: can't handle dep_bool/dep_mbool/dep_tristate condition
	make[1]: *** [kconfig.tk] Error 1
	make[1]: Leaving directory `/usr/src/linux/scripts'

-
Gunther

drivers/isdn/Config.in Sat Dec 16 12:21:48 2000 renamed from drivers/isdn/Config.in-240t13pre2-orig Sat Dec 16 12:20:59 2000 +1 -2
@@ -95,7 +95,7 @@
       dep_bool  '    Eicon PCI DIVA Server BRI/PRI/4BRI support' CONFIG_ISDN_DRV_EICON_PCI $CONFIG_PCI
       bool      '    Eicon S,SX,SCOM,Quadro,S2M support' CONFIG_ISDN_DRV_EICON_ISA
    fi
-   dep_tristate '  Build Eicon driver type standalone' CONFIG_ISDN_DRV_EICON_DIVAS
+   bool '  Build Eicon driver type standalone' CONFIG_ISDN_DRV_EICON_DIVAS
 fi
 
 # CAPI subsystem
-
Quoted 4 lines

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/