Skip to contentSkip to conversation

Subtle MM bug - 2 errors in MM code in pre-2.4.1?

DISCUSSION Benjamin Redelings I 1 participant 1 message Jan 9, 2001

lore
Share & tools
lore
#0 lore raw

Hi -
Based on my quick reading of this patch:
+
+empty:
+ spin_lock(&mmlist_lock);
+ return 0;

The above should actually be spin_UNlock?

Also the test for !inactive_shortage() seems to be inverted?

+ /* If refill_inactive_scan failed, try to page stuff out.. */
+ swap_out(priority, gfp_mask);
+ } while (!inactive_shortage());

-BenRI

Signature · 8 lines
"...assisted of course by pride, for we teach them to describe the
 Creeping Death, as Good Sense, or Maturity, or Experience." 
- "The Screwtape Letters"
Benjamin Redelings I      <><     http://www.bol.ucla.edu/~bredelin/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/