Skip to contentSkip to conversation

DVD bugfix in ide-cd.c

PATCH New Fredrik Vraalsen 4 participants 5 messages Feb 2, 2001 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 DVD bugfix in ide-cd.c

This is a small patch to Linux kernel 2.4.1 that fixes a problem with DVD playback in OMS (Open Media System). With the stock 2.4.1 kernel OMS will only play up to a certain point on the DVD before it complains about no more data left on input (basically read() returns 0). This patch reverts a change between 2.4.0 and 2.4.1.

drivers/ide/ide-cd.c renamed from linux/drivers/ide/ide-cd.c +3 -0
diff -u --recursive --new-file v2.4.0/linux/drivers/ide/ide-cd.c linux/drivers/ide/ide-cd.c
@@ -1872,6 +1872,9 @@
 	   If it is, just return. */
 	(void) cdrom_check_status(drive, sense);
 
+	if (CDROM_STATE_FLAGS(drive)->toc_valid)
+		return 0;
+
 	/* First read just the header, so we know how long the TOC is. */
 	stat = cdrom_read_tocentry(drive, 0, 1, 0, (char *) &toc->hdr,
 				    sizeof(struct atapi_toc_header), sense);
Signature · 6 lines
Fredrik Vraalsen  -  Research Assistant, Pablo research group
Department of Computer Science, University of Illinois at U-C
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
#2 lore raw
In reply to a message not in the archive

Hi...

Quoted 6 lines · Fredrik Vraalsen

This is a small patch to Linux kernel 2.4.1 that fixes a problem with DVD playback in OMS (Open Media System). With the stock 2.4.1 kernel OMS will only play up to a certain point on the DVD before it complains about no more data left on input (basically read() returns 0). This patch reverts a change between 2.4.0 and 2.4.1.

What's wrong with the people maintaining the source? The bug has been fixed in 2.2.18 and 2.4.0-test8. I can't imagine how the bug has been "implemented" in 2.4.1 again.

Any ideas?

Bye... SP.

Signature · 8 lines
Szymon Polom                              [email protected]
convergence integrated media GmbH         http://www.convergence.de
Rosenthaler Str. 51                       fon: +49(0)30-72 62 06 68 
D-10178 Berlin                            fax: +49(0)30-72 62 06 55
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
#3 lore raw
In reply to a message not in the archive

Hello,

Quoted 8 lines · Szymon Polom
Quoted 6 lines · Fredrik Vraalsen

This is a small patch to Linux kernel 2.4.1 that fixes a problem with DVD playback in OMS (Open Media System). With the stock 2.4.1 kernel OMS will only play up to a certain point on the DVD before it complains about no more data left on input (basically read() returns 0). This patch reverts a change between 2.4.0 and 2.4.1.

Quoted 5 lines

What's wrong with the people maintaining the source? The bug has been fixed in 2.2.18 and 2.4.0-test8. I can't imagine how the bug has been "implemented" in 2.4.1 again.

Any ideas?

I have to revoke my statement. The cached toc problem i meant was in cdrom_get_toc_entry() not in cdrom_read_toc().

Bye... SP.

Signature · 8 lines
Szymon Polom                              [email protected]
convergence integrated media GmbH         http://www.convergence.de
Rosenthaler Str. 51                       fon: +49(0)30-72 62 06 68 
D-10178 Berlin                            fax: +49(0)30-72 62 06 55
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
Applied
#4 lore raw
In reply to a message not in the archive
Quoted 6 lines · Fredrik Vraalsen

This is a small patch to Linux kernel 2.4.1 that fixes a problem with DVD playback in OMS (Open Media System). With the stock 2.4.1 kernel OMS will only play up to a certain point on the DVD before it complains about no more data left on input (basically read() returns 0). This patch reverts a change between 2.4.0 and 2.4.1.

Thanks applied, guess we need another work-around for buggy changers...

Signature · 6 lines
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
#5 lore raw
Quoted 4 lines · Jens Axboe

Thanks applied, guess we need another work-around for buggy changers...

Signature · 1 line
Jens Axboe

To quote my friend, about comments agreeing with Hale Landis..... WHY!!! are you still supporting junk? ;-)

Cheers,

Andre Hedrick
Linux ATA Development
ASL Kernel Development
-----------------------------------------------------------------------------

ASL, Inc.                                     Toll free: 1-877-ASL-3535
1757 Houret Court                             Fax: 1-408-941-2071
Milpitas, CA 95035                            Web: www.aslab.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/